[INFO] crate ogg_metadata 0.4.1 is already in cache [INFO] extracting crate ogg_metadata 0.4.1 into work/ex/clippy-test-run/sources/stable/reg/ogg_metadata/0.4.1 [INFO] extracting crate ogg_metadata 0.4.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ogg_metadata/0.4.1 [INFO] validating manifest of ogg_metadata-0.4.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ogg_metadata-0.4.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ogg_metadata-0.4.1 [INFO] finished frobbing ogg_metadata-0.4.1 [INFO] frobbed toml for ogg_metadata-0.4.1 written to work/ex/clippy-test-run/sources/stable/reg/ogg_metadata/0.4.1/Cargo.toml [INFO] started frobbing ogg_metadata-0.4.1 [INFO] finished frobbing ogg_metadata-0.4.1 [INFO] frobbed toml for ogg_metadata-0.4.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ogg_metadata/0.4.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ogg_metadata-0.4.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ogg_metadata/0.4.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2ea0f746500525eca92cfd15d163a1decb061434b4c005e73c82ddd757752505 [INFO] running `"docker" "start" "-a" "2ea0f746500525eca92cfd15d163a1decb061434b4c005e73c82ddd757752505"` [INFO] [stderr] Checking ogg v0.5.1 [INFO] [stderr] Checking ogg_metadata v0.4.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/opus.rs:73:3 [INFO] [stderr] | [INFO] [stderr] 73 | output_channels : output_channels, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_channels` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/opus.rs:74:3 [INFO] [stderr] | [INFO] [stderr] 74 | pre_skip : pre_skip, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `pre_skip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/opus.rs:73:3 [INFO] [stderr] | [INFO] [stderr] 73 | output_channels : output_channels, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_channels` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:10:24 [INFO] [stderr] | [INFO] [stderr] 10 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::redundant_field_names)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/opus.rs:74:3 [INFO] [stderr] | [INFO] [stderr] 74 | pre_skip : pre_skip, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `pre_skip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vorbis.rs:69:2 [INFO] [stderr] | [INFO] [stderr] 69 | return Ok(hdr); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(hdr)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/opus.rs:76:2 [INFO] [stderr] | [INFO] [stderr] 76 | return Ok(hdr); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(hdr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/theora.rs:54:2 [INFO] [stderr] | [INFO] [stderr] 54 | return Ok(hdr); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(hdr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:119:3 [INFO] [stderr] | [INFO] [stderr] 119 | return OggMetadataError::ReadError(err); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `OggMetadataError::ReadError(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:125:3 [INFO] [stderr] | [INFO] [stderr] 125 | return match err { [INFO] [stderr] | _________^ [INFO] [stderr] 126 | | OggReadError::ReadError(err) => OggMetadataError::ReadError(err), [INFO] [stderr] 127 | | _ => OggMetadataError::UnrecognizedFormat, [INFO] [stderr] 128 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 125 | match err { [INFO] [stderr] 126 | OggReadError::ReadError(err) => OggMetadataError::ReadError(err), [INFO] [stderr] 127 | _ => OggMetadataError::UnrecognizedFormat, [INFO] [stderr] 128 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:137:2 [INFO] [stderr] | [INFO] [stderr] 137 | return Ok(try!(pck_rdr.seek_bytes(SeekFrom::End(-(end_pos_to_seek as i64))))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(try!(pck_rdr.seek_bytes(SeekFrom::End(-(end_pos_to_seek as i64)))))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:151:2 [INFO] [stderr] | [INFO] [stderr] 151 | return Ok(pck.absgp_page); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(pck.absgp_page)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:182:2 [INFO] [stderr] | [INFO] [stderr] 182 | return Some(ret); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(ret)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:367:2 [INFO] [stderr] | [INFO] [stderr] 367 | return Ok(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/vorbis.rs:69:2 [INFO] [stderr] | [INFO] [stderr] 69 | return Ok(hdr); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(hdr)` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:10:24 [INFO] [stderr] | [INFO] [stderr] 10 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::needless_return)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/opus.rs:76:2 [INFO] [stderr] | [INFO] [stderr] 76 | return Ok(hdr); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(hdr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/theora.rs:54:2 [INFO] [stderr] | [INFO] [stderr] 54 | return Ok(hdr); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(hdr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/lib.rs:119:3 [INFO] [stderr] | [INFO] [stderr] 119 | return OggMetadataError::ReadError(err); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `OggMetadataError::ReadError(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/lib.rs:125:3 [INFO] [stderr] | [INFO] [stderr] 125 | return match err { [INFO] [stderr] | _________^ [INFO] [stderr] 126 | | OggReadError::ReadError(err) => OggMetadataError::ReadError(err), [INFO] [stderr] 127 | | _ => OggMetadataError::UnrecognizedFormat, [INFO] [stderr] 128 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 125 | match err { [INFO] [stderr] 126 | OggReadError::ReadError(err) => OggMetadataError::ReadError(err), [INFO] [stderr] 127 | _ => OggMetadataError::UnrecognizedFormat, [INFO] [stderr] 128 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/lib.rs:137:2 [INFO] [stderr] | [INFO] [stderr] 137 | return Ok(try!(pck_rdr.seek_bytes(SeekFrom::End(-(end_pos_to_seek as i64))))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(try!(pck_rdr.seek_bytes(SeekFrom::End(-(end_pos_to_seek as i64)))))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/lib.rs:151:2 [INFO] [stderr] | [INFO] [stderr] 151 | return Ok(pck.absgp_page); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(pck.absgp_page)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/lib.rs:182:2 [INFO] [stderr] | [INFO] [stderr] 182 | return Some(ret); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(ret)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/lib.rs:367:2 [INFO] [stderr] | [INFO] [stderr] 367 | return Ok(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/vorbis.rs:32:19 [INFO] [stderr] | [INFO] [stderr] 32 | ((l as f64) / (self.sample_rate as f64) * 1000.0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.sample_rate)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/vorbis.rs:42:42 [INFO] [stderr] | [INFO] [stderr] 42 | let duration_raw_secs = (l as f64) / (self.sample_rate as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.sample_rate)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:96:3 [INFO] [stderr] | [INFO] [stderr] 96 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 97 | | &UnrecognizedFormat => "Unrecognized or invalid format", [INFO] [stderr] 98 | | &ReadError(_) => "I/O error", [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 96 | match *self { [INFO] [stderr] 97 | UnrecognizedFormat => "Unrecognized or invalid format", [INFO] [stderr] 98 | ReadError(_) => "I/O error", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:103:3 [INFO] [stderr] | [INFO] [stderr] 103 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 104 | | &OggMetadataError::ReadError(ref err) => [INFO] [stderr] 105 | | Some(err as &std::error::Error), [INFO] [stderr] 106 | | _ => None [INFO] [stderr] 107 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 103 | match *self { [INFO] [stderr] 104 | OggMetadataError::ReadError(ref err) => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib.rs:167:5 [INFO] [stderr] | [INFO] [stderr] 167 | if pck_data.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `pck_data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:214:14 [INFO] [stderr] | [INFO] [stderr] 214 | |l| l - (ident_hdr.pre_skip as u64)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(ident_hdr.pre_skip)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/lib.rs:313:3 [INFO] [stderr] | [INFO] [stderr] 313 | 'pseudo_return: loop { [INFO] [stderr] | _________^ [INFO] [stderr] 314 | | // This pseudo_try is our local replacement for try, [INFO] [stderr] 315 | | // so that we don't escalate if we encounter any [INFO] [stderr] 316 | | // errors in reading the final absgp positions, [INFO] [stderr] ... | [INFO] [stderr] 356 | | break; [INFO] [stderr] 357 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `ogg_metadata`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to 11 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `ogg_metadata`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "2ea0f746500525eca92cfd15d163a1decb061434b4c005e73c82ddd757752505"` [INFO] running `"docker" "rm" "-f" "2ea0f746500525eca92cfd15d163a1decb061434b4c005e73c82ddd757752505"` [INFO] [stdout] 2ea0f746500525eca92cfd15d163a1decb061434b4c005e73c82ddd757752505