[INFO] crate oftb 0.1.3 is already in cache [INFO] extracting crate oftb 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/oftb/0.1.3 [INFO] extracting crate oftb 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/oftb/0.1.3 [INFO] validating manifest of oftb-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of oftb-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing oftb-0.1.3 [INFO] finished frobbing oftb-0.1.3 [INFO] frobbed toml for oftb-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/oftb/0.1.3/Cargo.toml [INFO] started frobbing oftb-0.1.3 [INFO] finished frobbing oftb-0.1.3 [INFO] frobbed toml for oftb-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/oftb/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting oftb-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/oftb/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d9970651e0662bcd68cfd65688da8d4c9b4fbe2008560f80be5f733e7c3d62db [INFO] running `"docker" "start" "-a" "d9970651e0662bcd68cfd65688da8d4c9b4fbe2008560f80be5f733e7c3d62db"` [INFO] [stderr] Checking smallvec v0.4.5 [INFO] [stderr] Checking itertools v0.6.5 [INFO] [stderr] Compiling synstructure v0.5.2 [INFO] [stderr] Checking pretty_logger v0.1.8 [INFO] [stderr] Compiling gc_derive v0.3.1 [INFO] [stderr] Checking oftlisp v0.1.3 [INFO] [stderr] Checking oftlisp-anf v0.1.3 [INFO] [stderr] Checking oftb v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/repl/commands.rs:59:72 [INFO] [stderr] | [INFO] [stderr] 59 | Err(Error::Runtime(RuntimeError::Exit(n))) => exit(n as i32), [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/repl/facade/plain.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | stdout().flush().ok().expect("Could not flush stdout"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/repl/run.rs:29:35 [INFO] [stderr] | [INFO] [stderr] 29 | Ok(Gc::new(Value::Nil(Default::default()))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 29 | Ok(Gc::new(Value::Nil(()))) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/repl/run.rs:38:54 [INFO] [stderr] | [INFO] [stderr] 38 | Ok(None) => return Ok(Gc::new(Value::Nil(Default::default()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 38 | Ok(None) => return Ok(Gc::new(Value::Nil(()))), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/repl/run.rs:46:35 [INFO] [stderr] | [INFO] [stderr] 46 | Ok(Gc::new(Value::Nil(Default::default()))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 46 | Ok(Gc::new(Value::Nil(()))) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's keys [INFO] [stderr] --> src/main.rs:84:24 [INFO] [stderr] | [INFO] [stderr] 84 | for (export, _) in &module.exports { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 84 | for export in module.exports.keys() { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:124:44 [INFO] [stderr] | [INFO] [stderr] 124 | } else if !meta.is_root && no_home { [INFO] [stderr] | ____________________________________________^ [INFO] [stderr] 125 | | false [INFO] [stderr] 126 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:122:36 [INFO] [stderr] | [INFO] [stderr] 122 | if meta.is_root && no_root { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 123 | | false [INFO] [stderr] 124 | | } else if !meta.is_root && no_home { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:124:16 [INFO] [stderr] | [INFO] [stderr] 124 | } else if !meta.is_root && no_home { [INFO] [stderr] | ________________^ [INFO] [stderr] 125 | | false [INFO] [stderr] 126 | | } else { [INFO] [stderr] 127 | | true [INFO] [stderr] 128 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `!(!meta.is_root && no_home)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:192:59 [INFO] [stderr] | [INFO] [stderr] 192 | Err(Right(RuntimeError::Exit(n))) => exit(n as i32), [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `oftb`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/repl/commands.rs:59:72 [INFO] [stderr] | [INFO] [stderr] 59 | Err(Error::Runtime(RuntimeError::Exit(n))) => exit(n as i32), [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/repl/facade/plain.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | stdout().flush().ok().expect("Could not flush stdout"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/repl/run.rs:29:35 [INFO] [stderr] | [INFO] [stderr] 29 | Ok(Gc::new(Value::Nil(Default::default()))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 29 | Ok(Gc::new(Value::Nil(()))) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/repl/run.rs:38:54 [INFO] [stderr] | [INFO] [stderr] 38 | Ok(None) => return Ok(Gc::new(Value::Nil(Default::default()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 38 | Ok(None) => return Ok(Gc::new(Value::Nil(()))), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/repl/run.rs:46:35 [INFO] [stderr] | [INFO] [stderr] 46 | Ok(Gc::new(Value::Nil(Default::default()))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 46 | Ok(Gc::new(Value::Nil(()))) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's keys [INFO] [stderr] --> src/main.rs:84:24 [INFO] [stderr] | [INFO] [stderr] 84 | for (export, _) in &module.exports { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 84 | for export in module.exports.keys() { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:124:44 [INFO] [stderr] | [INFO] [stderr] 124 | } else if !meta.is_root && no_home { [INFO] [stderr] | ____________________________________________^ [INFO] [stderr] 125 | | false [INFO] [stderr] 126 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:122:36 [INFO] [stderr] | [INFO] [stderr] 122 | if meta.is_root && no_root { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 123 | | false [INFO] [stderr] 124 | | } else if !meta.is_root && no_home { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:124:16 [INFO] [stderr] | [INFO] [stderr] 124 | } else if !meta.is_root && no_home { [INFO] [stderr] | ________________^ [INFO] [stderr] 125 | | false [INFO] [stderr] 126 | | } else { [INFO] [stderr] 127 | | true [INFO] [stderr] 128 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `!(!meta.is_root && no_home)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:192:59 [INFO] [stderr] | [INFO] [stderr] 192 | Err(Right(RuntimeError::Exit(n))) => exit(n as i32), [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `oftb`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d9970651e0662bcd68cfd65688da8d4c9b4fbe2008560f80be5f733e7c3d62db"` [INFO] running `"docker" "rm" "-f" "d9970651e0662bcd68cfd65688da8d4c9b4fbe2008560f80be5f733e7c3d62db"` [INFO] [stdout] d9970651e0662bcd68cfd65688da8d4c9b4fbe2008560f80be5f733e7c3d62db