[INFO] crate offwall 1.0.0 is already in cache [INFO] extracting crate offwall 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/offwall/1.0.0 [INFO] extracting crate offwall 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/offwall/1.0.0 [INFO] validating manifest of offwall-1.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of offwall-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing offwall-1.0.0 [INFO] finished frobbing offwall-1.0.0 [INFO] frobbed toml for offwall-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/offwall/1.0.0/Cargo.toml [INFO] started frobbing offwall-1.0.0 [INFO] finished frobbing offwall-1.0.0 [INFO] frobbed toml for offwall-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/offwall/1.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting offwall-1.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/offwall/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 60dc2e6c4ba7aef2c10e6b3cec4d7227e60f2624ae8bce46c8057aabe59b7f06 [INFO] running `"docker" "start" "-a" "60dc2e6c4ba7aef2c10e6b3cec4d7227e60f2624ae8bce46c8057aabe59b7f06"` [INFO] [stderr] Checking log-panics v1.2.0 [INFO] [stderr] Checking syslog v3.3.0 [INFO] [stderr] Checking simple_logger v0.4.0 [INFO] [stderr] Checking offwall v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bypass_csv.rs:202:13 [INFO] [stderr] | [INFO] [stderr] 202 | direction: direction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bypass_csv.rs:235:13 [INFO] [stderr] | [INFO] [stderr] 235 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bypass_csv.rs:236:13 [INFO] [stderr] | [INFO] [stderr] 236 | inside_net: inside_net, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `inside_net` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bypass_csv.rs:323:13 [INFO] [stderr] | [INFO] [stderr] 323 | src_ip: src_ip, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `src_ip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bypass_csv.rs:324:13 [INFO] [stderr] | [INFO] [stderr] 324 | src_port: src_port, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `src_port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bypass_csv.rs:325:13 [INFO] [stderr] | [INFO] [stderr] 325 | dst_ip: dst_ip, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `dst_ip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bypass_csv.rs:326:13 [INFO] [stderr] | [INFO] [stderr] 326 | dst_port: dst_port, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `dst_port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bypass_csv.rs:327:13 [INFO] [stderr] | [INFO] [stderr] 327 | proto: proto, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `proto` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bypass_csv.rs:328:13 [INFO] [stderr] | [INFO] [stderr] 328 | direction: direction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/conf.rs:289:21 [INFO] [stderr] | [INFO] [stderr] 289 | socket: socket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/messages/deserialize.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | typ: typ, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/messages/deserialize.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | code: code, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/messages/serialize.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | xid: xid, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `xid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/messages/serialize.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | port: port, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/messages/serialize.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | actions: actions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `actions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/messages/serialize.rs:184:13 [INFO] [stderr] | [INFO] [stderr] 184 | table_id: table_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `table_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/messages/serialize.rs:188:13 [INFO] [stderr] | [INFO] [stderr] 188 | priority: priority, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `priority` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/messages/serialize.rs:190:13 [INFO] [stderr] | [INFO] [stderr] 190 | out_port: out_port, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `out_port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/messages/serialize.rs:194:13 [INFO] [stderr] | [INFO] [stderr] 194 | match_field: match_field, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `match_field` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/messages/serialize.rs:195:13 [INFO] [stderr] | [INFO] [stderr] 195 | instructions: instructions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instructions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/messages/serialize.rs:208:13 [INFO] [stderr] | [INFO] [stderr] 208 | xid: xid, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `xid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/messages/serialize.rs:236:13 [INFO] [stderr] | [INFO] [stderr] 236 | arbitrary: arbitrary, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arbitrary` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/messages/serialize.rs:313:13 [INFO] [stderr] | [INFO] [stderr] 313 | xid: xid, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `xid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/messages/serialize.rs:323:13 [INFO] [stderr] | [INFO] [stderr] 323 | arbitrary: arbitrary, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arbitrary` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/messages/mod.rs:303:13 [INFO] [stderr] | [INFO] [stderr] 303 | hasmask: hasmask, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `hasmask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/messages/mod.rs:304:13 [INFO] [stderr] | [INFO] [stderr] 304 | field: field, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `field` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/messages/mod.rs:305:13 [INFO] [stderr] | [INFO] [stderr] 305 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/mod.rs:304:13 [INFO] [stderr] | [INFO] [stderr] 304 | table: table, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/mod.rs:305:13 [INFO] [stderr] | [INFO] [stderr] 305 | ports: ports, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ports` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/mod.rs:306:13 [INFO] [stderr] | [INFO] [stderr] 306 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/mod.rs:308:13 [INFO] [stderr] | [INFO] [stderr] 308 | records: records, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `records` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/mod.rs:309:13 [INFO] [stderr] | [INFO] [stderr] 309 | rx: rx, [INFO] [stderr] | ^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bypass_csv.rs:202:13 [INFO] [stderr] | [INFO] [stderr] 202 | direction: direction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bypass_csv.rs:235:13 [INFO] [stderr] | [INFO] [stderr] 235 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bypass_csv.rs:236:13 [INFO] [stderr] | [INFO] [stderr] 236 | inside_net: inside_net, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `inside_net` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bypass_csv.rs:323:13 [INFO] [stderr] | [INFO] [stderr] 323 | src_ip: src_ip, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `src_ip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bypass_csv.rs:324:13 [INFO] [stderr] | [INFO] [stderr] 324 | src_port: src_port, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `src_port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bypass_csv.rs:325:13 [INFO] [stderr] | [INFO] [stderr] 325 | dst_ip: dst_ip, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `dst_ip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bypass_csv.rs:326:13 [INFO] [stderr] | [INFO] [stderr] 326 | dst_port: dst_port, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `dst_port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bypass_csv.rs:327:13 [INFO] [stderr] | [INFO] [stderr] 327 | proto: proto, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `proto` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bypass_csv.rs:328:13 [INFO] [stderr] | [INFO] [stderr] 328 | direction: direction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/conf.rs:289:21 [INFO] [stderr] | [INFO] [stderr] 289 | socket: socket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/messages/deserialize.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | typ: typ, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/messages/deserialize.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | code: code, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/messages/serialize.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | xid: xid, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `xid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/messages/serialize.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | port: port, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/messages/serialize.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | actions: actions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `actions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/messages/serialize.rs:184:13 [INFO] [stderr] | [INFO] [stderr] 184 | table_id: table_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `table_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/messages/serialize.rs:188:13 [INFO] [stderr] | [INFO] [stderr] 188 | priority: priority, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `priority` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/messages/serialize.rs:190:13 [INFO] [stderr] | [INFO] [stderr] 190 | out_port: out_port, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `out_port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/messages/serialize.rs:194:13 [INFO] [stderr] | [INFO] [stderr] 194 | match_field: match_field, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `match_field` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/messages/serialize.rs:195:13 [INFO] [stderr] | [INFO] [stderr] 195 | instructions: instructions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instructions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/messages/serialize.rs:208:13 [INFO] [stderr] | [INFO] [stderr] 208 | xid: xid, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `xid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/messages/serialize.rs:236:13 [INFO] [stderr] | [INFO] [stderr] 236 | arbitrary: arbitrary, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arbitrary` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/messages/serialize.rs:313:13 [INFO] [stderr] | [INFO] [stderr] 313 | xid: xid, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `xid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/messages/serialize.rs:323:13 [INFO] [stderr] | [INFO] [stderr] 323 | arbitrary: arbitrary, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arbitrary` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/messages/mod.rs:303:13 [INFO] [stderr] | [INFO] [stderr] 303 | hasmask: hasmask, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `hasmask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/messages/mod.rs:304:13 [INFO] [stderr] | [INFO] [stderr] 304 | field: field, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `field` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/messages/mod.rs:305:13 [INFO] [stderr] | [INFO] [stderr] 305 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/mod.rs:304:13 [INFO] [stderr] | [INFO] [stderr] 304 | table: table, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/mod.rs:305:13 [INFO] [stderr] | [INFO] [stderr] 305 | ports: ports, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ports` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/mod.rs:306:13 [INFO] [stderr] | [INFO] [stderr] 306 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/mod.rs:308:13 [INFO] [stderr] | [INFO] [stderr] 308 | records: records, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `records` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/openflow/mod.rs:309:13 [INFO] [stderr] | [INFO] [stderr] 309 | rx: rx, [INFO] [stderr] | ^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs::File` [INFO] [stderr] --> src/conf.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | use std::fs::File; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::Read` [INFO] [stderr] --> src/conf.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | use std::io::Read; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `tls_api` [INFO] [stderr] --> src/conf.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | use tls_api; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `tls_api::TlsAcceptorBuilder` [INFO] [stderr] --> src/conf.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | use tls_api::TlsAcceptorBuilder; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs::File` [INFO] [stderr] --> src/conf.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | use std::fs::File; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::Read` [INFO] [stderr] --> src/conf.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | use std::io::Read; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `tls_api` [INFO] [stderr] --> src/conf.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | use tls_api; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `tls_api::TlsAcceptorBuilder` [INFO] [stderr] --> src/conf.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | use tls_api::TlsAcceptorBuilder; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/openflow/messages/deserialize.rs:150:18 [INFO] [stderr] | [INFO] [stderr] 150 | xid: 0x12345678, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/openflow/messages/serialize.rs:333:45 [INFO] [stderr] | [INFO] [stderr] 333 | let testee = OfpOxmTlv::new_in_port(0x11223344); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1122_3344` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/openflow/messages/serialize.rs:352:43 [INFO] [stderr] | [INFO] [stderr] 352 | let testee = OfpActionOutput::new(0x11223344); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1122_3344` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `P12_KEY` [INFO] [stderr] --> src/conf.rs:65:1 [INFO] [stderr] | [INFO] [stderr] 65 | const P12_KEY: &str = "pkcs12"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `PASS_KEY` [INFO] [stderr] --> src/conf.rs:66:1 [INFO] [stderr] | [INFO] [stderr] 66 | const PASS_KEY: &str = "passwd"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Tls` [INFO] [stderr] --> src/openflow/mod.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | Tls(TlsStream), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `P12_KEY` [INFO] [stderr] --> src/conf.rs:65:1 [INFO] [stderr] | [INFO] [stderr] 65 | const P12_KEY: &str = "pkcs12"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `PASS_KEY` [INFO] [stderr] --> src/conf.rs:66:1 [INFO] [stderr] | [INFO] [stderr] 66 | const PASS_KEY: &str = "passwd"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Tls` [INFO] [stderr] --> src/openflow/mod.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | Tls(TlsStream), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/openflow/messages/deserialize.rs:17:31 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn deserialize(bytes: &[u8; 8]) -> OfpHeader { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/openflow/messages/mod.rs:329:32 [INFO] [stderr] | [INFO] [stderr] 329 | pub fn new_ip_proto(proto: &IpProtocol) -> OfpOxmTlv { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `IpProtocol` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/openflow/messages/mod.rs:337:27 [INFO] [stderr] | [INFO] [stderr] 337 | pub fn new_ipv4(cidr: &Ipv4Network, endpoint: &ProtocolEndpoint) -> OfpOxmTlv { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Ipv4Network` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/openflow/messages/mod.rs:354:16 [INFO] [stderr] | [INFO] [stderr] 354 | proto: &IpProtocol, [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `IpProtocol` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/openflow/messages/deserialize.rs:17:31 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn deserialize(bytes: &[u8; 8]) -> OfpHeader { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/openflow/messages/mod.rs:329:32 [INFO] [stderr] | [INFO] [stderr] 329 | pub fn new_ip_proto(proto: &IpProtocol) -> OfpOxmTlv { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `IpProtocol` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/openflow/messages/mod.rs:337:27 [INFO] [stderr] | [INFO] [stderr] 337 | pub fn new_ipv4(cidr: &Ipv4Network, endpoint: &ProtocolEndpoint) -> OfpOxmTlv { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Ipv4Network` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/openflow/messages/mod.rs:354:16 [INFO] [stderr] | [INFO] [stderr] 354 | proto: &IpProtocol, [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `IpProtocol` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.96s [INFO] running `"docker" "inspect" "60dc2e6c4ba7aef2c10e6b3cec4d7227e60f2624ae8bce46c8057aabe59b7f06"` [INFO] running `"docker" "rm" "-f" "60dc2e6c4ba7aef2c10e6b3cec4d7227e60f2624ae8bce46c8057aabe59b7f06"` [INFO] [stdout] 60dc2e6c4ba7aef2c10e6b3cec4d7227e60f2624ae8bce46c8057aabe59b7f06