[INFO] crate office 0.8.1 is already in cache [INFO] extracting crate office 0.8.1 into work/ex/clippy-test-run/sources/stable/reg/office/0.8.1 [INFO] extracting crate office 0.8.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/office/0.8.1 [INFO] validating manifest of office-0.8.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of office-0.8.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing office-0.8.1 [INFO] finished frobbing office-0.8.1 [INFO] frobbed toml for office-0.8.1 written to work/ex/clippy-test-run/sources/stable/reg/office/0.8.1/Cargo.toml [INFO] started frobbing office-0.8.1 [INFO] finished frobbing office-0.8.1 [INFO] frobbed toml for office-0.8.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/office/0.8.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting office-0.8.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/office/0.8.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 14691a08e2904bb22fb636e84650461fa662b4b46da68d97b2339be76c933178 [INFO] running `"docker" "start" "-a" "14691a08e2904bb22fb636e84650461fa662b4b46da68d97b2339be76c933178"` [INFO] [stderr] Checking quick-xml v0.4.2 [INFO] [stderr] Checking office v0.8.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | sectors: sectors, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `sectors` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | fats: fats, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `fats` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | sector_size: sector_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sector_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | dir_len: dir_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `dir_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:148:13 [INFO] [stderr] | [INFO] [stderr] 148 | fat_len: fat_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `fat_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | dir_start: dir_start, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dir_start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | mini_fat_len: mini_fat_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mini_fat_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | mini_fat_start: mini_fat_start, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mini_fat_start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | difat_start: difat_start, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `difat_start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:222:13 [INFO] [stderr] | [INFO] [stderr] 222 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:223:13 [INFO] [stderr] | [INFO] [stderr] 223 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:224:13 [INFO] [stderr] | [INFO] [stderr] 224 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vba.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | cfb: cfb, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cfb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vba.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | modules: modules, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `modules` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vba.rs:330:13 [INFO] [stderr] | [INFO] [stderr] 330 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vba.rs:331:13 [INFO] [stderr] | [INFO] [stderr] 331 | stream_name: stream_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:186:13 [INFO] [stderr] | [INFO] [stderr] 186 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:310:13 [INFO] [stderr] | [INFO] [stderr] 310 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:311:13 [INFO] [stderr] | [INFO] [stderr] 311 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | sectors: sectors, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `sectors` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | fats: fats, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `fats` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | sector_size: sector_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sector_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | dir_len: dir_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `dir_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:148:13 [INFO] [stderr] | [INFO] [stderr] 148 | fat_len: fat_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `fat_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | dir_start: dir_start, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dir_start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | mini_fat_len: mini_fat_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mini_fat_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | mini_fat_start: mini_fat_start, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mini_fat_start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | difat_start: difat_start, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `difat_start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:222:13 [INFO] [stderr] | [INFO] [stderr] 222 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:223:13 [INFO] [stderr] | [INFO] [stderr] 223 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:224:13 [INFO] [stderr] | [INFO] [stderr] 224 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vba.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | cfb: cfb, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cfb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vba.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | modules: modules, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `modules` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vba.rs:330:13 [INFO] [stderr] | [INFO] [stderr] 330 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vba.rs:331:13 [INFO] [stderr] | [INFO] [stderr] 331 | stream_name: stream_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:186:13 [INFO] [stderr] | [INFO] [stderr] 186 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:310:13 [INFO] [stderr] | [INFO] [stderr] 310 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:311:13 [INFO] [stderr] | [INFO] [stderr] 311 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/xlsb.rs:130:27 [INFO] [stderr] | [INFO] [stderr] 130 | if rel_len != 0xFFFFFFFF { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/xlsx.rs:29:23 [INFO] [stderr] | [INFO] [stderr] 29 | Err(e) => return Some(Err(e.into())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Err(e.into()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cfb.rs:11:25 [INFO] [stderr] | [INFO] [stderr] 11 | const ENDOFCHAIN: u32 = 0xFFFFFFFE; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cfb.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | const FREESECT: u32 = 0xFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vba.rs:96:21 [INFO] [stderr] | [INFO] [stderr] 96 | None => return Err(format!("Cannot find module {}", name).into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("Cannot find module {}", name).into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/xlsb.rs:130:27 [INFO] [stderr] | [INFO] [stderr] 130 | if rel_len != 0xFFFFFFFF { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/xlsx.rs:29:23 [INFO] [stderr] | [INFO] [stderr] 29 | Err(e) => return Some(Err(e.into())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Err(e.into()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cfb.rs:11:25 [INFO] [stderr] | [INFO] [stderr] 11 | const ENDOFCHAIN: u32 = 0xFFFFFFFE; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cfb.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | const FREESECT: u32 = 0xFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vba.rs:96:21 [INFO] [stderr] | [INFO] [stderr] 96 | None => return Err(format!("Cannot find module {}", name).into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("Cannot find module {}", name).into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/xls.rs:153:9 [INFO] [stderr] | [INFO] [stderr] 153 | let mut read = &mut &r[8..]; [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/xls.rs:153:9 [INFO] [stderr] | [INFO] [stderr] 153 | let mut read = &mut &r[8..]; [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/errors.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | / error_chain! { [INFO] [stderr] 11 | | types { [INFO] [stderr] 12 | | Error, ErrorKind, ChainErr, Result; [INFO] [stderr] 13 | | } [INFO] [stderr] ... | [INFO] [stderr] 35 | | // } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: casting from `*const [u8]` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/utils.rs:8:43 [INFO] [stderr] | [INFO] [stderr] 8 | unsafe { ::std::slice::from_raw_parts(s as *const [u8] as *const u32, s.len() / 4) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:36:28 [INFO] [stderr] | [INFO] [stderr] 36 | row += ((c - b'0') as u32) * pow; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(c - b'0')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:48:25 [INFO] [stderr] | [INFO] [stderr] 48 | col += ((c - b'A') as u32 + 1) * pow; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(c - b'A')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:56:25 [INFO] [stderr] | [INFO] [stderr] 56 | col += ((c - b'a') as u32 + 1) * pow; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(c - b'a')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/xlsb.rs:45:42 [INFO] [stderr] | [INFO] [stderr] 45 | VbaProject::new(&mut f, len).map(|v| Cow::Owned(v)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Cow::Owned` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/errors.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | / error_chain! { [INFO] [stderr] 11 | | types { [INFO] [stderr] 12 | | Error, ErrorKind, ChainErr, Result; [INFO] [stderr] 13 | | } [INFO] [stderr] ... | [INFO] [stderr] 35 | | // } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: casting from `*const [u8]` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/utils.rs:8:43 [INFO] [stderr] | [INFO] [stderr] 8 | unsafe { ::std::slice::from_raw_parts(s as *const [u8] as *const u32, s.len() / 4) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:36:28 [INFO] [stderr] | [INFO] [stderr] 36 | row += ((c - b'0') as u32) * pow; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(c - b'0')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:48:25 [INFO] [stderr] | [INFO] [stderr] 48 | col += ((c - b'A') as u32 + 1) * pow; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(c - b'A')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:56:25 [INFO] [stderr] | [INFO] [stderr] 56 | col += ((c - b'a') as u32 + 1) * pow; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(c - b'a')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/xlsb.rs:186:33 [INFO] [stderr] | [INFO] [stderr] 186 | let v = (read_slice::(&buf[8..12]) >> 2) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(read_slice::(&buf[8..12]) >> 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/xlsb.rs:240:37 [INFO] [stderr] | [INFO] [stderr] 240 | Ok(spans.chunks(2).flat_map(|c| c[0]..(c[1] + 1)).map(|col| (row, col)).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `c[0]..=c[1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/xlsb.rs:45:42 [INFO] [stderr] | [INFO] [stderr] 45 | VbaProject::new(&mut f, len).map(|v| Cow::Owned(v)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Cow::Owned` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/xlsb.rs:258:13 [INFO] [stderr] | [INFO] [stderr] 258 | (b & 0x7F) as u16 + (((try!(self.read_u8()) & 0x7F) as u16)<<7) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(b & 0x7F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/xlsb.rs:258:34 [INFO] [stderr] | [INFO] [stderr] 258 | (b & 0x7F) as u16 + (((try!(self.read_u8()) & 0x7F) as u16)<<7) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(try!(self.read_u8()) & 0x7F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/xlsb.rs:260:13 [INFO] [stderr] | [INFO] [stderr] 260 | b as u16 [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/xlsb.rs:275:9 [INFO] [stderr] | [INFO] [stderr] 275 | let _ = try!(self.r.read_exact(&mut buf[..len])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/xlsx.rs:47:42 [INFO] [stderr] | [INFO] [stderr] 47 | VbaProject::new(&mut f, len).map(|v| Cow::Owned(v)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Cow::Owned` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/xlsx.rs:60:28 [INFO] [stderr] | [INFO] [stderr] 60 | if let None = rich_buffer { [INFO] [stderr] | _____________________- ^^^^ [INFO] [stderr] 61 | | // use a buffer since richtext has multiples and for the same cell [INFO] [stderr] 62 | | rich_buffer = Some(String::new()); [INFO] [stderr] 63 | | } [INFO] [stderr] | |_____________________- help: try this: `if rich_buffer.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/xlsb.rs:186:33 [INFO] [stderr] | [INFO] [stderr] 186 | let v = (read_slice::(&buf[8..12]) >> 2) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(read_slice::(&buf[8..12]) >> 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/xlsb.rs:240:37 [INFO] [stderr] | [INFO] [stderr] 240 | Ok(spans.chunks(2).flat_map(|c| c[0]..(c[1] + 1)).map(|col| (row, col)).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `c[0]..=c[1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/xlsb.rs:258:13 [INFO] [stderr] | [INFO] [stderr] 258 | (b & 0x7F) as u16 + (((try!(self.read_u8()) & 0x7F) as u16)<<7) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(b & 0x7F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/xlsb.rs:258:34 [INFO] [stderr] | [INFO] [stderr] 258 | (b & 0x7F) as u16 + (((try!(self.read_u8()) & 0x7F) as u16)<<7) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(try!(self.read_u8()) & 0x7F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/xlsb.rs:260:13 [INFO] [stderr] | [INFO] [stderr] 260 | b as u16 [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/xlsb.rs:275:9 [INFO] [stderr] | [INFO] [stderr] 275 | let _ = try!(self.r.read_exact(&mut buf[..len])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/xlsx.rs:47:42 [INFO] [stderr] | [INFO] [stderr] 47 | VbaProject::new(&mut f, len).map(|v| Cow::Owned(v)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Cow::Owned` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/xlsx.rs:60:28 [INFO] [stderr] | [INFO] [stderr] 60 | if let None = rich_buffer { [INFO] [stderr] | _____________________- ^^^^ [INFO] [stderr] 61 | | // use a buffer since richtext has multiples and for the same cell [INFO] [stderr] 62 | | rich_buffer = Some(String::new()); [INFO] [stderr] 63 | | } [INFO] [stderr] | |_____________________- help: try this: `if rich_buffer.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:167:22 [INFO] [stderr] | [INFO] [stderr] 167 | range.set_value((row as u32, col as u32), DataType::Float(v)); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:167:34 [INFO] [stderr] | [INFO] [stderr] 167 | range.set_value((row as u32, col as u32), DataType::Float(v)); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(col)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:192:22 [INFO] [stderr] | [INFO] [stderr] 192 | range.set_value((row as u32, col as u32), v); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:192:34 [INFO] [stderr] | [INFO] [stderr] 192 | range.set_value((row as u32, col as u32), v); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(col)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:210:17 [INFO] [stderr] | [INFO] [stderr] 210 | let v = (read_slice::(&v[4..]) >> 2) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(read_slice::(&v[4..]) >> 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:217:22 [INFO] [stderr] | [INFO] [stderr] 217 | range.set_value((row as u32, col as u32), v); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:217:34 [INFO] [stderr] | [INFO] [stderr] 217 | range.set_value((row as u32, col as u32), v); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(col)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:248:22 [INFO] [stderr] | [INFO] [stderr] 248 | range.set_value((row as u32, col as u32), DataType::String(strings[i].clone())); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:248:34 [INFO] [stderr] | [INFO] [stderr] 248 | range.set_value((row as u32, col as u32), DataType::String(strings[i].clone())); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(col)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:261:28 [INFO] [stderr] | [INFO] [stderr] 261 | let start = (rw_first, col_first as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(col_first)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:167:22 [INFO] [stderr] | [INFO] [stderr] 167 | range.set_value((row as u32, col as u32), DataType::Float(v)); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:167:34 [INFO] [stderr] | [INFO] [stderr] 167 | range.set_value((row as u32, col as u32), DataType::Float(v)); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(col)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:192:22 [INFO] [stderr] | [INFO] [stderr] 192 | range.set_value((row as u32, col as u32), v); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:192:34 [INFO] [stderr] | [INFO] [stderr] 192 | range.set_value((row as u32, col as u32), v); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(col)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:210:17 [INFO] [stderr] | [INFO] [stderr] 210 | let v = (read_slice::(&v[4..]) >> 2) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(read_slice::(&v[4..]) >> 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:217:22 [INFO] [stderr] | [INFO] [stderr] 217 | range.set_value((row as u32, col as u32), v); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:217:34 [INFO] [stderr] | [INFO] [stderr] 217 | range.set_value((row as u32, col as u32), v); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(col)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/cfb.rs:113:12 [INFO] [stderr] | [INFO] [stderr] 113 | if &buf[..8] != [0xD0, 0xCF, 0x11, 0xE0, 0xA1, 0xB1, 0x1A, 0xE1] { [INFO] [stderr] | ---------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `buf[..8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:248:22 [INFO] [stderr] | [INFO] [stderr] 248 | range.set_value((row as u32, col as u32), DataType::String(strings[i].clone())); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:248:34 [INFO] [stderr] | [INFO] [stderr] 248 | range.set_value((row as u32, col as u32), DataType::String(strings[i].clone())); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(col)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:261:28 [INFO] [stderr] | [INFO] [stderr] 261 | let start = (rw_first, col_first as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(col_first)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/cfb.rs:113:12 [INFO] [stderr] | [INFO] [stderr] 113 | if &buf[..8] != [0xD0, 0xCF, 0x11, 0xE0, 0xA1, 0xB1, 0x1A, 0xE1] { [INFO] [stderr] | ---------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `buf[..8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/vba.rs:191:9 [INFO] [stderr] | [INFO] [stderr] 191 | parts.next().map(|p| reference.description = p.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(p) = parts.next() { ... }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/vba.rs:192:9 [INFO] [stderr] | [INFO] [stderr] 192 | parts.next().map(|p| reference.path = p.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(p) = parts.next() { ... }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/vba.rs:191:9 [INFO] [stderr] | [INFO] [stderr] 191 | parts.next().map(|p| reference.description = p.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(p) = parts.next() { ... }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/vba.rs:192:9 [INFO] [stderr] | [INFO] [stderr] 192 | parts.next().map(|p| reference.path = p.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(p) = parts.next() { ... }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `office`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `office`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "14691a08e2904bb22fb636e84650461fa662b4b46da68d97b2339be76c933178"` [INFO] running `"docker" "rm" "-f" "14691a08e2904bb22fb636e84650461fa662b4b46da68d97b2339be76c933178"` [INFO] [stdout] 14691a08e2904bb22fb636e84650461fa662b4b46da68d97b2339be76c933178