[INFO] crate off_blockway 0.0.8 is already in cache [INFO] extracting crate off_blockway 0.0.8 into work/ex/clippy-test-run/sources/stable/reg/off_blockway/0.0.8 [INFO] extracting crate off_blockway 0.0.8 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/off_blockway/0.0.8 [INFO] validating manifest of off_blockway-0.0.8 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of off_blockway-0.0.8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing off_blockway-0.0.8 [INFO] finished frobbing off_blockway-0.0.8 [INFO] frobbed toml for off_blockway-0.0.8 written to work/ex/clippy-test-run/sources/stable/reg/off_blockway/0.0.8/Cargo.toml [INFO] started frobbing off_blockway-0.0.8 [INFO] finished frobbing off_blockway-0.0.8 [INFO] frobbed toml for off_blockway-0.0.8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/off_blockway/0.0.8/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting off_blockway-0.0.8 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/off_blockway/0.0.8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ac17e74ed7008e8442fa57fe4682da3c4cfca5ae878475796a285d5fa681b033 [INFO] running `"docker" "start" "-a" "ac17e74ed7008e8442fa57fe4682da3c4cfca5ae878475796a285d5fa681b033"` [INFO] [stderr] Checking sha3 v0.6.0 [INFO] [stderr] Checking off_blockway v0.0.8 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | value: value [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | merkle_root: merkle_root, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `merkle_root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/merkle.rs:163:17 [INFO] [stderr] | [INFO] [stderr] 163 | nodes: nodes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nodes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/proof.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/proof.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | hash: hash, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/proof.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | path: path [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transaction.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | uid: uid, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `uid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transaction.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | username: username, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `username` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transaction.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | content: content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transaction.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transaction.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | status: status [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `status` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | value: value [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | merkle_root: merkle_root, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `merkle_root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/merkle.rs:163:17 [INFO] [stderr] | [INFO] [stderr] 163 | nodes: nodes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nodes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/proof.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/proof.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | hash: hash, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/proof.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | path: path [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transaction.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | uid: uid, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `uid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transaction.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | username: username, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `username` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transaction.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | content: content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transaction.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transaction.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | status: status [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `status` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/block.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | return block; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `block` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/block.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | return block; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `block` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/block.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | Ok( ( json ) ) [INFO] [stderr] | ^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/block.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | Ok( ( json ) ) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/merkle.rs:516:13 [INFO] [stderr] | [INFO] [stderr] 516 | Ok( ( json ) ) [INFO] [stderr] | ^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/merkle.rs:516:13 [INFO] [stderr] | [INFO] [stderr] 516 | Ok( ( json ) ) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/merkle.rs:647:9 [INFO] [stderr] | [INFO] [stderr] 647 | return -1; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `-1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chain.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | return chain; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `chain` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chain.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | return self.chain.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.chain.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chain.rs:171:9 [INFO] [stderr] | [INFO] [stderr] 171 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/block.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | return block; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `block` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/block.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | return block; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `block` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/block.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | Ok( ( json ) ) [INFO] [stderr] | ^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/block.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | Ok( ( json ) ) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/merkle.rs:516:13 [INFO] [stderr] | [INFO] [stderr] 516 | Ok( ( json ) ) [INFO] [stderr] | ^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/merkle.rs:516:13 [INFO] [stderr] | [INFO] [stderr] 516 | Ok( ( json ) ) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/merkle.rs:647:9 [INFO] [stderr] | [INFO] [stderr] 647 | return -1; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `-1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chain.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | return chain; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `chain` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chain.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | return self.chain.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.chain.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chain.rs:171:9 [INFO] [stderr] | [INFO] [stderr] 171 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/block.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[allow(dead_code)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/block.rs:204:48 [INFO] [stderr] | [INFO] [stderr] 204 | pub fn set_previous_hash( &mut self, hash: &String ) [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 204 | pub fn set_previous_hash( &mut self, hash: &str ) [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `hash.clone()` to [INFO] [stderr] | [INFO] [stderr] 208 | self.previous_hash = hash.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/merkle.rs:274:39 [INFO] [stderr] | [INFO] [stderr] 274 | let current_row = self.map.get( ¤t_level ).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.map[¤t_level]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/merkle.rs:312:25 [INFO] [stderr] | [INFO] [stderr] 312 | self.root = self.map.get( &0 ).unwrap()[ 0 ].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.map[&0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/merkle.rs:403:37 [INFO] [stderr] | [INFO] [stderr] 403 | let current_nodes = self.map.get( ¤t_level ).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.map[¤t_level]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/merkle.rs:627:28 [INFO] [stderr] | [INFO] [stderr] 627 | let target_level = self.map.get( &level ).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.map[&level]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `target_level` [INFO] [stderr] --> src/merkle.rs:629:18 [INFO] [stderr] | [INFO] [stderr] 629 | for i in 0 .. target_level.len() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 629 | for (i, ) in target_level.iter().enumerate() [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/merkle.rs:659:28 [INFO] [stderr] | [INFO] [stderr] 659 | let target_level = self.map.get( &level ).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.map[&level]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `target_level`. [INFO] [stderr] --> src/merkle.rs:661:18 [INFO] [stderr] | [INFO] [stderr] 661 | for i in 0 .. target_level.len() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 661 | for in &target_level [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/proof.rs:68:33 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn verify( &self, root: &String ) -> bool [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/proof.rs:81:20 [INFO] [stderr] | [INFO] [stderr] 81 | hash = match instance [INFO] [stderr] | ____________________^ [INFO] [stderr] 82 | | { [INFO] [stderr] 83 | | [INFO] [stderr] 84 | | &Node::Left( ref proof ) => ::hash_util::create_node_hash( proof, &hash ), [INFO] [stderr] 85 | | &Node::Right( ref proof ) => ::hash_util::create_node_hash( &hash, proof ), [INFO] [stderr] 86 | | [INFO] [stderr] 87 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 81 | hash = match *instance [INFO] [stderr] 82 | { [INFO] [stderr] 83 | [INFO] [stderr] 84 | Node::Left( ref proof ) => ::hash_util::create_node_hash( proof, &hash ), [INFO] [stderr] 85 | Node::Right( ref proof ) => ::hash_util::create_node_hash( &hash, proof ), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: item `chain::Chain` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/chain.rs:51:1 [INFO] [stderr] | [INFO] [stderr] 51 | / impl Chain [INFO] [stderr] 52 | | { [INFO] [stderr] 53 | | [INFO] [stderr] 54 | | // Constructor for a new chain [INFO] [stderr] ... | [INFO] [stderr] 234 | | [INFO] [stderr] 235 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `chain::Chain` [INFO] [stderr] --> src/chain.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | / pub fn new() -> Chain [INFO] [stderr] 57 | | { [INFO] [stderr] 58 | | [INFO] [stderr] 59 | | // Sets the fields to be all empty [INFO] [stderr] ... | [INFO] [stderr] 72 | | [INFO] [stderr] 73 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 38 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/chain.rs:94:26 [INFO] [stderr] | [INFO] [stderr] 94 | self.tail_hash = self.chain.get( &key2 ).unwrap().hash().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.chain[&key2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/chain.rs:146:35 [INFO] [stderr] | [INFO] [stderr] 146 | pub fn contains( &self, hash: &String ) -> bool [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `off_blockway`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `value` [INFO] [stderr] --> src/lib.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | let value: u8 = 9; [INFO] [stderr] | ^^^^^ help: consider using `_value` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `left_value` [INFO] [stderr] --> src/lib.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | let left_value: u8 = 0; [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_left_value` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `right_value` [INFO] [stderr] --> src/lib.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | let right_value: u8 = 1; [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_right_value` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `status` [INFO] [stderr] --> src/lib.rs:212:13 [INFO] [stderr] | [INFO] [stderr] 212 | let status = Command::new( "rm" ).args( &[ "-rf", "testing-block.json" ] [INFO] [stderr] | ^^^^^^ help: consider using `_status` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `json_block` [INFO] [stderr] --> src/lib.rs:219:13 [INFO] [stderr] | [INFO] [stderr] 219 | let json_block = block::Block::read_and_construct( "testing-block.json" ).expect( "Did not convert json_block" ); [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_json_block` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/lib.rs:374:13 [INFO] [stderr] | [INFO] [stderr] 374 | for i in 0 .. 16 [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/lib.rs:423:13 [INFO] [stderr] | [INFO] [stderr] 423 | for i in 0 .. 8 [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/lib.rs:444:13 [INFO] [stderr] | [INFO] [stderr] 444 | for i in 0 .. 8 [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/lib.rs:465:13 [INFO] [stderr] | [INFO] [stderr] 465 | for i in 0 .. 8 [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/lib.rs:496:13 [INFO] [stderr] | [INFO] [stderr] 496 | for i in 0 .. 8 [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/lib.rs:529:13 [INFO] [stderr] | [INFO] [stderr] 529 | for i in 0 .. 8 [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/lib.rs:569:13 [INFO] [stderr] | [INFO] [stderr] 569 | for i in 0 .. 8 [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `status` [INFO] [stderr] --> src/lib.rs:677:13 [INFO] [stderr] | [INFO] [stderr] 677 | let status = Command::new( "rm" ).args( &[ "-rf", "testing-merkle.json" ] [INFO] [stderr] | ^^^^^^ help: consider using `_status` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `json_nodes` [INFO] [stderr] --> src/lib.rs:686:13 [INFO] [stderr] | [INFO] [stderr] 686 | let json_nodes = merkle::Merkle::read_and_construct( "testing-merkle.json" ).expect("Did not convert to json_nodes"); [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_json_nodes` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `status` [INFO] [stderr] --> src/lib.rs:785:13 [INFO] [stderr] | [INFO] [stderr] 785 | let status = Command::new( "rm" ).args( &[ "-rf", "testing-chain.json" ] ).status().expect( "Process failed "); [INFO] [stderr] | ^^^^^^ help: consider using `_status` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `d_chain` [INFO] [stderr] --> src/lib.rs:798:13 [INFO] [stderr] | [INFO] [stderr] 798 | let d_chain = chain::Chain::read_and_construct( "testing-chain.json" ).expect("Did not convert to d_chain"); [INFO] [stderr] | ^^^^^^^ help: consider using `_d_chain` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `status` [INFO] [stderr] --> src/lib.rs:909:13 [INFO] [stderr] | [INFO] [stderr] 909 | let status = Command::new( "rm" ).args( &[ "testing-write.json" ] ).status().expect( "Filed to delete the json files" ); [INFO] [stderr] | ^^^^^^ help: consider using `_status` instead [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/block.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[allow(dead_code)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/block.rs:204:48 [INFO] [stderr] | [INFO] [stderr] 204 | pub fn set_previous_hash( &mut self, hash: &String ) [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 204 | pub fn set_previous_hash( &mut self, hash: &str ) [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `hash.clone()` to [INFO] [stderr] | [INFO] [stderr] 208 | self.previous_hash = hash.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/merkle.rs:274:39 [INFO] [stderr] | [INFO] [stderr] 274 | let current_row = self.map.get( ¤t_level ).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.map[¤t_level]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/merkle.rs:312:25 [INFO] [stderr] | [INFO] [stderr] 312 | self.root = self.map.get( &0 ).unwrap()[ 0 ].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.map[&0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/merkle.rs:403:37 [INFO] [stderr] | [INFO] [stderr] 403 | let current_nodes = self.map.get( ¤t_level ).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.map[¤t_level]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/merkle.rs:627:28 [INFO] [stderr] | [INFO] [stderr] 627 | let target_level = self.map.get( &level ).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.map[&level]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `target_level` [INFO] [stderr] --> src/merkle.rs:629:18 [INFO] [stderr] | [INFO] [stderr] 629 | for i in 0 .. target_level.len() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 629 | for (i, ) in target_level.iter().enumerate() [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/merkle.rs:659:28 [INFO] [stderr] | [INFO] [stderr] 659 | let target_level = self.map.get( &level ).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.map[&level]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `target_level`. [INFO] [stderr] --> src/merkle.rs:661:18 [INFO] [stderr] | [INFO] [stderr] 661 | for i in 0 .. target_level.len() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 661 | for in &target_level [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/proof.rs:68:33 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn verify( &self, root: &String ) -> bool [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/proof.rs:81:20 [INFO] [stderr] | [INFO] [stderr] 81 | hash = match instance [INFO] [stderr] | ____________________^ [INFO] [stderr] 82 | | { [INFO] [stderr] 83 | | [INFO] [stderr] 84 | | &Node::Left( ref proof ) => ::hash_util::create_node_hash( proof, &hash ), [INFO] [stderr] 85 | | &Node::Right( ref proof ) => ::hash_util::create_node_hash( &hash, proof ), [INFO] [stderr] 86 | | [INFO] [stderr] 87 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 81 | hash = match *instance [INFO] [stderr] 82 | { [INFO] [stderr] 83 | [INFO] [stderr] 84 | Node::Left( ref proof ) => ::hash_util::create_node_hash( proof, &hash ), [INFO] [stderr] 85 | Node::Right( ref proof ) => ::hash_util::create_node_hash( &hash, proof ), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: item `chain::Chain` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/chain.rs:51:1 [INFO] [stderr] | [INFO] [stderr] 51 | / impl Chain [INFO] [stderr] 52 | | { [INFO] [stderr] 53 | | [INFO] [stderr] 54 | | // Constructor for a new chain [INFO] [stderr] ... | [INFO] [stderr] 234 | | [INFO] [stderr] 235 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `chain::Chain` [INFO] [stderr] --> src/chain.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | / pub fn new() -> Chain [INFO] [stderr] 57 | | { [INFO] [stderr] 58 | | [INFO] [stderr] 59 | | // Sets the fields to be all empty [INFO] [stderr] ... | [INFO] [stderr] 72 | | [INFO] [stderr] 73 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 38 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/chain.rs:94:26 [INFO] [stderr] | [INFO] [stderr] 94 | self.tail_hash = self.chain.get( &key2 ).unwrap().hash().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.chain[&key2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/chain.rs:146:35 [INFO] [stderr] | [INFO] [stderr] 146 | pub fn contains( &self, hash: &String ) -> bool [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:192:9 [INFO] [stderr] | [INFO] [stderr] 192 | block.write_to( &file_name ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:199:9 [INFO] [stderr] | [INFO] [stderr] 199 | file.read_to_string( &mut json ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:217:9 [INFO] [stderr] | [INFO] [stderr] 217 | block.write_to( "testing-block.json" ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:657:9 [INFO] [stderr] | [INFO] [stderr] 657 | merkle.write_to( &file_name ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:664:9 [INFO] [stderr] | [INFO] [stderr] 664 | file.read_to_string( &mut json ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:684:9 [INFO] [stderr] | [INFO] [stderr] 684 | merkle.write_to( "testing-merkle.json" ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/lib.rs:746:19 [INFO] [stderr] | [INFO] [stderr] 746 | assert!( chain.contains( &String::from("9") ) == false ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!chain.contains( &String::from("9") )` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:766:9 [INFO] [stderr] | [INFO] [stderr] 766 | chain.write_to( "testing-chain.json" ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:772:9 [INFO] [stderr] | [INFO] [stderr] 772 | file.read_to_string( &mut string ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:796:9 [INFO] [stderr] | [INFO] [stderr] 796 | chain.write_to( "testing-chain.json" ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:890:9 [INFO] [stderr] | [INFO] [stderr] 890 | transaction.write_to( "testing-write.json" ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:896:9 [INFO] [stderr] | [INFO] [stderr] 896 | file.read_to_string( &mut info ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:921:9 [INFO] [stderr] | [INFO] [stderr] 921 | transaction.write_to( "testing-write.json" ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `off_blockway`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "ac17e74ed7008e8442fa57fe4682da3c4cfca5ae878475796a285d5fa681b033"` [INFO] running `"docker" "rm" "-f" "ac17e74ed7008e8442fa57fe4682da3c4cfca5ae878475796a285d5fa681b033"` [INFO] [stdout] ac17e74ed7008e8442fa57fe4682da3c4cfca5ae878475796a285d5fa681b033