[INFO] crate odds 0.3.1 is already in cache [INFO] extracting crate odds 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/odds/0.3.1 [INFO] extracting crate odds 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/odds/0.3.1 [INFO] validating manifest of odds-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of odds-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing odds-0.3.1 [INFO] finished frobbing odds-0.3.1 [INFO] frobbed toml for odds-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/odds/0.3.1/Cargo.toml [INFO] started frobbing odds-0.3.1 [INFO] finished frobbing odds-0.3.1 [INFO] frobbed toml for odds-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/odds/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting odds-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/odds/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 090aac46ba17d6c2bc8ac20e17b11bfbdc81252f42ae082be83af1cab89b9260 [INFO] running `"docker" "start" "-a" "090aac46ba17d6c2bc8ac20e17b11bfbdc81252f42ae082be83af1cab89b9260"` [INFO] [stderr] Checking unchecked-index v0.2.2 [INFO] [stderr] Checking rawslice v0.1.0 [INFO] [stderr] Checking quickcheck v0.4.1 [INFO] [stderr] Checking odds v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/string.rs:224:22 [INFO] [stderr] | [INFO] [stderr] 224 | CharChunks { s: s, n: n } [INFO] [stderr] | ^^^^ help: replace it with: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/string.rs:224:28 [INFO] [stderr] | [INFO] [stderr] 224 | CharChunks { s: s, n: n } [INFO] [stderr] | ^^^^ help: replace it with: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/string.rs:262:35 [INFO] [stderr] | [INFO] [stderr] 262 | None => CharWindows { s: s, a: s.len(), b: s.len() }, [INFO] [stderr] | ^^^^ help: replace it with: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/string.rs:263:44 [INFO] [stderr] | [INFO] [stderr] 263 | Some((i, ch)) => CharWindows { s: s, a: 0, b: i + ch.len_utf8() } [INFO] [stderr] | ^^^^ help: replace it with: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/slice/blocked.rs:82:17 [INFO] [stderr] | [INFO] [stderr] 82 | ptr: ptr, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ptr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/slice/blocked.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/slice/iter.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | ptr: ptr, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ptr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/slice/iter.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/slice/unalign.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | ptr: ptr, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ptr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/slice/unalign.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/slice/unalign.rs:54:17 [INFO] [stderr] | [INFO] [stderr] 54 | ptr: ptr, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ptr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/slice/mod.rs:263:13 [INFO] [stderr] | [INFO] [stderr] 263 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stride.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | begin: begin, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `begin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stride.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | stride: stride, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stride` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stride.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | begin: begin, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `begin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stride.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | stride: stride, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stride` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/slice/iter.rs:131:17 [INFO] [stderr] | [INFO] [stderr] 131 | elt [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/slice/iter.rs:130:27 [INFO] [stderr] | [INFO] [stderr] 130 | let elt = Some(*self.end); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'get_unchecked': use unchecked-index crate [INFO] [stderr] --> src/slice/rev.rs:10:6 [INFO] [stderr] | [INFO] [stderr] 10 | use {get_unchecked, get_unchecked_mut}; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'get_unchecked_mut': use unchecked-index crate [INFO] [stderr] --> src/slice/rev.rs:10:21 [INFO] [stderr] | [INFO] [stderr] 10 | use {get_unchecked, get_unchecked_mut}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'slice_unchecked': use unchecked-index crate [INFO] [stderr] --> src/slice/rev.rs:12:6 [INFO] [stderr] | [INFO] [stderr] 12 | use {slice_unchecked, slice_unchecked_mut}; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'slice_unchecked_mut': use unchecked-index crate [INFO] [stderr] --> src/slice/rev.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | use {slice_unchecked, slice_unchecked_mut}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'get_unchecked': use unchecked-index crate [INFO] [stderr] --> src/slice/rev.rs:73:45 [INFO] [stderr] | [INFO] [stderr] 73 | self.raw_index(i).map(move |ri| get_unchecked(&self.0, ri)) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'get_unchecked_mut': use unchecked-index crate [INFO] [stderr] --> src/slice/rev.rs:82:45 [INFO] [stderr] | [INFO] [stderr] 82 | self.raw_index(i).map(move |ri| get_unchecked_mut(&mut self.0, ri)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'slice_unchecked': use unchecked-index crate [INFO] [stderr] --> src/slice/rev.rs:240:34 [INFO] [stderr] | [INFO] [stderr] 240 | <&RevSlice<_>>::from(slice_unchecked(&self.0, start_r, end_r)) [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'slice_unchecked_mut': use unchecked-index crate [INFO] [stderr] --> src/slice/rev.rs:258:38 [INFO] [stderr] | [INFO] [stderr] 258 | <&mut RevSlice<_>>::from(slice_unchecked_mut(&mut self.0, start_r, end_r)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/char.rs:62:28 [INFO] [stderr] | [INFO] [stderr] 62 | if code < MAX_ONE_B && buf.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/string.rs:104:27 [INFO] [stderr] | [INFO] [stderr] 104 | let end = r.end().unwrap_or(self.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/slice/blocked.rs:80:23 [INFO] [stderr] | [INFO] [stderr] 80 | let end = ptr.offset(len as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(len)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/slice/blocked.rs:126:28 [INFO] [stderr] | [INFO] [stderr] 126 | self.ptr = self.ptr.offset(B::capacity() as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.ptr.add(B::capacity())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/slice/blocked.rs:153:16 [INFO] [stderr] | [INFO] [stderr] 153 | &*(self.ptr.offset((i * B::capacity()) as isize) as *const B) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.ptr.add((i * B::capacity()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/slice/iter.rs:148:23 [INFO] [stderr] | [INFO] [stderr] 148 | let end = ptr.offset(slice.len() as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(slice.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/slice/iter.rs:172:15 [INFO] [stderr] | [INFO] [stderr] 172 | &*self.ptr.offset(i as isize) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.ptr.add(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/slice/unalign.rs:52:23 [INFO] [stderr] | [INFO] [stderr] 52 | let end = ptr.offset(len as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/slice/unalign.rs:102:28 [INFO] [stderr] | [INFO] [stderr] 102 | self.ptr = self.ptr.offset(size_of::() as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.ptr.add(size_of::())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: item `slice::rev::RevSlice` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/slice/rev.rs:47:1 [INFO] [stderr] | [INFO] [stderr] 47 | / impl RevSlice { [INFO] [stderr] 48 | | /// Return the length of the slice. [INFO] [stderr] 49 | | pub fn len(&self) -> usize { [INFO] [stderr] 50 | | self.0.len() [INFO] [stderr] ... | [INFO] [stderr] 123 | | } [INFO] [stderr] 124 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/slice/rev.rs:168:13 [INFO] [stderr] | [INFO] [stderr] 168 | transmute(slc.as_ref()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(slc.as_ref() as *const [T] as *const slice::rev::RevSlice)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/slice/rev.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | transmute(slc.as_mut()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(slc.as_mut() as *mut [T] as *mut slice::rev::RevSlice)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/slice/rev.rs:235:31 [INFO] [stderr] | [INFO] [stderr] 235 | let end = index.end().unwrap_or(self.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/slice/rev.rs:253:31 [INFO] [stderr] | [INFO] [stderr] 253 | let end = index.end().unwrap_or(self.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/slice/mod.rs:73:8 [INFO] [stderr] | [INFO] [stderr] 73 | if data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/slice/mod.rs:173:32 [INFO] [stderr] | [INFO] [stderr] 173 | let i = self.find(elt).unwrap_or(self.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/slice/mod.rs:182:32 [INFO] [stderr] | [INFO] [stderr] 182 | let i = self.find(elt).unwrap_or(self.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/slice/mod.rs:311:25 [INFO] [stderr] | [INFO] [stderr] 311 | let a_end = a.as_ptr().offset(a.len() as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `a.as_ptr().add(a.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/slice/mod.rs:325:25 [INFO] [stderr] | [INFO] [stderr] 325 | let a_end = a.as_ptr().offset(a.len() as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `a.as_ptr().add(a.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/slice/mod.rs:394:5 [INFO] [stderr] | [INFO] [stderr] 394 | / let t_len; [INFO] [stderr] 395 | | [INFO] [stderr] 396 | | if prefix > data.len() { [INFO] [stderr] 397 | | t_len = 0; [INFO] [stderr] 398 | | } else { [INFO] [stderr] 399 | | t_len = (data.len() - prefix) / size_t; [INFO] [stderr] 400 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let t_len = if prefix > data.len() { 0 } else { (data.len() - prefix) / size_t };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/slice/mod.rs:403:25 [INFO] [stderr] | [INFO] [stderr] 403 | from_raw_parts(ptr.offset(prefix as isize) as *const T, t_len), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(prefix)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/slice/mod.rs:404:25 [INFO] [stderr] | [INFO] [stderr] 404 | from_raw_parts(ptr.offset((prefix + t_len * size_t) as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add((prefix + t_len * size_t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/stride.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | / pub fn get<'b>(&'b self, i: usize) -> Option<&'b A> { [INFO] [stderr] 179 | | if i >= self.len() { [INFO] [stderr] 180 | | None [INFO] [stderr] 181 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 186 | | } [INFO] [stderr] 187 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 268 | stride_impl!{struct Stride -> &'a [A], as_ptr, *const A, &'a A} [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const A`) to a reference type (`&'b A`) [INFO] [stderr] --> src/stride.rs:184:30 [INFO] [stderr] | [INFO] [stderr] 184 | Some(mem::transmute(ptr)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `&*ptr` [INFO] [stderr] ... [INFO] [stderr] 268 | stride_impl!{struct Stride -> &'a [A], as_ptr, *const A, &'a A} [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const A`) to a reference type (`&'a A`) [INFO] [stderr] --> src/stride.rs:201:29 [INFO] [stderr] | [INFO] [stderr] 201 | mem::transmute(self.begin.offset(self.offset)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*self.begin.offset(self.offset)` [INFO] [stderr] ... [INFO] [stderr] 268 | stride_impl!{struct Stride -> &'a [A], as_ptr, *const A, &'a A} [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const A`) to a reference type (`&'a A`) [INFO] [stderr] --> src/stride.rs:225:35 [INFO] [stderr] | [INFO] [stderr] 225 | let elt = mem::transmute(self.begin.offset(self.end)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*self.begin.offset(self.end)` [INFO] [stderr] ... [INFO] [stderr] 268 | stride_impl!{struct Stride -> &'a [A], as_ptr, *const A, &'a A} [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/stride.rs:240:13 [INFO] [stderr] | [INFO] [stderr] 240 | / fn index<'b>(&'b self, i: usize) -> &'b A [INFO] [stderr] 241 | | { [INFO] [stderr] 242 | | assert!(i < self.len()); [INFO] [stderr] 243 | | unsafe { [INFO] [stderr] ... | [INFO] [stderr] 246 | | } [INFO] [stderr] 247 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 268 | stride_impl!{struct Stride -> &'a [A], as_ptr, *const A, &'a A} [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const A`) to a reference type (`&'b A`) [INFO] [stderr] --> src/stride.rs:245:21 [INFO] [stderr] | [INFO] [stderr] 245 | mem::transmute(ptr) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `&*ptr` [INFO] [stderr] ... [INFO] [stderr] 268 | stride_impl!{struct Stride -> &'a [A], as_ptr, *const A, &'a A} [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/stride.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | / pub fn get<'b>(&'b self, i: usize) -> Option<&'b A> { [INFO] [stderr] 179 | | if i >= self.len() { [INFO] [stderr] 180 | | None [INFO] [stderr] 181 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 186 | | } [INFO] [stderr] 187 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 269 | stride_impl!{struct StrideMut -> &'a mut [A], as_mut_ptr, *mut A, &'a mut A} [INFO] [stderr] | ---------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut A`) to a reference type (`&'b A`) [INFO] [stderr] --> src/stride.rs:184:30 [INFO] [stderr] | [INFO] [stderr] 184 | Some(mem::transmute(ptr)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `&*ptr` [INFO] [stderr] ... [INFO] [stderr] 269 | stride_impl!{struct StrideMut -> &'a mut [A], as_mut_ptr, *mut A, &'a mut A} [INFO] [stderr] | ---------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut A`) to a reference type (`&'a mut A`) [INFO] [stderr] --> src/stride.rs:201:29 [INFO] [stderr] | [INFO] [stderr] 201 | mem::transmute(self.begin.offset(self.offset)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *self.begin.offset(self.offset)` [INFO] [stderr] ... [INFO] [stderr] 269 | stride_impl!{struct StrideMut -> &'a mut [A], as_mut_ptr, *mut A, &'a mut A} [INFO] [stderr] | ---------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut A`) to a reference type (`&'a mut A`) [INFO] [stderr] --> src/stride.rs:225:35 [INFO] [stderr] | [INFO] [stderr] 225 | let elt = mem::transmute(self.begin.offset(self.end)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *self.begin.offset(self.end)` [INFO] [stderr] ... [INFO] [stderr] 269 | stride_impl!{struct StrideMut -> &'a mut [A], as_mut_ptr, *mut A, &'a mut A} [INFO] [stderr] | ---------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/stride.rs:240:13 [INFO] [stderr] | [INFO] [stderr] 240 | / fn index<'b>(&'b self, i: usize) -> &'b A [INFO] [stderr] 241 | | { [INFO] [stderr] 242 | | assert!(i < self.len()); [INFO] [stderr] 243 | | unsafe { [INFO] [stderr] ... | [INFO] [stderr] 246 | | } [INFO] [stderr] 247 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 269 | stride_impl!{struct StrideMut -> &'a mut [A], as_mut_ptr, *mut A, &'a mut A} [INFO] [stderr] | ---------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut A`) to a reference type (`&'b A`) [INFO] [stderr] --> src/stride.rs:245:21 [INFO] [stderr] | [INFO] [stderr] 245 | mem::transmute(ptr) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `&*ptr` [INFO] [stderr] ... [INFO] [stderr] 269 | stride_impl!{struct StrideMut -> &'a mut [A], as_mut_ptr, *mut A, &'a mut A} [INFO] [stderr] | ---------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/stride.rs:280:5 [INFO] [stderr] | [INFO] [stderr] 280 | / pub fn get_mut<'b>(&'b mut self, i: usize) -> Option<&'b mut A> { [INFO] [stderr] 281 | | if i >= self.len() { [INFO] [stderr] 282 | | None [INFO] [stderr] 283 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 288 | | } [INFO] [stderr] 289 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/stride.rs:296:5 [INFO] [stderr] | [INFO] [stderr] 296 | / fn index_mut<'b>(&'b mut self, i: usize) -> &'b mut A { [INFO] [stderr] 297 | | assert!(i < self.len()); [INFO] [stderr] 298 | | unsafe { [INFO] [stderr] 299 | | let ptr = self.begin.offset(self.offset + self.stride * (i as isize)); [INFO] [stderr] 300 | | &mut *ptr [INFO] [stderr] 301 | | } [INFO] [stderr] 302 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/string.rs:224:22 [INFO] [stderr] | [INFO] [stderr] 224 | CharChunks { s: s, n: n } [INFO] [stderr] | ^^^^ help: replace it with: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/string.rs:224:28 [INFO] [stderr] | [INFO] [stderr] 224 | CharChunks { s: s, n: n } [INFO] [stderr] | ^^^^ help: replace it with: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/string.rs:262:35 [INFO] [stderr] | [INFO] [stderr] 262 | None => CharWindows { s: s, a: s.len(), b: s.len() }, [INFO] [stderr] | ^^^^ help: replace it with: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/string.rs:263:44 [INFO] [stderr] | [INFO] [stderr] 263 | Some((i, ch)) => CharWindows { s: s, a: 0, b: i + ch.len_utf8() } [INFO] [stderr] | ^^^^ help: replace it with: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/slice/blocked.rs:82:17 [INFO] [stderr] | [INFO] [stderr] 82 | ptr: ptr, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ptr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/slice/blocked.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/slice/iter.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | ptr: ptr, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ptr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/slice/iter.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/slice/unalign.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | ptr: ptr, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ptr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/slice/unalign.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/slice/unalign.rs:54:17 [INFO] [stderr] | [INFO] [stderr] 54 | ptr: ptr, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ptr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/slice/mod.rs:263:13 [INFO] [stderr] | [INFO] [stderr] 263 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stride.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | begin: begin, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `begin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stride.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | stride: stride, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stride` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stride.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | begin: begin, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `begin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stride.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | stride: stride, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stride` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/bench.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `odds`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/slice/iter.rs:131:17 [INFO] [stderr] | [INFO] [stderr] 131 | elt [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/slice/iter.rs:130:27 [INFO] [stderr] | [INFO] [stderr] 130 | let elt = Some(*self.end); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/slice/unalign.rs:116:47 [INFO] [stderr] | [INFO] [stderr] 116 | assert_eq!(iter.next(), Some(u32::from_be(0x00010203))); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0001_0203` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/slice/unalign.rs:117:47 [INFO] [stderr] | [INFO] [stderr] 117 | assert_eq!(iter.next(), Some(u32::from_be(0x04050607))); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0405_0607` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'get_unchecked': use unchecked-index crate [INFO] [stderr] --> src/slice/rev.rs:10:6 [INFO] [stderr] | [INFO] [stderr] 10 | use {get_unchecked, get_unchecked_mut}; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'get_unchecked_mut': use unchecked-index crate [INFO] [stderr] --> src/slice/rev.rs:10:21 [INFO] [stderr] | [INFO] [stderr] 10 | use {get_unchecked, get_unchecked_mut}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'slice_unchecked': use unchecked-index crate [INFO] [stderr] --> src/slice/rev.rs:12:6 [INFO] [stderr] | [INFO] [stderr] 12 | use {slice_unchecked, slice_unchecked_mut}; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'slice_unchecked_mut': use unchecked-index crate [INFO] [stderr] --> src/slice/rev.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | use {slice_unchecked, slice_unchecked_mut}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'get_unchecked': use unchecked-index crate [INFO] [stderr] --> src/slice/rev.rs:73:45 [INFO] [stderr] | [INFO] [stderr] 73 | self.raw_index(i).map(move |ri| get_unchecked(&self.0, ri)) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'get_unchecked_mut': use unchecked-index crate [INFO] [stderr] --> src/slice/rev.rs:82:45 [INFO] [stderr] | [INFO] [stderr] 82 | self.raw_index(i).map(move |ri| get_unchecked_mut(&mut self.0, ri)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'slice_unchecked': use unchecked-index crate [INFO] [stderr] --> src/slice/rev.rs:240:34 [INFO] [stderr] | [INFO] [stderr] 240 | <&RevSlice<_>>::from(slice_unchecked(&self.0, start_r, end_r)) [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'slice_unchecked_mut': use unchecked-index crate [INFO] [stderr] --> src/slice/rev.rs:258:38 [INFO] [stderr] | [INFO] [stderr] 258 | <&mut RevSlice<_>>::from(slice_unchecked_mut(&mut self.0, start_r, end_r)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/count_ones.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/find.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] error: Could not compile `odds`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `odds`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/quick.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if v.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/quick.rs:34:12 [INFO] [stderr] | [INFO] [stderr] 34 | if v.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/quick.rs:45:12 [INFO] [stderr] | [INFO] [stderr] 45 | if v.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/char.rs:62:28 [INFO] [stderr] | [INFO] [stderr] 62 | if code < MAX_ONE_B && buf.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/string.rs:104:27 [INFO] [stderr] | [INFO] [stderr] 104 | let end = r.end().unwrap_or(self.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/string.rs:381:28 [INFO] [stderr] | [INFO] [stderr] 381 | assert_eq!(t.get_slice(0..t.len()+1), None); [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `0..=t.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/slice/blocked.rs:80:23 [INFO] [stderr] | [INFO] [stderr] 80 | let end = ptr.offset(len as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(len)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/slice/blocked.rs:126:28 [INFO] [stderr] | [INFO] [stderr] 126 | self.ptr = self.ptr.offset(B::capacity() as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.ptr.add(B::capacity())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/slice/blocked.rs:153:16 [INFO] [stderr] | [INFO] [stderr] 153 | &*(self.ptr.offset((i * B::capacity()) as isize) as *const B) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.ptr.add((i * B::capacity()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/slice/blocked.rs:186:5 [INFO] [stderr] | [INFO] [stderr] 186 | iter[2]; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::no_effect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/slice/iter.rs:148:23 [INFO] [stderr] | [INFO] [stderr] 148 | let end = ptr.offset(slice.len() as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(slice.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/slice/iter.rs:172:15 [INFO] [stderr] | [INFO] [stderr] 172 | &*self.ptr.offset(i as isize) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.ptr.add(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/slice/unalign.rs:52:23 [INFO] [stderr] | [INFO] [stderr] 52 | let end = ptr.offset(len as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/slice/unalign.rs:102:28 [INFO] [stderr] | [INFO] [stderr] 102 | self.ptr = self.ptr.offset(size_of::() as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.ptr.add(size_of::())` [INFO] [stderr] | [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> tests/slice.rs:80:35 [INFO] [stderr] | [INFO] [stderr] 80 | ch_slice = self.slice.slice_unchecked(0, char_len); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> tests/slice.rs:81:37 [INFO] [stderr] | [INFO] [stderr] 81 | self.slice = self.slice.slice_unchecked(char_len, self.slice.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: item `slice::rev::RevSlice` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/slice/rev.rs:47:1 [INFO] [stderr] | [INFO] [stderr] 47 | / impl RevSlice { [INFO] [stderr] 48 | | /// Return the length of the slice. [INFO] [stderr] 49 | | pub fn len(&self) -> usize { [INFO] [stderr] 50 | | self.0.len() [INFO] [stderr] ... | [INFO] [stderr] 123 | | } [INFO] [stderr] 124 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/slice/rev.rs:168:13 [INFO] [stderr] | [INFO] [stderr] 168 | transmute(slc.as_ref()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(slc.as_ref() as *const [T] as *const slice::rev::RevSlice)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/slice/rev.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | transmute(slc.as_mut()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(slc.as_mut() as *mut [T] as *mut slice::rev::RevSlice)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/slice/rev.rs:235:31 [INFO] [stderr] | [INFO] [stderr] 235 | let end = index.end().unwrap_or(self.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/slice/rev.rs:253:31 [INFO] [stderr] | [INFO] [stderr] 253 | let end = index.end().unwrap_or(self.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/slice/rev.rs:314:5 [INFO] [stderr] | [INFO] [stderr] 314 | r[4]; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/slice/rev.rs:323:5 [INFO] [stderr] | [INFO] [stderr] 323 | r[!0]; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/slice/mod.rs:73:8 [INFO] [stderr] | [INFO] [stderr] 73 | if data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/slice/mod.rs:173:32 [INFO] [stderr] | [INFO] [stderr] 173 | let i = self.find(elt).unwrap_or(self.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/slice/mod.rs:182:32 [INFO] [stderr] | [INFO] [stderr] 182 | let i = self.find(elt).unwrap_or(self.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/slice/mod.rs:311:25 [INFO] [stderr] | [INFO] [stderr] 311 | let a_end = a.as_ptr().offset(a.len() as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `a.as_ptr().add(a.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/slice.rs:65:12 [INFO] [stderr] | [INFO] [stderr] 65 | if self.slice.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.slice.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/slice/mod.rs:325:25 [INFO] [stderr] | [INFO] [stderr] 325 | let a_end = a.as_ptr().offset(a.len() as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `a.as_ptr().add(a.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/slice/mod.rs:394:5 [INFO] [stderr] | [INFO] [stderr] 394 | / let t_len; [INFO] [stderr] 395 | | [INFO] [stderr] 396 | | if prefix > data.len() { [INFO] [stderr] 397 | | t_len = 0; [INFO] [stderr] 398 | | } else { [INFO] [stderr] 399 | | t_len = (data.len() - prefix) / size_t; [INFO] [stderr] 400 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let t_len = if prefix > data.len() { 0 } else { (data.len() - prefix) / size_t };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/slice/mod.rs:403:25 [INFO] [stderr] | [INFO] [stderr] 403 | from_raw_parts(ptr.offset(prefix as isize) as *const T, t_len), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(prefix)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/slice/mod.rs:404:25 [INFO] [stderr] | [INFO] [stderr] 404 | from_raw_parts(ptr.offset((prefix + t_len * size_t) as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add((prefix + t_len * size_t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/slice/mod.rs:460:8 [INFO] [stderr] | [INFO] [stderr] 460 | if 0 < data.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/stride.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | / pub fn get<'b>(&'b self, i: usize) -> Option<&'b A> { [INFO] [stderr] 179 | | if i >= self.len() { [INFO] [stderr] 180 | | None [INFO] [stderr] 181 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 186 | | } [INFO] [stderr] 187 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 268 | stride_impl!{struct Stride -> &'a [A], as_ptr, *const A, &'a A} [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const A`) to a reference type (`&'b A`) [INFO] [stderr] --> src/stride.rs:184:30 [INFO] [stderr] | [INFO] [stderr] 184 | Some(mem::transmute(ptr)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `&*ptr` [INFO] [stderr] ... [INFO] [stderr] 268 | stride_impl!{struct Stride -> &'a [A], as_ptr, *const A, &'a A} [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const A`) to a reference type (`&'a A`) [INFO] [stderr] --> src/stride.rs:201:29 [INFO] [stderr] | [INFO] [stderr] 201 | mem::transmute(self.begin.offset(self.offset)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*self.begin.offset(self.offset)` [INFO] [stderr] ... [INFO] [stderr] 268 | stride_impl!{struct Stride -> &'a [A], as_ptr, *const A, &'a A} [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const A`) to a reference type (`&'a A`) [INFO] [stderr] --> src/stride.rs:225:35 [INFO] [stderr] | [INFO] [stderr] 225 | let elt = mem::transmute(self.begin.offset(self.end)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*self.begin.offset(self.end)` [INFO] [stderr] ... [INFO] [stderr] 268 | stride_impl!{struct Stride -> &'a [A], as_ptr, *const A, &'a A} [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/stride.rs:240:13 [INFO] [stderr] | [INFO] [stderr] 240 | / fn index<'b>(&'b self, i: usize) -> &'b A [INFO] [stderr] 241 | | { [INFO] [stderr] 242 | | assert!(i < self.len()); [INFO] [stderr] 243 | | unsafe { [INFO] [stderr] ... | [INFO] [stderr] 246 | | } [INFO] [stderr] 247 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 268 | stride_impl!{struct Stride -> &'a [A], as_ptr, *const A, &'a A} [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const A`) to a reference type (`&'b A`) [INFO] [stderr] --> src/stride.rs:245:21 [INFO] [stderr] | [INFO] [stderr] 245 | mem::transmute(ptr) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `&*ptr` [INFO] [stderr] ... [INFO] [stderr] 268 | stride_impl!{struct Stride -> &'a [A], as_ptr, *const A, &'a A} [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/stride.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | / pub fn get<'b>(&'b self, i: usize) -> Option<&'b A> { [INFO] [stderr] 179 | | if i >= self.len() { [INFO] [stderr] 180 | | None [INFO] [stderr] 181 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 186 | | } [INFO] [stderr] 187 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 269 | stride_impl!{struct StrideMut -> &'a mut [A], as_mut_ptr, *mut A, &'a mut A} [INFO] [stderr] | ---------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut A`) to a reference type (`&'b A`) [INFO] [stderr] --> src/stride.rs:184:30 [INFO] [stderr] | [INFO] [stderr] 184 | Some(mem::transmute(ptr)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `&*ptr` [INFO] [stderr] ... [INFO] [stderr] 269 | stride_impl!{struct StrideMut -> &'a mut [A], as_mut_ptr, *mut A, &'a mut A} [INFO] [stderr] | ---------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut A`) to a reference type (`&'a mut A`) [INFO] [stderr] --> src/stride.rs:201:29 [INFO] [stderr] | [INFO] [stderr] 201 | mem::transmute(self.begin.offset(self.offset)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *self.begin.offset(self.offset)` [INFO] [stderr] ... [INFO] [stderr] 269 | stride_impl!{struct StrideMut -> &'a mut [A], as_mut_ptr, *mut A, &'a mut A} [INFO] [stderr] | ---------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut A`) to a reference type (`&'a mut A`) [INFO] [stderr] --> src/stride.rs:225:35 [INFO] [stderr] | [INFO] [stderr] 225 | let elt = mem::transmute(self.begin.offset(self.end)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *self.begin.offset(self.end)` [INFO] [stderr] ... [INFO] [stderr] 269 | stride_impl!{struct StrideMut -> &'a mut [A], as_mut_ptr, *mut A, &'a mut A} [INFO] [stderr] | ---------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/stride.rs:240:13 [INFO] [stderr] | [INFO] [stderr] 240 | / fn index<'b>(&'b self, i: usize) -> &'b A [INFO] [stderr] 241 | | { [INFO] [stderr] 242 | | assert!(i < self.len()); [INFO] [stderr] 243 | | unsafe { [INFO] [stderr] ... | [INFO] [stderr] 246 | | } [INFO] [stderr] 247 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 269 | stride_impl!{struct StrideMut -> &'a mut [A], as_mut_ptr, *mut A, &'a mut A} [INFO] [stderr] | ---------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut A`) to a reference type (`&'b A`) [INFO] [stderr] --> src/stride.rs:245:21 [INFO] [stderr] | [INFO] [stderr] 245 | mem::transmute(ptr) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `&*ptr` [INFO] [stderr] ... [INFO] [stderr] 269 | stride_impl!{struct StrideMut -> &'a mut [A], as_mut_ptr, *mut A, &'a mut A} [INFO] [stderr] | ---------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/stride.rs:280:5 [INFO] [stderr] | [INFO] [stderr] 280 | / pub fn get_mut<'b>(&'b mut self, i: usize) -> Option<&'b mut A> { [INFO] [stderr] 281 | | if i >= self.len() { [INFO] [stderr] 282 | | None [INFO] [stderr] 283 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 288 | | } [INFO] [stderr] 289 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/stride.rs:296:5 [INFO] [stderr] | [INFO] [stderr] 296 | / fn index_mut<'b>(&'b mut self, i: usize) -> &'b mut A { [INFO] [stderr] 297 | | assert!(i < self.len()); [INFO] [stderr] 298 | | unsafe { [INFO] [stderr] 299 | | let ptr = self.begin.offset(self.offset + self.stride * (i as isize)); [INFO] [stderr] 300 | | &mut *ptr [INFO] [stderr] 301 | | } [INFO] [stderr] 302 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:162:42 [INFO] [stderr] | [INFO] [stderr] 162 | assert_eq!(raw_byte_repr("abc"), "abc".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "090aac46ba17d6c2bc8ac20e17b11bfbdc81252f42ae082be83af1cab89b9260"` [INFO] running `"docker" "rm" "-f" "090aac46ba17d6c2bc8ac20e17b11bfbdc81252f42ae082be83af1cab89b9260"` [INFO] [stdout] 090aac46ba17d6c2bc8ac20e17b11bfbdc81252f42ae082be83af1cab89b9260