[INFO] crate odbc-safe 0.4.1 is already in cache
[INFO] extracting crate odbc-safe 0.4.1 into work/ex/clippy-test-run/sources/stable/reg/odbc-safe/0.4.1
[INFO] extracting crate odbc-safe 0.4.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/odbc-safe/0.4.1
[INFO] validating manifest of odbc-safe-0.4.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of odbc-safe-0.4.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing odbc-safe-0.4.1
[INFO] finished frobbing odbc-safe-0.4.1
[INFO] frobbed toml for odbc-safe-0.4.1 written to work/ex/clippy-test-run/sources/stable/reg/odbc-safe/0.4.1/Cargo.toml
[INFO] started frobbing odbc-safe-0.4.1
[INFO] finished frobbing odbc-safe-0.4.1
[INFO] frobbed toml for odbc-safe-0.4.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/odbc-safe/0.4.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting odbc-safe-0.4.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/odbc-safe/0.4.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] c876b18845702b7892939caaea7fd54752448a56a4148cf515f12a4c17cd3c99
[INFO] running `"docker" "start" "-a" "c876b18845702b7892939caaea7fd54752448a56a4148cf515f12a4c17cd3c99"`
[INFO] [stderr]     Checking odbc-safe v0.4.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/diagnostics.rs:76:17
[INFO] [stderr]    |
[INFO] [stderr] 76 |                 text_length: text_length,
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `text_length`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/diagnostics.rs:77:17
[INFO] [stderr]    |
[INFO] [stderr] 77 |                 state: state,
[INFO] [stderr]    |                 ^^^^^^^^^^^^ help: replace it with: `state`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/diagnostics.rs:78:17
[INFO] [stderr]    |
[INFO] [stderr] 78 |                 native_error: native_error,
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `native_error`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/environment.rs:96:17
[INFO] [stderr]    |
[INFO] [stderr] 96 |                 handle: handle,
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^ help: replace it with: `handle`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/diagnostics.rs:76:17
[INFO] [stderr]    |
[INFO] [stderr] 76 |                 text_length: text_length,
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `text_length`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/diagnostics.rs:77:17
[INFO] [stderr]    |
[INFO] [stderr] 77 |                 state: state,
[INFO] [stderr]    |                 ^^^^^^^^^^^^ help: replace it with: `state`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/diagnostics.rs:78:17
[INFO] [stderr]    |
[INFO] [stderr] 78 |                 native_error: native_error,
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `native_error`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/environment.rs:96:17
[INFO] [stderr]    |
[INFO] [stderr] 96 |                 handle: handle,
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^ help: replace it with: `handle`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/handles/hdbc.rs:130:25
[INFO] [stderr]     |
[INFO] [stderr] 130 |     pub fn is_read_only(&mut self) -> Return<bool> {
[INFO] [stderr]     |                         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]    --> src/handles/hstmt.rs:187:5
[INFO] [stderr]     |
[INFO] [stderr] 187 | /     pub fn describe_col<T>(
[INFO] [stderr] 188 | |         &mut self,
[INFO] [stderr] 189 | |         column_number: SQLUSMALLINT,
[INFO] [stderr] 190 | |         column_name: &mut T,
[INFO] [stderr] ...   |
[INFO] [stderr] 212 | |         }
[INFO] [stderr] 213 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/data_source/mod.rs:168:25
[INFO] [stderr]     |
[INFO] [stderr] 168 |     pub fn is_read_only(&mut self) -> Return<bool> {
[INFO] [stderr]     |                         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> examples/prepared_query.rs:15:9
[INFO] [stderr]    |
[INFO] [stderr] 15 |         println!("");
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> examples/prepared_query.rs:79:9
[INFO] [stderr]    |
[INFO] [stderr] 79 |         println!("");
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/handles/hdbc.rs:130:25
[INFO] [stderr]     |
[INFO] [stderr] 130 |     pub fn is_read_only(&mut self) -> Return<bool> {
[INFO] [stderr]     |                         ^^^^^^^^^
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> examples/print_table.rs:116:9
[INFO] [stderr]     |
[INFO] [stderr] 116 |         println!("");
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]    --> src/handles/hstmt.rs:187:5
[INFO] [stderr]     |
[INFO] [stderr] 187 | /     pub fn describe_col<T>(
[INFO] [stderr] 188 | |         &mut self,
[INFO] [stderr] 189 | |         column_number: SQLUSMALLINT,
[INFO] [stderr] 190 | |         column_name: &mut T,
[INFO] [stderr] ...   |
[INFO] [stderr] 212 | |         }
[INFO] [stderr] 213 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/data_source/mod.rs:168:25
[INFO] [stderr]     |
[INFO] [stderr] 168 |     pub fn is_read_only(&mut self) -> Return<bool> {
[INFO] [stderr]     |                         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> examples/print_table.rs:93:22
[INFO] [stderr]    |
[INFO] [stderr] 93 |         for index in 1..(cols + 1) {
[INFO] [stderr]    |                      ^^^^^^^^^^^^^ help: use: `1..=cols`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `str::from_utf8` doesn't need a mutable reference
[INFO] [stderr]   --> tests/lib.rs:47:46
[INFO] [stderr]    |
[INFO] [stderr] 47 |                 let message = str::from_utf8(&mut message[..(rec.text_length as usize)]).unwrap();
[INFO] [stderr]    |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> tests/lib.rs:62:5
[INFO] [stderr]    |
[INFO] [stderr] 62 | /     match env.drivers(SQL_FETCH_NEXT, &mut description, &mut attributes) {
[INFO] [stderr] 63 | |         ReturnOption::Error(()) => panic!("SQLDrivers call returned error"),
[INFO] [stderr] 64 | |         _ => (),
[INFO] [stderr] 65 | |     }
[INFO] [stderr]    | |_____^ help: try this: `if let ReturnOption::Error(()) = env.drivers(SQL_FETCH_NEXT, &mut description, &mut attributes) { panic!("SQLDrivers call returned error") }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> tests/lib.rs:125:24
[INFO] [stderr]     |
[INFO] [stderr] 125 |             assert_eq!("2001: A Space Odyssey".as_bytes(), &buffer[..(i as usize)]);
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"2001: A Space Odyssey"`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.67s
[INFO] running `"docker" "inspect" "c876b18845702b7892939caaea7fd54752448a56a4148cf515f12a4c17cd3c99"`
[INFO] running `"docker" "rm" "-f" "c876b18845702b7892939caaea7fd54752448a56a4148cf515f12a4c17cd3c99"`
[INFO] [stdout] c876b18845702b7892939caaea7fd54752448a56a4148cf515f12a4c17cd3c99