[INFO] crate odbc-futures 0.1.1 is already in cache [INFO] extracting crate odbc-futures 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/odbc-futures/0.1.1 [INFO] extracting crate odbc-futures 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/odbc-futures/0.1.1 [INFO] validating manifest of odbc-futures-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of odbc-futures-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing odbc-futures-0.1.1 [INFO] finished frobbing odbc-futures-0.1.1 [INFO] frobbed toml for odbc-futures-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/odbc-futures/0.1.1/Cargo.toml [INFO] started frobbing odbc-futures-0.1.1 [INFO] finished frobbing odbc-futures-0.1.1 [INFO] frobbed toml for odbc-futures-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/odbc-futures/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting odbc-futures-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/odbc-futures/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ca0b963b6daa4583af09950cad62946e64dc7976fd6495395e7ff83a80e6773c [INFO] running `"docker" "start" "-a" "ca0b963b6daa4583af09950cad62946e64dc7976fd6495395e7ff83a80e6773c"` [INFO] [stderr] Compiling odbc-sys v0.7.0 [INFO] [stderr] Checking field-offset v0.1.1 [INFO] [stderr] Checking futures-state-stream v0.2.0 [INFO] [stderr] Checking odbc-futures v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/conn.rs:450:28 [INFO] [stderr] | [INFO] [stderr] 450 | const ANY_COLUMN = 0x00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/conn.rs:451:27 [INFO] [stderr] | [INFO] [stderr] 451 | const ANY_ORDER = 0x00000002; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/conn.rs:452:23 [INFO] [stderr] | [INFO] [stderr] 452 | const BLOCK = 0x00000004; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/conn.rs:453:23 [INFO] [stderr] | [INFO] [stderr] 453 | const BOUND = 0x00000008; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0008` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/conn.rs:454:31 [INFO] [stderr] | [INFO] [stderr] 454 | const OUTPUT_PARAMS = 0x00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/stmt.rs:465:38 [INFO] [stderr] | [INFO] [stderr] 465 | |stream_or_statement| -> Box< [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 466 | | Future>, SqlStatement), Error = (SqlError, SqlStatement)> [INFO] [stderr] 467 | | + Send, [INFO] [stderr] 468 | | > { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/conn.rs:450:28 [INFO] [stderr] | [INFO] [stderr] 450 | const ANY_COLUMN = 0x00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/conn.rs:451:27 [INFO] [stderr] | [INFO] [stderr] 451 | const ANY_ORDER = 0x00000002; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/conn.rs:452:23 [INFO] [stderr] | [INFO] [stderr] 452 | const BLOCK = 0x00000004; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/conn.rs:453:23 [INFO] [stderr] | [INFO] [stderr] 453 | const BOUND = 0x00000008; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0008` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/conn.rs:454:31 [INFO] [stderr] | [INFO] [stderr] 454 | const OUTPUT_PARAMS = 0x00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/stmt.rs:548:29 [INFO] [stderr] | [INFO] [stderr] 548 | const HELLO_WORLD: &'static str = "Привіт, світ! 你气不气?"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/stmt.rs:585:29 [INFO] [stderr] | [INFO] [stderr] 585 | const HELLO_WORLD: &'static str = "Привіт, світ! 你气不气?"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> tests/common.rs:208:54 [INFO] [stderr] | [INFO] [stderr] 208 | for s in [row.string.as_str(), c_string].into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> tests/common.rs:225:22 [INFO] [stderr] | [INFO] [stderr] 225 | pub fn statement(&self) -> Option<(RDBMS, SqlStatement)> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/common.rs:228:18 [INFO] [stderr] | [INFO] [stderr] 228 | .expect(&format!("failed to create statement for {:?}", self)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("failed to create statement for {:?}", self))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> tests/common.rs:242:26 [INFO] [stderr] | [INFO] [stderr] 242 | fn connection_string(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> tests/common.rs:260:19 [INFO] [stderr] | [INFO] [stderr] 260 | fn connection(&self) -> Option>> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/common.rs:264:14 [INFO] [stderr] | [INFO] [stderr] 264 | .expect(&format!("failed to create connection for {:?}", self)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("failed to create connection for {:?}", self))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/common.rs:267:14 [INFO] [stderr] | [INFO] [stderr] 267 | .expect(&format!("failed to connect to {:?}", self)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("failed to connect to {:?}", self))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `odbc-futures`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/stmt.rs:465:38 [INFO] [stderr] | [INFO] [stderr] 465 | |stream_or_statement| -> Box< [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 466 | | Future>, SqlStatement), Error = (SqlError, SqlStatement)> [INFO] [stderr] 467 | | + Send, [INFO] [stderr] 468 | | > { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "ca0b963b6daa4583af09950cad62946e64dc7976fd6495395e7ff83a80e6773c"` [INFO] running `"docker" "rm" "-f" "ca0b963b6daa4583af09950cad62946e64dc7976fd6495395e7ff83a80e6773c"` [INFO] [stdout] ca0b963b6daa4583af09950cad62946e64dc7976fd6495395e7ff83a80e6773c