[INFO] crate odbc 0.9.12 is already in cache
[INFO] extracting crate odbc 0.9.12 into work/ex/clippy-test-run/sources/stable/reg/odbc/0.9.12
[INFO] extracting crate odbc 0.9.12 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/odbc/0.9.12
[INFO] validating manifest of odbc-0.9.12 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of odbc-0.9.12 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing odbc-0.9.12
[INFO] finished frobbing odbc-0.9.12
[INFO] frobbed toml for odbc-0.9.12 written to work/ex/clippy-test-run/sources/stable/reg/odbc/0.9.12/Cargo.toml
[INFO] started frobbing odbc-0.9.12
[INFO] finished frobbing odbc-0.9.12
[INFO] frobbed toml for odbc-0.9.12 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/odbc/0.9.12/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting odbc-0.9.12 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/odbc/0.9.12:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 54e692ad1e53ce42d4085de8dbfc2faef5923350d2b46d09149d3651fc962db3
[INFO] running `"docker" "start" "-a" "54e692ad1e53ce42d4085de8dbfc2faef5923350d2b46d09149d3651fc962db3"`
[INFO] [stderr]     Checking odbc v0.9.12 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/statement/mod.rs:77:13
[INFO] [stderr]    |
[INFO] [stderr] 77 |             raii: raii,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `raii`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/statement/mod.rs:237:21
[INFO] [stderr]     |
[INFO] [stderr] 237 |                     data_type: data_type,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_type`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/statement/mod.rs:258:21
[INFO] [stderr]     |
[INFO] [stderr] 258 |                     data_type: data_type,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_type`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/statement/mod.rs:77:13
[INFO] [stderr]    |
[INFO] [stderr] 77 |             raii: raii,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `raii`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/statement/mod.rs:237:21
[INFO] [stderr]     |
[INFO] [stderr] 237 |                     data_type: data_type,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_type`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/statement/mod.rs:258:21
[INFO] [stderr]     |
[INFO] [stderr] 258 |                     data_type: data_type,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_type`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/statement/output.rs:77:21
[INFO] [stderr]    |
[INFO] [stderr] 77 |                     return self.get_partial_data(col_or_param_num, buffer, initial_len - 1);
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get_partial_data(col_or_param_num, buffer, initial_len - 1)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/statement/output.rs:82:25
[INFO] [stderr]    |
[INFO] [stderr] 82 |                         return self.get_partial_data(col_or_param_num, buffer, initial_len - 1);
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get_partial_data(col_or_param_num, buffer, initial_len - 1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/statement/output.rs:77:21
[INFO] [stderr]    |
[INFO] [stderr] 77 |                     return self.get_partial_data(col_or_param_num, buffer, initial_len - 1);
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get_partial_data(col_or_param_num, buffer, initial_len - 1)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/statement/output.rs:82:25
[INFO] [stderr]    |
[INFO] [stderr] 82 |                         return self.get_partial_data(col_or_param_num, buffer, initial_len - 1);
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get_partial_data(col_or_param_num, buffer, initial_len - 1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/diagnostics.rs:40:20
[INFO] [stderr]    |
[INFO] [stderr] 40 |             state: b"HY000\0".clone(),
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*b"HY000\0"`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/diagnostics.rs:55:27
[INFO] [stderr]    |
[INFO] [stderr] 55 |             &self.message[0..(self.message_length as usize + 1)],
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=self.message_length as usize`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/diagnostics.rs:76:49
[INFO] [stderr]    |
[INFO] [stderr] 76 |         CStr::from_bytes_with_nul(&self.message[0..(self.message_length as usize + 1)])
[INFO] [stderr]    |                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=self.message_length as usize`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/diagnostics.rs:109:21
[INFO] [stderr]     |
[INFO] [stderr] 109 |                     message_length = message_length - 1;
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `message_length -= 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/environment/list_data_sources.rs:108:39
[INFO] [stderr]     |
[INFO] [stderr] 108 |         let mut name_buffer: Vec<_> = (0..(max_name + 1)).map(|_| 0u8).collect();
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^ help: use: `(0..=max_name)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/environment/list_data_sources.rs:109:46
[INFO] [stderr]     |
[INFO] [stderr] 109 |         let mut description_buffer: Vec<_> = (0..(max_desc + 1)).map(|_| 0u8).collect();
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^^^ help: use: `(0..=max_desc)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/connection.rs:52:25
[INFO] [stderr]    |
[INFO] [stderr] 52 |     pub fn is_read_only(&mut self) -> Result<bool> {
[INFO] [stderr]    |                         ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const &'a [u8]`)
[INFO] [stderr]   --> src/statement/types.rs:35:9
[INFO] [stderr]    |
[INFO] [stderr] 35 |         self.as_ptr() as *const Self as ffi::SQLPOINTER
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::cast_ptr_alignment)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment
[INFO] [stderr] 
[INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const std::vec::Vec<u8>`)
[INFO] [stderr]   --> src/statement/types.rs:56:9
[INFO] [stderr]    |
[INFO] [stderr] 56 |         self.as_ptr() as *const Self as ffi::SQLPOINTER
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment
[INFO] [stderr] 
[INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u16`)
[INFO] [stderr]   --> src/statement/types.rs:69:33
[INFO] [stderr]    |
[INFO] [stderr] 69 |         unsafe { from_raw_parts(buffer.as_ptr() as *const u16, buffer.len() / 2) }
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment
[INFO] [stderr] 
[INFO] [stderr] error: casting from `*const u16` to a more-strictly-aligned pointer (`*const &'a [u16]`)
[INFO] [stderr]   --> src/statement/types.rs:77:9
[INFO] [stderr]    |
[INFO] [stderr] 77 |         self.as_ptr() as *const Self as ffi::SQLPOINTER
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment
[INFO] [stderr] 
[INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u16`)
[INFO] [stderr]   --> src/statement/types.rs:90:46
[INFO] [stderr]    |
[INFO] [stderr] 90 |         let buffer = unsafe { from_raw_parts(buffer.as_ptr() as *const u16, buffer.len() / 2) };
[INFO] [stderr]    |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment
[INFO] [stderr] 
[INFO] [stderr] error: casting from `*const u16` to a more-strictly-aligned pointer (`*const std::vec::Vec<u16>`)
[INFO] [stderr]   --> src/statement/types.rs:99:9
[INFO] [stderr]    |
[INFO] [stderr] 99 |         self.as_ptr() as *const Self as ffi::SQLPOINTER
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment
[INFO] [stderr] 
[INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const std::ffi::CString`)
[INFO] [stderr]    --> src/statement/types.rs:120:9
[INFO] [stderr]     |
[INFO] [stderr] 120 |         self.as_bytes().as_ptr() as *const Self as ffi::SQLPOINTER
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment
[INFO] [stderr] 
[INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const std::string::String`)
[INFO] [stderr]    --> src/statement/types.rs:141:9
[INFO] [stderr]     |
[INFO] [stderr] 141 |         self.as_bytes().as_ptr() as *const Self as ffi::SQLPOINTER
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment
[INFO] [stderr] 
[INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const &'a str`)
[INFO] [stderr]    --> src/statement/types.rs:162:9
[INFO] [stderr]     |
[INFO] [stderr] 162 |         self.as_bytes().as_ptr() as *const Self as ffi::SQLPOINTER
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `into_result` doesn't need a mutable reference
[INFO] [stderr]   --> src/statement/input.rs:59:50
[INFO] [stderr]    |
[INFO] [stderr] 59 |         self.raii.reset_parameters().into_result(&mut self)?;
[INFO] [stderr]    |                                                  ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]   --> src/statement/output.rs:60:17
[INFO] [stderr]    |
[INFO] [stderr] 60 |                 buffer.as_mut_ptr().offset(start_pos as isize) as ffi::SQLPOINTER,
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `buffer.as_mut_ptr().add(start_pos)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_offset_with_cast)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `into_result` doesn't need a mutable reference
[INFO] [stderr]   --> src/statement/prepare.rs:41:49
[INFO] [stderr]    |
[INFO] [stderr] 41 |         self.raii.prepare(sql_text).into_result(&mut self)?;
[INFO] [stderr]    |                                                 ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `into_result` doesn't need a mutable reference
[INFO] [stderr]   --> src/statement/prepare.rs:62:44
[INFO] [stderr]    |
[INFO] [stderr] 62 |         if self.raii.execute().into_result(&mut self)? {
[INFO] [stderr]    |                                            ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 9 previous errors
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/diagnostics.rs:40:20
[INFO] [stderr]    |
[INFO] [stderr] 40 |             state: b"HY000\0".clone(),
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*b"HY000\0"`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/diagnostics.rs:55:27
[INFO] [stderr]    |
[INFO] [stderr] 55 |             &self.message[0..(self.message_length as usize + 1)],
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=self.message_length as usize`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `odbc`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/diagnostics.rs:76:49
[INFO] [stderr]    |
[INFO] [stderr] 76 |         CStr::from_bytes_with_nul(&self.message[0..(self.message_length as usize + 1)])
[INFO] [stderr]    |                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=self.message_length as usize`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/diagnostics.rs:109:21
[INFO] [stderr]     |
[INFO] [stderr] 109 |                     message_length = message_length - 1;
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `message_length -= 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/diagnostics.rs:146:21
[INFO] [stderr]     |
[INFO] [stderr] 146 |         rec.state = b"HY010\0".clone();
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*b"HY010\0"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `message`
[INFO] [stderr]    --> src/diagnostics.rs:148:18
[INFO] [stderr]     |
[INFO] [stderr] 148 |         for i in 0..(rec.message_length as usize) {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 148 |         for (i, <item>) in message.iter().enumerate().take((rec.message_length as usize)) {
[INFO] [stderr]     |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]    --> src/diagnostics.rs:148:18
[INFO] [stderr]     |
[INFO] [stderr] 148 |         for i in 0..(rec.message_length as usize) {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing the loop by: `rec.message[..(rec.message_length as usize)].clone_from_slice(&message[..(rec.message_length as usize)])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::manual_memcpy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/environment/list_data_sources.rs:108:39
[INFO] [stderr]     |
[INFO] [stderr] 108 |         let mut name_buffer: Vec<_> = (0..(max_name + 1)).map(|_| 0u8).collect();
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^ help: use: `(0..=max_name)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/environment/list_data_sources.rs:109:46
[INFO] [stderr]     |
[INFO] [stderr] 109 |         let mut description_buffer: Vec<_> = (0..(max_desc + 1)).map(|_| 0u8).collect();
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^^^ help: use: `(0..=max_desc)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/connection.rs:52:25
[INFO] [stderr]    |
[INFO] [stderr] 52 |     pub fn is_read_only(&mut self) -> Result<bool> {
[INFO] [stderr]    |                         ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const &'a [u8]`)
[INFO] [stderr]   --> src/statement/types.rs:35:9
[INFO] [stderr]    |
[INFO] [stderr] 35 |         self.as_ptr() as *const Self as ffi::SQLPOINTER
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::cast_ptr_alignment)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment
[INFO] [stderr] 
[INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const std::vec::Vec<u8>`)
[INFO] [stderr]   --> src/statement/types.rs:56:9
[INFO] [stderr]    |
[INFO] [stderr] 56 |         self.as_ptr() as *const Self as ffi::SQLPOINTER
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment
[INFO] [stderr] 
[INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u16`)
[INFO] [stderr]   --> src/statement/types.rs:69:33
[INFO] [stderr]    |
[INFO] [stderr] 69 |         unsafe { from_raw_parts(buffer.as_ptr() as *const u16, buffer.len() / 2) }
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment
[INFO] [stderr] 
[INFO] [stderr] error: casting from `*const u16` to a more-strictly-aligned pointer (`*const &'a [u16]`)
[INFO] [stderr]   --> src/statement/types.rs:77:9
[INFO] [stderr]    |
[INFO] [stderr] 77 |         self.as_ptr() as *const Self as ffi::SQLPOINTER
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment
[INFO] [stderr] 
[INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u16`)
[INFO] [stderr]   --> src/statement/types.rs:90:46
[INFO] [stderr]    |
[INFO] [stderr] 90 |         let buffer = unsafe { from_raw_parts(buffer.as_ptr() as *const u16, buffer.len() / 2) };
[INFO] [stderr]    |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment
[INFO] [stderr] 
[INFO] [stderr] error: casting from `*const u16` to a more-strictly-aligned pointer (`*const std::vec::Vec<u16>`)
[INFO] [stderr]   --> src/statement/types.rs:99:9
[INFO] [stderr]    |
[INFO] [stderr] 99 |         self.as_ptr() as *const Self as ffi::SQLPOINTER
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment
[INFO] [stderr] 
[INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const std::ffi::CString`)
[INFO] [stderr]    --> src/statement/types.rs:120:9
[INFO] [stderr]     |
[INFO] [stderr] 120 |         self.as_bytes().as_ptr() as *const Self as ffi::SQLPOINTER
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment
[INFO] [stderr] 
[INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const std::string::String`)
[INFO] [stderr]    --> src/statement/types.rs:141:9
[INFO] [stderr]     |
[INFO] [stderr] 141 |         self.as_bytes().as_ptr() as *const Self as ffi::SQLPOINTER
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment
[INFO] [stderr] 
[INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const &'a str`)
[INFO] [stderr]    --> src/statement/types.rs:162:9
[INFO] [stderr]     |
[INFO] [stderr] 162 |         self.as_bytes().as_ptr() as *const Self as ffi::SQLPOINTER
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `into_result` doesn't need a mutable reference
[INFO] [stderr]   --> src/statement/input.rs:59:50
[INFO] [stderr]    |
[INFO] [stderr] 59 |         self.raii.reset_parameters().into_result(&mut self)?;
[INFO] [stderr]    |                                                  ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]   --> src/statement/output.rs:60:17
[INFO] [stderr]    |
[INFO] [stderr] 60 |                 buffer.as_mut_ptr().offset(start_pos as isize) as ffi::SQLPOINTER,
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `buffer.as_mut_ptr().add(start_pos)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_offset_with_cast)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `into_result` doesn't need a mutable reference
[INFO] [stderr]   --> src/statement/prepare.rs:41:49
[INFO] [stderr]    |
[INFO] [stderr] 41 |         self.raii.prepare(sql_text).into_result(&mut self)?;
[INFO] [stderr]    |                                                 ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `into_result` doesn't need a mutable reference
[INFO] [stderr]   --> src/statement/prepare.rs:62:44
[INFO] [stderr]    |
[INFO] [stderr] 62 |         if self.raii.execute().into_result(&mut self)? {
[INFO] [stderr]    |                                            ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 9 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `odbc`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "54e692ad1e53ce42d4085de8dbfc2faef5923350d2b46d09149d3651fc962db3"`
[INFO] running `"docker" "rm" "-f" "54e692ad1e53ce42d4085de8dbfc2faef5923350d2b46d09149d3651fc962db3"`
[INFO] [stdout] 54e692ad1e53ce42d4085de8dbfc2faef5923350d2b46d09149d3651fc962db3