[INFO] crate ocypod 0.1.0 is already in cache [INFO] extracting crate ocypod 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/ocypod/0.1.0 [INFO] extracting crate ocypod 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ocypod/0.1.0 [INFO] validating manifest of ocypod-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ocypod-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ocypod-0.1.0 [INFO] finished frobbing ocypod-0.1.0 [INFO] frobbed toml for ocypod-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/ocypod/0.1.0/Cargo.toml [INFO] started frobbing ocypod-0.1.0 [INFO] finished frobbing ocypod-0.1.0 [INFO] frobbed toml for ocypod-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ocypod/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ocypod-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ocypod/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7964bb387ac3b81c58412ad15e13191a41a6c63a04e5f7bc5490ffb81e9310c6 [INFO] running `"docker" "start" "-a" "7964bb387ac3b81c58412ad15e13191a41a6c63a04e5f7bc5490ffb81e9310c6"` [INFO] [stderr] Checking human-size v0.4.0 [INFO] [stderr] Checking serde-humantime v0.1.1 [INFO] [stderr] Checking combine v3.6.6 [INFO] [stderr] Checking redis v0.9.1 [INFO] [stderr] Checking ocypod v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models/duration.rs:101:39 [INFO] [stderr] | [INFO] [stderr] 101 | let dur = Duration::from_secs(1246656); [INFO] [stderr] | ^^^^^^^ help: consider: `1_246_656` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models/duration.rs:119:39 [INFO] [stderr] | [INFO] [stderr] 119 | let dur = Duration::from_secs(1234567890); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_234_567_890` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/models/job/mod.rs:72:45 [INFO] [stderr] | [INFO] [stderr] 72 | for (field, item) in fields.into_iter().zip(items) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/models/mod.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | (Option, Option, Option, Option, Option, Option) = redis::from_redis_value(v)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/application/manager.rs:379:12 [INFO] [stderr] | [INFO] [stderr] 379 | Ok(redis::cmd("PING").query(self.conn)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 379 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/support/mod.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | process: process, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `process` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/support/mod.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | addr: addr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/support/mod.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | server: server, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `server` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/support/mod.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/models/job/mod.rs:72:45 [INFO] [stderr] | [INFO] [stderr] 72 | for (field, item) in fields.into_iter().zip(items) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/models/mod.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | (Option, Option, Option, Option, Option, Option) = redis::from_redis_value(v)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/application/manager.rs:379:12 [INFO] [stderr] | [INFO] [stderr] 379 | Ok(redis::cmd("PING").query(self.conn)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 379 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> tests/support/mod.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | / match *self.get_client_addr() { [INFO] [stderr] 96 | | redis::ConnectionAddr::Unix(ref path) => { [INFO] [stderr] 97 | | fs::remove_file(&path).ok(); [INFO] [stderr] 98 | | } [INFO] [stderr] 99 | | _ => {} [INFO] [stderr] 100 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 95 | if let redis::ConnectionAddr::Unix(ref path) = *self.get_client_addr() { [INFO] [stderr] 96 | fs::remove_file(&path).ok(); [INFO] [stderr] 97 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> tests/test_basic.rs:303:1 [INFO] [stderr] | [INFO] [stderr] 303 | / fn job_deletion() { [INFO] [stderr] 304 | | let (_ctx, conn) = init(); [INFO] [stderr] 305 | | let qw = QueueWrapper::with_default_queue(&conn); [INFO] [stderr] 306 | | [INFO] [stderr] ... | [INFO] [stderr] 356 | | assert!(!qw.manager.delete_job(job_id_queued).unwrap()); [INFO] [stderr] 357 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> tests/test_basic.rs:597:1 [INFO] [stderr] | [INFO] [stderr] 597 | / fn job_fields() { [INFO] [stderr] 598 | | let (_ctx, conn) = init(); [INFO] [stderr] 599 | | let qw = QueueWrapper::with_default_queue(&conn); [INFO] [stderr] 600 | | [INFO] [stderr] ... | [INFO] [stderr] 639 | | [INFO] [stderr] 640 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 58.95s [INFO] running `"docker" "inspect" "7964bb387ac3b81c58412ad15e13191a41a6c63a04e5f7bc5490ffb81e9310c6"` [INFO] running `"docker" "rm" "-f" "7964bb387ac3b81c58412ad15e13191a41a6c63a04e5f7bc5490ffb81e9310c6"` [INFO] [stdout] 7964bb387ac3b81c58412ad15e13191a41a6c63a04e5f7bc5490ffb81e9310c6