[INFO] crate octicons 0.1.1 is already in cache [INFO] extracting crate octicons 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/octicons/0.1.1 [INFO] extracting crate octicons 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/octicons/0.1.1 [INFO] validating manifest of octicons-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of octicons-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing octicons-0.1.1 [INFO] finished frobbing octicons-0.1.1 [INFO] frobbed toml for octicons-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/octicons/0.1.1/Cargo.toml [INFO] started frobbing octicons-0.1.1 [INFO] finished frobbing octicons-0.1.1 [INFO] frobbed toml for octicons-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/octicons/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting octicons-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/octicons/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 42fb855e264215f21fd1a9be5d60d59fa0698142d44019c1b3e6827b5d544416 [INFO] running `"docker" "start" "-a" "42fb855e264215f21fd1a9be5d60d59fa0698142d44019c1b3e6827b5d544416"` [INFO] [stderr] Compiling phf_shared v0.7.21 [INFO] [stderr] Compiling phf v0.7.21 [INFO] [stderr] Compiling svgparser v0.5.0 [INFO] [stderr] Compiling octicons v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:228:16 [INFO] [stderr] | [INFO] [stderr] 228 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 229 | | if self.aria_hidden { [INFO] [stderr] 230 | | write!(f, "aria-hidden=\"true\" ")?; [INFO] [stderr] 231 | | } [INFO] [stderr] 232 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 228 | } else if self.aria_hidden { [INFO] [stderr] 229 | write!(f, "aria-hidden=\"true\" ")?; [INFO] [stderr] 230 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | / pub fn width<'a>(&'a mut self, width: usize) -> &'a mut Octicon { [INFO] [stderr] 80 | | self.width = width; [INFO] [stderr] 81 | | self [INFO] [stderr] 82 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | / pub fn height<'a>(&'a mut self, height: usize) -> &'a mut Octicon { [INFO] [stderr] 94 | | self.height = height; [INFO] [stderr] 95 | | self [INFO] [stderr] 96 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:208:5 [INFO] [stderr] | [INFO] [stderr] 208 | / pub fn aria_hidden<'a>(&'a mut self, aria_hidden: bool) -> &'a mut Octicon { [INFO] [stderr] 209 | | self.aria_hidden = aria_hidden; [INFO] [stderr] 210 | | self [INFO] [stderr] 211 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:228:16 [INFO] [stderr] | [INFO] [stderr] 228 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 229 | | if self.aria_hidden { [INFO] [stderr] 230 | | write!(f, "aria-hidden=\"true\" ")?; [INFO] [stderr] 231 | | } [INFO] [stderr] 232 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 228 | } else if self.aria_hidden { [INFO] [stderr] 229 | write!(f, "aria-hidden=\"true\" ")?; [INFO] [stderr] 230 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | / pub fn width<'a>(&'a mut self, width: usize) -> &'a mut Octicon { [INFO] [stderr] 80 | | self.width = width; [INFO] [stderr] 81 | | self [INFO] [stderr] 82 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | / pub fn height<'a>(&'a mut self, height: usize) -> &'a mut Octicon { [INFO] [stderr] 94 | | self.height = height; [INFO] [stderr] 95 | | self [INFO] [stderr] 96 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:208:5 [INFO] [stderr] | [INFO] [stderr] 208 | / pub fn aria_hidden<'a>(&'a mut self, aria_hidden: bool) -> &'a mut Octicon { [INFO] [stderr] 209 | | self.aria_hidden = aria_hidden; [INFO] [stderr] 210 | | self [INFO] [stderr] 211 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:327:13 [INFO] [stderr] | [INFO] [stderr] 327 | / ARROW_DOWN [INFO] [stderr] 328 | | .clone() [INFO] [stderr] | |________________________^ help: try removing the `clone` call: `ARROW_DOWN` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:334:13 [INFO] [stderr] | [INFO] [stderr] 334 | ARROW_DOWN.clone().xmlns(Some("http://www.w3.org/2000/svg")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `ARROW_DOWN` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.01s [INFO] running `"docker" "inspect" "42fb855e264215f21fd1a9be5d60d59fa0698142d44019c1b3e6827b5d544416"` [INFO] running `"docker" "rm" "-f" "42fb855e264215f21fd1a9be5d60d59fa0698142d44019c1b3e6827b5d544416"` [INFO] [stdout] 42fb855e264215f21fd1a9be5d60d59fa0698142d44019c1b3e6827b5d544416