[INFO] crate octavo-kdf 0.1.1 is already in cache [INFO] extracting crate octavo-kdf 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/octavo-kdf/0.1.1 [INFO] extracting crate octavo-kdf 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/octavo-kdf/0.1.1 [INFO] validating manifest of octavo-kdf-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of octavo-kdf-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing octavo-kdf-0.1.1 [INFO] removed path dependency octavo-crypto from octavo-kdf-0.1.1 [INFO] finished frobbing octavo-kdf-0.1.1 [INFO] frobbed toml for octavo-kdf-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/octavo-kdf/0.1.1/Cargo.toml [INFO] started frobbing octavo-kdf-0.1.1 [INFO] removed path dependency octavo-crypto from octavo-kdf-0.1.1 [INFO] finished frobbing octavo-kdf-0.1.1 [INFO] frobbed toml for octavo-kdf-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/octavo-kdf/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting octavo-kdf-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/octavo-kdf/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2a8f118782818c37fa6148bd2dd0b11ae8261385aa3e66bf441c186f0bb82913 [INFO] running `"docker" "start" "-a" "2a8f118782818c37fa6148bd2dd0b11ae8261385aa3e66bf441c186f0bb82913"` [INFO] [stderr] Checking octavo-crypto v0.1.1 [INFO] [stderr] Checking octavo-kdf v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bcrypt.rs:26:22 [INFO] [stderr] | [INFO] [stderr] 26 | let mut ctext = [0x4f727068, 0x65616e42, 0x65686f6c, 0x64657253, 0x63727944, 0x6f756274]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4f72_7068` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bcrypt.rs:26:34 [INFO] [stderr] | [INFO] [stderr] 26 | let mut ctext = [0x4f727068, 0x65616e42, 0x65686f6c, 0x64657253, 0x63727944, 0x6f756274]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6561_6e42` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bcrypt.rs:26:46 [INFO] [stderr] | [INFO] [stderr] 26 | let mut ctext = [0x4f727068, 0x65616e42, 0x65686f6c, 0x64657253, 0x63727944, 0x6f756274]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6568_6f6c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bcrypt.rs:26:58 [INFO] [stderr] | [INFO] [stderr] 26 | let mut ctext = [0x4f727068, 0x65616e42, 0x65686f6c, 0x64657253, 0x63727944, 0x6f756274]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6465_7253` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bcrypt.rs:26:70 [INFO] [stderr] | [INFO] [stderr] 26 | let mut ctext = [0x4f727068, 0x65616e42, 0x65686f6c, 0x64657253, 0x63727944, 0x6f756274]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6372_7944` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bcrypt.rs:26:82 [INFO] [stderr] | [INFO] [stderr] 26 | let mut ctext = [0x4f727068, 0x65616e42, 0x65686f6c, 0x64657253, 0x63727944, 0x6f756274]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6f75_6274` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/bcrypt.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | let mut output = output.as_mut(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bcrypt.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | assert!(0 < input.as_ref().len() && input.as_ref().len() <= 72); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!input.as_ref().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bcrypt.rs:26:22 [INFO] [stderr] | [INFO] [stderr] 26 | let mut ctext = [0x4f727068, 0x65616e42, 0x65686f6c, 0x64657253, 0x63727944, 0x6f756274]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4f72_7068` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bcrypt.rs:26:34 [INFO] [stderr] | [INFO] [stderr] 26 | let mut ctext = [0x4f727068, 0x65616e42, 0x65686f6c, 0x64657253, 0x63727944, 0x6f756274]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6561_6e42` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bcrypt.rs:26:46 [INFO] [stderr] | [INFO] [stderr] 26 | let mut ctext = [0x4f727068, 0x65616e42, 0x65686f6c, 0x64657253, 0x63727944, 0x6f756274]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6568_6f6c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bcrypt.rs:26:58 [INFO] [stderr] | [INFO] [stderr] 26 | let mut ctext = [0x4f727068, 0x65616e42, 0x65686f6c, 0x64657253, 0x63727944, 0x6f756274]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6465_7253` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bcrypt.rs:26:70 [INFO] [stderr] | [INFO] [stderr] 26 | let mut ctext = [0x4f727068, 0x65616e42, 0x65686f6c, 0x64657253, 0x63727944, 0x6f756274]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6372_7944` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bcrypt.rs:26:82 [INFO] [stderr] | [INFO] [stderr] 26 | let mut ctext = [0x4f727068, 0x65616e42, 0x65686f6c, 0x64657253, 0x63727944, 0x6f756274]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6f75_6274` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/bcrypt.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | let mut output = output.as_mut(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bcrypt.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | assert!(0 < input.as_ref().len() && input.as_ref().len() <= 72); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!input.as_ref().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.54s [INFO] running `"docker" "inspect" "2a8f118782818c37fa6148bd2dd0b11ae8261385aa3e66bf441c186f0bb82913"` [INFO] running `"docker" "rm" "-f" "2a8f118782818c37fa6148bd2dd0b11ae8261385aa3e66bf441c186f0bb82913"` [INFO] [stdout] 2a8f118782818c37fa6148bd2dd0b11ae8261385aa3e66bf441c186f0bb82913