[INFO] crate ocaml 0.5.0 is already in cache [INFO] extracting crate ocaml 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/ocaml/0.5.0 [INFO] extracting crate ocaml 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ocaml/0.5.0 [INFO] validating manifest of ocaml-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ocaml-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ocaml-0.5.0 [INFO] finished frobbing ocaml-0.5.0 [INFO] frobbed toml for ocaml-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/ocaml/0.5.0/Cargo.toml [INFO] started frobbing ocaml-0.5.0 [INFO] finished frobbing ocaml-0.5.0 [INFO] frobbed toml for ocaml-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ocaml/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ocaml-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ocaml/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 09c16274cca966a012cb26f4c2eed5360ce5a1f1090ba912c18d1f6b9d2ed4a8 [INFO] running `"docker" "start" "-a" "09c16274cca966a012cb26f4c2eed5360ce5a1f1090ba912c18d1f6b9d2ed4a8"` [INFO] [stderr] Checking ocaml v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/types.rs:413:13 [INFO] [stderr] | [INFO] [stderr] 413 | x [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/types.rs:412:21 [INFO] [stderr] | [INFO] [stderr] 412 | let x = (*ba).dim as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/value.rs:466:13 [INFO] [stderr] | [INFO] [stderr] 466 | return val1; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `val1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/value.rs:493:13 [INFO] [stderr] | [INFO] [stderr] 493 | return Value::ptr(ptr1.offset(1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Value::ptr(ptr1.offset(1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/types.rs:413:13 [INFO] [stderr] | [INFO] [stderr] 413 | x [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/types.rs:412:21 [INFO] [stderr] | [INFO] [stderr] 412 | let x = (*ba).dim as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/value.rs:466:13 [INFO] [stderr] | [INFO] [stderr] 466 | return val1; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `val1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/value.rs:493:13 [INFO] [stderr] | [INFO] [stderr] 493 | return Value::ptr(ptr1.offset(1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Value::ptr(ptr1.offset(1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/core/mlvalues.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | ($block as *mut $crate::core::mlvalues::Value).offset($i) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `($block as *mut $crate::core::mlvalues::Value).add(i)` [INFO] [stderr] ... [INFO] [stderr] 119 | field!(value, i as isize) [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/core/mlvalues.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | ($block as *mut $crate::core::mlvalues::Value).offset($i) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `($block as *mut $crate::core::mlvalues::Value).add(offset)` [INFO] [stderr] | [INFO] [stderr] ::: src/core/memory.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | store_field!(block, offset as isize, value); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/tag.rs:36:15 [INFO] [stderr] | [INFO] [stderr] 36 | match i as u32 { [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: item `types::Tuple` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/types.rs:37:1 [INFO] [stderr] | [INFO] [stderr] 37 | / impl Tuple { [INFO] [stderr] 38 | | /// Create a new tuple [INFO] [stderr] 39 | | pub fn new(n: Size) -> Tuple { [INFO] [stderr] 40 | | unsafe { [INFO] [stderr] ... | [INFO] [stderr] 68 | | } [INFO] [stderr] 69 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `types::Array` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/types.rs:105:1 [INFO] [stderr] | [INFO] [stderr] 105 | / impl Array { [INFO] [stderr] 106 | | /// Create a new array of the given size [INFO] [stderr] 107 | | pub fn new(n: Size) -> Array { [INFO] [stderr] 108 | | unsafe { [INFO] [stderr] ... | [INFO] [stderr] 176 | | } [INFO] [stderr] 177 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/types.rs:134:27 [INFO] [stderr] | [INFO] [stderr] 134 | let ptr = self.0.ptr_val::().offset(i as isize) as *mut f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.0.ptr_val::().add(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/types.rs:152:21 [INFO] [stderr] | [INFO] [stderr] 152 | Ok(*self.0.ptr_val::().offset(i as isize)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.0.ptr_val::().add(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/types.rs:192:13 [INFO] [stderr] | [INFO] [stderr] 192 | let _ = l.push_hd(v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/types.rs:205:13 [INFO] [stderr] | [INFO] [stderr] 205 | let _ = dst.push_hd(item.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: item `types::List` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/types.rs:212:1 [INFO] [stderr] | [INFO] [stderr] 212 | / impl List { [INFO] [stderr] 213 | | /// Create a new OCaml list [INFO] [stderr] 214 | | pub fn new() -> List { [INFO] [stderr] 215 | | List(Value::new(empty_list())) [INFO] [stderr] ... | [INFO] [stderr] 253 | | } [INFO] [stderr] 254 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `types::List` [INFO] [stderr] --> src/types.rs:214:5 [INFO] [stderr] | [INFO] [stderr] 214 | / pub fn new() -> List { [INFO] [stderr] 215 | | List(Value::new(empty_list())) [INFO] [stderr] 216 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 212 | impl Default for types::List { [INFO] [stderr] 213 | fn default() -> Self { [INFO] [stderr] 214 | Self::new() [INFO] [stderr] 215 | } [INFO] [stderr] 216 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: item `types::Str` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/types.rs:300:1 [INFO] [stderr] | [INFO] [stderr] 300 | / impl Str { [INFO] [stderr] 301 | | /// Create a new string of a given length [INFO] [stderr] 302 | | pub fn new(n: Size) -> Str { [INFO] [stderr] 303 | | unsafe { [INFO] [stderr] ... | [INFO] [stderr] 348 | | } [INFO] [stderr] 349 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `types::Array1` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/types.rs:393:1 [INFO] [stderr] | [INFO] [stderr] 393 | / impl Array1 { [INFO] [stderr] 394 | | pub fn of_slice(data: &mut [T]) -> Array1 { [INFO] [stderr] 395 | | unsafe { [INFO] [stderr] 396 | | let s = bigarray::caml_ba_alloc_dims(T::kind() | bigarray::Managed::EXTERNAL as i32, 1, data.as_mut_ptr() as bigarray::Data, data.len() as i32); [INFO] [stderr] ... | [INFO] [stderr] 429 | | } [INFO] [stderr] 430 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/conv.rs:8:36 [INFO] [stderr] | [INFO] [stderr] 8 | $crate::Value::i64(self.clone() as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.clone())` [INFO] [stderr] ... [INFO] [stderr] 42 | value_i!(i8, u8, i16, u16, i32, u32, i64, u64, isize, usize); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/conv.rs:8:36 [INFO] [stderr] | [INFO] [stderr] 8 | $crate::Value::i64(self.clone() as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.clone())` [INFO] [stderr] ... [INFO] [stderr] 42 | value_i!(i8, u8, i16, u16, i32, u32, i64, u64, isize, usize); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/conv.rs:8:36 [INFO] [stderr] | [INFO] [stderr] 8 | $crate::Value::i64(self.clone() as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.clone())` [INFO] [stderr] ... [INFO] [stderr] 42 | value_i!(i8, u8, i16, u16, i32, u32, i64, u64, isize, usize); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/conv.rs:8:36 [INFO] [stderr] | [INFO] [stderr] 8 | $crate::Value::i64(self.clone() as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.clone())` [INFO] [stderr] ... [INFO] [stderr] 42 | value_i!(i8, u8, i16, u16, i32, u32, i64, u64, isize, usize); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/conv.rs:8:36 [INFO] [stderr] | [INFO] [stderr] 8 | $crate::Value::i64(self.clone() as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.clone())` [INFO] [stderr] ... [INFO] [stderr] 42 | value_i!(i8, u8, i16, u16, i32, u32, i64, u64, isize, usize); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/conv.rs:8:36 [INFO] [stderr] | [INFO] [stderr] 8 | $crate::Value::i64(self.clone() as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.clone())` [INFO] [stderr] ... [INFO] [stderr] 42 | value_i!(i8, u8, i16, u16, i32, u32, i64, u64, isize, usize); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/core/mlvalues.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | ($block as *mut $crate::core::mlvalues::Value).offset($i) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `($block as *mut $crate::core::mlvalues::Value).add(i)` [INFO] [stderr] ... [INFO] [stderr] 119 | field!(value, i as isize) [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/core/mlvalues.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | ($block as *mut $crate::core::mlvalues::Value).offset($i) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `($block as *mut $crate::core::mlvalues::Value).add(offset)` [INFO] [stderr] | [INFO] [stderr] ::: src/core/memory.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | store_field!(block, offset as isize, value); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/tag.rs:36:15 [INFO] [stderr] | [INFO] [stderr] 36 | match i as u32 { [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: item `types::Tuple` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/types.rs:37:1 [INFO] [stderr] | [INFO] [stderr] 37 | / impl Tuple { [INFO] [stderr] 38 | | /// Create a new tuple [INFO] [stderr] 39 | | pub fn new(n: Size) -> Tuple { [INFO] [stderr] 40 | | unsafe { [INFO] [stderr] ... | [INFO] [stderr] 68 | | } [INFO] [stderr] 69 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `types::Array` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/types.rs:105:1 [INFO] [stderr] | [INFO] [stderr] 105 | / impl Array { [INFO] [stderr] 106 | | /// Create a new array of the given size [INFO] [stderr] 107 | | pub fn new(n: Size) -> Array { [INFO] [stderr] 108 | | unsafe { [INFO] [stderr] ... | [INFO] [stderr] 176 | | } [INFO] [stderr] 177 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/types.rs:134:27 [INFO] [stderr] | [INFO] [stderr] 134 | let ptr = self.0.ptr_val::().offset(i as isize) as *mut f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.0.ptr_val::().add(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/types.rs:152:21 [INFO] [stderr] | [INFO] [stderr] 152 | Ok(*self.0.ptr_val::().offset(i as isize)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.0.ptr_val::().add(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/types.rs:192:13 [INFO] [stderr] | [INFO] [stderr] 192 | let _ = l.push_hd(v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/types.rs:205:13 [INFO] [stderr] | [INFO] [stderr] 205 | let _ = dst.push_hd(item.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: item `types::List` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/types.rs:212:1 [INFO] [stderr] | [INFO] [stderr] 212 | / impl List { [INFO] [stderr] 213 | | /// Create a new OCaml list [INFO] [stderr] 214 | | pub fn new() -> List { [INFO] [stderr] 215 | | List(Value::new(empty_list())) [INFO] [stderr] ... | [INFO] [stderr] 253 | | } [INFO] [stderr] 254 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `types::List` [INFO] [stderr] --> src/types.rs:214:5 [INFO] [stderr] | [INFO] [stderr] 214 | / pub fn new() -> List { [INFO] [stderr] 215 | | List(Value::new(empty_list())) [INFO] [stderr] 216 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 212 | impl Default for types::List { [INFO] [stderr] 213 | fn default() -> Self { [INFO] [stderr] 214 | Self::new() [INFO] [stderr] 215 | } [INFO] [stderr] 216 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: item `types::Str` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/types.rs:300:1 [INFO] [stderr] | [INFO] [stderr] 300 | / impl Str { [INFO] [stderr] 301 | | /// Create a new string of a given length [INFO] [stderr] 302 | | pub fn new(n: Size) -> Str { [INFO] [stderr] 303 | | unsafe { [INFO] [stderr] ... | [INFO] [stderr] 348 | | } [INFO] [stderr] 349 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `types::Array1` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/types.rs:393:1 [INFO] [stderr] | [INFO] [stderr] 393 | / impl Array1 { [INFO] [stderr] 394 | | pub fn of_slice(data: &mut [T]) -> Array1 { [INFO] [stderr] 395 | | unsafe { [INFO] [stderr] 396 | | let s = bigarray::caml_ba_alloc_dims(T::kind() | bigarray::Managed::EXTERNAL as i32, 1, data.as_mut_ptr() as bigarray::Data, data.len() as i32); [INFO] [stderr] ... | [INFO] [stderr] 429 | | } [INFO] [stderr] 430 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/conv.rs:8:36 [INFO] [stderr] | [INFO] [stderr] 8 | $crate::Value::i64(self.clone() as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.clone())` [INFO] [stderr] ... [INFO] [stderr] 42 | value_i!(i8, u8, i16, u16, i32, u32, i64, u64, isize, usize); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/conv.rs:8:36 [INFO] [stderr] | [INFO] [stderr] 8 | $crate::Value::i64(self.clone() as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.clone())` [INFO] [stderr] ... [INFO] [stderr] 42 | value_i!(i8, u8, i16, u16, i32, u32, i64, u64, isize, usize); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/conv.rs:8:36 [INFO] [stderr] | [INFO] [stderr] 8 | $crate::Value::i64(self.clone() as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.clone())` [INFO] [stderr] ... [INFO] [stderr] 42 | value_i!(i8, u8, i16, u16, i32, u32, i64, u64, isize, usize); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/conv.rs:8:36 [INFO] [stderr] | [INFO] [stderr] 8 | $crate::Value::i64(self.clone() as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.clone())` [INFO] [stderr] ... [INFO] [stderr] 42 | value_i!(i8, u8, i16, u16, i32, u32, i64, u64, isize, usize); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/conv.rs:8:36 [INFO] [stderr] | [INFO] [stderr] 8 | $crate::Value::i64(self.clone() as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.clone())` [INFO] [stderr] ... [INFO] [stderr] 42 | value_i!(i8, u8, i16, u16, i32, u32, i64, u64, isize, usize); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/conv.rs:8:36 [INFO] [stderr] | [INFO] [stderr] 8 | $crate::Value::i64(self.clone() as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.clone())` [INFO] [stderr] ... [INFO] [stderr] 42 | value_i!(i8, u8, i16, u16, i32, u32, i64, u64, isize, usize); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/test.rs:5:20 [INFO] [stderr] | [INFO] [stderr] 5 | let caml_int = 7471857119 as usize; // if this is not cast, then it's a u32 and conversion will fail [INFO] [stderr] | ^^^^^^^^^^ help: consider: `7_471_857_119` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/test.rs:7:19 [INFO] [stderr] | [INFO] [stderr] 7 | assert_eq!(x, 0xdeadbeef); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.68s [INFO] running `"docker" "inspect" "09c16274cca966a012cb26f4c2eed5360ce5a1f1090ba912c18d1f6b9d2ed4a8"` [INFO] running `"docker" "rm" "-f" "09c16274cca966a012cb26f4c2eed5360ce5a1f1090ba912c18d1f6b9d2ed4a8"` [INFO] [stdout] 09c16274cca966a012cb26f4c2eed5360ce5a1f1090ba912c18d1f6b9d2ed4a8