[INFO] crate obstack 0.1.3 is already in cache [INFO] extracting crate obstack 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/obstack/0.1.3 [INFO] extracting crate obstack 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/obstack/0.1.3 [INFO] validating manifest of obstack-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of obstack-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing obstack-0.1.3 [INFO] finished frobbing obstack-0.1.3 [INFO] frobbed toml for obstack-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/obstack/0.1.3/Cargo.toml [INFO] started frobbing obstack-0.1.3 [INFO] finished frobbing obstack-0.1.3 [INFO] frobbed toml for obstack-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/obstack/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting obstack-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/obstack/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 43b3f164b33993d6973ac58292ef8a876ca235a4fc49ff5b0451003e378fe952 [INFO] running `"docker" "start" "-a" "43b3f164b33993d6973ac58292ef8a876ca235a4fc49ff5b0451003e378fe952"` [INFO] [stderr] Checking obstack v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:346:13 [INFO] [stderr] | [INFO] [stderr] 346 | write!(f, "Obstack Slabs:\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:348:13 [INFO] [stderr] | [INFO] [stderr] 348 | / write!(f, " {:p}: size = {}, used = {}\n", [INFO] [stderr] 349 | | state.tip.as_ptr(), [INFO] [stderr] 350 | | state.tip.capacity_bytes(), [INFO] [stderr] 351 | | state.tip.len_bytes())?; [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:354:17 [INFO] [stderr] | [INFO] [stderr] 354 | / write!(f, " {:p}: size = {}, used = {}\n", [INFO] [stderr] 355 | | slab.as_ptr(), slab.capacity_bytes(), slab.len_bytes())?; [INFO] [stderr] | |______________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:539:17 [INFO] [stderr] | [INFO] [stderr] 539 | count_ref: count_ref, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `count_ref` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:346:13 [INFO] [stderr] | [INFO] [stderr] 346 | write!(f, "Obstack Slabs:\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:348:13 [INFO] [stderr] | [INFO] [stderr] 348 | / write!(f, " {:p}: size = {}, used = {}\n", [INFO] [stderr] 349 | | state.tip.as_ptr(), [INFO] [stderr] 350 | | state.tip.capacity_bytes(), [INFO] [stderr] 351 | | state.tip.len_bytes())?; [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:354:17 [INFO] [stderr] | [INFO] [stderr] 354 | / write!(f, " {:p}: size = {}, used = {}\n", [INFO] [stderr] 355 | | slab.as_ptr(), slab.capacity_bytes(), slab.len_bytes())?; [INFO] [stderr] | |______________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:539:17 [INFO] [stderr] | [INFO] [stderr] 539 | count_ref: count_ref, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `count_ref` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Obstack` [INFO] [stderr] --> src/lib.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | / pub fn new() -> Self { [INFO] [stderr] 80 | | Self::with_initial_capacity(DEFAULT_INITIAL_CAPACITY-1) [INFO] [stderr] 81 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 61 | impl Default for Obstack { [INFO] [stderr] 62 | fn default() -> Self { [INFO] [stderr] 63 | Self::new() [INFO] [stderr] 64 | } [INFO] [stderr] 65 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | / pub fn push<'a, T>(&'a self, value: T) -> Ref<'a, T> { [INFO] [stderr] 95 | | let ptr = self.alloc(&value) as *mut T; [INFO] [stderr] 96 | | unsafe { [INFO] [stderr] 97 | | ptr::write(ptr, value); [INFO] [stderr] ... | [INFO] [stderr] 102 | | } [INFO] [stderr] 103 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/lib.rs:115:52 [INFO] [stderr] | [INFO] [stderr] 115 | pub fn push_copy<'a, T>(&'a self, value: T) -> &'a mut T [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::mut_from_ref)] on by default [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/lib.rs:115:29 [INFO] [stderr] | [INFO] [stderr] 115 | pub fn push_copy<'a, T>(&'a self, value: T) -> &'a mut T [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | / pub fn push_copy<'a, T>(&'a self, value: T) -> &'a mut T [INFO] [stderr] 116 | | where T: Copy, [INFO] [stderr] 117 | | { [INFO] [stderr] 118 | | unsafe { [INFO] [stderr] ... | [INFO] [stderr] 122 | | } [INFO] [stderr] 123 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/lib.rs:167:59 [INFO] [stderr] | [INFO] [stderr] 167 | pub fn copy_from_slice<'a, T>(&'a self, src: &[T]) -> &'a mut [T] [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/lib.rs:167:35 [INFO] [stderr] | [INFO] [stderr] 167 | pub fn copy_from_slice<'a, T>(&'a self, src: &[T]) -> &'a mut [T] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:319:25 [INFO] [stderr] | [INFO] [stderr] 319 | let start_ptr = self.tip.as_mut_ptr() [INFO] [stderr] | _________________________^ [INFO] [stderr] 320 | | .offset(self.tip.len_items() as isize); [INFO] [stderr] | |______________________________________________________________________^ help: try: `self.tip.as_mut_ptr().add(self.tip.len_items())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:327:25 [INFO] [stderr] | [INFO] [stderr] 327 | let start_ptr = start_ptr.offset(AlignedVec::::bytes_to_items(padding) as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `start_ptr.add(AlignedVec::::bytes_to_items(padding))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/impls.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | / fn ne(&self, other: &Ref<'a, T>) -> bool { [INFO] [stderr] 56 | | PartialEq::ne(self.ptr, other.ptr) [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `obstack`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Obstack` [INFO] [stderr] --> src/lib.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | / pub fn new() -> Self { [INFO] [stderr] 80 | | Self::with_initial_capacity(DEFAULT_INITIAL_CAPACITY-1) [INFO] [stderr] 81 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 61 | impl Default for Obstack { [INFO] [stderr] 62 | fn default() -> Self { [INFO] [stderr] 63 | Self::new() [INFO] [stderr] 64 | } [INFO] [stderr] 65 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | / pub fn push<'a, T>(&'a self, value: T) -> Ref<'a, T> { [INFO] [stderr] 95 | | let ptr = self.alloc(&value) as *mut T; [INFO] [stderr] 96 | | unsafe { [INFO] [stderr] 97 | | ptr::write(ptr, value); [INFO] [stderr] ... | [INFO] [stderr] 102 | | } [INFO] [stderr] 103 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/lib.rs:115:52 [INFO] [stderr] | [INFO] [stderr] 115 | pub fn push_copy<'a, T>(&'a self, value: T) -> &'a mut T [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::mut_from_ref)] on by default [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/lib.rs:115:29 [INFO] [stderr] | [INFO] [stderr] 115 | pub fn push_copy<'a, T>(&'a self, value: T) -> &'a mut T [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | / pub fn push_copy<'a, T>(&'a self, value: T) -> &'a mut T [INFO] [stderr] 116 | | where T: Copy, [INFO] [stderr] 117 | | { [INFO] [stderr] 118 | | unsafe { [INFO] [stderr] ... | [INFO] [stderr] 122 | | } [INFO] [stderr] 123 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/lib.rs:167:59 [INFO] [stderr] | [INFO] [stderr] 167 | pub fn copy_from_slice<'a, T>(&'a self, src: &[T]) -> &'a mut [T] [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/lib.rs:167:35 [INFO] [stderr] | [INFO] [stderr] 167 | pub fn copy_from_slice<'a, T>(&'a self, src: &[T]) -> &'a mut [T] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:319:25 [INFO] [stderr] | [INFO] [stderr] 319 | let start_ptr = self.tip.as_mut_ptr() [INFO] [stderr] | _________________________^ [INFO] [stderr] 320 | | .offset(self.tip.len_items() as isize); [INFO] [stderr] | |______________________________________________________________________^ help: try: `self.tip.as_mut_ptr().add(self.tip.len_items())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:327:25 [INFO] [stderr] | [INFO] [stderr] 327 | let start_ptr = start_ptr.offset(AlignedVec::::bytes_to_items(padding) as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `start_ptr.add(AlignedVec::::bytes_to_items(padding))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/impls.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | / fn ne(&self, other: &Ref<'a, T>) -> bool { [INFO] [stderr] 56 | | PartialEq::ne(self.ptr, other.ptr) [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:394:13 [INFO] [stderr] | [INFO] [stderr] 394 | **stack_ref = **stack_ref + 42; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `**stack_ref += 42` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:417:9 [INFO] [stderr] | [INFO] [stderr] 417 | / fn fill<'a>(stack: &'a Obstack) -> Multi<'a> { [INFO] [stderr] 418 | | match thread_rng().next_u32() % 8 { [INFO] [stderr] 419 | | 0 => { [INFO] [stderr] 420 | | let value = thread_rng().gen(); [INFO] [stderr] ... | [INFO] [stderr] 450 | | } [INFO] [stderr] 451 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `obstack`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "43b3f164b33993d6973ac58292ef8a876ca235a4fc49ff5b0451003e378fe952"` [INFO] running `"docker" "rm" "-f" "43b3f164b33993d6973ac58292ef8a876ca235a4fc49ff5b0451003e378fe952"` [INFO] [stdout] 43b3f164b33993d6973ac58292ef8a876ca235a4fc49ff5b0451003e378fe952