[INFO] crate objectid 0.2.0 is already in cache [INFO] extracting crate objectid 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/objectid/0.2.0 [INFO] extracting crate objectid 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/objectid/0.2.0 [INFO] validating manifest of objectid-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of objectid-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing objectid-0.2.0 [INFO] finished frobbing objectid-0.2.0 [INFO] frobbed toml for objectid-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/objectid/0.2.0/Cargo.toml [INFO] started frobbing objectid-0.2.0 [INFO] finished frobbing objectid-0.2.0 [INFO] frobbed toml for objectid-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/objectid/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting objectid-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/objectid/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 037157a25962f64e3d95bfd7ba17939bbcb1dff77cbdcca75a9e671c3b602244 [INFO] running `"docker" "start" "-a" "037157a25962f64e3d95bfd7ba17939bbcb1dff77cbdcca75a9e671c3b602244"` [INFO] [stderr] Checking objectid v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:41:24 [INFO] [stderr] | [INFO] [stderr] 41 | const MAX_U24: usize = 0xFFFFFF; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FF_FFFF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:313:17 [INFO] [stderr] | [INFO] [stderr] 313 | let start = 1122866; [INFO] [stderr] | ^^^^^^^ help: consider: `1_122_866` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:356:26 [INFO] [stderr] | [INFO] [stderr] 356 | assert!(get_time() > 1481757541); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_481_757_541` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:41:24 [INFO] [stderr] | [INFO] [stderr] 41 | const MAX_U24: usize = 0xFFFFFF; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FF_FFFF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:124:22 [INFO] [stderr] | [INFO] [stderr] 124 | for i in 0..12 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `byte_array[..12].clone_from_slice(&bytes[..12])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:169:18 [INFO] [stderr] | [INFO] [stderr] 169 | for i in 0..COUNTER_SIZE { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try replacing the loop by: `buf[1..(COUNTER_SIZE + 1)].clone_from_slice(&self.0[COUNTER_OFFSET..(COUNTER_SIZE + COUNTER_OFFSET)])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/lib.rs:290:19 [INFO] [stderr] | [INFO] [stderr] 290 | unsafe { time(0 as *mut libc::time_t) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:124:22 [INFO] [stderr] | [INFO] [stderr] 124 | for i in 0..12 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `byte_array[..12].clone_from_slice(&bytes[..12])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:169:18 [INFO] [stderr] | [INFO] [stderr] 169 | for i in 0..COUNTER_SIZE { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try replacing the loop by: `buf[1..(COUNTER_SIZE + 1)].clone_from_slice(&self.0[COUNTER_OFFSET..(COUNTER_SIZE + COUNTER_OFFSET)])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/lib.rs:290:19 [INFO] [stderr] | [INFO] [stderr] 290 | unsafe { time(0 as *mut libc::time_t) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.57s [INFO] running `"docker" "inspect" "037157a25962f64e3d95bfd7ba17939bbcb1dff77cbdcca75a9e671c3b602244"` [INFO] running `"docker" "rm" "-f" "037157a25962f64e3d95bfd7ba17939bbcb1dff77cbdcca75a9e671c3b602244"` [INFO] [stdout] 037157a25962f64e3d95bfd7ba17939bbcb1dff77cbdcca75a9e671c3b602244