[INFO] crate object 0.11.0 is already in cache [INFO] extracting crate object 0.11.0 into work/ex/clippy-test-run/sources/stable/reg/object/0.11.0 [INFO] extracting crate object 0.11.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/object/0.11.0 [INFO] validating manifest of object-0.11.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of object-0.11.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing object-0.11.0 [INFO] finished frobbing object-0.11.0 [INFO] frobbed toml for object-0.11.0 written to work/ex/clippy-test-run/sources/stable/reg/object/0.11.0/Cargo.toml [INFO] started frobbing object-0.11.0 [INFO] finished frobbing object-0.11.0 [INFO] frobbed toml for object-0.11.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/object/0.11.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting object-0.11.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/object/0.11.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4aca226868d8d27e4e40928a4f36fdedb0a5f64edca10adb89d2b5f8e9d4296f [INFO] running `"docker" "start" "-a" "4aca226868d8d27e4e40928a4f36fdedb0a5f64edca10adb89d2b5f8e9d4296f"` [INFO] [stderr] Checking uuid v0.7.2 [INFO] [stderr] Checking parity-wasm v0.35.7 [INFO] [stderr] Checking goblin v0.0.19 [INFO] [stderr] Checking object v0.11.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe.rs:314:17 [INFO] [stderr] | [INFO] [stderr] 314 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe.rs:314:17 [INFO] [stderr] | [INFO] [stderr] 314 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf.rs:335:37 [INFO] [stderr] | [INFO] [stderr] 335 | if (self.section.sh_flags & elf::section_header::SHF_COMPRESSED as u64) == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elf::section_header::SHF_COMPRESSED)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/elf.rs:360:16 [INFO] [stderr] | [INFO] [stderr] 360 | if let Err(_) = [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 361 | | decompress.decompress_vec(compressed_data, &mut decompressed, FlushDecompress::Finish) [INFO] [stderr] 362 | | { [INFO] [stderr] 363 | | return None; [INFO] [stderr] 364 | | } [INFO] [stderr] | |_________- help: try this: `if decompress.decompress_vec(compressed_data, &mut decompressed, FlushDecompress::Finish).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/elf.rs:388:16 [INFO] [stderr] | [INFO] [stderr] 388 | if let Err(_) = [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 389 | | decompress.decompress_vec(&data[12..], &mut decompressed, FlushDecompress::Finish) [INFO] [stderr] 390 | | { [INFO] [stderr] 391 | | return None; [INFO] [stderr] 392 | | } [INFO] [stderr] | |_________- help: try this: `if decompress.decompress_vec(&data[12..], &mut decompressed, FlushDecompress::Finish).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/elf.rs:522:17 [INFO] [stderr] | [INFO] [stderr] 522 | / while let Some(reloc) = relocations.next() { [INFO] [stderr] 523 | | let kind = match self.file.elf.header.e_machine { [INFO] [stderr] 524 | | elf::header::EM_ARM => match reloc.r_type { [INFO] [stderr] 525 | | elf::reloc::R_ARM_ABS32 => RelocationKind::Direct32, [INFO] [stderr] ... | [INFO] [stderr] 553 | | )); [INFO] [stderr] 554 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/macho.rs:326:17 [INFO] [stderr] | [INFO] [stderr] 326 | / while let Some(Ok((section, data))) = sections.next() { [INFO] [stderr] 327 | | return Some(MachOSection { [INFO] [stderr] 328 | | file: self.file, [INFO] [stderr] 329 | | section, [INFO] [stderr] 330 | | data, [INFO] [stderr] 331 | | }); [INFO] [stderr] 332 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/wasm.rs:83:58 [INFO] [stderr] | [INFO] [stderr] 83 | self.module.start_section().map_or(u64::MAX, |s| s as u64) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/wasm.rs:190:11 [INFO] [stderr] | [INFO] [stderr] 190 | }.unwrap_or(Cow::from(&[][..])) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Cow::from(&[][..]))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/lib.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | Elf(ElfFile<'data>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 89 | Elf(Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `object`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf.rs:335:37 [INFO] [stderr] | [INFO] [stderr] 335 | if (self.section.sh_flags & elf::section_header::SHF_COMPRESSED as u64) == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elf::section_header::SHF_COMPRESSED)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/elf.rs:360:16 [INFO] [stderr] | [INFO] [stderr] 360 | if let Err(_) = [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 361 | | decompress.decompress_vec(compressed_data, &mut decompressed, FlushDecompress::Finish) [INFO] [stderr] 362 | | { [INFO] [stderr] 363 | | return None; [INFO] [stderr] 364 | | } [INFO] [stderr] | |_________- help: try this: `if decompress.decompress_vec(compressed_data, &mut decompressed, FlushDecompress::Finish).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/elf.rs:388:16 [INFO] [stderr] | [INFO] [stderr] 388 | if let Err(_) = [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 389 | | decompress.decompress_vec(&data[12..], &mut decompressed, FlushDecompress::Finish) [INFO] [stderr] 390 | | { [INFO] [stderr] 391 | | return None; [INFO] [stderr] 392 | | } [INFO] [stderr] | |_________- help: try this: `if decompress.decompress_vec(&data[12..], &mut decompressed, FlushDecompress::Finish).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/elf.rs:522:17 [INFO] [stderr] | [INFO] [stderr] 522 | / while let Some(reloc) = relocations.next() { [INFO] [stderr] 523 | | let kind = match self.file.elf.header.e_machine { [INFO] [stderr] 524 | | elf::header::EM_ARM => match reloc.r_type { [INFO] [stderr] 525 | | elf::reloc::R_ARM_ABS32 => RelocationKind::Direct32, [INFO] [stderr] ... | [INFO] [stderr] 553 | | )); [INFO] [stderr] 554 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/macho.rs:326:17 [INFO] [stderr] | [INFO] [stderr] 326 | / while let Some(Ok((section, data))) = sections.next() { [INFO] [stderr] 327 | | return Some(MachOSection { [INFO] [stderr] 328 | | file: self.file, [INFO] [stderr] 329 | | section, [INFO] [stderr] 330 | | data, [INFO] [stderr] 331 | | }); [INFO] [stderr] 332 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/wasm.rs:83:58 [INFO] [stderr] | [INFO] [stderr] 83 | self.module.start_section().map_or(u64::MAX, |s| s as u64) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/wasm.rs:190:11 [INFO] [stderr] | [INFO] [stderr] 190 | }.unwrap_or(Cow::from(&[][..])) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Cow::from(&[][..]))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/lib.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | Elf(ElfFile<'data>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 89 | Elf(Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `object`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4aca226868d8d27e4e40928a4f36fdedb0a5f64edca10adb89d2b5f8e9d4296f"` [INFO] running `"docker" "rm" "-f" "4aca226868d8d27e4e40928a4f36fdedb0a5f64edca10adb89d2b5f8e9d4296f"` [INFO] [stdout] 4aca226868d8d27e4e40928a4f36fdedb0a5f64edca10adb89d2b5f8e9d4296f