[INFO] crate objc-encode 0.0.3 is already in cache [INFO] extracting crate objc-encode 0.0.3 into work/ex/clippy-test-run/sources/stable/reg/objc-encode/0.0.3 [INFO] extracting crate objc-encode 0.0.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/objc-encode/0.0.3 [INFO] validating manifest of objc-encode-0.0.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of objc-encode-0.0.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing objc-encode-0.0.3 [INFO] finished frobbing objc-encode-0.0.3 [INFO] frobbed toml for objc-encode-0.0.3 written to work/ex/clippy-test-run/sources/stable/reg/objc-encode/0.0.3/Cargo.toml [INFO] started frobbing objc-encode-0.0.3 [INFO] finished frobbing objc-encode-0.0.3 [INFO] frobbed toml for objc-encode-0.0.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/objc-encode/0.0.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting objc-encode-0.0.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/objc-encode/0.0.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 657ba2889b0ce8864b7f8d0115da67b4015b5b62003cc5134084740f4de8b693 [INFO] running `"docker" "start" "-a" "657ba2889b0ce8864b7f8d0115da67b4015b5b62003cc5134084740f4de8b693"` [INFO] [stderr] Checking objc-encode v0.0.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoding/array.rs:17:17 [INFO] [stderr] | [INFO] [stderr] 17 | Array { len: len, item: item } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoding/array.rs:17:27 [INFO] [stderr] | [INFO] [stderr] 17 | Array { len: len, item: item } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `item` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoding/structure.rs:18:18 [INFO] [stderr] | [INFO] [stderr] 18 | Struct { name: name, fields: fields } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoding/structure.rs:18:30 [INFO] [stderr] | [INFO] [stderr] 18 | Struct { name: name, fields: fields } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoding/union.rs:18:17 [INFO] [stderr] | [INFO] [stderr] 18 | Union { name: name, members: members } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoding/union.rs:18:29 [INFO] [stderr] | [INFO] [stderr] 18 | Union { name: name, members: members } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `members` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/multi.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | encs: encs, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `encs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/multi.rs:168:13 [INFO] [stderr] | [INFO] [stderr] 168 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoding/array.rs:17:17 [INFO] [stderr] | [INFO] [stderr] 17 | Array { len: len, item: item } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoding/array.rs:17:27 [INFO] [stderr] | [INFO] [stderr] 17 | Array { len: len, item: item } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `item` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoding/structure.rs:18:18 [INFO] [stderr] | [INFO] [stderr] 18 | Struct { name: name, fields: fields } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoding/structure.rs:18:30 [INFO] [stderr] | [INFO] [stderr] 18 | Struct { name: name, fields: fields } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoding/union.rs:18:17 [INFO] [stderr] | [INFO] [stderr] 18 | Union { name: name, members: members } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoding/union.rs:18:29 [INFO] [stderr] | [INFO] [stderr] 18 | Union { name: name, members: members } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `members` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/multi.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | encs: encs, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `encs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/multi.rs:168:13 [INFO] [stderr] | [INFO] [stderr] 168 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/multi.rs:44:1 [INFO] [stderr] | [INFO] [stderr] 44 | / macro_rules! fmt_repeat { [INFO] [stderr] 45 | | () => (""); [INFO] [stderr] 46 | | ($a:ident) => ("{}"); [INFO] [stderr] 47 | | ($a:ident, $($b:ident),+) => (concat!("{}", fmt_repeat!($($b),*))); [INFO] [stderr] 48 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse/mod.rs:10:20 [INFO] [stderr] | [INFO] [stderr] 10 | const QUALIFIERS: &'static [char] = &[ [INFO] [stderr] | -^^^^^^^------- help: consider removing `'static`: `&[char]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/multi.rs:44:1 [INFO] [stderr] | [INFO] [stderr] 44 | / macro_rules! fmt_repeat { [INFO] [stderr] 45 | | () => (""); [INFO] [stderr] 46 | | ($a:ident) => ("{}"); [INFO] [stderr] 47 | | ($a:ident, $($b:ident),+) => (concat!("{}", fmt_repeat!($($b),*))); [INFO] [stderr] 48 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse/mod.rs:10:20 [INFO] [stderr] | [INFO] [stderr] 10 | const QUALIFIERS: &'static [char] = &[ [INFO] [stderr] | -^^^^^^^------- help: consider removing `'static`: `&[char]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/parse/encoding.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / pub fn from_str(s: &str) -> Result<&StrEncoding, ParseEncodingError<&str>> { [INFO] [stderr] 39 | | if is_valid(s) { [INFO] [stderr] 40 | | Ok(StrEncoding::from_str_unchecked(s)) [INFO] [stderr] 41 | | } else { [INFO] [stderr] 42 | | Err(ParseEncodingError(s)) [INFO] [stderr] 43 | | } [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/parse/encoding.rs:54:18 [INFO] [stderr] | [INFO] [stderr] 54 | unsafe { mem::transmute(s) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `&*(s as *const str as *const parse::encoding::StrEncoding)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/parse/multi.rs:14:18 [INFO] [stderr] | [INFO] [stderr] 14 | unsafe { mem::transmute(s) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `&*(s as *const str as *const parse::multi::StrEncodings)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> src/encoding/pointer.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | assert!(p == p); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> src/encoding/primitive.rs:72:17 [INFO] [stderr] | [INFO] [stderr] 72 | assert!(i == i); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> src/encoding/structure.rs:71:17 [INFO] [stderr] | [INFO] [stderr] 71 | assert!(s == s); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> src/encoding/structure.rs:75:17 [INFO] [stderr] | [INFO] [stderr] 75 | assert!(s2 == s2); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> src/encoding/union.rs:70:17 [INFO] [stderr] | [INFO] [stderr] 70 | assert!(u == u); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/parse/encoding.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / pub fn from_str(s: &str) -> Result<&StrEncoding, ParseEncodingError<&str>> { [INFO] [stderr] 39 | | if is_valid(s) { [INFO] [stderr] 40 | | Ok(StrEncoding::from_str_unchecked(s)) [INFO] [stderr] 41 | | } else { [INFO] [stderr] 42 | | Err(ParseEncodingError(s)) [INFO] [stderr] 43 | | } [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/parse/encoding.rs:54:18 [INFO] [stderr] | [INFO] [stderr] 54 | unsafe { mem::transmute(s) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `&*(s as *const str as *const parse::encoding::StrEncoding)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/parse/multi.rs:14:18 [INFO] [stderr] | [INFO] [stderr] 14 | unsafe { mem::transmute(s) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `&*(s as *const str as *const parse::multi::StrEncodings)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `objc-encode`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "657ba2889b0ce8864b7f8d0115da67b4015b5b62003cc5134084740f4de8b693"` [INFO] running `"docker" "rm" "-f" "657ba2889b0ce8864b7f8d0115da67b4015b5b62003cc5134084740f4de8b693"` [INFO] [stdout] 657ba2889b0ce8864b7f8d0115da67b4015b5b62003cc5134084740f4de8b693