[INFO] crate oauth2 2.0.0-alpha.3 is already in cache [INFO] extracting crate oauth2 2.0.0-alpha.3 into work/ex/clippy-test-run/sources/stable/reg/oauth2/2.0.0-alpha.3 [INFO] extracting crate oauth2 2.0.0-alpha.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/oauth2/2.0.0-alpha.3 [INFO] validating manifest of oauth2-2.0.0-alpha.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of oauth2-2.0.0-alpha.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing oauth2-2.0.0-alpha.3 [INFO] finished frobbing oauth2-2.0.0-alpha.3 [INFO] frobbed toml for oauth2-2.0.0-alpha.3 written to work/ex/clippy-test-run/sources/stable/reg/oauth2/2.0.0-alpha.3/Cargo.toml [INFO] started frobbing oauth2-2.0.0-alpha.3 [INFO] finished frobbing oauth2-2.0.0-alpha.3 [INFO] frobbed toml for oauth2-2.0.0-alpha.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/oauth2/2.0.0-alpha.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting oauth2-2.0.0-alpha.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/oauth2/2.0.0-alpha.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c33cae990afafaae440d8bf041c9d489ace1bb52b023036918c8ed477486b9b4 [INFO] running `"docker" "start" "-a" "c33cae990afafaae440d8bf041c9d489ace1bb52b023036918c8ed477486b9b4"` [INFO] [stderr] Checking oauth2 v2.0.0-alpha.3 (/opt/crater/workdir) [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> examples/github.rs:138:70 [INFO] [stderr] | [INFO] [stderr] 138 | .map(|comma_separated| comma_separated.split(",")) [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> tests/lib.rs:221:9 [INFO] [stderr] | [INFO] [stderr] 221 | &vec![("foo", "bar")], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[("foo", "bar")]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> tests/lib.rs:321:26 [INFO] [stderr] | [INFO] [stderr] 321 | assert_eq!("foobar", token.refresh_token().clone().unwrap().secret()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `token.refresh_token()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> tests/lib.rs:887:13 [INFO] [stderr] | [INFO] [stderr] 887 | / match self { [INFO] [stderr] 888 | | &ColorfulErrorResponseType::TooDark => "too_dark", [INFO] [stderr] 889 | | &ColorfulErrorResponseType::TooLight => "too_light", [INFO] [stderr] 890 | | &ColorfulErrorResponseType::WrongColorSpace => "wrong_color_space", [INFO] [stderr] 891 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 887 | match *self { [INFO] [stderr] 888 | ColorfulErrorResponseType::TooDark => "too_dark", [INFO] [stderr] 889 | ColorfulErrorResponseType::TooLight => "too_light", [INFO] [stderr] 890 | ColorfulErrorResponseType::WrongColorSpace => "wrong_color_space", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> tests/lib.rs:997:26 [INFO] [stderr] | [INFO] [stderr] 997 | assert_eq!("foobar", token.refresh_token().clone().unwrap().secret()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `token.refresh_token()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 16.40s [INFO] running `"docker" "inspect" "c33cae990afafaae440d8bf041c9d489ace1bb52b023036918c8ed477486b9b4"` [INFO] running `"docker" "rm" "-f" "c33cae990afafaae440d8bf041c9d489ace1bb52b023036918c8ed477486b9b4"` [INFO] [stdout] c33cae990afafaae440d8bf041c9d489ace1bb52b023036918c8ed477486b9b4