[INFO] crate oak_runtime 0.5.5 is already in cache [INFO] extracting crate oak_runtime 0.5.5 into work/ex/clippy-test-run/sources/stable/reg/oak_runtime/0.5.5 [INFO] extracting crate oak_runtime 0.5.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/oak_runtime/0.5.5 [INFO] validating manifest of oak_runtime-0.5.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of oak_runtime-0.5.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing oak_runtime-0.5.5 [INFO] finished frobbing oak_runtime-0.5.5 [INFO] frobbed toml for oak_runtime-0.5.5 written to work/ex/clippy-test-run/sources/stable/reg/oak_runtime/0.5.5/Cargo.toml [INFO] started frobbing oak_runtime-0.5.5 [INFO] finished frobbing oak_runtime-0.5.5 [INFO] frobbed toml for oak_runtime-0.5.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/oak_runtime/0.5.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting oak_runtime-0.5.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/oak_runtime/0.5.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 92c44dfb3e844c8b1bf16d1256afc74df81487b47be343b12bae880d418fbe04 [INFO] running `"docker" "start" "-a" "92c44dfb3e844c8b1bf16d1256afc74df81487b47be343b12bae880d418fbe04"` [INFO] [stderr] Checking oak_runtime v0.5.5 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/str_stream.rs:51:7 [INFO] [stderr] | [INFO] [stderr] 51 | raw_data: raw_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `raw_data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse_state.rs:48:7 [INFO] [stderr] | [INFO] [stderr] 48 | farthest_read: farthest_read [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `farthest_read` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/str_stream.rs:51:7 [INFO] [stderr] | [INFO] [stderr] 51 | raw_data: raw_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `raw_data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse_state.rs:48:7 [INFO] [stderr] | [INFO] [stderr] 48 | farthest_read: farthest_read [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `farthest_read` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parse_state.rs:58:8 [INFO] [stderr] | [INFO] [stderr] 58 | if self.expected.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.expected.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parse_state.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | / match self { [INFO] [stderr] 97 | | &Success(ref data) => { [INFO] [stderr] 98 | | formatter.write_fmt(format_args!( [INFO] [stderr] 99 | | "Full match, got data `{:?}`.", data)) [INFO] [stderr] ... | [INFO] [stderr] 110 | | } [INFO] [stderr] 111 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 96 | match *self { [INFO] [stderr] 97 | Success(ref data) => { [INFO] [stderr] 98 | formatter.write_fmt(format_args!( [INFO] [stderr] 99 | "Full match, got data `{:?}`.", data)) [INFO] [stderr] 100 | } [INFO] [stderr] 101 | Partial(ref data, ref expectation) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/file_map_stream.rs:49:49 [INFO] [stderr] | [INFO] [stderr] 49 | fn register_lines(filemap: &Rc, src: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/str_stream.rs:204:3 [INFO] [stderr] | [INFO] [stderr] 204 | / fn test_str_stream<'a, I>(mut s1: StrStream<'a>, chars: I) where [INFO] [stderr] 205 | | I: Iterator [INFO] [stderr] 206 | | { [INFO] [stderr] 207 | | let s1_init = s1.clone(); [INFO] [stderr] ... | [INFO] [stderr] 219 | | assert!(s1 == s2); [INFO] [stderr] 220 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> src/str_stream.rs:241:13 [INFO] [stderr] | [INFO] [stderr] 241 | assert!(empty == empty); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `>` [INFO] [stderr] --> src/str_stream.rs:242:14 [INFO] [stderr] | [INFO] [stderr] 242 | assert!(!(empty > empty)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parse_state.rs:58:8 [INFO] [stderr] | [INFO] [stderr] 58 | if self.expected.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.expected.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parse_state.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | / match self { [INFO] [stderr] 97 | | &Success(ref data) => { [INFO] [stderr] 98 | | formatter.write_fmt(format_args!( [INFO] [stderr] 99 | | "Full match, got data `{:?}`.", data)) [INFO] [stderr] ... | [INFO] [stderr] 110 | | } [INFO] [stderr] 111 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 96 | match *self { [INFO] [stderr] 97 | Success(ref data) => { [INFO] [stderr] 98 | formatter.write_fmt(format_args!( [INFO] [stderr] 99 | "Full match, got data `{:?}`.", data)) [INFO] [stderr] 100 | } [INFO] [stderr] 101 | Partial(ref data, ref expectation) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/file_map_stream.rs:49:49 [INFO] [stderr] | [INFO] [stderr] 49 | fn register_lines(filemap: &Rc, src: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/file_map_stream.rs:147:39 [INFO] [stderr] | [INFO] [stderr] 147 | let filemap = codemap.new_filemap(format!("fake"), None, format!("A\n\nT\n")); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"fake".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/file_map_stream.rs:147:62 [INFO] [stderr] | [INFO] [stderr] 147 | let filemap = codemap.new_filemap(format!("fake"), None, format!("A\n\nT\n")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"A\n\nT\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `oak_runtime`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "92c44dfb3e844c8b1bf16d1256afc74df81487b47be343b12bae880d418fbe04"` [INFO] running `"docker" "rm" "-f" "92c44dfb3e844c8b1bf16d1256afc74df81487b47be343b12bae880d418fbe04"` [INFO] [stdout] 92c44dfb3e844c8b1bf16d1256afc74df81487b47be343b12bae880d418fbe04