[INFO] crate nzsc_single_player_json_interface 0.1.0 is already in cache [INFO] extracting crate nzsc_single_player_json_interface 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/nzsc_single_player_json_interface/0.1.0 [INFO] extracting crate nzsc_single_player_json_interface 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nzsc_single_player_json_interface/0.1.0 [INFO] validating manifest of nzsc_single_player_json_interface-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nzsc_single_player_json_interface-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nzsc_single_player_json_interface-0.1.0 [INFO] finished frobbing nzsc_single_player_json_interface-0.1.0 [INFO] frobbed toml for nzsc_single_player_json_interface-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/nzsc_single_player_json_interface/0.1.0/Cargo.toml [INFO] started frobbing nzsc_single_player_json_interface-0.1.0 [INFO] finished frobbing nzsc_single_player_json_interface-0.1.0 [INFO] frobbed toml for nzsc_single_player_json_interface-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nzsc_single_player_json_interface/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nzsc_single_player_json_interface-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/nzsc_single_player_json_interface/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 70e0985cf82ac87ec48a9d85a755e55f9d7cc62fd3f81d572f367d0dea88322e [INFO] running `"docker" "start" "-a" "70e0985cf82ac87ec48a9d85a755e55f9d7cc62fd3f81d572f367d0dea88322e"` [INFO] [stderr] Checking nzsc_single_player v0.5.1 [INFO] [stderr] Checking nzsc_single_player_json_interface v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/notification.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / match notification { [INFO] [stderr] 9 | | &Notification::CharacterSelectionAndHeadstart { [INFO] [stderr] 10 | | ref human_character, [INFO] [stderr] 11 | | ref computer_character, [INFO] [stderr] ... | [INFO] [stderr] 143 | | }, [INFO] [stderr] 144 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 8 | match *notification { [INFO] [stderr] 9 | Notification::CharacterSelectionAndHeadstart { [INFO] [stderr] 10 | ref human_character, [INFO] [stderr] 11 | ref computer_character, [INFO] [stderr] 12 | ref who_gets_the_headstart, [INFO] [stderr] 13 | } => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/notification.rs:80:27 [INFO] [stderr] | [INFO] [stderr] 80 | let margin = (human_points as i16 - computer_points as i16).abs() as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(human_points)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/notification.rs:80:49 [INFO] [stderr] | [INFO] [stderr] 80 | let margin = (human_points as i16 - computer_points as i16).abs() as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(computer_points)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/question.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / match question { [INFO] [stderr] 9 | | &Question::ChooseCharacter { [INFO] [stderr] 10 | | ref available_characters, [INFO] [stderr] 11 | | } => { [INFO] [stderr] ... | [INFO] [stderr] 32 | | }, [INFO] [stderr] 33 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 8 | match *question { [INFO] [stderr] 9 | Question::ChooseCharacter { [INFO] [stderr] 10 | ref available_characters, [INFO] [stderr] 11 | } => { [INFO] [stderr] 12 | write!(s, r#""type":"CHOOSE_CHARACTER","availableCharacters":["#).unwrap(); [INFO] [stderr] 13 | for character in available_characters { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/notification.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / match notification { [INFO] [stderr] 9 | | &Notification::CharacterSelectionAndHeadstart { [INFO] [stderr] 10 | | ref human_character, [INFO] [stderr] 11 | | ref computer_character, [INFO] [stderr] ... | [INFO] [stderr] 143 | | }, [INFO] [stderr] 144 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 8 | match *notification { [INFO] [stderr] 9 | Notification::CharacterSelectionAndHeadstart { [INFO] [stderr] 10 | ref human_character, [INFO] [stderr] 11 | ref computer_character, [INFO] [stderr] 12 | ref who_gets_the_headstart, [INFO] [stderr] 13 | } => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/notification.rs:80:27 [INFO] [stderr] | [INFO] [stderr] 80 | let margin = (human_points as i16 - computer_points as i16).abs() as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(human_points)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/notification.rs:80:49 [INFO] [stderr] | [INFO] [stderr] 80 | let margin = (human_points as i16 - computer_points as i16).abs() as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(computer_points)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/question.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / match question { [INFO] [stderr] 9 | | &Question::ChooseCharacter { [INFO] [stderr] 10 | | ref available_characters, [INFO] [stderr] 11 | | } => { [INFO] [stderr] ... | [INFO] [stderr] 32 | | }, [INFO] [stderr] 33 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 8 | match *question { [INFO] [stderr] 9 | Question::ChooseCharacter { [INFO] [stderr] 10 | ref available_characters, [INFO] [stderr] 11 | } => { [INFO] [stderr] 12 | write!(s, r#""type":"CHOOSE_CHARACTER","availableCharacters":["#).unwrap(); [INFO] [stderr] 13 | for character in available_characters { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.73s [INFO] running `"docker" "inspect" "70e0985cf82ac87ec48a9d85a755e55f9d7cc62fd3f81d572f367d0dea88322e"` [INFO] running `"docker" "rm" "-f" "70e0985cf82ac87ec48a9d85a755e55f9d7cc62fd3f81d572f367d0dea88322e"` [INFO] [stdout] 70e0985cf82ac87ec48a9d85a755e55f9d7cc62fd3f81d572f367d0dea88322e