[INFO] crate nzsc2p 0.3.0 is already in cache
[INFO] extracting crate nzsc2p 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/nzsc2p/0.3.0
[INFO] extracting crate nzsc2p 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nzsc2p/0.3.0
[INFO] validating manifest of nzsc2p-0.3.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of nzsc2p-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing nzsc2p-0.3.0
[INFO] finished frobbing nzsc2p-0.3.0
[INFO] frobbed toml for nzsc2p-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/nzsc2p/0.3.0/Cargo.toml
[INFO] started frobbing nzsc2p-0.3.0
[INFO] finished frobbing nzsc2p-0.3.0
[INFO] frobbed toml for nzsc2p-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nzsc2p/0.3.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting nzsc2p-0.3.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/nzsc2p/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 2347dc5dab156f0c5e1efca164801599d22961205a8fe147aac8b086d62e56e9
[INFO] running `"docker" "start" "-a" "2347dc5dab156f0c5e1efca164801599d22961205a8fe147aac8b086d62e56e9"`
[INFO] [stderr]     Checking nzsc_core v0.2.0
[INFO] [stderr]     Checking nzsc2p v0.3.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/players.rs:63:13
[INFO] [stderr]    |
[INFO] [stderr] 63 |             return 1;
[INFO] [stderr]    |             ^^^^^^^^^ help: remove `return` as shown: `1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/players.rs:66:13
[INFO] [stderr]    |
[INFO] [stderr] 66 |             return 0;
[INFO] [stderr]    |             ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/players.rs:88:13
[INFO] [stderr]    |
[INFO] [stderr] 88 |             return 1;
[INFO] [stderr]    |             ^^^^^^^^^ help: remove `return` as shown: `1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/players.rs:91:13
[INFO] [stderr]    |
[INFO] [stderr] 91 |             return 0;
[INFO] [stderr]    |             ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/players.rs:132:13
[INFO] [stderr]     |
[INFO] [stderr] 132 |             return 1;
[INFO] [stderr]     |             ^^^^^^^^^ help: remove `return` as shown: `1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/players.rs:135:13
[INFO] [stderr]     |
[INFO] [stderr] 135 |             return 0;
[INFO] [stderr]     |             ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/two_player_game.rs:65:24
[INFO] [stderr]     |
[INFO] [stderr] 65  |                   } else {
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 66  | |                     if let Ok(character) = Character::from_str(&choice[..]) {
[INFO] [stderr] 67  | |                         if a.character_streak.times == 3
[INFO] [stderr] 68  | |                             && a.character_streak.repeated_character == Some(character)
[INFO] [stderr] ...   |
[INFO] [stderr] 115 | |                     }
[INFO] [stderr] 116 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 65  |                 } else if let Ok(character) = Character::from_str(&choice[..]) {
[INFO] [stderr] 66  |     if a.character_streak.times == 3
[INFO] [stderr] 67  |         && a.character_streak.repeated_character == Some(character)
[INFO] [stderr] 68  |     {
[INFO] [stderr] 69  |         b.points += a.penalize(3);
[INFO] [stderr] 70  | 
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/two_player_game.rs:77:32
[INFO] [stderr]     |
[INFO] [stderr] 77  |                           } else {
[INFO] [stderr]     |  ________________________________^
[INFO] [stderr] 78  | |                             if let Some(b_character) = b.selected_character {
[INFO] [stderr] 79  | |                                 if character == b_character {
[INFO] [stderr] 80  | |                                     a.selected_character = None;
[INFO] [stderr] ...   |
[INFO] [stderr] 105 | |                             }
[INFO] [stderr] 106 | |                         }
[INFO] [stderr]     | |_________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 77  |                         } else if let Some(b_character) = b.selected_character {
[INFO] [stderr] 78  |     if character == b_character {
[INFO] [stderr] 79  |         a.selected_character = None;
[INFO] [stderr] 80  |         b.selected_character = None;
[INFO] [stderr] 81  |         a.character_streak.add(character);
[INFO] [stderr] 82  |         b.character_streak.add(character);
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/two_player_game.rs:134:24
[INFO] [stderr]     |
[INFO] [stderr] 134 |                   } else {
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 135 | |                     if let Ok(booster) = Booster::from_str(&choice[..]) {
[INFO] [stderr] 136 | |                         if a.available_boosters().contains(&booster) {
[INFO] [stderr] 137 | |                             if let Some(b_booster) = b.selected_booster {
[INFO] [stderr] ...   |
[INFO] [stderr] 166 | |                     }
[INFO] [stderr] 167 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 134 |                 } else if let Ok(booster) = Booster::from_str(&choice[..]) {
[INFO] [stderr] 135 |     if a.available_boosters().contains(&booster) {
[INFO] [stderr] 136 |         if let Some(b_booster) = b.selected_booster {
[INFO] [stderr] 137 |             new_phase = Some(Phase::MoveChoosing(
[INFO] [stderr] 138 |                 a.to_moveless_player(booster),
[INFO] [stderr] 139 |                 b.to_moveless_player(b_booster),
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/two_player_game.rs:185:24
[INFO] [stderr]     |
[INFO] [stderr] 185 |                   } else {
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 186 | |                     if let Ok(a_move) = Move::from_str(&choice[..]) {
[INFO] [stderr] 187 | |                         if a.available_moves().contains(&a_move) {
[INFO] [stderr] 188 | |                             if let Some(b_move) = b.selected_move {
[INFO] [stderr] ...   |
[INFO] [stderr] 270 | |                     }
[INFO] [stderr] 271 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 185 |                 } else if let Ok(a_move) = Move::from_str(&choice[..]) {
[INFO] [stderr] 186 |     if a.available_moves().contains(&a_move) {
[INFO] [stderr] 187 |         if let Some(b_move) = b.selected_move {
[INFO] [stderr] 188 |             let points = outcomes::get_points(vec![(a.booster, a_move), (b.booster, b_move)]);
[INFO] [stderr] 189 |             a.points += points[0];
[INFO] [stderr] 190 |             b.points += points[1];
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/two_player_game.rs:218:32
[INFO] [stderr]     |
[INFO] [stderr] 218 |                           } else {
[INFO] [stderr]     |  ________________________________^
[INFO] [stderr] 219 | |                             if a.destroyed_moves.contains(&a_move) {
[INFO] [stderr] 220 | |                                 b.points += a.penalize(4);
[INFO] [stderr] 221 | |
[INFO] [stderr] ...   |
[INFO] [stderr] 260 | |                             }
[INFO] [stderr] 261 | |                         }
[INFO] [stderr]     | |_________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 218 |                         } else if a.destroyed_moves.contains(&a_move) {
[INFO] [stderr] 219 |     b.points += a.penalize(4);
[INFO] [stderr] 220 | 
[INFO] [stderr] 221 |     if b.points >= 5 {
[INFO] [stderr] 222 |         new_phase = Some(Phase::GameOver(a.points, b.points));
[INFO] [stderr] 223 |     }
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `players::CharacterlessPlayer`
[INFO] [stderr]   --> src/players.rs:36:5
[INFO] [stderr]    |
[INFO] [stderr] 36 | /     pub fn new() -> Self {
[INFO] [stderr] 37 | |         Self {
[INFO] [stderr] 38 | |             points: 0,
[INFO] [stderr] 39 | |             waits: 4,
[INFO] [stderr] ...  |
[INFO] [stderr] 42 | |         }
[INFO] [stderr] 43 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 35 | impl Default for players::CharacterlessPlayer {
[INFO] [stderr] 36 |     fn default() -> Self {
[INFO] [stderr] 37 |         Self::new()
[INFO] [stderr] 38 |     }
[INFO] [stderr] 39 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `two_player_game::NZSCTwoPlayerGame`
[INFO] [stderr]   --> src/two_player_game.rs:37:5
[INFO] [stderr]    |
[INFO] [stderr] 37 | /     pub fn new() -> Self {
[INFO] [stderr] 38 | |         Self {
[INFO] [stderr] 39 | |             phase: Phase::CharacterChoosing(
[INFO] [stderr] 40 | |                 CharacterlessPlayer::new(),
[INFO] [stderr] ...  |
[INFO] [stderr] 43 | |         }
[INFO] [stderr] 44 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 36 | impl Default for two_player_game::NZSCTwoPlayerGame {
[INFO] [stderr] 37 |     fn default() -> Self {
[INFO] [stderr] 38 |         Self::new()
[INFO] [stderr] 39 |     }
[INFO] [stderr] 40 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 38
[INFO] [stderr]    --> src/two_player_game.rs:46:5
[INFO] [stderr]     |
[INFO] [stderr] 46  | /     pub fn process_choice(&mut self, chooser: WhichPlayer, choice: String) -> Result<(), ()> {
[INFO] [stderr] 47  | |         let mut new_phase: Option<Phase> = None;
[INFO] [stderr] 48  | |
[INFO] [stderr] 49  | |         let return_val = match &mut self.phase {
[INFO] [stderr] ...   |
[INFO] [stderr] 288 | |         return_val
[INFO] [stderr] 289 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/two_player_game.rs:49:26
[INFO] [stderr]     |
[INFO] [stderr] 49  |           let return_val = match &mut self.phase {
[INFO] [stderr]     |  __________________________^
[INFO] [stderr] 50  | |             &mut Phase::CharacterChoosing(ref mut a, ref mut b) => {
[INFO] [stderr] 51  | |                 let tuple = match chooser {
[INFO] [stderr] 52  | |                     WhichPlayer::PlayerA => {
[INFO] [stderr] ...   |
[INFO] [stderr] 277 | |             },
[INFO] [stderr] 278 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 49  |         let return_val = match *(&mut self.phase) {
[INFO] [stderr] 50  |             Phase::CharacterChoosing(ref mut a, ref mut b) => {
[INFO] [stderr] 51  |                 let tuple = match chooser {
[INFO] [stderr] 52  |                     WhichPlayer::PlayerA => {
[INFO] [stderr] 53  |                         (a, b)
[INFO] [stderr] 54  |                     },
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/two_player_game.rs:62:24
[INFO] [stderr]     |
[INFO] [stderr] 62  |                   if let Some(_) = a.selected_character {
[INFO] [stderr]     |  _________________-      ^^^^^^^
[INFO] [stderr] 63  | |                     // Cannot repick.
[INFO] [stderr] 64  | |                     Err(())
[INFO] [stderr] 65  | |                 } else {
[INFO] [stderr] ...   |
[INFO] [stderr] 115 | |                     }
[INFO] [stderr] 116 | |                 }
[INFO] [stderr]     | |_________________- help: try this: `if a.selected_character.is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/two_player_game.rs:131:24
[INFO] [stderr]     |
[INFO] [stderr] 131 |                   if let Some(_) = a.selected_booster {
[INFO] [stderr]     |  _________________-      ^^^^^^^
[INFO] [stderr] 132 | |                     // Cannot repick.
[INFO] [stderr] 133 | |                     Err(())
[INFO] [stderr] 134 | |                 } else {
[INFO] [stderr] ...   |
[INFO] [stderr] 166 | |                     }
[INFO] [stderr] 167 | |                 }
[INFO] [stderr]     | |_________________- help: try this: `if a.selected_booster.is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/two_player_game.rs:182:24
[INFO] [stderr]     |
[INFO] [stderr] 182 |                   if let Some(_) = a.selected_move {
[INFO] [stderr]     |  _________________-      ^^^^^^^
[INFO] [stderr] 183 | |                     // Cannot repick.
[INFO] [stderr] 184 | |                     Err(())
[INFO] [stderr] 185 | |                 } else {
[INFO] [stderr] ...   |
[INFO] [stderr] 270 | |                     }
[INFO] [stderr] 271 | |                 }
[INFO] [stderr]     | |_________________- help: try this: `if a.selected_move.is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/two_player_game.rs:294:9
[INFO] [stderr]     |
[INFO] [stderr] 294 | /         match self {
[INFO] [stderr] 295 | |             &Phase::CharacterChoosing(ref a, ref b) => {
[INFO] [stderr] 296 | |                 Phase::CharacterChoosing(b.clone(), a.clone())
[INFO] [stderr] 297 | |             },
[INFO] [stderr] ...   |
[INFO] [stderr] 306 | |             },
[INFO] [stderr] 307 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 294 |         match *self {
[INFO] [stderr] 295 |             Phase::CharacterChoosing(ref a, ref b) => {
[INFO] [stderr] 296 |                 Phase::CharacterChoosing(b.clone(), a.clone())
[INFO] [stderr] 297 |             },
[INFO] [stderr] 298 |             Phase::BoosterChoosing(ref a, ref b) => {
[INFO] [stderr] 299 |                 Phase::BoosterChoosing(b.clone(), a.clone())
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/two_player_game.rs:305:33
[INFO] [stderr]     |
[INFO] [stderr] 305 |                 Phase::GameOver(b.clone(), a.clone())
[INFO] [stderr]     |                                 ^^^^^^^^^ help: try dereferencing it: `*b`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/two_player_game.rs:305:44
[INFO] [stderr]     |
[INFO] [stderr] 305 |                 Phase::GameOver(b.clone(), a.clone())
[INFO] [stderr]     |                                            ^^^^^^^^^ help: try dereferencing it: `*a`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/players.rs:63:13
[INFO] [stderr]    |
[INFO] [stderr] 63 |             return 1;
[INFO] [stderr]    |             ^^^^^^^^^ help: remove `return` as shown: `1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/players.rs:66:13
[INFO] [stderr]    |
[INFO] [stderr] 66 |             return 0;
[INFO] [stderr]    |             ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/players.rs:88:13
[INFO] [stderr]    |
[INFO] [stderr] 88 |             return 1;
[INFO] [stderr]    |             ^^^^^^^^^ help: remove `return` as shown: `1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/players.rs:91:13
[INFO] [stderr]    |
[INFO] [stderr] 91 |             return 0;
[INFO] [stderr]    |             ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/players.rs:132:13
[INFO] [stderr]     |
[INFO] [stderr] 132 |             return 1;
[INFO] [stderr]     |             ^^^^^^^^^ help: remove `return` as shown: `1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/players.rs:135:13
[INFO] [stderr]     |
[INFO] [stderr] 135 |             return 0;
[INFO] [stderr]     |             ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/two_player_game.rs:65:24
[INFO] [stderr]     |
[INFO] [stderr] 65  |                   } else {
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 66  | |                     if let Ok(character) = Character::from_str(&choice[..]) {
[INFO] [stderr] 67  | |                         if a.character_streak.times == 3
[INFO] [stderr] 68  | |                             && a.character_streak.repeated_character == Some(character)
[INFO] [stderr] ...   |
[INFO] [stderr] 115 | |                     }
[INFO] [stderr] 116 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 65  |                 } else if let Ok(character) = Character::from_str(&choice[..]) {
[INFO] [stderr] 66  |     if a.character_streak.times == 3
[INFO] [stderr] 67  |         && a.character_streak.repeated_character == Some(character)
[INFO] [stderr] 68  |     {
[INFO] [stderr] 69  |         b.points += a.penalize(3);
[INFO] [stderr] 70  | 
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/two_player_game.rs:77:32
[INFO] [stderr]     |
[INFO] [stderr] 77  |                           } else {
[INFO] [stderr]     |  ________________________________^
[INFO] [stderr] 78  | |                             if let Some(b_character) = b.selected_character {
[INFO] [stderr] 79  | |                                 if character == b_character {
[INFO] [stderr] 80  | |                                     a.selected_character = None;
[INFO] [stderr] ...   |
[INFO] [stderr] 105 | |                             }
[INFO] [stderr] 106 | |                         }
[INFO] [stderr]     | |_________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 77  |                         } else if let Some(b_character) = b.selected_character {
[INFO] [stderr] 78  |     if character == b_character {
[INFO] [stderr] 79  |         a.selected_character = None;
[INFO] [stderr] 80  |         b.selected_character = None;
[INFO] [stderr] 81  |         a.character_streak.add(character);
[INFO] [stderr] 82  |         b.character_streak.add(character);
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/two_player_game.rs:134:24
[INFO] [stderr]     |
[INFO] [stderr] 134 |                   } else {
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 135 | |                     if let Ok(booster) = Booster::from_str(&choice[..]) {
[INFO] [stderr] 136 | |                         if a.available_boosters().contains(&booster) {
[INFO] [stderr] 137 | |                             if let Some(b_booster) = b.selected_booster {
[INFO] [stderr] ...   |
[INFO] [stderr] 166 | |                     }
[INFO] [stderr] 167 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 134 |                 } else if let Ok(booster) = Booster::from_str(&choice[..]) {
[INFO] [stderr] 135 |     if a.available_boosters().contains(&booster) {
[INFO] [stderr] 136 |         if let Some(b_booster) = b.selected_booster {
[INFO] [stderr] 137 |             new_phase = Some(Phase::MoveChoosing(
[INFO] [stderr] 138 |                 a.to_moveless_player(booster),
[INFO] [stderr] 139 |                 b.to_moveless_player(b_booster),
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/two_player_game.rs:185:24
[INFO] [stderr]     |
[INFO] [stderr] 185 |                   } else {
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 186 | |                     if let Ok(a_move) = Move::from_str(&choice[..]) {
[INFO] [stderr] 187 | |                         if a.available_moves().contains(&a_move) {
[INFO] [stderr] 188 | |                             if let Some(b_move) = b.selected_move {
[INFO] [stderr] ...   |
[INFO] [stderr] 270 | |                     }
[INFO] [stderr] 271 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 185 |                 } else if let Ok(a_move) = Move::from_str(&choice[..]) {
[INFO] [stderr] 186 |     if a.available_moves().contains(&a_move) {
[INFO] [stderr] 187 |         if let Some(b_move) = b.selected_move {
[INFO] [stderr] 188 |             let points = outcomes::get_points(vec![(a.booster, a_move), (b.booster, b_move)]);
[INFO] [stderr] 189 |             a.points += points[0];
[INFO] [stderr] 190 |             b.points += points[1];
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/two_player_game.rs:218:32
[INFO] [stderr]     |
[INFO] [stderr] 218 |                           } else {
[INFO] [stderr]     |  ________________________________^
[INFO] [stderr] 219 | |                             if a.destroyed_moves.contains(&a_move) {
[INFO] [stderr] 220 | |                                 b.points += a.penalize(4);
[INFO] [stderr] 221 | |
[INFO] [stderr] ...   |
[INFO] [stderr] 260 | |                             }
[INFO] [stderr] 261 | |                         }
[INFO] [stderr]     | |_________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 218 |                         } else if a.destroyed_moves.contains(&a_move) {
[INFO] [stderr] 219 |     b.points += a.penalize(4);
[INFO] [stderr] 220 | 
[INFO] [stderr] 221 |     if b.points >= 5 {
[INFO] [stderr] 222 |         new_phase = Some(Phase::GameOver(a.points, b.points));
[INFO] [stderr] 223 |     }
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 28
[INFO] [stderr]    --> src/tests.rs:11:1
[INFO] [stderr]     |
[INFO] [stderr] 11  | / fn it_works() {
[INFO] [stderr] 12  | |     let mut g = NZSCTwoPlayerGame::new();
[INFO] [stderr] 13  | |
[INFO] [stderr] 14  | |     g.process_choice(WhichPlayer::PlayerA, "Ninja".to_string()).unwrap();
[INFO] [stderr] ...   |
[INFO] [stderr] 106 | |     }
[INFO] [stderr] 107 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `players::CharacterlessPlayer`
[INFO] [stderr]   --> src/players.rs:36:5
[INFO] [stderr]    |
[INFO] [stderr] 36 | /     pub fn new() -> Self {
[INFO] [stderr] 37 | |         Self {
[INFO] [stderr] 38 | |             points: 0,
[INFO] [stderr] 39 | |             waits: 4,
[INFO] [stderr] ...  |
[INFO] [stderr] 42 | |         }
[INFO] [stderr] 43 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 35 | impl Default for players::CharacterlessPlayer {
[INFO] [stderr] 36 |     fn default() -> Self {
[INFO] [stderr] 37 |         Self::new()
[INFO] [stderr] 38 |     }
[INFO] [stderr] 39 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `two_player_game::NZSCTwoPlayerGame`
[INFO] [stderr]   --> src/two_player_game.rs:37:5
[INFO] [stderr]    |
[INFO] [stderr] 37 | /     pub fn new() -> Self {
[INFO] [stderr] 38 | |         Self {
[INFO] [stderr] 39 | |             phase: Phase::CharacterChoosing(
[INFO] [stderr] 40 | |                 CharacterlessPlayer::new(),
[INFO] [stderr] ...  |
[INFO] [stderr] 43 | |         }
[INFO] [stderr] 44 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 36 | impl Default for two_player_game::NZSCTwoPlayerGame {
[INFO] [stderr] 37 |     fn default() -> Self {
[INFO] [stderr] 38 |         Self::new()
[INFO] [stderr] 39 |     }
[INFO] [stderr] 40 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 38
[INFO] [stderr]    --> src/two_player_game.rs:46:5
[INFO] [stderr]     |
[INFO] [stderr] 46  | /     pub fn process_choice(&mut self, chooser: WhichPlayer, choice: String) -> Result<(), ()> {
[INFO] [stderr] 47  | |         let mut new_phase: Option<Phase> = None;
[INFO] [stderr] 48  | |
[INFO] [stderr] 49  | |         let return_val = match &mut self.phase {
[INFO] [stderr] ...   |
[INFO] [stderr] 288 | |         return_val
[INFO] [stderr] 289 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/two_player_game.rs:49:26
[INFO] [stderr]     |
[INFO] [stderr] 49  |           let return_val = match &mut self.phase {
[INFO] [stderr]     |  __________________________^
[INFO] [stderr] 50  | |             &mut Phase::CharacterChoosing(ref mut a, ref mut b) => {
[INFO] [stderr] 51  | |                 let tuple = match chooser {
[INFO] [stderr] 52  | |                     WhichPlayer::PlayerA => {
[INFO] [stderr] ...   |
[INFO] [stderr] 277 | |             },
[INFO] [stderr] 278 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 49  |         let return_val = match *(&mut self.phase) {
[INFO] [stderr] 50  |             Phase::CharacterChoosing(ref mut a, ref mut b) => {
[INFO] [stderr] 51  |                 let tuple = match chooser {
[INFO] [stderr] 52  |                     WhichPlayer::PlayerA => {
[INFO] [stderr] 53  |                         (a, b)
[INFO] [stderr] 54  |                     },
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/two_player_game.rs:62:24
[INFO] [stderr]     |
[INFO] [stderr] 62  |                   if let Some(_) = a.selected_character {
[INFO] [stderr]     |  _________________-      ^^^^^^^
[INFO] [stderr] 63  | |                     // Cannot repick.
[INFO] [stderr] 64  | |                     Err(())
[INFO] [stderr] 65  | |                 } else {
[INFO] [stderr] ...   |
[INFO] [stderr] 115 | |                     }
[INFO] [stderr] 116 | |                 }
[INFO] [stderr]     | |_________________- help: try this: `if a.selected_character.is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/two_player_game.rs:131:24
[INFO] [stderr]     |
[INFO] [stderr] 131 |                   if let Some(_) = a.selected_booster {
[INFO] [stderr]     |  _________________-      ^^^^^^^
[INFO] [stderr] 132 | |                     // Cannot repick.
[INFO] [stderr] 133 | |                     Err(())
[INFO] [stderr] 134 | |                 } else {
[INFO] [stderr] ...   |
[INFO] [stderr] 166 | |                     }
[INFO] [stderr] 167 | |                 }
[INFO] [stderr]     | |_________________- help: try this: `if a.selected_booster.is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/two_player_game.rs:182:24
[INFO] [stderr]     |
[INFO] [stderr] 182 |                   if let Some(_) = a.selected_move {
[INFO] [stderr]     |  _________________-      ^^^^^^^
[INFO] [stderr] 183 | |                     // Cannot repick.
[INFO] [stderr] 184 | |                     Err(())
[INFO] [stderr] 185 | |                 } else {
[INFO] [stderr] ...   |
[INFO] [stderr] 270 | |                     }
[INFO] [stderr] 271 | |                 }
[INFO] [stderr]     | |_________________- help: try this: `if a.selected_move.is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/two_player_game.rs:294:9
[INFO] [stderr]     |
[INFO] [stderr] 294 | /         match self {
[INFO] [stderr] 295 | |             &Phase::CharacterChoosing(ref a, ref b) => {
[INFO] [stderr] 296 | |                 Phase::CharacterChoosing(b.clone(), a.clone())
[INFO] [stderr] 297 | |             },
[INFO] [stderr] ...   |
[INFO] [stderr] 306 | |             },
[INFO] [stderr] 307 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 294 |         match *self {
[INFO] [stderr] 295 |             Phase::CharacterChoosing(ref a, ref b) => {
[INFO] [stderr] 296 |                 Phase::CharacterChoosing(b.clone(), a.clone())
[INFO] [stderr] 297 |             },
[INFO] [stderr] 298 |             Phase::BoosterChoosing(ref a, ref b) => {
[INFO] [stderr] 299 |                 Phase::BoosterChoosing(b.clone(), a.clone())
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/two_player_game.rs:305:33
[INFO] [stderr]     |
[INFO] [stderr] 305 |                 Phase::GameOver(b.clone(), a.clone())
[INFO] [stderr]     |                                 ^^^^^^^^^ help: try dereferencing it: `*b`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/two_player_game.rs:305:44
[INFO] [stderr]     |
[INFO] [stderr] 305 |                 Phase::GameOver(b.clone(), a.clone())
[INFO] [stderr]     |                                            ^^^^^^^^^ help: try dereferencing it: `*a`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.00s
[INFO] running `"docker" "inspect" "2347dc5dab156f0c5e1efca164801599d22961205a8fe147aac8b086d62e56e9"`
[INFO] running `"docker" "rm" "-f" "2347dc5dab156f0c5e1efca164801599d22961205a8fe147aac8b086d62e56e9"`
[INFO] [stdout] 2347dc5dab156f0c5e1efca164801599d22961205a8fe147aac8b086d62e56e9