[INFO] crate nvoclock 0.0.3 is already in cache
[INFO] extracting crate nvoclock 0.0.3 into work/ex/clippy-test-run/sources/stable/reg/nvoclock/0.0.3
[INFO] extracting crate nvoclock 0.0.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nvoclock/0.0.3
[INFO] validating manifest of nvoclock-0.0.3 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of nvoclock-0.0.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing nvoclock-0.0.3
[INFO] finished frobbing nvoclock-0.0.3
[INFO] frobbed toml for nvoclock-0.0.3 written to work/ex/clippy-test-run/sources/stable/reg/nvoclock/0.0.3/Cargo.toml
[INFO] started frobbing nvoclock-0.0.3
[INFO] finished frobbing nvoclock-0.0.3
[INFO] frobbed toml for nvoclock-0.0.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nvoclock/0.0.3/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting nvoclock-0.0.3 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/nvoclock/0.0.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 6b740b0b918ca988f38b560a462ef91c24a4ecb1ef5f980ab67b4b6fecc0ea6b
[INFO] running `"docker" "start" "-a" "6b740b0b918ca988f38b560a462ef91c24a4ecb1ef5f980ab67b4b6fecc0ea6b"`
[INFO] [stderr] warning: `panic` setting is ignored for `test` profile
[INFO] [stderr] warning: `panic` setting is ignored for `bench` profile
[INFO] [stderr]     Checking cfg-if v0.1.6
[INFO] [stderr]     Checking lazy_static v1.2.0
[INFO] [stderr]     Checking ucd-util v0.1.3
[INFO] [stderr]     Checking utf8-ranges v1.0.2
[INFO] [stderr]     Checking unicode-width v0.1.5
[INFO] [stderr]     Checking itoa v0.4.3
[INFO] [stderr]     Checking term v0.4.6
[INFO] [stderr]     Checking encode_unicode v0.3.5
[INFO] [stderr]     Checking lazy_static v0.2.11
[INFO] [stderr]     Checking result v0.0.1
[INFO] [stderr]     Checking quick-error v1.2.2
[INFO] [stderr]     Checking log v0.4.6
[INFO] [stderr]     Checking textwrap v0.10.0
[INFO] [stderr]     Checking thread_local v0.3.6
[INFO] [stderr]     Checking regex-syntax v0.5.6
[INFO] [stderr]     Checking libc v0.2.48
[INFO] [stderr]     Checking serde v1.0.85
[INFO] [stderr]     Checking ryu v0.2.7
[INFO] [stderr]     Checking clap v2.32.0
[INFO] [stderr]     Checking prettytable-rs v0.6.7
[INFO] [stderr]     Checking csv v1.0.5
[INFO] [stderr]     Checking nvapi-sys v0.0.3
[INFO] [stderr]     Checking log v0.3.9
[INFO] [stderr]     Checking memchr v2.1.3
[INFO] [stderr]     Checking atty v0.2.11
[INFO] [stderr]     Checking aho-corasick v0.6.9
[INFO] [stderr]     Checking csv-core v0.1.5
[INFO] [stderr]     Checking regex v0.2.11
[INFO] [stderr]     Checking nvapi v0.0.3
[INFO] [stderr]     Checking env_logger v0.4.3
[INFO] [stderr]     Checking serde_json v1.0.37
[INFO] [stderr]     Checking nvapi-hi v0.0.3
[INFO] [stderr]     Checking nvoclock v0.0.3 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/auto.rs:33:13
[INFO] [stderr]    |
[INFO] [stderr] 33 |             options: options,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `options`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/auto.rs:37:13
[INFO] [stderr]    |
[INFO] [stderr] 37 |             gpu: gpu,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `gpu`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:775:45
[INFO] [stderr]     |
[INFO] [stderr] 775 |                                             frequency: frequency,
[INFO] [stderr]     |                                             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frequency`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:776:45
[INFO] [stderr]     |
[INFO] [stderr] 776 |                                             delta: delta,
[INFO] [stderr]     |                                             ^^^^^^^^^^^^ help: replace it with: `delta`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/types.rs:26:31
[INFO] [stderr]    |
[INFO] [stderr] 26 | pub const POSSIBLE_BOOL_OFF: &'static str = "off";
[INFO] [stderr]    |                              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/types.rs:27:30
[INFO] [stderr]    |
[INFO] [stderr] 27 | pub const POSSIBLE_BOOL_ON: &'static str = "on";
[INFO] [stderr]    |                             -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/types.rs:28:27
[INFO] [stderr]    |
[INFO] [stderr] 28 | pub const POSSIBLE_BOOL: &'static [&'static str] = &[POSSIBLE_BOOL_OFF, POSSIBLE_BOOL_ON];
[INFO] [stderr]    |                          -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/types.rs:28:37
[INFO] [stderr]    |
[INFO] [stderr] 28 | pub const POSSIBLE_BOOL: &'static [&'static str] = &[POSSIBLE_BOOL_OFF, POSSIBLE_BOOL_ON];
[INFO] [stderr]    |                                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `matches`
[INFO] [stderr]    --> src/main.rs:396:23
[INFO] [stderr]     |
[INFO] [stderr] 396 |         ("info", Some(matches)) => {
[INFO] [stderr]     |                       ^^^^^^^ help: consider using `_matches` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `matches`
[INFO] [stderr]    --> src/main.rs:801:35
[INFO] [stderr]     |
[INFO] [stderr] 801 |                 ("overvolt", Some(matches)) => {
[INFO] [stderr]     |                                   ^^^^^^^ help: consider using `_matches` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `test`
[INFO] [stderr]    --> src/auto.rs:122:25
[INFO] [stderr]     |
[INFO] [stderr] 122 |         if let Some(ref test) = self.options.test {
[INFO] [stderr]     |                         ^^^^ help: consider using `_test` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `voltage`
[INFO] [stderr]    --> src/auto.rs:121:42
[INFO] [stderr]     |
[INFO] [stderr] 121 |     pub fn run_test_operation(&mut self, voltage: Microvolts, frequency: Kilohertz) -> Result<bool, Error> {
[INFO] [stderr]     |                                          ^^^^^^^ help: consider using `_voltage` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `frequency`
[INFO] [stderr]    --> src/auto.rs:121:63
[INFO] [stderr]     |
[INFO] [stderr] 121 |     pub fn run_test_operation(&mut self, voltage: Microvolts, frequency: Kilohertz) -> Result<bool, Error> {
[INFO] [stderr]     |                                                               ^^^^^^^^^ help: consider using `_frequency` instead
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/main.rs:333:9
[INFO] [stderr]     |
[INFO] [stderr] 333 |     let mut exit_code = 0;
[INFO] [stderr]     |         ----^^^^^^^^^
[INFO] [stderr]     |         |
[INFO] [stderr]     |         help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/auto.rs:43:51
[INFO] [stderr]    |
[INFO] [stderr] 43 |             .get(&ClockDomain::Graphics).cloned().ok_or("couldn't read GPU clock".into())
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "couldn't read GPU clock".into())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to want to iterate on a map's values
[INFO] [stderr]   --> src/human.rs:62:22
[INFO] [stderr]    |
[INFO] [stderr] 62 |     for (_, lock) in &set.vfp_locks {
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::for_kv_map)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stderr] help: use the corresponding method
[INFO] [stderr]    |
[INFO] [stderr] 62 |     for lock in set.vfp_locks.values() {
[INFO] [stderr]    |         ^^^^    ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/human.rs:125:29
[INFO] [stderr]     |
[INFO] [stderr] 125 |             .unwrap_or_else(|| String::new());
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::new`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 28
[INFO] [stderr]    --> src/human.rs:202:1
[INFO] [stderr]     |
[INFO] [stderr] 202 | / pub fn print_info(info: &GpuInfo) {
[INFO] [stderr] 203 | |     pline!("GPU", "{} ({})", info.name, info.codename);
[INFO] [stderr] 204 | |     pline!("Vendor", "{}", info.vendor);
[INFO] [stderr] 205 | |     pline!("GPU Shaders", "{} ({}:{} pipes)",
[INFO] [stderr] ...   |
[INFO] [stderr] 264 | |     }
[INFO] [stderr] 265 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]   --> src/main.rs:58:8
[INFO] [stderr]    |
[INFO] [stderr] 58 |       Ok(for point in points {
[INFO] [stderr]    |  ________^
[INFO] [stderr] 59 | |         w.serialize(point)?;
[INFO] [stderr] 60 | |     })
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]    |
[INFO] [stderr] 58 |     Ok(())
[INFO] [stderr]    |        ^^
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 43
[INFO] [stderr]    --> src/main.rs:63:1
[INFO] [stderr]     |
[INFO] [stderr] 63  | / fn main_result() -> Result<i32, Error> {
[INFO] [stderr] 64  | |     if let Err(e) = env_logger::init() {
[INFO] [stderr] 65  | |         let _ = writeln!(io::stderr(), "Failed to initialize env_logger: {}", e);
[INFO] [stderr] 66  | |     }
[INFO] [stderr] ...   |
[INFO] [stderr] 811 | |     Ok(exit_code)
[INFO] [stderr] 812 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]    --> src/main.rs:344:29
[INFO] [stderr]     |
[INFO] [stderr] 344 |         let mut gpus = gpus.into_iter();
[INFO] [stderr]     |                             ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]    --> src/main.rs:367:26
[INFO] [stderr]     |
[INFO] [stderr] 367 |             None => gpus.into_iter().collect(),
[INFO] [stderr]     |                          ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/main.rs:498:71
[INFO] [stderr]     |
[INFO] [stderr] 498 |                                         (*i0, VfPoint::new(p.clone(), d.clone()))
[INFO] [stderr]     |                                                                       ^^^^^^^^^ help: try dereferencing it: `*d`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/main.rs:533:40
[INFO] [stderr]     |
[INFO] [stderr] 533 |                 if let Some(monitor) = monitor.clone() {
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `monitor`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable
[INFO] [stderr]    --> src/main.rs:566:18
[INFO] [stderr]     |
[INFO] [stderr] 566 |                 (ResetSettings::possible_values_typed().iter().cloned().collect::<Vec<_>>(), false)
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::iter_cloned_collect)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/main.rs:635:74
[INFO] [stderr]     |
[INFO] [stderr] 635 |                     let plimit = plimit.map(u32::from_str).map(|v| v.map(|v| Percentage(v))).collect::<Result<Vec<_>, _>>()?;
[INFO] [stderr]     |                                                                          ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Percentage`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/main.rs:640:74
[INFO] [stderr]     |
[INFO] [stderr] 640 |                     let tlimit = tlimit.map(i32::from_str).map(|v| v.map(|v| Celsius(v))).collect::<Result<Vec<_>, _>>()?;
[INFO] [stderr]     |                                                                          ^^^^^^^^^^^^^^ help: remove closure as shown: `Celsius`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:752:43
[INFO] [stderr]     |
[INFO] [stderr] 752 |                             let end = end.unwrap_or(vfp.graphics.iter().map(|(&i, _)| i).max().unwrap());
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vfp.graphics.iter().map(|(&i, _)| i).max().unwrap())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/main.rs:769:54
[INFO] [stderr]     |
[INFO] [stderr] 769 |                                 .map(|(i, v)| (i, v, vfp_delta.graphics.get(&i).unwrap()))
[INFO] [stderr]     |                                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&vfp_delta.graphics[&i]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/main.rs:796:29
[INFO] [stderr]     |
[INFO] [stderr] 796 |                             let _ = res.and_then(|_| io_res.map_err(From::from))?;
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/auto.rs:33:13
[INFO] [stderr]    |
[INFO] [stderr] 33 |             options: options,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `options`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/auto.rs:37:13
[INFO] [stderr]    |
[INFO] [stderr] 37 |             gpu: gpu,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `gpu`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:775:45
[INFO] [stderr]     |
[INFO] [stderr] 775 |                                             frequency: frequency,
[INFO] [stderr]     |                                             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frequency`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:776:45
[INFO] [stderr]     |
[INFO] [stderr] 776 |                                             delta: delta,
[INFO] [stderr]     |                                             ^^^^^^^^^^^^ help: replace it with: `delta`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/types.rs:26:31
[INFO] [stderr]    |
[INFO] [stderr] 26 | pub const POSSIBLE_BOOL_OFF: &'static str = "off";
[INFO] [stderr]    |                              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/types.rs:27:30
[INFO] [stderr]    |
[INFO] [stderr] 27 | pub const POSSIBLE_BOOL_ON: &'static str = "on";
[INFO] [stderr]    |                             -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/types.rs:28:27
[INFO] [stderr]    |
[INFO] [stderr] 28 | pub const POSSIBLE_BOOL: &'static [&'static str] = &[POSSIBLE_BOOL_OFF, POSSIBLE_BOOL_ON];
[INFO] [stderr]    |                          -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/types.rs:28:37
[INFO] [stderr]    |
[INFO] [stderr] 28 | pub const POSSIBLE_BOOL: &'static [&'static str] = &[POSSIBLE_BOOL_OFF, POSSIBLE_BOOL_ON];
[INFO] [stderr]    |                                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `matches`
[INFO] [stderr]    --> src/main.rs:396:23
[INFO] [stderr]     |
[INFO] [stderr] 396 |         ("info", Some(matches)) => {
[INFO] [stderr]     |                       ^^^^^^^ help: consider using `_matches` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `matches`
[INFO] [stderr]    --> src/main.rs:801:35
[INFO] [stderr]     |
[INFO] [stderr] 801 |                 ("overvolt", Some(matches)) => {
[INFO] [stderr]     |                                   ^^^^^^^ help: consider using `_matches` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `test`
[INFO] [stderr]    --> src/auto.rs:122:25
[INFO] [stderr]     |
[INFO] [stderr] 122 |         if let Some(ref test) = self.options.test {
[INFO] [stderr]     |                         ^^^^ help: consider using `_test` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `voltage`
[INFO] [stderr]    --> src/auto.rs:121:42
[INFO] [stderr]     |
[INFO] [stderr] 121 |     pub fn run_test_operation(&mut self, voltage: Microvolts, frequency: Kilohertz) -> Result<bool, Error> {
[INFO] [stderr]     |                                          ^^^^^^^ help: consider using `_voltage` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `frequency`
[INFO] [stderr]    --> src/auto.rs:121:63
[INFO] [stderr]     |
[INFO] [stderr] 121 |     pub fn run_test_operation(&mut self, voltage: Microvolts, frequency: Kilohertz) -> Result<bool, Error> {
[INFO] [stderr]     |                                                               ^^^^^^^^^ help: consider using `_frequency` instead
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/main.rs:333:9
[INFO] [stderr]     |
[INFO] [stderr] 333 |     let mut exit_code = 0;
[INFO] [stderr]     |         ----^^^^^^^^^
[INFO] [stderr]     |         |
[INFO] [stderr]     |         help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/auto.rs:43:51
[INFO] [stderr]    |
[INFO] [stderr] 43 |             .get(&ClockDomain::Graphics).cloned().ok_or("couldn't read GPU clock".into())
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "couldn't read GPU clock".into())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to want to iterate on a map's values
[INFO] [stderr]   --> src/human.rs:62:22
[INFO] [stderr]    |
[INFO] [stderr] 62 |     for (_, lock) in &set.vfp_locks {
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::for_kv_map)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stderr] help: use the corresponding method
[INFO] [stderr]    |
[INFO] [stderr] 62 |     for lock in set.vfp_locks.values() {
[INFO] [stderr]    |         ^^^^    ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/human.rs:125:29
[INFO] [stderr]     |
[INFO] [stderr] 125 |             .unwrap_or_else(|| String::new());
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::new`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 28
[INFO] [stderr]    --> src/human.rs:202:1
[INFO] [stderr]     |
[INFO] [stderr] 202 | / pub fn print_info(info: &GpuInfo) {
[INFO] [stderr] 203 | |     pline!("GPU", "{} ({})", info.name, info.codename);
[INFO] [stderr] 204 | |     pline!("Vendor", "{}", info.vendor);
[INFO] [stderr] 205 | |     pline!("GPU Shaders", "{} ({}:{} pipes)",
[INFO] [stderr] ...   |
[INFO] [stderr] 264 | |     }
[INFO] [stderr] 265 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]   --> src/main.rs:58:8
[INFO] [stderr]    |
[INFO] [stderr] 58 |       Ok(for point in points {
[INFO] [stderr]    |  ________^
[INFO] [stderr] 59 | |         w.serialize(point)?;
[INFO] [stderr] 60 | |     })
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]    |
[INFO] [stderr] 58 |     Ok(())
[INFO] [stderr]    |        ^^
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 43
[INFO] [stderr]    --> src/main.rs:63:1
[INFO] [stderr]     |
[INFO] [stderr] 63  | / fn main_result() -> Result<i32, Error> {
[INFO] [stderr] 64  | |     if let Err(e) = env_logger::init() {
[INFO] [stderr] 65  | |         let _ = writeln!(io::stderr(), "Failed to initialize env_logger: {}", e);
[INFO] [stderr] 66  | |     }
[INFO] [stderr] ...   |
[INFO] [stderr] 811 | |     Ok(exit_code)
[INFO] [stderr] 812 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]    --> src/main.rs:344:29
[INFO] [stderr]     |
[INFO] [stderr] 344 |         let mut gpus = gpus.into_iter();
[INFO] [stderr]     |                             ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]    --> src/main.rs:367:26
[INFO] [stderr]     |
[INFO] [stderr] 367 |             None => gpus.into_iter().collect(),
[INFO] [stderr]     |                          ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/main.rs:498:71
[INFO] [stderr]     |
[INFO] [stderr] 498 |                                         (*i0, VfPoint::new(p.clone(), d.clone()))
[INFO] [stderr]     |                                                                       ^^^^^^^^^ help: try dereferencing it: `*d`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/main.rs:533:40
[INFO] [stderr]     |
[INFO] [stderr] 533 |                 if let Some(monitor) = monitor.clone() {
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `monitor`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable
[INFO] [stderr]    --> src/main.rs:566:18
[INFO] [stderr]     |
[INFO] [stderr] 566 |                 (ResetSettings::possible_values_typed().iter().cloned().collect::<Vec<_>>(), false)
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::iter_cloned_collect)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/main.rs:635:74
[INFO] [stderr]     |
[INFO] [stderr] 635 |                     let plimit = plimit.map(u32::from_str).map(|v| v.map(|v| Percentage(v))).collect::<Result<Vec<_>, _>>()?;
[INFO] [stderr]     |                                                                          ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Percentage`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/main.rs:640:74
[INFO] [stderr]     |
[INFO] [stderr] 640 |                     let tlimit = tlimit.map(i32::from_str).map(|v| v.map(|v| Celsius(v))).collect::<Result<Vec<_>, _>>()?;
[INFO] [stderr]     |                                                                          ^^^^^^^^^^^^^^ help: remove closure as shown: `Celsius`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:752:43
[INFO] [stderr]     |
[INFO] [stderr] 752 |                             let end = end.unwrap_or(vfp.graphics.iter().map(|(&i, _)| i).max().unwrap());
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vfp.graphics.iter().map(|(&i, _)| i).max().unwrap())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/main.rs:769:54
[INFO] [stderr]     |
[INFO] [stderr] 769 |                                 .map(|(i, v)| (i, v, vfp_delta.graphics.get(&i).unwrap()))
[INFO] [stderr]     |                                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&vfp_delta.graphics[&i]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/main.rs:796:29
[INFO] [stderr]     |
[INFO] [stderr] 796 |                             let _ = res.and_then(|_| io_res.map_err(From::from))?;
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 38.41s
[INFO] running `"docker" "inspect" "6b740b0b918ca988f38b560a462ef91c24a4ecb1ef5f980ab67b4b6fecc0ea6b"`
[INFO] running `"docker" "rm" "-f" "6b740b0b918ca988f38b560a462ef91c24a4ecb1ef5f980ab67b4b6fecc0ea6b"`
[INFO] [stdout] 6b740b0b918ca988f38b560a462ef91c24a4ecb1ef5f980ab67b4b6fecc0ea6b