[INFO] crate nv-card 0.1.2 is already in cache
[INFO] extracting crate nv-card 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/nv-card/0.1.2
[INFO] extracting crate nv-card 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nv-card/0.1.2
[INFO] validating manifest of nv-card-0.1.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of nv-card-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing nv-card-0.1.2
[INFO] finished frobbing nv-card-0.1.2
[INFO] frobbed toml for nv-card-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/nv-card/0.1.2/Cargo.toml
[INFO] started frobbing nv-card-0.1.2
[INFO] finished frobbing nv-card-0.1.2
[INFO] frobbed toml for nv-card-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nv-card/0.1.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting nv-card-0.1.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/nv-card/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 18e18a6dec9b6f5786845cc71444790fe4c11ca2899285c6cff2c99cdd2990fe
[INFO] running `"docker" "start" "-a" "18e18a6dec9b6f5786845cc71444790fe4c11ca2899285c6cff2c99cdd2990fe"`
[INFO] [stderr]     Checking nv-card v0.1.2 (/opt/crater/workdir)
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/collection/mod.rs:4:1
[INFO] [stderr]   |
[INFO] [stderr] 4 | mod collection;
[INFO] [stderr]   | ^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::module_inception)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/collection/vector_collection.rs:14:39
[INFO] [stderr]    |
[INFO] [stderr] 14 |     fn push(&mut self, item: Self::Item) -> ()
[INFO] [stderr]    |                                          ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/collection/vector_collection.rs:24:58
[INFO] [stderr]    |
[INFO] [stderr] 24 |     fn insert_at(&mut self, index: usize, item: Self::Item) -> ()
[INFO] [stderr]    |                                                             ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/deck/duplicates_deck.rs:35:39
[INFO] [stderr]    |
[INFO] [stderr] 35 |     fn push(&mut self, item: Self::Item) -> ()
[INFO] [stderr]    |                                          ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/deck/duplicates_deck.rs:45:58
[INFO] [stderr]    |
[INFO] [stderr] 45 |     fn insert_at(&mut self, index: usize, item: Self::Item) -> ()
[INFO] [stderr]    |                                                             ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/deck/non_duplicate_deck.rs:45:39
[INFO] [stderr]    |
[INFO] [stderr] 45 |     fn push(&mut self, item: Self::Item) -> ()
[INFO] [stderr]    |                                          ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/deck/non_duplicate_deck.rs:56:58
[INFO] [stderr]    |
[INFO] [stderr] 56 |     fn insert_at(&mut self, index: usize, item: Self::Item) -> ()
[INFO] [stderr]    |                                                             ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/deck/mod.rs:8:1
[INFO] [stderr]   |
[INFO] [stderr] 8 | mod deck;
[INFO] [stderr]   | ^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/deck/deck.rs:30:24
[INFO] [stderr]    |
[INFO] [stderr] 30 |     fn shuffle(&mut self) -> ()
[INFO] [stderr]    |                           ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/deck/deck.rs:35:45
[INFO] [stderr]    |
[INFO] [stderr] 35 |     fn add_card_to_bottom(&mut self, card : I) -> ()
[INFO] [stderr]    |                                                ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/deck/deck.rs:40:51
[INFO] [stderr]    |
[INFO] [stderr] 40 |     fn add_card_to_top(&mut self, card : Self::Card) -> ()
[INFO] [stderr]    |                                                      ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/collection/vector_collection.rs:31:3
[INFO] [stderr]    |
[INFO] [stderr] 31 |           match index >= self.size()
[INFO] [stderr]    |  _________^
[INFO] [stderr] 32 | |         {
[INFO] [stderr] 33 | |             true => {None},
[INFO] [stderr] 34 | |             false => {Some(self.remove(index))}
[INFO] [stderr] 35 | |         }
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if index >= self.size() {None} else {Some(self.remove(index))}`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `deck::duplicates_deck::DuplicatesAllowedDeck<T>`
[INFO] [stderr]   --> src/deck/duplicates_deck.rs:13:2
[INFO] [stderr]    |
[INFO] [stderr] 13 |       pub fn new() -> DuplicatesAllowedDeck<T>
[INFO] [stderr]    |  _____^
[INFO] [stderr] 14 | |     {
[INFO] [stderr] 15 | |         DuplicatesAllowedDeck{_cards:Vec::new()}
[INFO] [stderr] 16 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 7  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `deck::non_duplicate_deck::NoDuplicatesDeck<T>`
[INFO] [stderr]   --> src/deck/non_duplicate_deck.rs:16:2
[INFO] [stderr]    |
[INFO] [stderr] 16 |       pub fn new() -> NoDuplicatesDeck<T>
[INFO] [stderr]    |  _____^
[INFO] [stderr] 17 | |     {
[INFO] [stderr] 18 | |         NoDuplicatesDeck{_cards:Vec::new()}
[INFO] [stderr] 19 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 9  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/collection/mod.rs:4:1
[INFO] [stderr]   |
[INFO] [stderr] 4 | mod collection;
[INFO] [stderr]   | ^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::module_inception)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/collection/vector_collection.rs:14:39
[INFO] [stderr]    |
[INFO] [stderr] 14 |     fn push(&mut self, item: Self::Item) -> ()
[INFO] [stderr]    |                                          ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/collection/vector_collection.rs:24:58
[INFO] [stderr]    |
[INFO] [stderr] 24 |     fn insert_at(&mut self, index: usize, item: Self::Item) -> ()
[INFO] [stderr]    |                                                             ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/collection/vector_collection.rs:54:17
[INFO] [stderr]    |
[INFO] [stderr] 54 |     fn size_test() -> ()
[INFO] [stderr]    |                    ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/collection/vector_collection.rs:61:21
[INFO] [stderr]    |
[INFO] [stderr] 61 |     fn is_empty_test() -> ()
[INFO] [stderr]    |                        ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/collection/vector_collection.rs:70:17
[INFO] [stderr]    |
[INFO] [stderr] 70 |     fn push_test() -> ()
[INFO] [stderr]    |                    ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/collection/vector_collection.rs:78:27
[INFO] [stderr]    |
[INFO] [stderr] 78 |     fn pop_with_items_test() -> ()
[INFO] [stderr]    |                              ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/collection/vector_collection.rs:85:22
[INFO] [stderr]    |
[INFO] [stderr] 85 |     fn empty_pop_test() -> ()
[INFO] [stderr]    |                         ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/collection/vector_collection.rs:92:22
[INFO] [stderr]    |
[INFO] [stderr] 92 |     fn insert_at_test() -> ()
[INFO] [stderr]    |                         ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/collection/vector_collection.rs:100:34
[INFO] [stderr]     |
[INFO] [stderr] 100 |     fn remove_at_valid_index_test() -> ()
[INFO] [stderr]     |                                     ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/collection/vector_collection.rs:107:36
[INFO] [stderr]     |
[INFO] [stderr] 107 |     fn remove_at_invalid_index_test() -> ()
[INFO] [stderr]     |                                       ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/collection/vector_collection.rs:115:18
[INFO] [stderr]     |
[INFO] [stderr] 115 |     fn slice_test() -> ()
[INFO] [stderr]     |                     ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/card.rs:73:24
[INFO] [stderr]    |
[INFO] [stderr] 73 |     fn description_test() -> ()
[INFO] [stderr]    |                           ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/card.rs:79:29
[INFO] [stderr]    |
[INFO] [stderr] 79 |     fn jack_description_test() -> ()
[INFO] [stderr]    |                                ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/card.rs:85:30
[INFO] [stderr]    |
[INFO] [stderr] 85 |     fn queen_description_test() -> ()
[INFO] [stderr]    |                                 ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/card.rs:91:29
[INFO] [stderr]    |
[INFO] [stderr] 91 |     fn king_description_test() -> ()
[INFO] [stderr]    |                                ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/card.rs:97:28
[INFO] [stderr]    |
[INFO] [stderr] 97 |     fn ace_description_test() -> ()
[INFO] [stderr]    |                               ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/card.rs:103:30
[INFO] [stderr]     |
[INFO] [stderr] 103 |     fn joker_description_test() -> ()
[INFO] [stderr]     |                                 ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/card.rs:109:18
[INFO] [stderr]     |
[INFO] [stderr] 109 |     fn value_test() -> ()
[INFO] [stderr]     |                     ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/card.rs:115:17
[INFO] [stderr]     |
[INFO] [stderr] 115 |     fn suit_test() -> ()
[INFO] [stderr]     |                    ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/deck/duplicates_deck.rs:35:39
[INFO] [stderr]    |
[INFO] [stderr] 35 |     fn push(&mut self, item: Self::Item) -> ()
[INFO] [stderr]    |                                          ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/deck/duplicates_deck.rs:45:58
[INFO] [stderr]    |
[INFO] [stderr] 45 |     fn insert_at(&mut self, index: usize, item: Self::Item) -> ()
[INFO] [stderr]    |                                                             ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/deck/non_duplicate_deck.rs:45:39
[INFO] [stderr]    |
[INFO] [stderr] 45 |     fn push(&mut self, item: Self::Item) -> ()
[INFO] [stderr]    |                                          ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/deck/non_duplicate_deck.rs:56:58
[INFO] [stderr]    |
[INFO] [stderr] 56 |     fn insert_at(&mut self, index: usize, item: Self::Item) -> ()
[INFO] [stderr]    |                                                             ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/deck/non_duplicate_deck.rs:86:29
[INFO] [stderr]    |
[INFO] [stderr] 86 |     fn cannot_add_duplicates() -> ()
[INFO] [stderr]    |                                ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/deck/mod.rs:8:1
[INFO] [stderr]   |
[INFO] [stderr] 8 | mod deck;
[INFO] [stderr]   | ^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/deck/deck.rs:30:24
[INFO] [stderr]    |
[INFO] [stderr] 30 |     fn shuffle(&mut self) -> ()
[INFO] [stderr]    |                           ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/deck/deck.rs:35:45
[INFO] [stderr]    |
[INFO] [stderr] 35 |     fn add_card_to_bottom(&mut self, card : I) -> ()
[INFO] [stderr]    |                                                ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/deck/deck.rs:40:51
[INFO] [stderr]    |
[INFO] [stderr] 40 |     fn add_card_to_top(&mut self, card : Self::Card) -> ()
[INFO] [stderr]    |                                                      ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/collection/vector_collection.rs:31:3
[INFO] [stderr]    |
[INFO] [stderr] 31 |           match index >= self.size()
[INFO] [stderr]    |  _________^
[INFO] [stderr] 32 | |         {
[INFO] [stderr] 33 | |             true => {None},
[INFO] [stderr] 34 | |             false => {Some(self.remove(index))}
[INFO] [stderr] 35 | |         }
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if index >= self.size() {None} else {Some(self.remove(index))}`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/collection/vector_collection.rs:73:3
[INFO] [stderr]    |
[INFO] [stderr] 73 |         let _ = v.push(1);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `deck::duplicates_deck::DuplicatesAllowedDeck<T>`
[INFO] [stderr]   --> src/deck/duplicates_deck.rs:13:2
[INFO] [stderr]    |
[INFO] [stderr] 13 |       pub fn new() -> DuplicatesAllowedDeck<T>
[INFO] [stderr]    |  _____^
[INFO] [stderr] 14 | |     {
[INFO] [stderr] 15 | |         DuplicatesAllowedDeck{_cards:Vec::new()}
[INFO] [stderr] 16 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 7  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `deck::non_duplicate_deck::NoDuplicatesDeck<T>`
[INFO] [stderr]   --> src/deck/non_duplicate_deck.rs:16:2
[INFO] [stderr]    |
[INFO] [stderr] 16 |       pub fn new() -> NoDuplicatesDeck<T>
[INFO] [stderr]    |  _____^
[INFO] [stderr] 17 | |     {
[INFO] [stderr] 18 | |         NoDuplicatesDeck{_cards:Vec::new()}
[INFO] [stderr] 19 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 9  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.46s
[INFO] running `"docker" "inspect" "18e18a6dec9b6f5786845cc71444790fe4c11ca2899285c6cff2c99cdd2990fe"`
[INFO] running `"docker" "rm" "-f" "18e18a6dec9b6f5786845cc71444790fe4c11ca2899285c6cff2c99cdd2990fe"`
[INFO] [stdout] 18e18a6dec9b6f5786845cc71444790fe4c11ca2899285c6cff2c99cdd2990fe