[INFO] crate numpress 1.1.0 is already in cache [INFO] extracting crate numpress 1.1.0 into work/ex/clippy-test-run/sources/stable/reg/numpress/1.1.0 [INFO] extracting crate numpress 1.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/numpress/1.1.0 [INFO] validating manifest of numpress-1.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of numpress-1.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing numpress-1.1.0 [INFO] finished frobbing numpress-1.1.0 [INFO] frobbed toml for numpress-1.1.0 written to work/ex/clippy-test-run/sources/stable/reg/numpress/1.1.0/Cargo.toml [INFO] started frobbing numpress-1.1.0 [INFO] finished frobbing numpress-1.1.0 [INFO] frobbed toml for numpress-1.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/numpress/1.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting numpress-1.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/numpress/1.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 218422c9b4abc1f4008f999271a96f44f1cba2e6b797e148c1b4e504a27e28f2 [INFO] running `"docker" "start" "-a" "218422c9b4abc1f4008f999271a96f44f1cba2e6b797e148c1b4e504a27e28f2"` [INFO] [stderr] Checking numpress v1.1.0 (/opt/crater/workdir) [INFO] [stderr] Checking approx v0.3.1 [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:226:23 [INFO] [stderr] | [INFO] [stderr] 226 | const MASK: u32 = 0xf0000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xf000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:307:16 [INFO] [stderr] | [INFO] [stderr] 307 | mask = 0xf0000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xf000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:511:9 [INFO] [stderr] | [INFO] [stderr] 511 | / if di == (data_size - 1) && half == 1 { [INFO] [stderr] 512 | | if (*data.add(di) & 0xf) == 0x0 { [INFO] [stderr] 513 | | break; [INFO] [stderr] 514 | | } [INFO] [stderr] 515 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 511 | if di == (data_size - 1) && half == 1 && (*data.add(di) & 0xf) == 0x0 { [INFO] [stderr] 512 | break; [INFO] [stderr] 513 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:549:20 [INFO] [stderr] | [INFO] [stderr] 549 | 1 => floor(2147483647.0 / *data), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `2_147_483_647.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:567:19 [INFO] [stderr] | [INFO] [stderr] 567 | floor(2147483647.0 / max_double) [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `2_147_483_647.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:310:13 [INFO] [stderr] | [INFO] [stderr] 310 | *res = *res | m; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `*res |= m` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:331:20 [INFO] [stderr] | [INFO] [stderr] 331 | let hb32 = hb as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(hb)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:332:9 [INFO] [stderr] | [INFO] [stderr] 332 | *res = *res | (hb32 << ((i-n)*4)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*res |= (hb32 << ((i-n)*4))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:481:16 [INFO] [stderr] | [INFO] [stderr] 481 | init = *data.add(8+i) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*data.add(8+i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:483:9 [INFO] [stderr] | [INFO] [stderr] 483 | ints[1] = ints[1] | xi; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ints[1] |= xi` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:497:16 [INFO] [stderr] | [INFO] [stderr] 497 | init = *data.add(12+i) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*data.add(12+i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:499:9 [INFO] [stderr] | [INFO] [stderr] 499 | ints[2] = ints[2] | xi; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ints[2] |= xi` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/lib.rs:512:16 [INFO] [stderr] | [INFO] [stderr] 512 | if (*data.add(di) & 0xf) == 0x0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(*data.add(di)).trailing_zeros() >= 4` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::verbose_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:523:24 [INFO] [stderr] | [INFO] [stderr] 523 | y = extrapol + diff as i64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(diff)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:226:23 [INFO] [stderr] | [INFO] [stderr] 226 | const MASK: u32 = 0xf0000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xf000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:307:16 [INFO] [stderr] | [INFO] [stderr] 307 | mask = 0xf0000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xf000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:511:9 [INFO] [stderr] | [INFO] [stderr] 511 | / if di == (data_size - 1) && half == 1 { [INFO] [stderr] 512 | | if (*data.add(di) & 0xf) == 0x0 { [INFO] [stderr] 513 | | break; [INFO] [stderr] 514 | | } [INFO] [stderr] 515 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 511 | if di == (data_size - 1) && half == 1 && (*data.add(di) & 0xf) == 0x0 { [INFO] [stderr] 512 | break; [INFO] [stderr] 513 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:549:20 [INFO] [stderr] | [INFO] [stderr] 549 | 1 => floor(2147483647.0 / *data), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `2_147_483_647.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:567:19 [INFO] [stderr] | [INFO] [stderr] 567 | floor(2147483647.0 / max_double) [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `2_147_483_647.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:712:50 [INFO] [stderr] | [INFO] [stderr] 712 | let result = numpress_compress(&decoded, 21262214.0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `21_262_214.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:716:38 [INFO] [stderr] | [INFO] [stderr] 716 | let decoded: Vec = vec![472.36640759869624, 8161.255047730418, 31419.174861096908, 31340.37083086082, 11031.961448006856, 35019.3535619803, 22837.824611949254, 2076.226408785704, 23277.55357717535, 37604.579217858874, 34185.89109314591, 5077.6548386088325]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `472.366_407_598_696_24` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:716:58 [INFO] [stderr] | [INFO] [stderr] 716 | let decoded: Vec = vec![472.36640759869624, 8161.255047730418, 31419.174861096908, 31340.37083086082, 11031.961448006856, 35019.3535619803, 22837.824611949254, 2076.226408785704, 23277.55357717535, 37604.579217858874, 34185.89109314591, 5077.6548386088325]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `8_161.255_047_730_418` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:716:77 [INFO] [stderr] | [INFO] [stderr] 716 | let decoded: Vec = vec![472.36640759869624, 8161.255047730418, 31419.174861096908, 31340.37083086082, 11031.961448006856, 35019.3535619803, 22837.824611949254, 2076.226408785704, 23277.55357717535, 37604.579217858874, 34185.89109314591, 5077.6548386088325]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `31_419.174_861_096_908` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:716:97 [INFO] [stderr] | [INFO] [stderr] 716 | let decoded: Vec = vec![472.36640759869624, 8161.255047730418, 31419.174861096908, 31340.37083086082, 11031.961448006856, 35019.3535619803, 22837.824611949254, 2076.226408785704, 23277.55357717535, 37604.579217858874, 34185.89109314591, 5077.6548386088325]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `31_340.370_830_860_82` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:716:116 [INFO] [stderr] | [INFO] [stderr] 716 | let decoded: Vec = vec![472.36640759869624, 8161.255047730418, 31419.174861096908, 31340.37083086082, 11031.961448006856, 35019.3535619803, 22837.824611949254, 2076.226408785704, 23277.55357717535, 37604.579217858874, 34185.89109314591, 5077.6548386088325]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `11_031.961_448_006_856` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:716:136 [INFO] [stderr] | [INFO] [stderr] 716 | let decoded: Vec = vec![472.36640759869624, 8161.255047730418, 31419.174861096908, 31340.37083086082, 11031.961448006856, 35019.3535619803, 22837.824611949254, 2076.226408785704, 23277.55357717535, 37604.579217858874, 34185.89109314591, 5077.6548386088325]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `35_019.353_561_980_3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:716:154 [INFO] [stderr] | [INFO] [stderr] 716 | let decoded: Vec = vec![472.36640759869624, 8161.255047730418, 31419.174861096908, 31340.37083086082, 11031.961448006856, 35019.3535619803, 22837.824611949254, 2076.226408785704, 23277.55357717535, 37604.579217858874, 34185.89109314591, 5077.6548386088325]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `22_837.824_611_949_254` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:716:174 [INFO] [stderr] | [INFO] [stderr] 716 | let decoded: Vec = vec![472.36640759869624, 8161.255047730418, 31419.174861096908, 31340.37083086082, 11031.961448006856, 35019.3535619803, 22837.824611949254, 2076.226408785704, 23277.55357717535, 37604.579217858874, 34185.89109314591, 5077.6548386088325]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `2_076.226_408_785_704` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:716:193 [INFO] [stderr] | [INFO] [stderr] 716 | let decoded: Vec = vec![472.36640759869624, 8161.255047730418, 31419.174861096908, 31340.37083086082, 11031.961448006856, 35019.3535619803, 22837.824611949254, 2076.226408785704, 23277.55357717535, 37604.579217858874, 34185.89109314591, 5077.6548386088325]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `23_277.553_577_175_35` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:716:212 [INFO] [stderr] | [INFO] [stderr] 716 | let decoded: Vec = vec![472.36640759869624, 8161.255047730418, 31419.174861096908, 31340.37083086082, 11031.961448006856, 35019.3535619803, 22837.824611949254, 2076.226408785704, 23277.55357717535, 37604.579217858874, 34185.89109314591, 5077.6548386088325]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `37_604.579_217_858_874` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:716:232 [INFO] [stderr] | [INFO] [stderr] 716 | let decoded: Vec = vec![472.36640759869624, 8161.255047730418, 31419.174861096908, 31340.37083086082, 11031.961448006856, 35019.3535619803, 22837.824611949254, 2076.226408785704, 23277.55357717535, 37604.579217858874, 34185.89109314591, 5077.6548386088325]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `34_185.891_093_145_91` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:716:251 [INFO] [stderr] | [INFO] [stderr] 716 | let decoded: Vec = vec![472.36640759869624, 8161.255047730418, 31419.174861096908, 31340.37083086082, 11031.961448006856, 35019.3535619803, 22837.824611949254, 2076.226408785704, 23277.55357717535, 37604.579217858874, 34185.89109314591, 5077.6548386088325]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `5_077.654_838_608_832_5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:741:47 [INFO] [stderr] | [INFO] [stderr] 741 | assert_eq!(optimal_scaling(&decoded), 21262214.0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `21_262_214.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:310:13 [INFO] [stderr] | [INFO] [stderr] 310 | *res = *res | m; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `*res |= m` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:331:20 [INFO] [stderr] | [INFO] [stderr] 331 | let hb32 = hb as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(hb)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:332:9 [INFO] [stderr] | [INFO] [stderr] 332 | *res = *res | (hb32 << ((i-n)*4)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*res |= (hb32 << ((i-n)*4))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:481:16 [INFO] [stderr] | [INFO] [stderr] 481 | init = *data.add(8+i) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*data.add(8+i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:483:9 [INFO] [stderr] | [INFO] [stderr] 483 | ints[1] = ints[1] | xi; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ints[1] |= xi` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:497:16 [INFO] [stderr] | [INFO] [stderr] 497 | init = *data.add(12+i) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*data.add(12+i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:499:9 [INFO] [stderr] | [INFO] [stderr] 499 | ints[2] = ints[2] | xi; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ints[2] |= xi` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/lib.rs:512:16 [INFO] [stderr] | [INFO] [stderr] 512 | if (*data.add(di) & 0xf) == 0x0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(*data.add(di)).trailing_zeros() >= 4` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::verbose_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:523:24 [INFO] [stderr] | [INFO] [stderr] 523 | y = extrapol + diff as i64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(diff)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:674:13 [INFO] [stderr] | [INFO] [stderr] 674 | assert_eq!(low_level::decode_fixed_point(xi.as_ptr()), x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:674:13 [INFO] [stderr] | [INFO] [stderr] 674 | assert_eq!(low_level::decode_fixed_point(xi.as_ptr()), x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:679:13 [INFO] [stderr] | [INFO] [stderr] 679 | assert_eq!(low_level::decode_fixed_point(yi.as_ptr()), y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:679:13 [INFO] [stderr] | [INFO] [stderr] 679 | assert_eq!(low_level::decode_fixed_point(yi.as_ptr()), y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:694:13 [INFO] [stderr] | [INFO] [stderr] 694 | assert_eq!(low_level::decode_fixed_point(xi), x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:694:13 [INFO] [stderr] | [INFO] [stderr] 694 | assert_eq!(low_level::decode_fixed_point(xi), x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:741:9 [INFO] [stderr] | [INFO] [stderr] 741 | assert_eq!(optimal_scaling(&decoded), 21262214.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:741:9 [INFO] [stderr] | [INFO] [stderr] 741 | assert_eq!(optimal_scaling(&decoded), 21262214.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `numpress`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "218422c9b4abc1f4008f999271a96f44f1cba2e6b797e148c1b4e504a27e28f2"` [INFO] running `"docker" "rm" "-f" "218422c9b4abc1f4008f999271a96f44f1cba2e6b797e148c1b4e504a27e28f2"` [INFO] [stdout] 218422c9b4abc1f4008f999271a96f44f1cba2e6b797e148c1b4e504a27e28f2