[INFO] crate num-complex 0.2.1 is already in cache [INFO] extracting crate num-complex 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/num-complex/0.2.1 [INFO] extracting crate num-complex 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/num-complex/0.2.1 [INFO] validating manifest of num-complex-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of num-complex-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing num-complex-0.2.1 [INFO] finished frobbing num-complex-0.2.1 [INFO] frobbed toml for num-complex-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/num-complex/0.2.1/Cargo.toml [INFO] started frobbing num-complex-0.2.1 [INFO] finished frobbing num-complex-0.2.1 [INFO] frobbed toml for num-complex-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/num-complex/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting num-complex-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/num-complex/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 36f5057a3d92621922df583c5a18aae8aa87d3eb3508c2a3fd956f2901d3bbc2 [INFO] running `"docker" "start" "-a" "36f5057a3d92621922df583c5a18aae8aa87d3eb3508c2a3fd956f2901d3bbc2"` [INFO] [stderr] Compiling num-complex v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cast.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | re: re, [INFO] [stderr] | ^^^^^^ help: replace it with: `re` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:97:19 [INFO] [stderr] | [INFO] [stderr] 97 | Complex { re: re, im: im } [INFO] [stderr] | ^^^^^^ help: replace it with: `re` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:97:27 [INFO] [stderr] | [INFO] [stderr] 97 | Complex { re: re, im: im } [INFO] [stderr] | ^^^^^^ help: replace it with: `im` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:443:13 [INFO] [stderr] | [INFO] [stderr] 443 | re: re, [INFO] [stderr] | ^^^^^^ help: replace it with: `re` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:1096:13 [INFO] [stderr] | [INFO] [stderr] 1096 | let c = w[1]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cast.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | re: re, [INFO] [stderr] | ^^^^^^ help: replace it with: `re` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:97:19 [INFO] [stderr] | [INFO] [stderr] 97 | Complex { re: re, im: im } [INFO] [stderr] | ^^^^^^ help: replace it with: `re` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:97:27 [INFO] [stderr] | [INFO] [stderr] 97 | Complex { re: re, im: im } [INFO] [stderr] | ^^^^^^ help: replace it with: `im` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:443:13 [INFO] [stderr] | [INFO] [stderr] 443 | re: re, [INFO] [stderr] | ^^^^^^ help: replace it with: `re` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:1096:13 [INFO] [stderr] | [INFO] [stderr] 1096 | let c = w[1]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1479:51 [INFO] [stderr] | [INFO] [stderr] 1479 | assert!(close_to_tol(r, Complex::new(-0.8684746, -16.695934), 1e-5)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.868_474_6` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1479:63 [INFO] [stderr] | [INFO] [stderr] 1479 | assert!(close_to_tol(r, Complex::new(-0.8684746, -16.695934), 1e-5)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `16.695_934` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1486:50 [INFO] [stderr] | [INFO] [stderr] 1486 | assert!(close_to_tol(r, Complex::new(0.349485, -0.20135958), 1e-5)); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.349_485` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1486:61 [INFO] [stderr] | [INFO] [stderr] 1486 | assert!(close_to_tol(r, Complex::new(0.349485, -0.20135958), 1e-5)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.201_359_58` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:1101:20 [INFO] [stderr] | [INFO] [stderr] 1101 | a = &s[..i + 1].trim_right_matches(is_whitespace); [INFO] [stderr] | ^^^^^^^ help: use: `..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:1115:13 [INFO] [stderr] | [INFO] [stderr] 1115 | b = match a.ends_with(imag) { [INFO] [stderr] | _____________^ [INFO] [stderr] 1116 | | false => "0i", [INFO] [stderr] 1117 | | true => "0", [INFO] [stderr] 1118 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if a.ends_with(imag) { "0" } else { "0i" }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:1101:20 [INFO] [stderr] | [INFO] [stderr] 1101 | a = &s[..i + 1].trim_right_matches(is_whitespace); [INFO] [stderr] | ^^^^^^^ help: use: `..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:1115:13 [INFO] [stderr] | [INFO] [stderr] 1115 | b = match a.ends_with(imag) { [INFO] [stderr] | _____________^ [INFO] [stderr] 1116 | | false => "0i", [INFO] [stderr] 1117 | | true => "0", [INFO] [stderr] 1118 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if a.ends_with(imag) { "0" } else { "0i" }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:1382:17 [INFO] [stderr] | [INFO] [stderr] 1382 | assert_eq!(c.norm_sqr(), ns); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:1382:17 [INFO] [stderr] | [INFO] [stderr] 1382 | assert_eq!(c.norm_sqr(), ns); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:1383:17 [INFO] [stderr] | [INFO] [stderr] 1383 | assert_eq!(c.norm(), ns.sqrt()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:1383:17 [INFO] [stderr] | [INFO] [stderr] 1383 | assert_eq!(c.norm(), ns.sqrt()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `num-complex`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "36f5057a3d92621922df583c5a18aae8aa87d3eb3508c2a3fd956f2901d3bbc2"` [INFO] running `"docker" "rm" "-f" "36f5057a3d92621922df583c5a18aae8aa87d3eb3508c2a3fd956f2901d3bbc2"` [INFO] [stdout] 36f5057a3d92621922df583c5a18aae8aa87d3eb3508c2a3fd956f2901d3bbc2