[INFO] crate nuid 0.1.0 is already in cache [INFO] extracting crate nuid 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/nuid/0.1.0 [INFO] extracting crate nuid 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nuid/0.1.0 [INFO] validating manifest of nuid-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nuid-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nuid-0.1.0 [INFO] finished frobbing nuid-0.1.0 [INFO] frobbed toml for nuid-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/nuid/0.1.0/Cargo.toml [INFO] started frobbing nuid-0.1.0 [INFO] finished frobbing nuid-0.1.0 [INFO] frobbed toml for nuid-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nuid/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nuid-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/nuid/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4576a72a1ffb4204b0667f29abcec3e679cf711c9628d06eb4aa1f139755782e [INFO] running `"docker" "start" "-a" "4576a72a1ffb4204b0667f29abcec3e679cf711c9628d06eb4aa1f139755782e"` [INFO] [stderr] Checking nuid v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:32:22 [INFO] [stderr] | [INFO] [stderr] 32 | const MAX_SEQ: u64 = 839299365868340224; // (BASE ^ remaining bytes 22 - 12) == 62^10 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `839_299_365_868_340_224` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `NUID` [INFO] [stderr] --> src/lib.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / pub fn new() -> NUID { [INFO] [stderr] 60 | | let mut n = NUID { [INFO] [stderr] 61 | | pre: [0; PRE_LEN], [INFO] [stderr] 62 | | seq: thread_rng().gen_range::(0, MAX_SEQ), [INFO] [stderr] ... | [INFO] [stderr] 66 | | n [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 50 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | / pub fn next(&mut self) -> String { [INFO] [stderr] 78 | | self.seq += self.inc; [INFO] [stderr] 79 | | if self.seq >= MAX_SEQ { [INFO] [stderr] 80 | | self.randomize_prefix(); [INFO] [stderr] ... | [INFO] [stderr] 97 | | String::from_utf8(b.to_vec()).unwrap() [INFO] [stderr] 98 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | l = l/BASE; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `l /= BASE` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:32:22 [INFO] [stderr] | [INFO] [stderr] 32 | const MAX_SEQ: u64 = 839299365868340224; // (BASE ^ remaining bytes 22 - 12) == 62^10 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `839_299_365_868_340_224` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `NUID` [INFO] [stderr] --> src/lib.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / pub fn new() -> NUID { [INFO] [stderr] 60 | | let mut n = NUID { [INFO] [stderr] 61 | | pre: [0; PRE_LEN], [INFO] [stderr] 62 | | seq: thread_rng().gen_range::(0, MAX_SEQ), [INFO] [stderr] ... | [INFO] [stderr] 66 | | n [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 50 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | / pub fn next(&mut self) -> String { [INFO] [stderr] 78 | | self.seq += self.inc; [INFO] [stderr] 79 | | if self.seq >= MAX_SEQ { [INFO] [stderr] 80 | | self.randomize_prefix(); [INFO] [stderr] ... | [INFO] [stderr] 97 | | String::from_utf8(b.to_vec()).unwrap() [INFO] [stderr] 98 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | l = l/BASE; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `l /= BASE` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.94s [INFO] running `"docker" "inspect" "4576a72a1ffb4204b0667f29abcec3e679cf711c9628d06eb4aa1f139755782e"` [INFO] running `"docker" "rm" "-f" "4576a72a1ffb4204b0667f29abcec3e679cf711c9628d06eb4aa1f139755782e"` [INFO] [stdout] 4576a72a1ffb4204b0667f29abcec3e679cf711c9628d06eb4aa1f139755782e