[INFO] crate nuform 0.1.2 is already in cache
[INFO] extracting crate nuform 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/nuform/0.1.2
[INFO] extracting crate nuform 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nuform/0.1.2
[INFO] validating manifest of nuform-0.1.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of nuform-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing nuform-0.1.2
[INFO] finished frobbing nuform-0.1.2
[INFO] frobbed toml for nuform-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/nuform/0.1.2/Cargo.toml
[INFO] started frobbing nuform-0.1.2
[INFO] finished frobbing nuform-0.1.2
[INFO] frobbed toml for nuform-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nuform/0.1.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting nuform-0.1.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/nuform/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 6da3bde1f183eea5665f37f7ff9032ce590517bf2282330a7d93066901eab3d6
[INFO] running `"docker" "start" "-a" "6da3bde1f183eea5665f37f7ff9032ce590517bf2282330a7d93066901eab3d6"`
[INFO] [stderr]    Compiling toml v0.3.2
[INFO] [stderr]     Checking semver v0.6.0
[INFO] [stderr]     Checking toml v0.2.1
[INFO] [stderr]     Checking docopt v0.7.0
[INFO] [stderr]    Compiling nuform v0.1.2 (/opt/crater/workdir)
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/config.rs:34:9
[INFO] [stderr]    |
[INFO] [stderr] 34 | /         match self.name.as_str() {
[INFO] [stderr] 35 | |             "" => return Some(io::Error::new(io::ErrorKind::InvalidData, "Error parsing config: detected an environment without a name")),
[INFO] [stderr] 36 | |             _ => {}
[INFO] [stderr] 37 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let "" = self.name.as_str() { return Some(io::Error::new(io::ErrorKind::InvalidData, "Error parsing config: detected an environment without a name")) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/config.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 | /         match self.bucket_name.as_str() {
[INFO] [stderr] 40 | |             "" => return Some(io::Error::new(io::ErrorKind::InvalidData, format!("Error parsing config: Environment '{}' is missing a bucket_name", self.name))),
[INFO] [stderr] 41 | |             _ => {}
[INFO] [stderr] 42 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let "" = self.bucket_name.as_str() { return Some(io::Error::new(io::ErrorKind::InvalidData, format!("Error parsing config: Environment '{}' is missing a bucket_name", self.name))) }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/config.rs:116:51
[INFO] [stderr]     |
[INFO] [stderr] 116 |             raw_config.validate().map(|e| Err(e)).unwrap_or(configuration_for_environment(raw_config, environment_name.as_ref()))
[INFO] [stderr]     |                                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| configuration_for_environment(raw_config, environment_name.as_ref()))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/config.rs:116:39
[INFO] [stderr]     |
[INFO] [stderr] 116 |             raw_config.validate().map(|e| Err(e)).unwrap_or(configuration_for_environment(raw_config, environment_name.as_ref()))
[INFO] [stderr]     |                                       ^^^^^^^^^^ help: remove closure as shown: `Err`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/version.rs:40:61
[INFO] [stderr]    |
[INFO] [stderr] 40 |         _ => Err(io::Error::new(io::ErrorKind::InvalidData, format!("Expected a string in [\"crate\"][\"max_version\"], but got something else. The API might have changed")))
[INFO] [stderr]    |                                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Expected a string in [\"crate\"][\"max_version\"], but got something else. The API might have changed".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/config.rs:34:9
[INFO] [stderr]    |
[INFO] [stderr] 34 | /         match self.name.as_str() {
[INFO] [stderr] 35 | |             "" => return Some(io::Error::new(io::ErrorKind::InvalidData, "Error parsing config: detected an environment without a name")),
[INFO] [stderr] 36 | |             _ => {}
[INFO] [stderr] 37 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let "" = self.name.as_str() { return Some(io::Error::new(io::ErrorKind::InvalidData, "Error parsing config: detected an environment without a name")) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/config.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 | /         match self.bucket_name.as_str() {
[INFO] [stderr] 40 | |             "" => return Some(io::Error::new(io::ErrorKind::InvalidData, format!("Error parsing config: Environment '{}' is missing a bucket_name", self.name))),
[INFO] [stderr] 41 | |             _ => {}
[INFO] [stderr] 42 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let "" = self.bucket_name.as_str() { return Some(io::Error::new(io::ErrorKind::InvalidData, format!("Error parsing config: Environment '{}' is missing a bucket_name", self.name))) }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/config.rs:116:51
[INFO] [stderr]     |
[INFO] [stderr] 116 |             raw_config.validate().map(|e| Err(e)).unwrap_or(configuration_for_environment(raw_config, environment_name.as_ref()))
[INFO] [stderr]     |                                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| configuration_for_environment(raw_config, environment_name.as_ref()))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/config.rs:116:39
[INFO] [stderr]     |
[INFO] [stderr] 116 |             raw_config.validate().map(|e| Err(e)).unwrap_or(configuration_for_environment(raw_config, environment_name.as_ref()))
[INFO] [stderr]     |                                       ^^^^^^^^^^ help: remove closure as shown: `Err`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/version.rs:40:61
[INFO] [stderr]    |
[INFO] [stderr] 40 |         _ => Err(io::Error::new(io::ErrorKind::InvalidData, format!("Expected a string in [\"crate\"][\"max_version\"], but got something else. The API might have changed")))
[INFO] [stderr]    |                                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Expected a string in [\"crate\"][\"max_version\"], but got something else. The API might have changed".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> /opt/crater/target/debug/build/nuform-f58a5b7dc8cce807/out/cargo-version.rs:1:17
[INFO] [stderr]   |
[INFO] [stderr] 1 | const VERSION: &'static str = "0.1.2";
[INFO] [stderr]   |                -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> bin/main.rs:24:15
[INFO] [stderr]    |
[INFO] [stderr] 24 | const USAGE: &'static str = "
[INFO] [stderr]    |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> bin/main.rs:50:31
[INFO] [stderr]    |
[INFO] [stderr] 50 |     env::var("NUFORM_CONFIG").unwrap_or(String::from("nuform.toml"))
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("nuform.toml"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead
[INFO] [stderr]   --> bin/main.rs:66:17
[INFO] [stderr]    |
[INFO] [stderr] 66 |                 writeln!(io::stderr(), "Execution of command '{:?}' failed:\n{}", command, status).unwrap();
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::explicit_write)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write
[INFO] [stderr] 
[INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead
[INFO] [stderr]   --> bin/main.rs:71:13
[INFO] [stderr]    |
[INFO] [stderr] 71 |             writeln!(io::stderr(), "Failed to execute command: '{:?}'\n{}", command, e).unwrap();
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]   --> bin/main.rs:80:5
[INFO] [stderr]    |
[INFO] [stderr] 80 |     is_latest(VERSION).map(|message| println!("{}", message));
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
[INFO] [stderr]    |     |
[INFO] [stderr]    |     help: try this: `if let Some(message) = is_latest(VERSION) { $ crate :: io :: _print ( format_args_nl ! ( $ ( $ arg ) * ) ) ; }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead
[INFO] [stderr]   --> bin/main.rs:94:13
[INFO] [stderr]    |
[INFO] [stderr] 94 |             writeln!(io::stderr(), "Failed to load configuration from '{}': {}", config_path(), e).unwrap();
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> /opt/crater/target/debug/build/nuform-f58a5b7dc8cce807/out/cargo-version.rs:1:17
[INFO] [stderr]   |
[INFO] [stderr] 1 | const VERSION: &'static str = "0.1.2";
[INFO] [stderr]   |                -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> bin/main.rs:24:15
[INFO] [stderr]    |
[INFO] [stderr] 24 | const USAGE: &'static str = "
[INFO] [stderr]    |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> bin/main.rs:50:31
[INFO] [stderr]    |
[INFO] [stderr] 50 |     env::var("NUFORM_CONFIG").unwrap_or(String::from("nuform.toml"))
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("nuform.toml"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead
[INFO] [stderr]   --> bin/main.rs:66:17
[INFO] [stderr]    |
[INFO] [stderr] 66 |                 writeln!(io::stderr(), "Execution of command '{:?}' failed:\n{}", command, status).unwrap();
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::explicit_write)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write
[INFO] [stderr] 
[INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead
[INFO] [stderr]   --> bin/main.rs:71:13
[INFO] [stderr]    |
[INFO] [stderr] 71 |             writeln!(io::stderr(), "Failed to execute command: '{:?}'\n{}", command, e).unwrap();
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]   --> bin/main.rs:80:5
[INFO] [stderr]    |
[INFO] [stderr] 80 |     is_latest(VERSION).map(|message| println!("{}", message));
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
[INFO] [stderr]    |     |
[INFO] [stderr]    |     help: try this: `if let Some(message) = is_latest(VERSION) { $ crate :: io :: _print ( format_args_nl ! ( $ ( $ arg ) * ) ) ; }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead
[INFO] [stderr]   --> bin/main.rs:94:13
[INFO] [stderr]    |
[INFO] [stderr] 94 |             writeln!(io::stderr(), "Failed to load configuration from '{}': {}", config_path(), e).unwrap();
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 18.32s
[INFO] running `"docker" "inspect" "6da3bde1f183eea5665f37f7ff9032ce590517bf2282330a7d93066901eab3d6"`
[INFO] running `"docker" "rm" "-f" "6da3bde1f183eea5665f37f7ff9032ce590517bf2282330a7d93066901eab3d6"`
[INFO] [stdout] 6da3bde1f183eea5665f37f7ff9032ce590517bf2282330a7d93066901eab3d6