[INFO] crate nucleic-acid 0.1.1 is already in cache [INFO] extracting crate nucleic-acid 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/nucleic-acid/0.1.1 [INFO] extracting crate nucleic-acid 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nucleic-acid/0.1.1 [INFO] validating manifest of nucleic-acid-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nucleic-acid-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nucleic-acid-0.1.1 [INFO] finished frobbing nucleic-acid-0.1.1 [INFO] frobbed toml for nucleic-acid-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/nucleic-acid/0.1.1/Cargo.toml [INFO] started frobbing nucleic-acid-0.1.1 [INFO] finished frobbing nucleic-acid-0.1.1 [INFO] frobbed toml for nucleic-acid-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nucleic-acid/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nucleic-acid-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/nucleic-acid/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dc88e2e59843dda7b6bd921f64181a8c7b375ef52c0272864d7c10398fb8d89e [INFO] running `"docker" "start" "-a" "dc88e2e59843dda7b6bd921f64181a8c7b375ef52c0272864d7c10398fb8d89e"` [INFO] [stderr] Checking nucleic-acid v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits_vec.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | bits: bits, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bits` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bwt.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | lf_vec: lf_vec, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `lf_vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits_vec.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | bits: bits, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bits` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bwt.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | lf_vec: lf_vec, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `lf_vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `Value` [INFO] [stderr] --> src/bits_vec.rs:482:5 [INFO] [stderr] | [INFO] [stderr] 482 | / enum TestEnum { [INFO] [stderr] 483 | | Value1, [INFO] [stderr] 484 | | Value2, [INFO] [stderr] 485 | | Value3, [INFO] [stderr] 486 | | Value4, [INFO] [stderr] 487 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u8` to a `bool` [INFO] [stderr] --> src/bits_vec.rs:49:18 [INFO] [stderr] | [INFO] [stderr] 49 | unsafe { mem::transmute(i as u8) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `i as u8 != 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_bool [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `char` [INFO] [stderr] --> src/bits_vec.rs:56:18 [INFO] [stderr] | [INFO] [stderr] 56 | unsafe { mem::transmute(i as u32) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::char::from_u32(i as u32).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_char)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_char [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/bits_vec.rs:121:17 [INFO] [stderr] | [INFO] [stderr] 121 | #[derive(Clone, Hash)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/bits_vec.rs:401:1 [INFO] [stderr] | [INFO] [stderr] 401 | / impl PartialEq for BitsVec { [INFO] [stderr] 402 | | fn eq(&self, other: &Self) -> bool { [INFO] [stderr] 403 | | if self.units != other.units || self.bits != other.bits { [INFO] [stderr] 404 | | return false [INFO] [stderr] ... | [INFO] [stderr] 408 | | } [INFO] [stderr] 409 | | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: defining a method called `into_iter` on this type; consider implementing the `std::iter::IntoIterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/bits_vec.rs:329:5 [INFO] [stderr] | [INFO] [stderr] 329 | / pub fn into_iter(self) -> IntoIter { [INFO] [stderr] 330 | | IntoIter { range: 0..self.units, vec: self } [INFO] [stderr] 331 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/bits_vec.rs:391:9 [INFO] [stderr] | [INFO] [stderr] 391 | self.iter().find(|ref i| i == &element).is_some() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|ref i| i == &element).is_some()` with `any(|ref i| i == &element)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `map`. [INFO] [stderr] --> src/bwt.rs:27:14 [INFO] [stderr] | [INFO] [stderr] 27 | for i in 0..map.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 27 | for in &mut map { [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the variable `idx` is used as a loop counter. Consider using `for (idx, item) in &bwt_data.enumerate()` or similar iterators [INFO] [stderr] --> src/bwt.rs:135:18 [INFO] [stderr] | [INFO] [stderr] 135 | for i in &bwt_data { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/sa.rs:62:14 [INFO] [stderr] | [INFO] [stderr] 62 | for i in 0..(length + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `0..=length` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/sa.rs:145:14 [INFO] [stderr] | [INFO] [stderr] 145 | for i in 0..(max_byte + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `0..=max_byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `nucleic-acid`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: transmute from a `u8` to a `bool` [INFO] [stderr] --> src/bits_vec.rs:49:18 [INFO] [stderr] | [INFO] [stderr] 49 | unsafe { mem::transmute(i as u8) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `i as u8 != 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_bool [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `char` [INFO] [stderr] --> src/bits_vec.rs:56:18 [INFO] [stderr] | [INFO] [stderr] 56 | unsafe { mem::transmute(i as u32) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::char::from_u32(i as u32).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_char)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_char [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/bits_vec.rs:121:17 [INFO] [stderr] | [INFO] [stderr] 121 | #[derive(Clone, Hash)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/bits_vec.rs:401:1 [INFO] [stderr] | [INFO] [stderr] 401 | / impl PartialEq for BitsVec { [INFO] [stderr] 402 | | fn eq(&self, other: &Self) -> bool { [INFO] [stderr] 403 | | if self.units != other.units || self.bits != other.bits { [INFO] [stderr] 404 | | return false [INFO] [stderr] ... | [INFO] [stderr] 408 | | } [INFO] [stderr] 409 | | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: defining a method called `into_iter` on this type; consider implementing the `std::iter::IntoIterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/bits_vec.rs:329:5 [INFO] [stderr] | [INFO] [stderr] 329 | / pub fn into_iter(self) -> IntoIter { [INFO] [stderr] 330 | | IntoIter { range: 0..self.units, vec: self } [INFO] [stderr] 331 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/bits_vec.rs:391:9 [INFO] [stderr] | [INFO] [stderr] 391 | self.iter().find(|ref i| i == &element).is_some() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|ref i| i == &element).is_some()` with `any(|ref i| i == &element)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `map`. [INFO] [stderr] --> src/bwt.rs:27:14 [INFO] [stderr] | [INFO] [stderr] 27 | for i in 0..map.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 27 | for in &mut map { [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the variable `idx` is used as a loop counter. Consider using `for (idx, item) in &bwt_data.enumerate()` or similar iterators [INFO] [stderr] --> src/bwt.rs:135:18 [INFO] [stderr] | [INFO] [stderr] 135 | for i in &bwt_data { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/sa.rs:62:14 [INFO] [stderr] | [INFO] [stderr] 62 | for i in 0..(length + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `0..=length` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/sa.rs:145:14 [INFO] [stderr] | [INFO] [stderr] 145 | for i in 0..(max_byte + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `0..=max_byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `nucleic-acid`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "dc88e2e59843dda7b6bd921f64181a8c7b375ef52c0272864d7c10398fb8d89e"` [INFO] running `"docker" "rm" "-f" "dc88e2e59843dda7b6bd921f64181a8c7b375ef52c0272864d7c10398fb8d89e"` [INFO] [stdout] dc88e2e59843dda7b6bd921f64181a8c7b375ef52c0272864d7c10398fb8d89e