[INFO] crate ntrumls-plus 0.0.6 is already in cache [INFO] extracting crate ntrumls-plus 0.0.6 into work/ex/clippy-test-run/sources/stable/reg/ntrumls-plus/0.0.6 [INFO] extracting crate ntrumls-plus 0.0.6 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ntrumls-plus/0.0.6 [INFO] validating manifest of ntrumls-plus-0.0.6 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ntrumls-plus-0.0.6 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ntrumls-plus-0.0.6 [INFO] finished frobbing ntrumls-plus-0.0.6 [INFO] frobbed toml for ntrumls-plus-0.0.6 written to work/ex/clippy-test-run/sources/stable/reg/ntrumls-plus/0.0.6/Cargo.toml [INFO] started frobbing ntrumls-plus-0.0.6 [INFO] finished frobbing ntrumls-plus-0.0.6 [INFO] frobbed toml for ntrumls-plus-0.0.6 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ntrumls-plus/0.0.6/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ntrumls-plus-0.0.6 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ntrumls-plus/0.0.6:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8c416eed2303709d7472068743722be343d82bd1894754e2b03f017e3cba6336 [INFO] running `"docker" "start" "-a" "8c416eed2303709d7472068743722be343d82bd1894754e2b03f017e3cba6336"` [INFO] [stderr] Compiling ntrumls-plus v0.0.6 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'gcc::Build': crate has been renamed to `cc`, the `gcc` name is not maintained [INFO] [stderr] --> build.rs:17:24 [INFO] [stderr] | [INFO] [stderr] 17 | let mut base_config = gcc::Build::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'gcc::Build::new': crate has been renamed to `cc`, the `gcc` name is not maintained [INFO] [stderr] --> build.rs:17:24 [INFO] [stderr] | [INFO] [stderr] 17 | let mut base_config = gcc::Build::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: depend/NTRUMLS/src/crypto_hash_sha512.c: In function 'crypto_hash_sha512': [INFO] [stderr] warning: depend/NTRUMLS/src/crypto_hash_sha512.c:279:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] [INFO] [stderr] warning: for (i = 0;i < inlen;++i) padded[i] = in[i]; [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/NTRUMLS/src/crypto_stream.c: In function 'crypto_stream': [INFO] [stderr] warning: depend/NTRUMLS/src/crypto_stream.c:168:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] [INFO] [stderr] warning: for (i = 0;i < clen;++i) c[i] = block[i]; [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/NTRUMLS/src/convert.c: In function 'bits_2_int64_trits': [INFO] [stderr] warning: depend/NTRUMLS/src/convert.c:145:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] [INFO] [stderr] warning: if((N+4)/5 != in_len) [INFO] [stderr] warning: ^~ [INFO] [stderr] warning: depend/NTRUMLS/src/pack.c: In function 'pack_signature': [INFO] [stderr] warning: depend/NTRUMLS/src/pack.c:217:15: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] [INFO] [stderr] warning: if(blob_len != SIGNATURE_BYTES(P)) [INFO] [stderr] warning: ^~ [INFO] [stderr] warning: depend/NTRUMLS/src/pack.c: In function 'unpack_signature': [INFO] [stderr] warning: depend/NTRUMLS/src/pack.c:238:15: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] [INFO] [stderr] warning: if(blob_len != SIGNATURE_BYTES(P)) [INFO] [stderr] warning: ^~ [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:219:13 [INFO] [stderr] | [INFO] [stderr] 219 | return Some((PrivateKey(privkey_blob), PublicKey(pubkey_blob))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((PrivateKey(privkey_blob), PublicKey(pubkey_blob)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:268:13 [INFO] [stderr] | [INFO] [stderr] 268 | return Some((PrivateKey(privkey_blob), PublicKey(pubkey_blob))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((PrivateKey(privkey_blob), PublicKey(pubkey_blob)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:284:13 [INFO] [stderr] | [INFO] [stderr] 284 | return Some(Signature(sig)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Signature(sig))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:219:13 [INFO] [stderr] | [INFO] [stderr] 219 | return Some((PrivateKey(privkey_blob), PublicKey(pubkey_blob))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((PrivateKey(privkey_blob), PublicKey(pubkey_blob)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:268:13 [INFO] [stderr] | [INFO] [stderr] 268 | return Some((PrivateKey(privkey_blob), PublicKey(pubkey_blob))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((PrivateKey(privkey_blob), PublicKey(pubkey_blob)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:284:13 [INFO] [stderr] | [INFO] [stderr] 284 | return Some(Signature(sig)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Signature(sig))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: field is never used: `bytes` [INFO] [stderr] --> src/lib.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | bytes: Vec [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:188:54 [INFO] [stderr] | [INFO] [stderr] 188 | let packed_mod_q_poly_bytes_len = (p.n * p.q_bits as u16 + 7)/8; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(p.q_bits)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:276:40 [INFO] [stderr] | [INFO] [stderr] 276 | let mut sig_len = (((p.n * (p.q_bits-1) as u16) + 7)/8) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(p.q_bits-1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused variable: `pk_de` [INFO] [stderr] --> src/lib.rs:321:13 [INFO] [stderr] | [INFO] [stderr] 321 | let pk_de = serde_json::from_str::<::PublicKey>(&pk_se).expect("failed to deserialize public key"); [INFO] [stderr] | ^^^^^ help: consider using `_pk_de` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `sk_de` [INFO] [stderr] --> src/lib.rs:323:13 [INFO] [stderr] | [INFO] [stderr] 323 | let sk_de = serde_json::from_str::<::PrivateKey>(&sk_se).expect("failed to deserialize private key"); [INFO] [stderr] | ^^^^^ help: consider using `_sk_de` instead [INFO] [stderr] [INFO] [stderr] warning: field is never used: `bytes` [INFO] [stderr] --> src/lib.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | bytes: Vec [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:188:54 [INFO] [stderr] | [INFO] [stderr] 188 | let packed_mod_q_poly_bytes_len = (p.n * p.q_bits as u16 + 7)/8; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(p.q_bits)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:276:40 [INFO] [stderr] | [INFO] [stderr] 276 | let mut sig_len = (((p.n * (p.q_bits-1) as u16) + 7)/8) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(p.q_bits-1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.48s [INFO] running `"docker" "inspect" "8c416eed2303709d7472068743722be343d82bd1894754e2b03f017e3cba6336"` [INFO] running `"docker" "rm" "-f" "8c416eed2303709d7472068743722be343d82bd1894754e2b03f017e3cba6336"` [INFO] [stdout] 8c416eed2303709d7472068743722be343d82bd1894754e2b03f017e3cba6336