[INFO] crate nt-packet-derive 0.1.4 is already in cache [INFO] extracting crate nt-packet-derive 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/nt-packet-derive/0.1.4 [INFO] extracting crate nt-packet-derive 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nt-packet-derive/0.1.4 [INFO] validating manifest of nt-packet-derive-0.1.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nt-packet-derive-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nt-packet-derive-0.1.4 [INFO] finished frobbing nt-packet-derive-0.1.4 [INFO] frobbed toml for nt-packet-derive-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/nt-packet-derive/0.1.4/Cargo.toml [INFO] started frobbing nt-packet-derive-0.1.4 [INFO] finished frobbing nt-packet-derive-0.1.4 [INFO] frobbed toml for nt-packet-derive-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nt-packet-derive/0.1.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nt-packet-derive-0.1.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/nt-packet-derive/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1c2cf5d8145376a0201a279caa3a26ffd7e94fcbaf791c47da1736574bf4c9e7 [INFO] running `"docker" "start" "-a" "1c2cf5d8145376a0201a279caa3a26ffd7e94fcbaf791c47da1736574bf4c9e7"` [INFO] [stderr] Checking nt-leb128 v0.2.4 [INFO] [stderr] Checking nt-packet v0.1.2 [INFO] [stderr] Checking nt-packet-derive v0.1.4 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/util.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | / match ty { [INFO] [stderr] 5 | | &Type::Path(ref path) => { [INFO] [stderr] 6 | | let segment_name: &PathSegment = path.path.segments.iter().last().unwrap(); [INFO] [stderr] 7 | | Some(segment_name.ident.clone()) [INFO] [stderr] ... | [INFO] [stderr] 10 | | _ => None [INFO] [stderr] 11 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 4 | match *ty { [INFO] [stderr] 5 | Type::Path(ref path) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/util.rs:19:24 [INFO] [stderr] | [INFO] [stderr] 19 | if named_value.ident.to_string() == "packet_id".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*named_value.ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/util.rs:19:57 [INFO] [stderr] | [INFO] [stderr] 19 | if named_value.ident.to_string() == "packet_id".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"packet_id"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/util.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | / match ty { [INFO] [stderr] 5 | | &Type::Path(ref path) => { [INFO] [stderr] 6 | | let segment_name: &PathSegment = path.path.segments.iter().last().unwrap(); [INFO] [stderr] 7 | | Some(segment_name.ident.clone()) [INFO] [stderr] ... | [INFO] [stderr] 10 | | _ => None [INFO] [stderr] 11 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 4 | match *ty { [INFO] [stderr] 5 | Type::Path(ref path) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/util.rs:19:24 [INFO] [stderr] | [INFO] [stderr] 19 | if named_value.ident.to_string() == "packet_id".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*named_value.ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/util.rs:19:57 [INFO] [stderr] | [INFO] [stderr] 19 | if named_value.ident.to_string() == "packet_id".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"packet_id"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.29s [INFO] running `"docker" "inspect" "1c2cf5d8145376a0201a279caa3a26ffd7e94fcbaf791c47da1736574bf4c9e7"` [INFO] running `"docker" "rm" "-f" "1c2cf5d8145376a0201a279caa3a26ffd7e94fcbaf791c47da1736574bf4c9e7"` [INFO] [stdout] 1c2cf5d8145376a0201a279caa3a26ffd7e94fcbaf791c47da1736574bf4c9e7