[INFO] crate nsutils 0.0.5 is already in cache [INFO] extracting crate nsutils 0.0.5 into work/ex/clippy-test-run/sources/stable/reg/nsutils/0.0.5 [INFO] extracting crate nsutils 0.0.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nsutils/0.0.5 [INFO] validating manifest of nsutils-0.0.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nsutils-0.0.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nsutils-0.0.5 [INFO] finished frobbing nsutils-0.0.5 [INFO] frobbed toml for nsutils-0.0.5 written to work/ex/clippy-test-run/sources/stable/reg/nsutils/0.0.5/Cargo.toml [INFO] started frobbing nsutils-0.0.5 [INFO] finished frobbing nsutils-0.0.5 [INFO] frobbed toml for nsutils-0.0.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nsutils/0.0.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nsutils-0.0.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/nsutils/0.0.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3e80deee67e07a06c2304a30f10cd0888f072799fa2f8d867b586331262b6c6d [INFO] running `"docker" "start" "-a" "3e80deee67e07a06c2304a30f10cd0888f072799fa2f8d867b586331262b6c6d"` [INFO] [stderr] Compiling procinfo v0.3.1 [INFO] [stderr] Checking unshare v0.1.15 [INFO] [stderr] Checking nsutils v0.0.5 (/opt/crater/workdir) [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/nsutils.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | let ref name = self.name; [INFO] [stderr] | ----^^^^^^^^------------- help: try: `let name = &self.name;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/nsutils.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | / if result_nslist.contains_key(&nsid) { [INFO] [stderr] 61 | | let mut listns = result_nslist.get_mut(&nsid).unwrap(); [INFO] [stderr] 62 | | *listns = ListNs { [INFO] [stderr] 63 | | nstype: nsctx.nstype, [INFO] [stderr] ... | [INFO] [stderr] 77 | | }); [INFO] [stderr] 78 | | } [INFO] [stderr] | |_____________^ help: consider using: `result_nslist.entry(nsid)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/nsutils.rs:86:11 [INFO] [stderr] | [INFO] [stderr] 86 | match nsname.as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try this: `nsname` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/nsutils.rs:97:32 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn ns_const_to_str<'a>(ns: &Namespace) -> &'a str { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Namespace` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/nsutils.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | / match ns { [INFO] [stderr] 99 | | &Namespace::Ipc => "ipc", [INFO] [stderr] 100 | | &Namespace::Mount => "mnt", [INFO] [stderr] 101 | | &Namespace::Net => "net", [INFO] [stderr] ... | [INFO] [stderr] 104 | | &Namespace::Uts => "uts", [INFO] [stderr] 105 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 98 | match *ns { [INFO] [stderr] 99 | Namespace::Ipc => "ipc", [INFO] [stderr] 100 | Namespace::Mount => "mnt", [INFO] [stderr] 101 | Namespace::Net => "net", [INFO] [stderr] 102 | Namespace::Pid => "pid", [INFO] [stderr] 103 | Namespace::User => "user", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/nsutils.rs:133:19 [INFO] [stderr] | [INFO] [stderr] 133 | let pathbuf = PathBuf::from(entry.path()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `entry.path()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/nsutils.rs:230:25 [INFO] [stderr] | [INFO] [stderr] 230 | let test_nsid = 4000000000u64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `4_000_000_000u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/nsutils.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | let ref name = self.name; [INFO] [stderr] | ----^^^^^^^^------------- help: try: `let name = &self.name;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/nsutils.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | / if result_nslist.contains_key(&nsid) { [INFO] [stderr] 61 | | let mut listns = result_nslist.get_mut(&nsid).unwrap(); [INFO] [stderr] 62 | | *listns = ListNs { [INFO] [stderr] 63 | | nstype: nsctx.nstype, [INFO] [stderr] ... | [INFO] [stderr] 77 | | }); [INFO] [stderr] 78 | | } [INFO] [stderr] | |_____________^ help: consider using: `result_nslist.entry(nsid)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/nsutils.rs:86:11 [INFO] [stderr] | [INFO] [stderr] 86 | match nsname.as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try this: `nsname` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/nsutils.rs:97:32 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn ns_const_to_str<'a>(ns: &Namespace) -> &'a str { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Namespace` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/nsutils.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | / match ns { [INFO] [stderr] 99 | | &Namespace::Ipc => "ipc", [INFO] [stderr] 100 | | &Namespace::Mount => "mnt", [INFO] [stderr] 101 | | &Namespace::Net => "net", [INFO] [stderr] ... | [INFO] [stderr] 104 | | &Namespace::Uts => "uts", [INFO] [stderr] 105 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 98 | match *ns { [INFO] [stderr] 99 | Namespace::Ipc => "ipc", [INFO] [stderr] 100 | Namespace::Mount => "mnt", [INFO] [stderr] 101 | Namespace::Net => "net", [INFO] [stderr] 102 | Namespace::Pid => "pid", [INFO] [stderr] 103 | Namespace::User => "user", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/nsutils.rs:133:19 [INFO] [stderr] | [INFO] [stderr] 133 | let pathbuf = PathBuf::from(entry.path()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `entry.path()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.25s [INFO] running `"docker" "inspect" "3e80deee67e07a06c2304a30f10cd0888f072799fa2f8d867b586331262b6c6d"` [INFO] running `"docker" "rm" "-f" "3e80deee67e07a06c2304a30f10cd0888f072799fa2f8d867b586331262b6c6d"` [INFO] [stdout] 3e80deee67e07a06c2304a30f10cd0888f072799fa2f8d867b586331262b6c6d