[INFO] crate nss 0.7.1 is already in cache [INFO] extracting crate nss 0.7.1 into work/ex/clippy-test-run/sources/stable/reg/nss/0.7.1 [INFO] extracting crate nss 0.7.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nss/0.7.1 [INFO] validating manifest of nss-0.7.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nss-0.7.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nss-0.7.1 [INFO] removed path dependency nss-sys from nss-0.7.1 [INFO] finished frobbing nss-0.7.1 [INFO] frobbed toml for nss-0.7.1 written to work/ex/clippy-test-run/sources/stable/reg/nss/0.7.1/Cargo.toml [INFO] started frobbing nss-0.7.1 [INFO] removed path dependency nss-sys from nss-0.7.1 [INFO] finished frobbing nss-0.7.1 [INFO] frobbed toml for nss-0.7.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nss/0.7.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nss-0.7.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/nss/0.7.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b44b3a75535c8a1da19886b1c76de7609b95fdc5073d25da478230b52b5307db [INFO] running `"docker" "start" "-a" "b44b3a75535c8a1da19886b1c76de7609b95fdc5073d25da478230b52b5307db"` [INFO] [stderr] Compiling nss-sys v0.1.9 [INFO] [stderr] Checking nss v0.7.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nspr/fd.rs:256:13 [INFO] [stderr] | [INFO] [stderr] 256 | file_type: file_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nspr/fd.rs:315:13 [INFO] [stderr] | [INFO] [stderr] 315 | inner: inner [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:186:17 [INFO] [stderr] | [INFO] [stderr] 186 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:187:17 [INFO] [stderr] | [INFO] [stderr] 187 | callbacks: callbacks, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `callbacks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nspr/fd.rs:256:13 [INFO] [stderr] | [INFO] [stderr] 256 | file_type: file_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nspr/fd.rs:315:13 [INFO] [stderr] | [INFO] [stderr] 315 | inner: inner [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:186:17 [INFO] [stderr] | [INFO] [stderr] 186 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:187:17 [INFO] [stderr] | [INFO] [stderr] 187 | callbacks: callbacks, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `callbacks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/nspr/time.rs:43:48 [INFO] [stderr] | [INFO] [stderr] 43 | Duration::new((it / tps) as u64, scale_u32((it % tps), tps, 1_000_000_000)) [INFO] [stderr] | ^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/nspr/net.rs:114:68 [INFO] [stderr] | [INFO] [stderr] 114 | 8080, 0x23456, 0x23456789)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2345_6789` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/nspr/time.rs:43:48 [INFO] [stderr] | [INFO] [stderr] 43 | Duration::new((it / tps) as u64, scale_u32((it % tps), tps, 1_000_000_000)) [INFO] [stderr] | ^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/cert.rs:18:17 [INFO] [stderr] | [INFO] [stderr] 18 | assert!(ptr != ptr::null_mut()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_null)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/cert.rs:22:12 [INFO] [stderr] | [INFO] [stderr] 22 | if ptr == ptr::null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/cert.rs:30:23 [INFO] [stderr] | [INFO] [stderr] 30 | debug_assert!(ptr != ptr::null_mut()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/cert.rs:35:23 [INFO] [stderr] | [INFO] [stderr] 35 | debug_assert!(self.0 != ptr::null_mut()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const nss_sys::cert::CERTCertificateStr`) to a reference type (`&nss_sys::cert::CERTCertificateStr`) [INFO] [stderr] --> src/cert.rs:39:18 [INFO] [stderr] | [INFO] [stderr] 39 | unsafe { mem::transmute(self.as_raw_ptr()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*self.as_raw_ptr()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/cert.rs:58:12 [INFO] [stderr] | [INFO] [stderr] 58 | if ptr != ptr::null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/cert.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | mem::transmute(self) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&*(self as *const cert::BorrowedCertificate<'a> as *const cert::Certificate)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/cert.rs:94:17 [INFO] [stderr] | [INFO] [stderr] 94 | assert!(ptr != ptr::null_mut()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/cert.rs:98:12 [INFO] [stderr] | [INFO] [stderr] 98 | if ptr == ptr::null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/cert.rs:112:12 [INFO] [stderr] | [INFO] [stderr] 112 | if ptr != ptr::null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/nspr/fd.rs:31:12 [INFO] [stderr] | [INFO] [stderr] 31 | if fd != null() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut nss_sys::nspr::PRFilePrivate`) to a reference type (`&Inner`) [INFO] [stderr] --> src/nspr/fd.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | mem::transmute(ptr) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `&*(ptr as *const Inner)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut nss_sys::nspr::PRFilePrivate`) to a reference type (`&mut Inner`) [INFO] [stderr] --> src/nspr/fd.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | mem::transmute(ptr) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(ptr as *mut Inner)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/nspr/fd.rs:54:23 [INFO] [stderr] | [INFO] [stderr] 54 | debug_assert!(self.0 != null()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/nspr/fd.rs:58:17 [INFO] [stderr] | [INFO] [stderr] 58 | assert!(fd != null()); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/nspr/fd.rs:62:12 [INFO] [stderr] | [INFO] [stderr] 62 | if fd == null() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/nspr/fd.rs:69:12 [INFO] [stderr] | [INFO] [stderr] 69 | if fd == null() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/nspr/fd.rs:87:18 [INFO] [stderr] | [INFO] [stderr] 87 | unsafe { mem::transmute(self) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&*(self as *const nspr::fd::BorrowedFile as *const nspr::fd::File)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/nspr/fd.rs:92:18 [INFO] [stderr] | [INFO] [stderr] 92 | unsafe { mem::transmute(self) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(self as *mut nspr::fd::BorrowedFile as *mut nspr::fd::File)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/nspr/fd.rs:98:17 [INFO] [stderr] | [INFO] [stderr] 98 | assert!(fd != null()); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `nspr::net::NetAddrStorage` [INFO] [stderr] --> src/nspr/net.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn new() -> Self { unsafe { mem::uninitialized() } } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | impl Default for nspr::net::NetAddrStorage { [INFO] [stderr] 17 | fn default() -> Self { [INFO] [stderr] 18 | Self::new() [INFO] [stderr] 19 | } [INFO] [stderr] 20 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: casting from `*const nss_sys::nspr::PRNetAddr` to a more-strictly-aligned pointer (`*const nss_sys::nspr::PRNetAddrRaw`) [INFO] [stderr] --> src/nspr/net.rs:24:20 [INFO] [stderr] | [INFO] [stderr] 24 | let family = (*(ptr as *const ffi::PRNetAddrRaw)).family; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const nss_sys::nspr::PRNetAddr` to a more-strictly-aligned pointer (`*const nss_sys::nspr::PRNetAddrInet`) [INFO] [stderr] --> src/nspr/net.rs:26:19 [INFO] [stderr] | [INFO] [stderr] 26 | let ptr = ptr as *const ffi::PRNetAddrInet; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const nss_sys::nspr::PRNetAddr` to a more-strictly-aligned pointer (`*const nss_sys::nspr::PRNetAddrInet6`) [INFO] [stderr] --> src/nspr/net.rs:31:19 [INFO] [stderr] | [INFO] [stderr] 31 | let ptr = ptr as *const ffi::PRNetAddrInet6; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut nss_sys::nspr::PRNetAddr` to a more-strictly-aligned pointer (`*mut nss_sys::nspr::PRNetAddrInet`) [INFO] [stderr] --> src/nspr/net.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | *(ptr as *mut _) = ffi::PRNetAddrInet { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut nss_sys::nspr::PRNetAddr` to a more-strictly-aligned pointer (`*mut nss_sys::nspr::PRNetAddrInet6`) [INFO] [stderr] --> src/nspr/net.rs:60:14 [INFO] [stderr] | [INFO] [stderr] 60 | *(ptr as *mut _) = ffi::PRNetAddrInet6 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/nspr/time.rs:18:6 [INFO] [stderr] | [INFO] [stderr] 18 | ((input as u64) * (out_scale as u64) / (in_scale as u64)) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(input)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/nspr/time.rs:18:23 [INFO] [stderr] | [INFO] [stderr] 18 | ((input as u64) * (out_scale as u64) / (in_scale as u64)) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(out_scale)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/nspr/time.rs:18:44 [INFO] [stderr] | [INFO] [stderr] 18 | ((input as u64) * (out_scale as u64) / (in_scale as u64)) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(in_scale)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/nspr/time.rs:25:38 [INFO] [stderr] | [INFO] [stderr] 25 | let ticks = whole.saturating_mul(tps as u64).saturating_add(frac as u64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(tps)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/nspr/time.rs:25:65 [INFO] [stderr] | [INFO] [stderr] 25 | let ticks = whole.saturating_mul(tps as u64).saturating_add(frac as u64); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(frac)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/nspr/time.rs:26:17 [INFO] [stderr] | [INFO] [stderr] 26 | if ticks <= u32::MAX as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(u32::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/nspr/time.rs:43:19 [INFO] [stderr] | [INFO] [stderr] 43 | Duration::new((it / tps) as u64, scale_u32((it % tps), tps, 1_000_000_000)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(it / tps)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:165:16 [INFO] [stderr] | [INFO] [stderr] 165 | if let Some(_) = model { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 166 | | // This will copy the callbacks; need to unset or fix them. [INFO] [stderr] 167 | | unimplemented!(); [INFO] [stderr] 168 | | } [INFO] [stderr] | |_________- help: try this: `if model.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/lib.rs:199:42 [INFO] [stderr] | [INFO] [stderr] 199 | mem::transmute(this)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `this as *const TLSSocketImpl as *mut libc::c_void` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/cert.rs:18:17 [INFO] [stderr] | [INFO] [stderr] 18 | assert!(ptr != ptr::null_mut()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_null)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut libc::c_void`) to a reference type (`&TLSSocketImpl`) [INFO] [stderr] --> src/lib.rs:321:50 [INFO] [stderr] | [INFO] [stderr] 321 | let this: BorrowedTLSSocket = mem::transmute(arg); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `&*(arg as *const TLSSocketImpl)` [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/cert.rs:22:12 [INFO] [stderr] | [INFO] [stderr] 22 | if ptr == ptr::null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/cert.rs:30:23 [INFO] [stderr] | [INFO] [stderr] 30 | debug_assert!(ptr != ptr::null_mut()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/cert.rs:35:23 [INFO] [stderr] | [INFO] [stderr] 35 | debug_assert!(self.0 != ptr::null_mut()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const nss_sys::cert::CERTCertificateStr`) to a reference type (`&nss_sys::cert::CERTCertificateStr`) [INFO] [stderr] --> src/cert.rs:39:18 [INFO] [stderr] | [INFO] [stderr] 39 | unsafe { mem::transmute(self.as_raw_ptr()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*self.as_raw_ptr()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/cert.rs:58:12 [INFO] [stderr] | [INFO] [stderr] 58 | if ptr != ptr::null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/cert.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | mem::transmute(self) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&*(self as *const cert::BorrowedCertificate<'a> as *const cert::Certificate)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/cert.rs:94:17 [INFO] [stderr] | [INFO] [stderr] 94 | assert!(ptr != ptr::null_mut()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/cert.rs:98:12 [INFO] [stderr] | [INFO] [stderr] 98 | if ptr == ptr::null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/cert.rs:112:12 [INFO] [stderr] | [INFO] [stderr] 112 | if ptr != ptr::null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:402:49 [INFO] [stderr] | [INFO] [stderr] 402 | pub fn to_ffi(self) -> ffi::nspr::PRInt32 { self.0 as ffi::nspr::PRInt32 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:409:31 [INFO] [stderr] | [INFO] [stderr] 409 | pub fn is_default_enabled(&self) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `nss`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/nspr/fd.rs:31:12 [INFO] [stderr] | [INFO] [stderr] 31 | if fd != null() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut nss_sys::nspr::PRFilePrivate`) to a reference type (`&Inner`) [INFO] [stderr] --> src/nspr/fd.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | mem::transmute(ptr) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `&*(ptr as *const Inner)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut nss_sys::nspr::PRFilePrivate`) to a reference type (`&mut Inner`) [INFO] [stderr] --> src/nspr/fd.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | mem::transmute(ptr) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(ptr as *mut Inner)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/nspr/fd.rs:54:23 [INFO] [stderr] | [INFO] [stderr] 54 | debug_assert!(self.0 != null()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/nspr/fd.rs:58:17 [INFO] [stderr] | [INFO] [stderr] 58 | assert!(fd != null()); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/nspr/fd.rs:62:12 [INFO] [stderr] | [INFO] [stderr] 62 | if fd == null() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/nspr/fd.rs:69:12 [INFO] [stderr] | [INFO] [stderr] 69 | if fd == null() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/nspr/fd.rs:87:18 [INFO] [stderr] | [INFO] [stderr] 87 | unsafe { mem::transmute(self) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&*(self as *const nspr::fd::BorrowedFile as *const nspr::fd::File)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/nspr/fd.rs:92:18 [INFO] [stderr] | [INFO] [stderr] 92 | unsafe { mem::transmute(self) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(self as *mut nspr::fd::BorrowedFile as *mut nspr::fd::File)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/nspr/fd.rs:98:17 [INFO] [stderr] | [INFO] [stderr] 98 | assert!(fd != null()); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/nspr/fd.rs:491:36 [INFO] [stderr] | [INFO] [stderr] 491 | assert_eq!(&read_buf[..4], "Test".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Test"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `nspr::net::NetAddrStorage` [INFO] [stderr] --> src/nspr/net.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn new() -> Self { unsafe { mem::uninitialized() } } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | impl Default for nspr::net::NetAddrStorage { [INFO] [stderr] 17 | fn default() -> Self { [INFO] [stderr] 18 | Self::new() [INFO] [stderr] 19 | } [INFO] [stderr] 20 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: casting from `*const nss_sys::nspr::PRNetAddr` to a more-strictly-aligned pointer (`*const nss_sys::nspr::PRNetAddrRaw`) [INFO] [stderr] --> src/nspr/net.rs:24:20 [INFO] [stderr] | [INFO] [stderr] 24 | let family = (*(ptr as *const ffi::PRNetAddrRaw)).family; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const nss_sys::nspr::PRNetAddr` to a more-strictly-aligned pointer (`*const nss_sys::nspr::PRNetAddrInet`) [INFO] [stderr] --> src/nspr/net.rs:26:19 [INFO] [stderr] | [INFO] [stderr] 26 | let ptr = ptr as *const ffi::PRNetAddrInet; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const nss_sys::nspr::PRNetAddr` to a more-strictly-aligned pointer (`*const nss_sys::nspr::PRNetAddrInet6`) [INFO] [stderr] --> src/nspr/net.rs:31:19 [INFO] [stderr] | [INFO] [stderr] 31 | let ptr = ptr as *const ffi::PRNetAddrInet6; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut nss_sys::nspr::PRNetAddr` to a more-strictly-aligned pointer (`*mut nss_sys::nspr::PRNetAddrInet`) [INFO] [stderr] --> src/nspr/net.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | *(ptr as *mut _) = ffi::PRNetAddrInet { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut nss_sys::nspr::PRNetAddr` to a more-strictly-aligned pointer (`*mut nss_sys::nspr::PRNetAddrInet6`) [INFO] [stderr] --> src/nspr/net.rs:60:14 [INFO] [stderr] | [INFO] [stderr] 60 | *(ptr as *mut _) = ffi::PRNetAddrInet6 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/nspr/time.rs:18:6 [INFO] [stderr] | [INFO] [stderr] 18 | ((input as u64) * (out_scale as u64) / (in_scale as u64)) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(input)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/nspr/time.rs:18:23 [INFO] [stderr] | [INFO] [stderr] 18 | ((input as u64) * (out_scale as u64) / (in_scale as u64)) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(out_scale)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/nspr/time.rs:18:44 [INFO] [stderr] | [INFO] [stderr] 18 | ((input as u64) * (out_scale as u64) / (in_scale as u64)) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(in_scale)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/nspr/time.rs:25:38 [INFO] [stderr] | [INFO] [stderr] 25 | let ticks = whole.saturating_mul(tps as u64).saturating_add(frac as u64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(tps)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/nspr/time.rs:25:65 [INFO] [stderr] | [INFO] [stderr] 25 | let ticks = whole.saturating_mul(tps as u64).saturating_add(frac as u64); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(frac)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/nspr/time.rs:26:17 [INFO] [stderr] | [INFO] [stderr] 26 | if ticks <= u32::MAX as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(u32::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/nspr/time.rs:43:19 [INFO] [stderr] | [INFO] [stderr] 43 | Duration::new((it / tps) as u64, scale_u32((it % tps), tps, 1_000_000_000)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(it / tps)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:165:16 [INFO] [stderr] | [INFO] [stderr] 165 | if let Some(_) = model { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 166 | | // This will copy the callbacks; need to unset or fix them. [INFO] [stderr] 167 | | unimplemented!(); [INFO] [stderr] 168 | | } [INFO] [stderr] | |_________- help: try this: `if model.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/lib.rs:199:42 [INFO] [stderr] | [INFO] [stderr] 199 | mem::transmute(this)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `this as *const TLSSocketImpl as *mut libc::c_void` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut libc::c_void`) to a reference type (`&TLSSocketImpl`) [INFO] [stderr] --> src/lib.rs:321:50 [INFO] [stderr] | [INFO] [stderr] 321 | let this: BorrowedTLSSocket = mem::transmute(arg); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `&*(arg as *const TLSSocketImpl)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:402:49 [INFO] [stderr] | [INFO] [stderr] 402 | pub fn to_ffi(self) -> ffi::nspr::PRInt32 { self.0 as ffi::nspr::PRInt32 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:409:31 [INFO] [stderr] | [INFO] [stderr] 409 | pub fn is_default_enabled(&self) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `nss`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "b44b3a75535c8a1da19886b1c76de7609b95fdc5073d25da478230b52b5307db"` [INFO] running `"docker" "rm" "-f" "b44b3a75535c8a1da19886b1c76de7609b95fdc5073d25da478230b52b5307db"` [INFO] [stdout] b44b3a75535c8a1da19886b1c76de7609b95fdc5073d25da478230b52b5307db