[INFO] crate nsqueue 0.1.5 is already in cache [INFO] extracting crate nsqueue 0.1.5 into work/ex/clippy-test-run/sources/stable/reg/nsqueue/0.1.5 [INFO] extracting crate nsqueue 0.1.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nsqueue/0.1.5 [INFO] validating manifest of nsqueue-0.1.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nsqueue-0.1.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nsqueue-0.1.5 [INFO] finished frobbing nsqueue-0.1.5 [INFO] frobbed toml for nsqueue-0.1.5 written to work/ex/clippy-test-run/sources/stable/reg/nsqueue/0.1.5/Cargo.toml [INFO] started frobbing nsqueue-0.1.5 [INFO] finished frobbing nsqueue-0.1.5 [INFO] frobbed toml for nsqueue-0.1.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nsqueue/0.1.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nsqueue-0.1.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/nsqueue/0.1.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] aa06f7338b4930f74acbff5d5eb5e3886b28887437464e3048e9ee7f7923d172 [INFO] running `"docker" "start" "-a" "aa06f7338b4930f74acbff5d5eb5e3886b28887437464e3048e9ee7f7923d172"` [INFO] [stderr] Checking nsqueue v0.1.5 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:93:21 [INFO] [stderr] | [INFO] [stderr] 93 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:93:21 [INFO] [stderr] | [INFO] [stderr] 93 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/codec.rs:22:19 [INFO] [stderr] | [INFO] [stderr] 22 | const HEARTBEAT: &'static str = "_heartbeat_"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/commands.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / pub mod commands { [INFO] [stderr] 2 | | pub const VERSION_2: &'static str = " V2"; [INFO] [stderr] 3 | | [INFO] [stderr] 4 | | pub const PUB: &'static str = "PUB"; [INFO] [stderr] ... | [INFO] [stderr] 14 | | pub const IDENTIFY: &'static str = "IDENTIFY"; [INFO] [stderr] 15 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/commands.rs:2:27 [INFO] [stderr] | [INFO] [stderr] 2 | pub const VERSION_2: &'static str = " V2"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/commands.rs:4:21 [INFO] [stderr] | [INFO] [stderr] 4 | pub const PUB: &'static str = "PUB"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/commands.rs:5:22 [INFO] [stderr] | [INFO] [stderr] 5 | pub const MPUB: &'static str = "MPUB"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/commands.rs:6:22 [INFO] [stderr] | [INFO] [stderr] 6 | pub const DPUB: &'static str = "DPUB"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/commands.rs:8:21 [INFO] [stderr] | [INFO] [stderr] 8 | pub const SUB: &'static str = "SUB"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/commands.rs:10:21 [INFO] [stderr] | [INFO] [stderr] 10 | pub const RDY: &'static str = "RDY"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/commands.rs:11:21 [INFO] [stderr] | [INFO] [stderr] 11 | pub const FIN: &'static str = "FIN"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/commands.rs:13:21 [INFO] [stderr] | [INFO] [stderr] 13 | pub const NOP: &'static str = "NOP"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/commands.rs:14:26 [INFO] [stderr] | [INFO] [stderr] 14 | pub const IDENTIFY: &'static str = "IDENTIFY"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/protocol.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | ch [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/protocol.rs:59:22 [INFO] [stderr] | [INFO] [stderr] 59 | let ch = transport.send(identify) [INFO] [stderr] | ______________________^ [INFO] [stderr] 60 | | .and_then(|transport| transport.into_future().map_err(|(e, _)| e)) [INFO] [stderr] 61 | | .and_then(|(resp, transport)| { [INFO] [stderr] 62 | | Ok(transport) [INFO] [stderr] 63 | | }); [INFO] [stderr] | |__________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/consumer.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | rdy [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/consumer.rs:47:27 [INFO] [stderr] | [INFO] [stderr] 47 | let rdy = service.inner.call(Message::WithoutBody(request)) [INFO] [stderr] | ___________________________^ [INFO] [stderr] 48 | | .map_err(|e| {e.into()}); [INFO] [stderr] | |____________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/protocol.rs:4:23 [INFO] [stderr] | [INFO] [stderr] 4 | use tokio_io::codec::{Framed}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/protocol.rs:37:22 [INFO] [stderr] | [INFO] [stderr] 37 | type Transport = Framed; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/codec.rs:22:19 [INFO] [stderr] | [INFO] [stderr] 22 | const HEARTBEAT: &'static str = "_heartbeat_"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/commands.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / pub mod commands { [INFO] [stderr] 2 | | pub const VERSION_2: &'static str = " V2"; [INFO] [stderr] 3 | | [INFO] [stderr] 4 | | pub const PUB: &'static str = "PUB"; [INFO] [stderr] ... | [INFO] [stderr] 14 | | pub const IDENTIFY: &'static str = "IDENTIFY"; [INFO] [stderr] 15 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/commands.rs:2:27 [INFO] [stderr] | [INFO] [stderr] 2 | pub const VERSION_2: &'static str = " V2"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/commands.rs:4:21 [INFO] [stderr] | [INFO] [stderr] 4 | pub const PUB: &'static str = "PUB"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/commands.rs:5:22 [INFO] [stderr] | [INFO] [stderr] 5 | pub const MPUB: &'static str = "MPUB"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/commands.rs:6:22 [INFO] [stderr] | [INFO] [stderr] 6 | pub const DPUB: &'static str = "DPUB"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/commands.rs:8:21 [INFO] [stderr] | [INFO] [stderr] 8 | pub const SUB: &'static str = "SUB"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/commands.rs:10:21 [INFO] [stderr] | [INFO] [stderr] 10 | pub const RDY: &'static str = "RDY"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/commands.rs:11:21 [INFO] [stderr] | [INFO] [stderr] 11 | pub const FIN: &'static str = "FIN"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/commands.rs:13:21 [INFO] [stderr] | [INFO] [stderr] 13 | pub const NOP: &'static str = "NOP"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/commands.rs:14:26 [INFO] [stderr] | [INFO] [stderr] 14 | pub const IDENTIFY: &'static str = "IDENTIFY"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/protocol.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | ch [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/protocol.rs:59:22 [INFO] [stderr] | [INFO] [stderr] 59 | let ch = transport.send(identify) [INFO] [stderr] | ______________________^ [INFO] [stderr] 60 | | .and_then(|transport| transport.into_future().map_err(|(e, _)| e)) [INFO] [stderr] 61 | | .and_then(|(resp, transport)| { [INFO] [stderr] 62 | | Ok(transport) [INFO] [stderr] 63 | | }); [INFO] [stderr] | |__________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/consumer.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | rdy [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/consumer.rs:47:27 [INFO] [stderr] | [INFO] [stderr] 47 | let rdy = service.inner.call(Message::WithoutBody(request)) [INFO] [stderr] | ___________________________^ [INFO] [stderr] 48 | | .map_err(|e| {e.into()}); [INFO] [stderr] | |____________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/protocol.rs:4:23 [INFO] [stderr] | [INFO] [stderr] 4 | use tokio_io::codec::{Framed}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/protocol.rs:37:22 [INFO] [stderr] | [INFO] [stderr] 37 | type Transport = Framed; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::Buf::get_i32': use get_i32_be or get_i32_le [INFO] [stderr] --> src/codec.rs:49:32 [INFO] [stderr] | [INFO] [stderr] 49 | let size: i32 = cursor.get_i32::(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::Buf::get_i32': use get_i32_be or get_i32_le [INFO] [stderr] --> src/codec.rs:55:38 [INFO] [stderr] | [INFO] [stderr] 55 | let frame_type: i32 = cursor.get_i32::(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::Buf::get_i64': use get_i64_be or get_i64_le [INFO] [stderr] --> src/codec.rs:86:40 [INFO] [stderr] | [INFO] [stderr] 86 | let timestamp = cursor.get_i64::(); // timestamp [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::Buf::get_u16': use get_u16_be or get_u16_le [INFO] [stderr] --> src/codec.rs:87:32 [INFO] [stderr] | [INFO] [stderr] 87 | let _ = cursor.get_u16::(); // attempts [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::BufMut::put_u32': use put_u32_be or put_u32_le [INFO] [stderr] --> src/codec.rs:134:28 [INFO] [stderr] | [INFO] [stderr] 134 | buf_32.put_u32::(body_len); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::BufMut::put_u32': use put_u32_be or put_u32_le [INFO] [stderr] --> src/codec.rs:148:28 [INFO] [stderr] | [INFO] [stderr] 148 | buf_32.put_u32::(body_len); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::BufMut::put_u32': use put_u32_be or put_u32_le [INFO] [stderr] --> src/codec.rs:151:28 [INFO] [stderr] | [INFO] [stderr] 151 | buf_32.put_u32::(messages_len); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::BufMut::put_u32': use put_u32_be or put_u32_le [INFO] [stderr] --> src/codec.rs:155:32 [INFO] [stderr] | [INFO] [stderr] 155 | buf_32.put_u32::(message_len); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::AsyncRead::framed': Use tokio_codec::Decoder::framed instead [INFO] [stderr] --> src/protocol.rs:52:28 [INFO] [stderr] | [INFO] [stderr] 52 | let handshake = io.framed(codec).send(version) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::Buf::get_i32': use get_i32_be or get_i32_le [INFO] [stderr] --> src/codec.rs:49:32 [INFO] [stderr] | [INFO] [stderr] 49 | let size: i32 = cursor.get_i32::(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::Buf::get_i32': use get_i32_be or get_i32_le [INFO] [stderr] --> src/codec.rs:55:38 [INFO] [stderr] | [INFO] [stderr] 55 | let frame_type: i32 = cursor.get_i32::(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::Buf::get_i64': use get_i64_be or get_i64_le [INFO] [stderr] --> src/codec.rs:86:40 [INFO] [stderr] | [INFO] [stderr] 86 | let timestamp = cursor.get_i64::(); // timestamp [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::Buf::get_u16': use get_u16_be or get_u16_le [INFO] [stderr] --> src/codec.rs:87:32 [INFO] [stderr] | [INFO] [stderr] 87 | let _ = cursor.get_u16::(); // attempts [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::BufMut::put_u32': use put_u32_be or put_u32_le [INFO] [stderr] --> src/codec.rs:134:28 [INFO] [stderr] | [INFO] [stderr] 134 | buf_32.put_u32::(body_len); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::BufMut::put_u32': use put_u32_be or put_u32_le [INFO] [stderr] --> src/codec.rs:148:28 [INFO] [stderr] | [INFO] [stderr] 148 | buf_32.put_u32::(body_len); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::BufMut::put_u32': use put_u32_be or put_u32_le [INFO] [stderr] --> src/codec.rs:151:28 [INFO] [stderr] | [INFO] [stderr] 151 | buf_32.put_u32::(messages_len); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::BufMut::put_u32': use put_u32_be or put_u32_le [INFO] [stderr] --> src/codec.rs:155:32 [INFO] [stderr] | [INFO] [stderr] 155 | buf_32.put_u32::(message_len); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::AsyncRead::framed': Use tokio_codec::Decoder::framed instead [INFO] [stderr] --> src/protocol.rs:52:28 [INFO] [stderr] | [INFO] [stderr] 52 | let handshake = io.framed(codec).send(version) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/codec.rs:142:54 [INFO] [stderr] | [INFO] [stderr] 142 | .map(|message| message.len()) [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 143 | | .fold(0, |acc, len| acc + len); [INFO] [stderr] | |______________________________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/codec.rs:142:54 [INFO] [stderr] | [INFO] [stderr] 142 | .map(|message| message.len()) [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 143 | | .fold(0, |acc, len| acc + len); [INFO] [stderr] | |______________________________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/consumer.rs:43:27 [INFO] [stderr] | [INFO] [stderr] 43 | .map_err(|e| {e.into()}) [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/consumer.rs:48:35 [INFO] [stderr] | [INFO] [stderr] 48 | .map_err(|e| {e.into()}); [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/consumer.rs:72:26 [INFO] [stderr] | [INFO] [stderr] 72 | .map_err(|e| e.into()) [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/consumer.rs:85:26 [INFO] [stderr] | [INFO] [stderr] 85 | .map_err(|e| e.into()) [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/producer.rs:63:18 [INFO] [stderr] | [INFO] [stderr] 63 | e.into()} [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/consumer.rs:43:27 [INFO] [stderr] | [INFO] [stderr] 43 | .map_err(|e| {e.into()}) [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/consumer.rs:48:35 [INFO] [stderr] | [INFO] [stderr] 48 | .map_err(|e| {e.into()}); [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/consumer.rs:72:26 [INFO] [stderr] | [INFO] [stderr] 72 | .map_err(|e| e.into()) [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/consumer.rs:85:26 [INFO] [stderr] | [INFO] [stderr] 85 | .map_err(|e| e.into()) [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/producer.rs:63:18 [INFO] [stderr] | [INFO] [stderr] 63 | e.into()} [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> examples/sub.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | ret [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> examples/sub.rs:20:27 [INFO] [stderr] | [INFO] [stderr] 20 | let ret = response.for_each(move |message| { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 21 | | if message.message_id == "_heartbeat_" { [INFO] [stderr] 22 | | conn.nop(); [INFO] [stderr] 23 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 27 | | Ok(()) [INFO] [stderr] 28 | | }); [INFO] [stderr] | |__________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.73s [INFO] running `"docker" "inspect" "aa06f7338b4930f74acbff5d5eb5e3886b28887437464e3048e9ee7f7923d172"` [INFO] running `"docker" "rm" "-f" "aa06f7338b4930f74acbff5d5eb5e3886b28887437464e3048e9ee7f7923d172"` [INFO] [stdout] aa06f7338b4930f74acbff5d5eb5e3886b28887437464e3048e9ee7f7923d172