[INFO] crate ns-router 0.1.6 is already in cache [INFO] extracting crate ns-router 0.1.6 into work/ex/clippy-test-run/sources/stable/reg/ns-router/0.1.6 [INFO] extracting crate ns-router 0.1.6 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ns-router/0.1.6 [INFO] validating manifest of ns-router-0.1.6 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ns-router-0.1.6 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ns-router-0.1.6 [INFO] finished frobbing ns-router-0.1.6 [INFO] frobbed toml for ns-router-0.1.6 written to work/ex/clippy-test-run/sources/stable/reg/ns-router/0.1.6/Cargo.toml [INFO] started frobbing ns-router-0.1.6 [INFO] finished frobbing ns-router-0.1.6 [INFO] frobbed toml for ns-router-0.1.6 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ns-router/0.1.6/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ns-router-0.1.6 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ns-router/0.1.6:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3d5c225eb6ec89f450b3720831f58a4c528fa1df815eb505d80b89506883d858 [INFO] running `"docker" "start" "-a" "3d5c225eb6ec89f450b3720831f58a4c528fa1df815eb505d80b89506883d858"` [INFO] [stderr] Checking ns-router v0.1.6 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/coroutine.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | futures: futures, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `futures` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/coroutine.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | futures: futures, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `futures` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/coroutine.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | return &cfg.root; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&cfg.root` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/multisubscr.rs:244:9 [INFO] [stderr] | [INFO] [stderr] 244 | return TaskResult::Continue; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TaskResult::Continue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/multisubscr.rs:233:13 [INFO] [stderr] | [INFO] [stderr] 233 | / if self.timer.is_some() { [INFO] [stderr] 234 | | if self.items.values().all(|x| x.is_complete()) { [INFO] [stderr] 235 | | self.timer = None; [INFO] [stderr] 236 | | } [INFO] [stderr] 237 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 233 | if self.timer.is_some() && self.items.values().all(|x| x.is_complete()) { [INFO] [stderr] 234 | self.timer = None; [INFO] [stderr] 235 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/multisubscr.rs:238:13 [INFO] [stderr] | [INFO] [stderr] 238 | / if self.timer.is_none() { [INFO] [stderr] 239 | | if !self.send_current() { [INFO] [stderr] 240 | | return TaskResult::Stop; [INFO] [stderr] 241 | | } [INFO] [stderr] 242 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 238 | if self.timer.is_none() && !self.send_current() { [INFO] [stderr] 239 | return TaskResult::Stop; [INFO] [stderr] 240 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/router.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | / return ( [INFO] [stderr] 86 | | Router { [INFO] [stderr] 87 | | requests: tx, [INFO] [stderr] 88 | | }, [INFO] [stderr] 89 | | UpdateSink(ctx), [INFO] [stderr] 90 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 85 | ( [INFO] [stderr] 86 | Router { [INFO] [stderr] 87 | requests: tx, [INFO] [stderr] 88 | }, [INFO] [stderr] 89 | UpdateSink(ctx), [INFO] [stderr] 90 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/coroutine.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | return &cfg.root; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&cfg.root` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/multisubscr.rs:244:9 [INFO] [stderr] | [INFO] [stderr] 244 | return TaskResult::Continue; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TaskResult::Continue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/multisubscr.rs:233:13 [INFO] [stderr] | [INFO] [stderr] 233 | / if self.timer.is_some() { [INFO] [stderr] 234 | | if self.items.values().all(|x| x.is_complete()) { [INFO] [stderr] 235 | | self.timer = None; [INFO] [stderr] 236 | | } [INFO] [stderr] 237 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 233 | if self.timer.is_some() && self.items.values().all(|x| x.is_complete()) { [INFO] [stderr] 234 | self.timer = None; [INFO] [stderr] 235 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/multisubscr.rs:238:13 [INFO] [stderr] | [INFO] [stderr] 238 | / if self.timer.is_none() { [INFO] [stderr] 239 | | if !self.send_current() { [INFO] [stderr] 240 | | return TaskResult::Stop; [INFO] [stderr] 241 | | } [INFO] [stderr] 242 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 238 | if self.timer.is_none() && !self.send_current() { [INFO] [stderr] 239 | return TaskResult::Stop; [INFO] [stderr] 240 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/router.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | / return ( [INFO] [stderr] 86 | | Router { [INFO] [stderr] 87 | | requests: tx, [INFO] [stderr] 88 | | }, [INFO] [stderr] 89 | | UpdateSink(ctx), [INFO] [stderr] 90 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 85 | ( [INFO] [stderr] 86 | Router { [INFO] [stderr] 87 | requests: tx, [INFO] [stderr] 88 | }, [INFO] [stderr] 89 | UpdateSink(ctx), [INFO] [stderr] 90 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `config::Config` [INFO] [stderr] --> src/config.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / pub fn new() -> Config { [INFO] [stderr] 29 | | Config { [INFO] [stderr] 30 | | restart_delay: Duration::from_millis(100), [INFO] [stderr] 31 | | convergence_delay: Duration::from_millis(100), [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 25 | impl Default for config::Config { [INFO] [stderr] 26 | fn default() -> Self { [INFO] [stderr] 27 | Self::new() [INFO] [stderr] 28 | } [INFO] [stderr] 29 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/coroutine.rs:50:19 [INFO] [stderr] | [INFO] [stderr] 50 | fn mapper(res: Result<(Option>, S), (Void, S)>) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `config::Config` [INFO] [stderr] --> src/config.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / pub fn new() -> Config { [INFO] [stderr] 29 | | Config { [INFO] [stderr] 30 | | restart_delay: Duration::from_millis(100), [INFO] [stderr] 31 | | convergence_delay: Duration::from_millis(100), [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 25 | impl Default for config::Config { [INFO] [stderr] 26 | fn default() -> Self { [INFO] [stderr] 27 | Self::new() [INFO] [stderr] 28 | } [INFO] [stderr] 29 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/multisubscr.rs:136:22 [INFO] [stderr] | [INFO] [stderr] 136 | if all_ok && self.current.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.current.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/coroutine.rs:50:19 [INFO] [stderr] | [INFO] [stderr] 50 | fn mapper(res: Result<(Option>, S), (Void, S)>) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/name.rs:107:41 [INFO] [stderr] | [INFO] [stderr] 107 | } else if x.starts_with("_") { [INFO] [stderr] | ^^^ help: try using a char instead: `'_'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/subscr.rs:183:13 [INFO] [stderr] | [INFO] [stderr] 183 | let ref nsub = get_suffix(cfg, self.name.as_ref()); [INFO] [stderr] | ----^^^^^^^^--------------------------------------- help: try: `let nsub = &get_suffix(cfg, self.name.as_ref());` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/multisubscr.rs:136:22 [INFO] [stderr] | [INFO] [stderr] 136 | if all_ok && self.current.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.current.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/name.rs:107:41 [INFO] [stderr] | [INFO] [stderr] 107 | } else if x.starts_with("_") { [INFO] [stderr] | ^^^ help: try using a char instead: `'_'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/subscr.rs:183:13 [INFO] [stderr] | [INFO] [stderr] 183 | let ref nsub = get_suffix(cfg, self.name.as_ref()); [INFO] [stderr] | ----^^^^^^^^--------------------------------------- help: try: `let nsub = &get_suffix(cfg, self.name.as_ref());` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 16.17s [INFO] running `"docker" "inspect" "3d5c225eb6ec89f450b3720831f58a4c528fa1df815eb505d80b89506883d858"` [INFO] running `"docker" "rm" "-f" "3d5c225eb6ec89f450b3720831f58a4c528fa1df815eb505d80b89506883d858"` [INFO] [stdout] 3d5c225eb6ec89f450b3720831f58a4c528fa1df815eb505d80b89506883d858