[INFO] crate nphysics_testbed2d 0.3.0 is already in cache [INFO] extracting crate nphysics_testbed2d 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/nphysics_testbed2d/0.3.0 [INFO] extracting crate nphysics_testbed2d 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nphysics_testbed2d/0.3.0 [INFO] validating manifest of nphysics_testbed2d-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nphysics_testbed2d-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nphysics_testbed2d-0.3.0 [INFO] finished frobbing nphysics_testbed2d-0.3.0 [INFO] frobbed toml for nphysics_testbed2d-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/nphysics_testbed2d/0.3.0/Cargo.toml [INFO] started frobbing nphysics_testbed2d-0.3.0 [INFO] finished frobbing nphysics_testbed2d-0.3.0 [INFO] frobbed toml for nphysics_testbed2d-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nphysics_testbed2d/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nphysics_testbed2d-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/nphysics_testbed2d/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 48eb8ebad04ee2b66f14c5d558b8097eafef028d01ca1c675fdc1668ed64f667 [INFO] running `"docker" "start" "-a" "48eb8ebad04ee2b66f14c5d558b8097eafef028d01ca1c675fdc1668ed64f667"` [INFO] [stderr] Checking rusttype v0.7.3 [INFO] [stderr] Compiling num-derive v0.2.4 [INFO] [stderr] Checking ncollide3d v0.17.3 [INFO] [stderr] Checking ncollide2d v0.17.3 [INFO] [stderr] Checking andrew v0.1.6 [INFO] [stderr] Checking rusttype v0.6.5 [INFO] [stderr] Checking smithay-client-toolkit v0.4.4 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking winit v0.18.1 [INFO] [stderr] Checking nphysics2d v0.9.4 [INFO] [stderr] Checking glutin v0.19.0 [INFO] [stderr] Checking kiss3d v0.17.1 [INFO] [stderr] Checking nphysics_testbed2d v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item '>::from_coordinates': Use Point::from(vector) instead. [INFO] [stderr] --> src/engine.rs:236:24 [INFO] [stderr] | [INFO] [stderr] 236 | let position = Point2::from_coordinates(pos.translation.vector); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/engine.rs:197:5 [INFO] [stderr] | [INFO] [stderr] 197 | / fn add_shape( [INFO] [stderr] 198 | | &mut self, [INFO] [stderr] 199 | | window: &mut Window, [INFO] [stderr] 200 | | object: ColliderHandle, [INFO] [stderr] ... | [INFO] [stderr] 223 | | } [INFO] [stderr] 224 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/engine.rs:244:5 [INFO] [stderr] | [INFO] [stderr] 244 | / fn add_polyline( [INFO] [stderr] 245 | | &mut self, [INFO] [stderr] 246 | | window: &mut Window, [INFO] [stderr] 247 | | object: ColliderHandle, [INFO] [stderr] ... | [INFO] [stderr] 263 | | ))) [INFO] [stderr] 264 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/engine.rs:266:5 [INFO] [stderr] | [INFO] [stderr] 266 | / fn add_ball( [INFO] [stderr] 267 | | &mut self, [INFO] [stderr] 268 | | window: &mut Window, [INFO] [stderr] 269 | | object: ColliderHandle, [INFO] [stderr] ... | [INFO] [stderr] 284 | | ))) [INFO] [stderr] 285 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/engine.rs:287:5 [INFO] [stderr] | [INFO] [stderr] 287 | / fn add_box( [INFO] [stderr] 288 | | &mut self, [INFO] [stderr] 289 | | window: &mut Window, [INFO] [stderr] 290 | | object: ColliderHandle, [INFO] [stderr] ... | [INFO] [stderr] 303 | | ))) [INFO] [stderr] 304 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/engine.rs:306:5 [INFO] [stderr] | [INFO] [stderr] 306 | / fn add_convex( [INFO] [stderr] 307 | | &mut self, [INFO] [stderr] 308 | | window: &mut Window, [INFO] [stderr] 309 | | object: ColliderHandle, [INFO] [stderr] ... | [INFO] [stderr] 325 | | ))) [INFO] [stderr] 326 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/objects/plane.rs:18:19 [INFO] [stderr] | [INFO] [stderr] 18 | position: &Point2, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Point2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/objects/plane.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | normal: &Unit>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Unit>` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/testbed.rs:178:28 [INFO] [stderr] | [INFO] [stderr] 178 | pub fn world(&self) -> &Box { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `&WorldOwner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/testbed.rs:251:5 [INFO] [stderr] | [INFO] [stderr] 251 | / fn step(&mut self, window: &mut Window) { [INFO] [stderr] 252 | | for mut event in window.events().iter() { [INFO] [stderr] 253 | | match event.value { [INFO] [stderr] 254 | | // WindowEvent::MouseButton(MouseButton::Button2, Action::Press, Key::LControl) | [INFO] [stderr] ... | [INFO] [stderr] 532 | | window.draw_text(CONTROLS, &Point2::new(0.0, 75.0), 40.0, &self.font, &color); [INFO] [stderr] 533 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::from_coordinates': Use Point::from(vector) instead. [INFO] [stderr] --> src/engine.rs:236:24 [INFO] [stderr] | [INFO] [stderr] 236 | let position = Point2::from_coordinates(pos.translation.vector); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/engine.rs:197:5 [INFO] [stderr] | [INFO] [stderr] 197 | / fn add_shape( [INFO] [stderr] 198 | | &mut self, [INFO] [stderr] 199 | | window: &mut Window, [INFO] [stderr] 200 | | object: ColliderHandle, [INFO] [stderr] ... | [INFO] [stderr] 223 | | } [INFO] [stderr] 224 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/engine.rs:244:5 [INFO] [stderr] | [INFO] [stderr] 244 | / fn add_polyline( [INFO] [stderr] 245 | | &mut self, [INFO] [stderr] 246 | | window: &mut Window, [INFO] [stderr] 247 | | object: ColliderHandle, [INFO] [stderr] ... | [INFO] [stderr] 263 | | ))) [INFO] [stderr] 264 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/engine.rs:266:5 [INFO] [stderr] | [INFO] [stderr] 266 | / fn add_ball( [INFO] [stderr] 267 | | &mut self, [INFO] [stderr] 268 | | window: &mut Window, [INFO] [stderr] 269 | | object: ColliderHandle, [INFO] [stderr] ... | [INFO] [stderr] 284 | | ))) [INFO] [stderr] 285 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/engine.rs:287:5 [INFO] [stderr] | [INFO] [stderr] 287 | / fn add_box( [INFO] [stderr] 288 | | &mut self, [INFO] [stderr] 289 | | window: &mut Window, [INFO] [stderr] 290 | | object: ColliderHandle, [INFO] [stderr] ... | [INFO] [stderr] 303 | | ))) [INFO] [stderr] 304 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/engine.rs:306:5 [INFO] [stderr] | [INFO] [stderr] 306 | / fn add_convex( [INFO] [stderr] 307 | | &mut self, [INFO] [stderr] 308 | | window: &mut Window, [INFO] [stderr] 309 | | object: ColliderHandle, [INFO] [stderr] ... | [INFO] [stderr] 325 | | ))) [INFO] [stderr] 326 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/objects/plane.rs:18:19 [INFO] [stderr] | [INFO] [stderr] 18 | position: &Point2, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Point2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/objects/plane.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | normal: &Unit>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Unit>` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/testbed.rs:178:28 [INFO] [stderr] | [INFO] [stderr] 178 | pub fn world(&self) -> &Box { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `&WorldOwner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/testbed.rs:251:5 [INFO] [stderr] | [INFO] [stderr] 251 | / fn step(&mut self, window: &mut Window) { [INFO] [stderr] 252 | | for mut event in window.events().iter() { [INFO] [stderr] 253 | | match event.value { [INFO] [stderr] 254 | | // WindowEvent::MouseButton(MouseButton::Button2, Action::Press, Key::LControl) | [INFO] [stderr] ... | [INFO] [stderr] 532 | | window.draw_text(CONTROLS, &Point2::new(0.0, 75.0), 40.0, &self.font, &color); [INFO] [stderr] 533 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 56.89s [INFO] running `"docker" "inspect" "48eb8ebad04ee2b66f14c5d558b8097eafef028d01ca1c675fdc1668ed64f667"` [INFO] running `"docker" "rm" "-f" "48eb8ebad04ee2b66f14c5d558b8097eafef028d01ca1c675fdc1668ed64f667"` [INFO] [stdout] 48eb8ebad04ee2b66f14c5d558b8097eafef028d01ca1c675fdc1668ed64f667