[INFO] crate nphysics2d 0.9.4 is already in cache [INFO] extracting crate nphysics2d 0.9.4 into work/ex/clippy-test-run/sources/stable/reg/nphysics2d/0.9.4 [INFO] extracting crate nphysics2d 0.9.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nphysics2d/0.9.4 [INFO] validating manifest of nphysics2d-0.9.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nphysics2d-0.9.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nphysics2d-0.9.4 [INFO] finished frobbing nphysics2d-0.9.4 [INFO] frobbed toml for nphysics2d-0.9.4 written to work/ex/clippy-test-run/sources/stable/reg/nphysics2d/0.9.4/Cargo.toml [INFO] started frobbing nphysics2d-0.9.4 [INFO] finished frobbing nphysics2d-0.9.4 [INFO] frobbed toml for nphysics2d-0.9.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nphysics2d/0.9.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nphysics2d-0.9.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/nphysics2d/0.9.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1ad921b3e680570a0bfd944e37cd940939545363c0e8d2dd182047f873bc5f49 [INFO] running `"docker" "start" "-a" "1ad921b3e680570a0bfd944e37cd940939545363c0e8d2dd182047f873bc5f49"` [INFO] [stderr] Checking approx v0.3.1 [INFO] [stderr] Checking alga v0.7.2 [INFO] [stderr] Checking nalgebra v0.16.13 [INFO] [stderr] Checking ncollide2d v0.17.3 [INFO] [stderr] Checking nphysics2d v0.9.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/detection/activation_manager.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | mix_factor: mix_factor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mix_factor` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/joint/prismatic_joint.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | axis: axis, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/joint/prismatic_joint.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/joint/prismatic_joint.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | axis: axis, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/joint/prismatic_joint.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/joint/revolute_joint.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | angle: angle, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `angle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/joint/revolute_joint.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | axis: axis, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/joint/revolute_joint.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | angle: angle, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `angle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/joint/unit_joint.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | assembly_id: assembly_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assembly_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/joint/unit_joint.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | ndofs: ndofs, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ndofs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/joint/unit_joint.rs:150:17 [INFO] [stderr] | [INFO] [stderr] 150 | assembly_id: assembly_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assembly_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/joint/unit_joint.rs:153:17 [INFO] [stderr] | [INFO] [stderr] 153 | ndofs: ndofs, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ndofs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/detection/activation_manager.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | mix_factor: mix_factor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mix_factor` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/object/body_set.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | handle: handle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/joint/prismatic_joint.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | axis: axis, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/joint/prismatic_joint.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/joint/prismatic_joint.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | axis: axis, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/joint/prismatic_joint.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/joint/revolute_joint.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | angle: angle, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `angle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/joint/revolute_joint.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | axis: axis, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/joint/revolute_joint.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | angle: angle, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `angle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/object/multibody_link.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | internal_id: internal_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `internal_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/joint/unit_joint.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | assembly_id: assembly_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assembly_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/joint/unit_joint.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | ndofs: ndofs, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ndofs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/joint/unit_joint.rs:150:17 [INFO] [stderr] | [INFO] [stderr] 150 | assembly_id: assembly_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assembly_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/solver/constraint.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | assembly_id1: assembly_id1, [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/joint/unit_joint.rs:153:17 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assembly_id1` [INFO] [stderr] | [INFO] [stderr] 153 | ndofs: ndofs, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ndofs` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/solver/constraint.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | assembly_id2: assembly_id2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assembly_id2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/solver/constraint.rs:241:13 [INFO] [stderr] | [INFO] [stderr] 241 | assembly_id1: assembly_id1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assembly_id1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/solver/constraint.rs:242:13 [INFO] [stderr] | [INFO] [stderr] 242 | assembly_id2: assembly_id2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assembly_id2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/solver/moreau_jean_solver.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | contact_model: contact_model, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contact_model` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/solver/moreau_jean_solver.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | constraints: constraints, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `constraints` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/object/body_set.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | handle: handle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/solver/signorini_coulomb_pyramid_model.rs:112:21 [INFO] [stderr] | [INFO] [stderr] 112 | dependency: dependency, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dependency` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/object/multibody_link.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | internal_id: internal_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `internal_id` [INFO] [stderr] | [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/volumetric/volumetric_cuboid.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | let _2: N = na::convert(2.0f64); [INFO] [stderr] | ^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = note: #[warn(clippy::just_underscores_and_digits)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/volumetric/volumetric_cuboid.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | let _0: N = na::zero(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/volumetric/volumetric_cuboid.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | let _2: N = na::convert(2.0f64); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/solver/constraint.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | assembly_id1: assembly_id1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assembly_id1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/solver/constraint.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | assembly_id2: assembly_id2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assembly_id2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/solver/constraint.rs:241:13 [INFO] [stderr] | [INFO] [stderr] 241 | assembly_id1: assembly_id1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assembly_id1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/solver/constraint.rs:242:13 [INFO] [stderr] | [INFO] [stderr] 242 | assembly_id2: assembly_id2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assembly_id2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/solver/moreau_jean_solver.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | contact_model: contact_model, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contact_model` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/solver/moreau_jean_solver.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | constraints: constraints, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `constraints` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/solver/signorini_coulomb_pyramid_model.rs:112:21 [INFO] [stderr] | [INFO] [stderr] 112 | dependency: dependency, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dependency` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/volumetric/volumetric_cuboid.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | let _2: N = na::convert(2.0f64); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::just_underscores_and_digits)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/volumetric/volumetric_cuboid.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | let _0: N = na::zero(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/volumetric/volumetric_cuboid.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | let _2: N = na::convert(2.0f64); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/force_generator/mod.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | mod force_generator; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/joint/mod.rs:51:1 [INFO] [stderr] | [INFO] [stderr] 51 | mod joint; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/joint/prismatic_constraint.rs:294:9 [INFO] [stderr] | [INFO] [stderr] 294 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/joint/revolute_constraint.rs:300:9 [INFO] [stderr] | [INFO] [stderr] 300 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/joint/unit_constraint.rs:35:20 [INFO] [stderr] | [INFO] [stderr] 35 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 36 | | if offset <= min { [INFO] [stderr] 37 | | (true, -*axis) [INFO] [stderr] 38 | | } else if offset >= max { [INFO] [stderr] ... | [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 35 | } else if offset <= min { [INFO] [stderr] 36 | (true, -*axis) [INFO] [stderr] 37 | } else if offset >= max { [INFO] [stderr] 38 | (true, *axis) [INFO] [stderr] 39 | } else { [INFO] [stderr] 40 | return; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/object/body_set.rs:205:16 [INFO] [stderr] | [INFO] [stderr] 205 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 206 | | if let BodyId::MultibodyLinkId(mb_id, parent_id) = self.ids[parent.handle] { [INFO] [stderr] 207 | | let mb_handle = BodyHandle::new( [INFO] [stderr] 208 | | self.ids [INFO] [stderr] ... | [INFO] [stderr] 226 | | } [INFO] [stderr] 227 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 205 | } else if let BodyId::MultibodyLinkId(mb_id, parent_id) = self.ids[parent.handle] { [INFO] [stderr] 206 | let mb_handle = BodyHandle::new( [INFO] [stderr] 207 | self.ids [INFO] [stderr] 208 | .insert(BodyId::MultibodyLinkId(mb_id, MultibodyLinkId::ground())), [INFO] [stderr] 209 | ); [INFO] [stderr] 210 | let id = self.mbs[mb_id] [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/force_generator/mod.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | mod force_generator; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/object/body_set.rs:496:9 [INFO] [stderr] | [INFO] [stderr] 496 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/joint/mod.rs:51:1 [INFO] [stderr] | [INFO] [stderr] 51 | mod joint; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/joint/prismatic_constraint.rs:294:9 [INFO] [stderr] | [INFO] [stderr] 294 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/joint/revolute_constraint.rs:300:9 [INFO] [stderr] | [INFO] [stderr] 300 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/joint/unit_constraint.rs:35:20 [INFO] [stderr] | [INFO] [stderr] 35 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 36 | | if offset <= min { [INFO] [stderr] 37 | | (true, -*axis) [INFO] [stderr] 38 | | } else if offset >= max { [INFO] [stderr] ... | [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 35 | } else if offset <= min { [INFO] [stderr] 36 | (true, -*axis) [INFO] [stderr] 37 | } else if offset >= max { [INFO] [stderr] 38 | (true, *axis) [INFO] [stderr] 39 | } else { [INFO] [stderr] 40 | return; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/object/body_set.rs:205:16 [INFO] [stderr] | [INFO] [stderr] 205 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 206 | | if let BodyId::MultibodyLinkId(mb_id, parent_id) = self.ids[parent.handle] { [INFO] [stderr] 207 | | let mb_handle = BodyHandle::new( [INFO] [stderr] 208 | | self.ids [INFO] [stderr] ... | [INFO] [stderr] 226 | | } [INFO] [stderr] 227 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/volumetric/mod.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | pub mod volumetric; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 205 | } else if let BodyId::MultibodyLinkId(mb_id, parent_id) = self.ids[parent.handle] { [INFO] [stderr] 206 | let mb_handle = BodyHandle::new( [INFO] [stderr] 207 | self.ids [INFO] [stderr] 208 | .insert(BodyId::MultibodyLinkId(mb_id, MultibodyLinkId::ground())), [INFO] [stderr] 209 | ); [INFO] [stderr] 210 | let id = self.mbs[mb_id] [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/object/body_set.rs:496:9 [INFO] [stderr] | [INFO] [stderr] 496 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/world/mod.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | mod world; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/volumetric/mod.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | pub mod volumetric; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Vector3`, `self` [INFO] [stderr] --> src/volumetric/volumetric_convex2.rs:159:14 [INFO] [stderr] | [INFO] [stderr] 159 | use na::{self, Matrix1, Point2, Vector2, Vector3}; [INFO] [stderr] | ^^^^ ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `ncollide::procedural` [INFO] [stderr] --> src/volumetric/volumetric_convex2.rs:160:9 [INFO] [stderr] | [INFO] [stderr] 160 | use ncollide::procedural; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/world/mod.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | mod world; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'na::norm_squared': use `Matrix::norm_squared` or `Quaternion::norm_squared` instead [INFO] [stderr] --> src/volumetric/volumetric.rs:73:37 [INFO] [stderr] | [INFO] [stderr] 73 | *self + Matrix1::new(mass * na::norm_squared(&pt.coords)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'na::norm_squared': use `Matrix::norm_squared` or `Quaternion::norm_squared` instead [INFO] [stderr] --> src/volumetric/volumetric.rs:92:20 [INFO] [stderr] | [INFO] [stderr] 92 | let diag = na::norm_squared(&pt.coords); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'na::norm_squared': use `Matrix::norm_squared` or `Quaternion::norm_squared` instead [INFO] [stderr] --> src/volumetric/volumetric.rs:73:37 [INFO] [stderr] | [INFO] [stderr] 73 | *self + Matrix1::new(mass * na::norm_squared(&pt.coords)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'na::norm_squared': use `Matrix::norm_squared` or `Quaternion::norm_squared` instead [INFO] [stderr] --> src/volumetric/volumetric.rs:92:20 [INFO] [stderr] | [INFO] [stderr] 92 | let diag = na::norm_squared(&pt.coords); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::from_vector': Use `::from` instead. [INFO] [stderr] --> src/joint/cartesian_joint.rs:27:17 [INFO] [stderr] | [INFO] [stderr] 27 | let t = Translation::from_vector(parent_shift - body_shift + self.position); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::from_vector': Use `::from` instead. [INFO] [stderr] --> src/joint/fixed_joint.rs:31:28 [INFO] [stderr] | [INFO] [stderr] 31 | let parent_trans = Translation::from_vector(*parent_shift); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::from_vector': Use `::from` instead. [INFO] [stderr] --> src/joint/fixed_joint.rs:32:26 [INFO] [stderr] | [INFO] [stderr] 32 | let body_trans = Translation::from_vector(*body_shift); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::from_vector': Use `::from` instead. [INFO] [stderr] --> src/joint/prismatic_joint.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | Translation::from_vector(*self.axis * self.offset) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::from_vector': Use `::from` instead. [INFO] [stderr] --> src/joint/prismatic_joint.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | Translation::from_vector(parent_shift - body_shift + self.axis.as_ref() * self.offset); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::from_vector': Use `::from` instead. [INFO] [stderr] --> src/joint/revolute_joint.rs:193:21 [INFO] [stderr] | [INFO] [stderr] 193 | let trans = Translation::from_vector(parent_shift - self.rot * body_shift); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::unwrap': use `.into_inner()` instead [INFO] [stderr] --> src/joint/revolute_joint.rs:201:88 [INFO] [stderr] | [INFO] [stderr] 201 | self.jacobian = Velocity::new_with_vectors(self.axis.gcross(&shift), self.axis.unwrap()); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::from_coordinates': Use Point::from(vector) instead. [INFO] [stderr] --> src/joint/cartesian_constraint.rs:80:23 [INFO] [stderr] | [INFO] [stderr] 80 | let anchor1 = Point::from_coordinates(pos1.translation.vector); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::from_coordinates': Use Point::from(vector) instead. [INFO] [stderr] --> src/joint/cartesian_constraint.rs:81:23 [INFO] [stderr] | [INFO] [stderr] 81 | let anchor2 = Point::from_coordinates(pos2.translation.vector); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::from_coordinates': Use Point::from(vector) instead. [INFO] [stderr] --> src/joint/cartesian_constraint.rs:144:23 [INFO] [stderr] | [INFO] [stderr] 144 | let anchor1 = Point::from_coordinates(pos1.translation.vector); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::from_coordinates': Use Point::from(vector) instead. [INFO] [stderr] --> src/joint/cartesian_constraint.rs:145:23 [INFO] [stderr] | [INFO] [stderr] 145 | let anchor2 = Point::from_coordinates(pos2.translation.vector); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::from_coordinates': Use Point::from(vector) instead. [INFO] [stderr] --> src/joint/fixed_constraint.rs:82:23 [INFO] [stderr] | [INFO] [stderr] 82 | let anchor1 = Point::from_coordinates(pos1.translation.vector); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::from_coordinates': Use Point::from(vector) instead. [INFO] [stderr] --> src/joint/fixed_constraint.rs:83:23 [INFO] [stderr] | [INFO] [stderr] 83 | let anchor2 = Point::from_coordinates(pos2.translation.vector); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::from_vector': Use `::from` instead. [INFO] [stderr] --> src/joint/cartesian_joint.rs:27:17 [INFO] [stderr] | [INFO] [stderr] 27 | let t = Translation::from_vector(parent_shift - body_shift + self.position); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::from_coordinates': Use Point::from(vector) instead. [INFO] [stderr] --> src/joint/fixed_constraint.rs:170:23 [INFO] [stderr] | [INFO] [stderr] 170 | let anchor1 = Point::from_coordinates(pos1.translation.vector); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::from_coordinates': Use Point::from(vector) instead. [INFO] [stderr] --> src/joint/fixed_constraint.rs:171:23 [INFO] [stderr] | [INFO] [stderr] 171 | let anchor2 = Point::from_coordinates(pos2.translation.vector); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::from_vector': Use `::from` instead. [INFO] [stderr] --> src/joint/fixed_joint.rs:31:28 [INFO] [stderr] | [INFO] [stderr] 31 | let parent_trans = Translation::from_vector(*parent_shift); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::from_vector': Use `::from` instead. [INFO] [stderr] --> src/joint/fixed_joint.rs:32:26 [INFO] [stderr] | [INFO] [stderr] 32 | let body_trans = Translation::from_vector(*body_shift); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::from_vector': Use `::from` instead. [INFO] [stderr] --> src/joint/prismatic_joint.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | Translation::from_vector(*self.axis * self.offset) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::from_vector': Use `::from` instead. [INFO] [stderr] --> src/joint/prismatic_joint.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | Translation::from_vector(parent_shift - body_shift + self.axis.as_ref() * self.offset); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::from_vector': Use `::from` instead. [INFO] [stderr] --> src/joint/revolute_joint.rs:193:21 [INFO] [stderr] | [INFO] [stderr] 193 | let trans = Translation::from_vector(parent_shift - self.rot * body_shift); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::unwrap': use `.into_inner()` instead [INFO] [stderr] --> src/joint/revolute_joint.rs:201:88 [INFO] [stderr] | [INFO] [stderr] 201 | self.jacobian = Velocity::new_with_vectors(self.axis.gcross(&shift), self.axis.unwrap()); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::from_coordinates': Use Point::from(vector) instead. [INFO] [stderr] --> src/joint/cartesian_constraint.rs:80:23 [INFO] [stderr] | [INFO] [stderr] 80 | let anchor1 = Point::from_coordinates(pos1.translation.vector); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::from_coordinates': Use Point::from(vector) instead. [INFO] [stderr] --> src/joint/cartesian_constraint.rs:81:23 [INFO] [stderr] | [INFO] [stderr] 81 | let anchor2 = Point::from_coordinates(pos2.translation.vector); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::from_coordinates': Use Point::from(vector) instead. [INFO] [stderr] --> src/joint/cartesian_constraint.rs:144:23 [INFO] [stderr] | [INFO] [stderr] 144 | let anchor1 = Point::from_coordinates(pos1.translation.vector); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::from_coordinates': Use Point::from(vector) instead. [INFO] [stderr] --> src/joint/cartesian_constraint.rs:145:23 [INFO] [stderr] | [INFO] [stderr] 145 | let anchor2 = Point::from_coordinates(pos2.translation.vector); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::from_coordinates': Use Point::from(vector) instead. [INFO] [stderr] --> src/joint/fixed_constraint.rs:82:23 [INFO] [stderr] | [INFO] [stderr] 82 | let anchor1 = Point::from_coordinates(pos1.translation.vector); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::from_coordinates': Use Point::from(vector) instead. [INFO] [stderr] --> src/joint/fixed_constraint.rs:83:23 [INFO] [stderr] | [INFO] [stderr] 83 | let anchor2 = Point::from_coordinates(pos2.translation.vector); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::from_coordinates': Use Point::from(vector) instead. [INFO] [stderr] --> src/joint/fixed_constraint.rs:170:23 [INFO] [stderr] | [INFO] [stderr] 170 | let anchor1 = Point::from_coordinates(pos1.translation.vector); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::from_coordinates': Use Point::from(vector) instead. [INFO] [stderr] --> src/joint/fixed_constraint.rs:171:23 [INFO] [stderr] | [INFO] [stderr] 171 | let anchor2 = Point::from_coordinates(pos2.translation.vector); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::from_vector': Use `::from` instead. [INFO] [stderr] --> src/object/rigid_body.rs:308:27 [INFO] [stderr] | [INFO] [stderr] 308 | let translation = Translation::from_vector(displacement.linear); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::from_vector': Use `::from` instead. [INFO] [stderr] --> src/object/rigid_body.rs:309:21 [INFO] [stderr] | [INFO] [stderr] 309 | let shift = Translation::from_vector(self.com.coords); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::unwrap': use `.into_inner()` instead [INFO] [stderr] --> src/solver/helper.rs:785:48 [INFO] [stderr] | [INFO] [stderr] 785 | Vector::orthonormal_subspace_basis(&[axis1.unwrap()], |dir| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::unwrap': use `.into_inner()` instead [INFO] [stderr] --> src/solver/helper.rs:859:32 [INFO] [stderr] | [INFO] [stderr] 859 | let proj = anchor1 + axis1.unwrap() * axis1.dot(&dpt); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::from_vector': Use `::from` instead. [INFO] [stderr] --> src/object/rigid_body.rs:308:27 [INFO] [stderr] | [INFO] [stderr] 308 | let translation = Translation::from_vector(displacement.linear); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::from_vector': Use `::from` instead. [INFO] [stderr] --> src/object/rigid_body.rs:309:21 [INFO] [stderr] | [INFO] [stderr] 309 | let shift = Translation::from_vector(self.com.coords); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::unwrap': use `.into_inner()` instead [INFO] [stderr] --> src/solver/signorini_coulomb_pyramid_model.rs:121:40 [INFO] [stderr] | [INFO] [stderr] 121 | + c.contact.normal.unwrap() * manifold.collider1.data().margin(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::unwrap': use `.into_inner()` instead [INFO] [stderr] --> src/solver/signorini_coulomb_pyramid_model.rs:123:40 [INFO] [stderr] | [INFO] [stderr] 123 | - c.contact.normal.unwrap() * manifold.collider2.data().margin(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::unwrap': use `.into_inner()` instead [INFO] [stderr] --> src/solver/signorini_coulomb_pyramid_model.rs:125:71 [INFO] [stderr] | [INFO] [stderr] 125 | Vector::orthonormal_subspace_basis(&[c.contact.normal.unwrap()], |friction_dir| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::unwrap': use `.into_inner()` instead [INFO] [stderr] --> src/solver/signorini_model.rs:57:59 [INFO] [stderr] | [INFO] [stderr] 57 | let center1 = c.contact.world1 + c.contact.normal.unwrap() * data1.margin(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::unwrap': use `.into_inner()` instead [INFO] [stderr] --> src/solver/signorini_model.rs:58:59 [INFO] [stderr] | [INFO] [stderr] 58 | let center2 = c.contact.world2 - c.contact.normal.unwrap() * data2.margin(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::unwrap': use `.into_inner()` instead [INFO] [stderr] --> src/solver/helper.rs:785:48 [INFO] [stderr] | [INFO] [stderr] 785 | Vector::orthonormal_subspace_basis(&[axis1.unwrap()], |dir| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::unwrap': use `.into_inner()` instead [INFO] [stderr] --> src/solver/helper.rs:859:32 [INFO] [stderr] | [INFO] [stderr] 859 | let proj = anchor1 + axis1.unwrap() * axis1.dot(&dpt); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::unwrap': use `.into_inner()` instead [INFO] [stderr] --> src/solver/signorini_coulomb_pyramid_model.rs:121:40 [INFO] [stderr] | [INFO] [stderr] 121 | + c.contact.normal.unwrap() * manifold.collider1.data().margin(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::unwrap': use `.into_inner()` instead [INFO] [stderr] --> src/solver/signorini_coulomb_pyramid_model.rs:123:40 [INFO] [stderr] | [INFO] [stderr] 123 | - c.contact.normal.unwrap() * manifold.collider2.data().margin(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::unwrap': use `.into_inner()` instead [INFO] [stderr] --> src/solver/signorini_coulomb_pyramid_model.rs:125:71 [INFO] [stderr] | [INFO] [stderr] 125 | Vector::orthonormal_subspace_basis(&[c.contact.normal.unwrap()], |friction_dir| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::unwrap': use `.into_inner()` instead [INFO] [stderr] --> src/solver/signorini_model.rs:57:59 [INFO] [stderr] | [INFO] [stderr] 57 | let center1 = c.contact.world1 + c.contact.normal.unwrap() * data1.margin(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::unwrap': use `.into_inner()` instead [INFO] [stderr] --> src/solver/signorini_model.rs:58:59 [INFO] [stderr] | [INFO] [stderr] 58 | let center2 = c.contact.world2 - c.contact.normal.unwrap() * data2.margin(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/algebra/velocity2.rs:74:18 [INFO] [stderr] | [INFO] [stderr] 74 | unsafe { mem::transmute(self) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&*(self as *const algebra::velocity2::Velocity2 as *const na::Matrix>)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/algebra/velocity2.rs:82:18 [INFO] [stderr] | [INFO] [stderr] 82 | unsafe { mem::transmute(self) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(self as *mut algebra::velocity2::Velocity2 as *mut na::Matrix>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/algebra/velocity3.rs:73:18 [INFO] [stderr] | [INFO] [stderr] 73 | unsafe { mem::transmute(self) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&*(self as *const algebra::velocity3::Velocity3 as *const na::Matrix>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/algebra/velocity3.rs:80:18 [INFO] [stderr] | [INFO] [stderr] 80 | unsafe { mem::transmute(self) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(self as *mut algebra::velocity3::Velocity3 as *mut na::Matrix>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/algebra/force2.rs:96:18 [INFO] [stderr] | [INFO] [stderr] 96 | unsafe { mem::transmute(self) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&*(self as *const algebra::force2::Force2 as *const na::Matrix>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/algebra/force2.rs:104:18 [INFO] [stderr] | [INFO] [stderr] 104 | unsafe { mem::transmute(self) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(self as *mut algebra::force2::Force2 as *mut na::Matrix>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/algebra/force3.rs:102:18 [INFO] [stderr] | [INFO] [stderr] 102 | unsafe { mem::transmute(self) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&*(self as *const algebra::force3::Force3 as *const na::Matrix>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/algebra/force3.rs:110:18 [INFO] [stderr] | [INFO] [stderr] 110 | unsafe { mem::transmute(self) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(self as *mut algebra::force3::Force3 as *mut na::Matrix>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/algebra/inertia2.rs:40:18 [INFO] [stderr] | [INFO] [stderr] 40 | unsafe { mem::transmute(&self.angular) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self.angular as *const N as *const na::Matrix>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: item `detection::collider_contact_manifold::ColliderContactManifold<'a, N>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/detection/collider_contact_manifold.rs:32:1 [INFO] [stderr] | [INFO] [stderr] 32 | / impl<'a, N: Real> ColliderContactManifold<'a, N> { [INFO] [stderr] 33 | | /// Initialize a new contact manifold. [INFO] [stderr] 34 | | pub fn new( [INFO] [stderr] 35 | | collider1: &'a Collider, [INFO] [stderr] ... | [INFO] [stderr] 89 | | } [INFO] [stderr] 90 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/joint/joint.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / fn velocity_constraints( [INFO] [stderr] 60 | | &self, [INFO] [stderr] 61 | | _params: &IntegrationParameters, [INFO] [stderr] 62 | | _link: &MultibodyLinkRef, [INFO] [stderr] ... | [INFO] [stderr] 69 | | ) { [INFO] [stderr] 70 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/joint/joint.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / fn velocity_constraints( [INFO] [stderr] 60 | | &self, [INFO] [stderr] 61 | | _params: &IntegrationParameters, [INFO] [stderr] 62 | | _link: &MultibodyLinkRef, [INFO] [stderr] ... | [INFO] [stderr] 69 | | ) { [INFO] [stderr] 70 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/joint/unit_joint.rs:46:1 [INFO] [stderr] | [INFO] [stderr] 46 | / pub fn unit_joint_velocity_constraints>( [INFO] [stderr] 47 | | joint: &J, [INFO] [stderr] 48 | | params: &IntegrationParameters, [INFO] [stderr] 49 | | link: &MultibodyLinkRef, [INFO] [stderr] ... | [INFO] [stderr] 159 | | } [INFO] [stderr] 160 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/joint/joint_constraint.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / fn velocity_constraints( [INFO] [stderr] 34 | | &mut self, [INFO] [stderr] 35 | | params: &IntegrationParameters, [INFO] [stderr] 36 | | bodies: &BodySet, [INFO] [stderr] ... | [INFO] [stderr] 41 | | velocity_constraints: &mut ConstraintSet, [INFO] [stderr] 42 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (16/7) [INFO] [stderr] --> src/joint/unit_constraint.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / pub fn build_linear_limits_velocity_constraint( [INFO] [stderr] 9 | | body1: &BodyPart, [INFO] [stderr] 10 | | body2: &BodyPart, [INFO] [stderr] 11 | | assembly_id1: usize, [INFO] [stderr] ... | [INFO] [stderr] 125 | | } [INFO] [stderr] 126 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/joint/unit_constraint.rs:128:1 [INFO] [stderr] | [INFO] [stderr] 128 | / pub fn build_linear_limits_position_constraint( [INFO] [stderr] 129 | | params: &IntegrationParameters, [INFO] [stderr] 130 | | body1: &BodyPart, [INFO] [stderr] 131 | | body2: &BodyPart, [INFO] [stderr] ... | [INFO] [stderr] 186 | | } [INFO] [stderr] 187 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: item `object::body_set::BodySet` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/object/body_set.rs:76:1 [INFO] [stderr] | [INFO] [stderr] 76 | / impl BodySet { [INFO] [stderr] 77 | | /// Create a new empty set of bodies. [INFO] [stderr] 78 | | pub fn new() -> Self { [INFO] [stderr] 79 | | BodySet { [INFO] [stderr] ... | [INFO] [stderr] 474 | | } [INFO] [stderr] 475 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/object/multibody.rs:249:5 [INFO] [stderr] | [INFO] [stderr] 249 | / pub(crate) fn add_link>( [INFO] [stderr] 250 | | &mut self, [INFO] [stderr] 251 | | handle: BodyHandle, [INFO] [stderr] 252 | | parent: MultibodyLinkId, [INFO] [stderr] ... | [INFO] [stderr] 318 | | MultibodyLinkMut::new(MultibodyLinkId::new(internal_id), self) [INFO] [stderr] 319 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/object/multibody_link.rs:30:20 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn is_root(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/object/multibody_link.rs:35:22 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn is_ground(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/object/multibody_link.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | / pub fn new( [INFO] [stderr] 73 | | handle: BodyHandle, [INFO] [stderr] 74 | | assembly_id: usize, [INFO] [stderr] 75 | | impulse_id: usize, [INFO] [stderr] ... | [INFO] [stderr] 114 | | } [INFO] [stderr] 115 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: item `solver::constraint_set::ConstraintSet` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/solver/constraint_set.rs:88:1 [INFO] [stderr] | [INFO] [stderr] 88 | / impl ConstraintSet { [INFO] [stderr] 89 | | /// Create a new empty set of constraints. [INFO] [stderr] 90 | | pub fn new() -> Self { [INFO] [stderr] 91 | | ConstraintSet { [INFO] [stderr] ... | [INFO] [stderr] 106 | | } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/solver/contact_model.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / fn constraints( [INFO] [stderr] 16 | | &mut self, [INFO] [stderr] 17 | | params: &IntegrationParameters, [INFO] [stderr] 18 | | bodies: &BodySet, [INFO] [stderr] ... | [INFO] [stderr] 24 | | constraints: &mut ConstraintSet, [INFO] [stderr] 25 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/solver/helper.rs:43:1 [INFO] [stderr] | [INFO] [stderr] 43 | / pub fn fill_constraint_geometry( [INFO] [stderr] 44 | | body: &BodyPart, [INFO] [stderr] 45 | | ndofs: usize, [INFO] [stderr] 46 | | center: &Point, [INFO] [stderr] ... | [INFO] [stderr] 76 | | *inv_r += j.dot(&invm_j); [INFO] [stderr] 77 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/solver/helper.rs:85:1 [INFO] [stderr] | [INFO] [stderr] 85 | / pub fn constraint_pair_geometry( [INFO] [stderr] 86 | | body1: &BodyPart, [INFO] [stderr] 87 | | body2: &BodyPart, [INFO] [stderr] 88 | | center1: &Point, [INFO] [stderr] ... | [INFO] [stderr] 149 | | res [INFO] [stderr] 150 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/solver/helper.rs:156:1 [INFO] [stderr] | [INFO] [stderr] 156 | / pub fn constraint_pair_velocity( [INFO] [stderr] 157 | | body1: &BodyPart, [INFO] [stderr] 158 | | body2: &BodyPart, [INFO] [stderr] 159 | | assembly_id1: usize, [INFO] [stderr] ... | [INFO] [stderr] 208 | | vel [INFO] [stderr] 209 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (14/7) [INFO] [stderr] --> src/solver/helper.rs:224:1 [INFO] [stderr] | [INFO] [stderr] 224 | / pub fn cancel_relative_linear_velocity_wrt_axis( [INFO] [stderr] 225 | | body1: &BodyPart, [INFO] [stderr] 226 | | body2: &BodyPart, [INFO] [stderr] 227 | | assembly_id1: usize, [INFO] [stderr] ... | [INFO] [stderr] 296 | | } [INFO] [stderr] 297 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (13/7) [INFO] [stderr] --> src/solver/helper.rs:302:1 [INFO] [stderr] | [INFO] [stderr] 302 | / pub fn cancel_relative_linear_velocity( [INFO] [stderr] 303 | | body1: &BodyPart, [INFO] [stderr] 304 | | body2: &BodyPart, [INFO] [stderr] 305 | | assembly_id1: usize, [INFO] [stderr] ... | [INFO] [stderr] 339 | | }); [INFO] [stderr] 340 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (14/7) [INFO] [stderr] --> src/solver/helper.rs:447:1 [INFO] [stderr] | [INFO] [stderr] 447 | / pub fn cancel_relative_angular_velocity_wrt_axis( [INFO] [stderr] 448 | | body1: &BodyPart, [INFO] [stderr] 449 | | body2: &BodyPart, [INFO] [stderr] 450 | | assembly_id1: usize, [INFO] [stderr] ... | [INFO] [stderr] 519 | | } [INFO] [stderr] 520 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (13/7) [INFO] [stderr] --> src/solver/helper.rs:525:1 [INFO] [stderr] | [INFO] [stderr] 525 | / pub fn cancel_relative_angular_velocity( [INFO] [stderr] 526 | | body1: &BodyPart, [INFO] [stderr] 527 | | body2: &BodyPart, [INFO] [stderr] 528 | | assembly_id1: usize, [INFO] [stderr] ... | [INFO] [stderr] 562 | | }); [INFO] [stderr] 563 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/solver/helper.rs:568:1 [INFO] [stderr] | [INFO] [stderr] 568 | / pub fn cancel_relative_rotation( [INFO] [stderr] 569 | | params: &IntegrationParameters, [INFO] [stderr] 570 | | body1: &BodyPart, [INFO] [stderr] 571 | | body2: &BodyPart, [INFO] [stderr] ... | [INFO] [stderr] 611 | | } [INFO] [stderr] 612 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (14/7) [INFO] [stderr] --> src/solver/helper.rs:763:1 [INFO] [stderr] | [INFO] [stderr] 763 | / pub fn restrict_relative_linear_velocity_to_axis( [INFO] [stderr] 764 | | body1: &BodyPart, [INFO] [stderr] 765 | | body2: &BodyPart, [INFO] [stderr] 766 | | assembly_id1: usize, [INFO] [stderr] ... | [INFO] [stderr] 842 | | }); [INFO] [stderr] 843 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/solver/integration_parameters.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | / pub fn new( [INFO] [stderr] 38 | | dt: N, [INFO] [stderr] 39 | | erp: N, [INFO] [stderr] 40 | | warmstart_coeff: N, [INFO] [stderr] ... | [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/solver/nonlinear_constraint.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn new( [INFO] [stderr] 34 | | body1: BodyHandle, [INFO] [stderr] 35 | | body2: BodyHandle, [INFO] [stderr] 36 | | is_angular: bool, [INFO] [stderr] ... | [INFO] [stderr] 54 | | } [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `solver::nonlinear_sor_prox::NonlinearSORProx` [INFO] [stderr] --> src/solver/nonlinear_sor_prox.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn new() -> Self { [INFO] [stderr] 21 | | NonlinearSORProx { [INFO] [stderr] 22 | | _phantom: PhantomData, [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/solver/nonlinear_sor_prox.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn solve( [INFO] [stderr] 28 | | &self, [INFO] [stderr] 29 | | params: &IntegrationParameters, [INFO] [stderr] 30 | | bodies: &mut BodySet, [INFO] [stderr] ... | [INFO] [stderr] 52 | | } [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/solver/signorini_coulomb_pyramid_model.rs:97:17 [INFO] [stderr] | [INFO] [stderr] 97 | / let dependency; [INFO] [stderr] 98 | | [INFO] [stderr] 99 | | if ground_constraint { [INFO] [stderr] 100 | | let constraints = &constraints.velocity.unilateral_ground; [INFO] [stderr] ... | [INFO] [stderr] 104 | | dependency = constraints.len() - 1; [INFO] [stderr] 105 | | } [INFO] [stderr] | |_________________^ help: it is more idiomatic to write: `let dependency = if ground_constraint { ..; constraints.len() - 1 } else { ..; constraints.len() - 1 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `solver::signorini_model::SignoriniModel` [INFO] [stderr] --> src/solver/signorini_model.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn new() -> Self { [INFO] [stderr] 24 | | SignoriniModel { [INFO] [stderr] 25 | | impulses: ImpulseCache::new(), [INFO] [stderr] 26 | | vel_ground_rng: 0..0, [INFO] [stderr] 27 | | vel_rng: 0..0, [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | impl Default for solver::signorini_model::SignoriniModel { [INFO] [stderr] 22 | fn default() -> Self { [INFO] [stderr] 23 | Self::new() [INFO] [stderr] 24 | } [INFO] [stderr] 25 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/solver/signorini_model.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / pub fn build_velocity_constraint( [INFO] [stderr] 33 | | params: &IntegrationParameters, [INFO] [stderr] 34 | | bodies: &BodySet, [INFO] [stderr] 35 | | manifold: &ColliderContactManifold, [INFO] [stderr] ... | [INFO] [stderr] 127 | | } [INFO] [stderr] 128 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/algebra/velocity2.rs:74:18 [INFO] [stderr] | [INFO] [stderr] 74 | unsafe { mem::transmute(self) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&*(self as *const algebra::velocity2::Velocity2 as *const na::Matrix>)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/algebra/velocity2.rs:82:18 [INFO] [stderr] | [INFO] [stderr] 82 | unsafe { mem::transmute(self) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(self as *mut algebra::velocity2::Velocity2 as *mut na::Matrix>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `solver::sor_prox::SORProx` [INFO] [stderr] --> src/solver/sor_prox.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> Self { [INFO] [stderr] 19 | | SORProx { [INFO] [stderr] 20 | | _phantom: PhantomData, [INFO] [stderr] 21 | | } [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/solver/sor_prox.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / pub fn solve( [INFO] [stderr] 26 | | &self, [INFO] [stderr] 27 | | unilateral_ground: &mut [UnilateralGroundConstraint], [INFO] [stderr] 28 | | unilateral: &mut [UnilateralConstraint], [INFO] [stderr] ... | [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/algebra/velocity3.rs:73:18 [INFO] [stderr] | [INFO] [stderr] 73 | unsafe { mem::transmute(self) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&*(self as *const algebra::velocity3::Velocity3 as *const na::Matrix>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/algebra/velocity3.rs:80:18 [INFO] [stderr] | [INFO] [stderr] 80 | unsafe { mem::transmute(self) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(self as *mut algebra::velocity3::Velocity3 as *mut na::Matrix>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/algebra/force2.rs:96:18 [INFO] [stderr] | [INFO] [stderr] 96 | unsafe { mem::transmute(self) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&*(self as *const algebra::force2::Force2 as *const na::Matrix>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/algebra/force2.rs:104:18 [INFO] [stderr] | [INFO] [stderr] 104 | unsafe { mem::transmute(self) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(self as *mut algebra::force2::Force2 as *mut na::Matrix>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/algebra/force3.rs:102:18 [INFO] [stderr] | [INFO] [stderr] 102 | unsafe { mem::transmute(self) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&*(self as *const algebra::force3::Force3 as *const na::Matrix>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/algebra/force3.rs:110:18 [INFO] [stderr] | [INFO] [stderr] 110 | unsafe { mem::transmute(self) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(self as *mut algebra::force3::Force3 as *mut na::Matrix>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/algebra/inertia2.rs:40:18 [INFO] [stderr] | [INFO] [stderr] 40 | unsafe { mem::transmute(&self.angular) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self.angular as *const N as *const na::Matrix>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: item `detection::collider_contact_manifold::ColliderContactManifold<'a, N>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/detection/collider_contact_manifold.rs:32:1 [INFO] [stderr] | [INFO] [stderr] 32 | / impl<'a, N: Real> ColliderContactManifold<'a, N> { [INFO] [stderr] 33 | | /// Initialize a new contact manifold. [INFO] [stderr] 34 | | pub fn new( [INFO] [stderr] 35 | | collider1: &'a Collider, [INFO] [stderr] ... | [INFO] [stderr] 89 | | } [INFO] [stderr] 90 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/joint/joint.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / fn velocity_constraints( [INFO] [stderr] 60 | | &self, [INFO] [stderr] 61 | | _params: &IntegrationParameters, [INFO] [stderr] 62 | | _link: &MultibodyLinkRef, [INFO] [stderr] ... | [INFO] [stderr] 69 | | ) { [INFO] [stderr] 70 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/joint/joint.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / fn velocity_constraints( [INFO] [stderr] 60 | | &self, [INFO] [stderr] 61 | | _params: &IntegrationParameters, [INFO] [stderr] 62 | | _link: &MultibodyLinkRef, [INFO] [stderr] ... | [INFO] [stderr] 69 | | ) { [INFO] [stderr] 70 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/joint/unit_joint.rs:46:1 [INFO] [stderr] | [INFO] [stderr] 46 | / pub fn unit_joint_velocity_constraints>( [INFO] [stderr] 47 | | joint: &J, [INFO] [stderr] 48 | | params: &IntegrationParameters, [INFO] [stderr] 49 | | link: &MultibodyLinkRef, [INFO] [stderr] ... | [INFO] [stderr] 159 | | } [INFO] [stderr] 160 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/joint/joint_constraint.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / fn velocity_constraints( [INFO] [stderr] 34 | | &mut self, [INFO] [stderr] 35 | | params: &IntegrationParameters, [INFO] [stderr] 36 | | bodies: &BodySet, [INFO] [stderr] ... | [INFO] [stderr] 41 | | velocity_constraints: &mut ConstraintSet, [INFO] [stderr] 42 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (16/7) [INFO] [stderr] --> src/joint/unit_constraint.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / pub fn build_linear_limits_velocity_constraint( [INFO] [stderr] 9 | | body1: &BodyPart, [INFO] [stderr] 10 | | body2: &BodyPart, [INFO] [stderr] 11 | | assembly_id1: usize, [INFO] [stderr] ... | [INFO] [stderr] 125 | | } [INFO] [stderr] 126 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/joint/unit_constraint.rs:128:1 [INFO] [stderr] | [INFO] [stderr] 128 | / pub fn build_linear_limits_position_constraint( [INFO] [stderr] 129 | | params: &IntegrationParameters, [INFO] [stderr] 130 | | body1: &BodyPart, [INFO] [stderr] 131 | | body2: &BodyPart, [INFO] [stderr] ... | [INFO] [stderr] 186 | | } [INFO] [stderr] 187 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: item `object::body_set::BodySet` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/object/body_set.rs:76:1 [INFO] [stderr] | [INFO] [stderr] 76 | / impl BodySet { [INFO] [stderr] 77 | | /// Create a new empty set of bodies. [INFO] [stderr] 78 | | pub fn new() -> Self { [INFO] [stderr] 79 | | BodySet { [INFO] [stderr] ... | [INFO] [stderr] 474 | | } [INFO] [stderr] 475 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/object/multibody.rs:249:5 [INFO] [stderr] | [INFO] [stderr] 249 | / pub(crate) fn add_link>( [INFO] [stderr] 250 | | &mut self, [INFO] [stderr] 251 | | handle: BodyHandle, [INFO] [stderr] 252 | | parent: MultibodyLinkId, [INFO] [stderr] ... | [INFO] [stderr] 318 | | MultibodyLinkMut::new(MultibodyLinkId::new(internal_id), self) [INFO] [stderr] 319 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/object/multibody_link.rs:30:20 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn is_root(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/object/multibody_link.rs:35:22 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn is_ground(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/object/multibody_link.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | / pub fn new( [INFO] [stderr] 73 | | handle: BodyHandle, [INFO] [stderr] 74 | | assembly_id: usize, [INFO] [stderr] 75 | | impulse_id: usize, [INFO] [stderr] ... | [INFO] [stderr] 114 | | } [INFO] [stderr] 115 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: item `solver::constraint_set::ConstraintSet` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/solver/constraint_set.rs:88:1 [INFO] [stderr] | [INFO] [stderr] 88 | / impl ConstraintSet { [INFO] [stderr] 89 | | /// Create a new empty set of constraints. [INFO] [stderr] 90 | | pub fn new() -> Self { [INFO] [stderr] 91 | | ConstraintSet { [INFO] [stderr] ... | [INFO] [stderr] 106 | | } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/solver/contact_model.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / fn constraints( [INFO] [stderr] 16 | | &mut self, [INFO] [stderr] 17 | | params: &IntegrationParameters, [INFO] [stderr] 18 | | bodies: &BodySet, [INFO] [stderr] ... | [INFO] [stderr] 24 | | constraints: &mut ConstraintSet, [INFO] [stderr] 25 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/solver/helper.rs:43:1 [INFO] [stderr] | [INFO] [stderr] 43 | / pub fn fill_constraint_geometry( [INFO] [stderr] 44 | | body: &BodyPart, [INFO] [stderr] 45 | | ndofs: usize, [INFO] [stderr] 46 | | center: &Point, [INFO] [stderr] ... | [INFO] [stderr] 76 | | *inv_r += j.dot(&invm_j); [INFO] [stderr] 77 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/solver/helper.rs:85:1 [INFO] [stderr] | [INFO] [stderr] 85 | / pub fn constraint_pair_geometry( [INFO] [stderr] 86 | | body1: &BodyPart, [INFO] [stderr] 87 | | body2: &BodyPart, [INFO] [stderr] 88 | | center1: &Point, [INFO] [stderr] ... | [INFO] [stderr] 149 | | res [INFO] [stderr] 150 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/solver/helper.rs:156:1 [INFO] [stderr] | [INFO] [stderr] 156 | / pub fn constraint_pair_velocity( [INFO] [stderr] 157 | | body1: &BodyPart, [INFO] [stderr] 158 | | body2: &BodyPart, [INFO] [stderr] 159 | | assembly_id1: usize, [INFO] [stderr] ... | [INFO] [stderr] 208 | | vel [INFO] [stderr] 209 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (14/7) [INFO] [stderr] --> src/solver/helper.rs:224:1 [INFO] [stderr] | [INFO] [stderr] 224 | / pub fn cancel_relative_linear_velocity_wrt_axis( [INFO] [stderr] 225 | | body1: &BodyPart, [INFO] [stderr] 226 | | body2: &BodyPart, [INFO] [stderr] 227 | | assembly_id1: usize, [INFO] [stderr] ... | [INFO] [stderr] 296 | | } [INFO] [stderr] 297 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (13/7) [INFO] [stderr] --> src/solver/helper.rs:302:1 [INFO] [stderr] | [INFO] [stderr] 302 | / pub fn cancel_relative_linear_velocity( [INFO] [stderr] 303 | | body1: &BodyPart, [INFO] [stderr] 304 | | body2: &BodyPart, [INFO] [stderr] 305 | | assembly_id1: usize, [INFO] [stderr] ... | [INFO] [stderr] 339 | | }); [INFO] [stderr] 340 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (14/7) [INFO] [stderr] --> src/solver/helper.rs:447:1 [INFO] [stderr] | [INFO] [stderr] 447 | / pub fn cancel_relative_angular_velocity_wrt_axis( [INFO] [stderr] 448 | | body1: &BodyPart, [INFO] [stderr] 449 | | body2: &BodyPart, [INFO] [stderr] 450 | | assembly_id1: usize, [INFO] [stderr] ... | [INFO] [stderr] 519 | | } [INFO] [stderr] 520 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (13/7) [INFO] [stderr] --> src/solver/helper.rs:525:1 [INFO] [stderr] | [INFO] [stderr] 525 | / pub fn cancel_relative_angular_velocity( [INFO] [stderr] 526 | | body1: &BodyPart, [INFO] [stderr] 527 | | body2: &BodyPart, [INFO] [stderr] 528 | | assembly_id1: usize, [INFO] [stderr] ... | [INFO] [stderr] 562 | | }); [INFO] [stderr] 563 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/solver/helper.rs:568:1 [INFO] [stderr] | [INFO] [stderr] 568 | / pub fn cancel_relative_rotation( [INFO] [stderr] 569 | | params: &IntegrationParameters, [INFO] [stderr] 570 | | body1: &BodyPart, [INFO] [stderr] 571 | | body2: &BodyPart, [INFO] [stderr] ... | [INFO] [stderr] 611 | | } [INFO] [stderr] 612 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (14/7) [INFO] [stderr] --> src/solver/helper.rs:763:1 [INFO] [stderr] | [INFO] [stderr] 763 | / pub fn restrict_relative_linear_velocity_to_axis( [INFO] [stderr] 764 | | body1: &BodyPart, [INFO] [stderr] 765 | | body2: &BodyPart, [INFO] [stderr] 766 | | assembly_id1: usize, [INFO] [stderr] ... | [INFO] [stderr] 842 | | }); [INFO] [stderr] 843 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/solver/integration_parameters.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | / pub fn new( [INFO] [stderr] 38 | | dt: N, [INFO] [stderr] 39 | | erp: N, [INFO] [stderr] 40 | | warmstart_coeff: N, [INFO] [stderr] ... | [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/solver/nonlinear_constraint.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn new( [INFO] [stderr] 34 | | body1: BodyHandle, [INFO] [stderr] 35 | | body2: BodyHandle, [INFO] [stderr] 36 | | is_angular: bool, [INFO] [stderr] ... | [INFO] [stderr] 54 | | } [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `solver::nonlinear_sor_prox::NonlinearSORProx` [INFO] [stderr] --> src/solver/nonlinear_sor_prox.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn new() -> Self { [INFO] [stderr] 21 | | NonlinearSORProx { [INFO] [stderr] 22 | | _phantom: PhantomData, [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/solver/nonlinear_sor_prox.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn solve( [INFO] [stderr] 28 | | &self, [INFO] [stderr] 29 | | params: &IntegrationParameters, [INFO] [stderr] 30 | | bodies: &mut BodySet, [INFO] [stderr] ... | [INFO] [stderr] 52 | | } [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/solver/signorini_coulomb_pyramid_model.rs:97:17 [INFO] [stderr] | [INFO] [stderr] 97 | / let dependency; [INFO] [stderr] 98 | | [INFO] [stderr] 99 | | if ground_constraint { [INFO] [stderr] 100 | | let constraints = &constraints.velocity.unilateral_ground; [INFO] [stderr] ... | [INFO] [stderr] 104 | | dependency = constraints.len() - 1; [INFO] [stderr] 105 | | } [INFO] [stderr] | |_________________^ help: it is more idiomatic to write: `let dependency = if ground_constraint { ..; constraints.len() - 1 } else { ..; constraints.len() - 1 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `solver::signorini_model::SignoriniModel` [INFO] [stderr] --> src/solver/signorini_model.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn new() -> Self { [INFO] [stderr] 24 | | SignoriniModel { [INFO] [stderr] 25 | | impulses: ImpulseCache::new(), [INFO] [stderr] 26 | | vel_ground_rng: 0..0, [INFO] [stderr] 27 | | vel_rng: 0..0, [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | impl Default for solver::signorini_model::SignoriniModel { [INFO] [stderr] 22 | fn default() -> Self { [INFO] [stderr] 23 | Self::new() [INFO] [stderr] 24 | } [INFO] [stderr] 25 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/solver/signorini_model.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / pub fn build_velocity_constraint( [INFO] [stderr] 33 | | params: &IntegrationParameters, [INFO] [stderr] 34 | | bodies: &BodySet, [INFO] [stderr] 35 | | manifold: &ColliderContactManifold, [INFO] [stderr] ... | [INFO] [stderr] 127 | | } [INFO] [stderr] 128 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `solver::sor_prox::SORProx` [INFO] [stderr] --> src/solver/sor_prox.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> Self { [INFO] [stderr] 19 | | SORProx { [INFO] [stderr] 20 | | _phantom: PhantomData, [INFO] [stderr] 21 | | } [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/solver/sor_prox.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / pub fn solve( [INFO] [stderr] 26 | | &self, [INFO] [stderr] 27 | | unilateral_ground: &mut [UnilateralGroundConstraint], [INFO] [stderr] 28 | | unilateral: &mut [UnilateralConstraint], [INFO] [stderr] ... | [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 56.02s [INFO] running `"docker" "inspect" "1ad921b3e680570a0bfd944e37cd940939545363c0e8d2dd182047f873bc5f49"` [INFO] running `"docker" "rm" "-f" "1ad921b3e680570a0bfd944e37cd940939545363c0e8d2dd182047f873bc5f49"` [INFO] [stdout] 1ad921b3e680570a0bfd944e37cd940939545363c0e8d2dd182047f873bc5f49