[INFO] crate notifier-rs 0.1.3 is already in cache [INFO] extracting crate notifier-rs 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/notifier-rs/0.1.3 [INFO] extracting crate notifier-rs 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/notifier-rs/0.1.3 [INFO] validating manifest of notifier-rs-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of notifier-rs-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing notifier-rs-0.1.3 [INFO] finished frobbing notifier-rs-0.1.3 [INFO] frobbed toml for notifier-rs-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/notifier-rs/0.1.3/Cargo.toml [INFO] started frobbing notifier-rs-0.1.3 [INFO] finished frobbing notifier-rs-0.1.3 [INFO] frobbed toml for notifier-rs-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/notifier-rs/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting notifier-rs-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/notifier-rs/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5fa68aaf7f3f6512fab72d83c7aef8c2857f4df0353e8fff4db7d941d9850dbb [INFO] running `"docker" "start" "-a" "5fa68aaf7f3f6512fab72d83c7aef8c2857f4df0353e8fff4db7d941d9850dbb"` [INFO] [stderr] Checking slack-hook v0.6.0 [INFO] [stderr] Checking notifier-rs v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `notification_service::NotificationService` [INFO] [stderr] --> src/notification_service.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / pub fn new() -> NotificationService { [INFO] [stderr] 10 | | NotificationService { [INFO] [stderr] 11 | | notifiers: Vec::new() [INFO] [stderr] 12 | | } [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/notification_service.rs:19:35 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn notify(&self, message: &String, notification_level: NotificationLevel) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/notifier.rs:4:31 [INFO] [stderr] | [INFO] [stderr] 4 | fn notify(&self, message: &String, notification_level: &NotificationLevel); [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/notifiers/slack_notifier.rs:11:29 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn new(webhook_url: &String) -> Result { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 11 | pub fn new(webhook_url: &str) -> Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `webhook_url.as_str()` to [INFO] [stderr] | [INFO] [stderr] 13 | slack: Slack::new(webhook_url)? [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/notifiers/slack_notifier.rs:27:32 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn notify(webhook_url: &String, message: &String, notification_level: NotificationLevel) { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 27 | pub fn notify(webhook_url: &str, message: &String, notification_level: NotificationLevel) { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `webhook_url.as_str()` to [INFO] [stderr] | [INFO] [stderr] 28 | let slack = match Slack::new(webhook_url) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/notifiers/slack_notifier.rs:27:50 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn notify(webhook_url: &String, message: &String, notification_level: NotificationLevel) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/notifiers/slack_notifier.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | / match slack.send(&p) { [INFO] [stderr] 49 | | Err(e) => println!("notifier-rs error: {:?}", e), [INFO] [stderr] 50 | | _ => {} [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = slack.send(&p) { println!("notifier-rs error: {:?}", e) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/notifiers/slack_notifier.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | / match self.slack.send(&p) { [INFO] [stderr] 73 | | Err(e) => println!("notifier-rs error: {:?}", e), [INFO] [stderr] 74 | | _ => {} [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = self.slack.send(&p) { println!("notifier-rs error: {:?}", e) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `notification_service::NotificationService` [INFO] [stderr] --> src/notification_service.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / pub fn new() -> NotificationService { [INFO] [stderr] 10 | | NotificationService { [INFO] [stderr] 11 | | notifiers: Vec::new() [INFO] [stderr] 12 | | } [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/notification_service.rs:19:35 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn notify(&self, message: &String, notification_level: NotificationLevel) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/notifier.rs:4:31 [INFO] [stderr] | [INFO] [stderr] 4 | fn notify(&self, message: &String, notification_level: &NotificationLevel); [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/notifiers/slack_notifier.rs:11:29 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn new(webhook_url: &String) -> Result { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 11 | pub fn new(webhook_url: &str) -> Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `webhook_url.as_str()` to [INFO] [stderr] | [INFO] [stderr] 13 | slack: Slack::new(webhook_url)? [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/notifiers/slack_notifier.rs:27:32 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn notify(webhook_url: &String, message: &String, notification_level: NotificationLevel) { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 27 | pub fn notify(webhook_url: &str, message: &String, notification_level: NotificationLevel) { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `webhook_url.as_str()` to [INFO] [stderr] | [INFO] [stderr] 28 | let slack = match Slack::new(webhook_url) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/notifiers/slack_notifier.rs:27:50 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn notify(webhook_url: &String, message: &String, notification_level: NotificationLevel) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/notifiers/slack_notifier.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | / match slack.send(&p) { [INFO] [stderr] 49 | | Err(e) => println!("notifier-rs error: {:?}", e), [INFO] [stderr] 50 | | _ => {} [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = slack.send(&p) { println!("notifier-rs error: {:?}", e) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/notifiers/slack_notifier.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | / match self.slack.send(&p) { [INFO] [stderr] 73 | | Err(e) => println!("notifier-rs error: {:?}", e), [INFO] [stderr] 74 | | _ => {} [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = self.slack.send(&p) { println!("notifier-rs error: {:?}", e) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 15.75s [INFO] running `"docker" "inspect" "5fa68aaf7f3f6512fab72d83c7aef8c2857f4df0353e8fff4db7d941d9850dbb"` [INFO] running `"docker" "rm" "-f" "5fa68aaf7f3f6512fab72d83c7aef8c2857f4df0353e8fff4db7d941d9850dbb"` [INFO] [stdout] 5fa68aaf7f3f6512fab72d83c7aef8c2857f4df0353e8fff4db7d941d9850dbb