[INFO] crate noteref 0.9.1 is already in cache [INFO] extracting crate noteref 0.9.1 into work/ex/clippy-test-run/sources/stable/reg/noteref/0.9.1 [INFO] extracting crate noteref 0.9.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/noteref/0.9.1 [INFO] validating manifest of noteref-0.9.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of noteref-0.9.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing noteref-0.9.1 [INFO] finished frobbing noteref-0.9.1 [INFO] frobbed toml for noteref-0.9.1 written to work/ex/clippy-test-run/sources/stable/reg/noteref/0.9.1/Cargo.toml [INFO] started frobbing noteref-0.9.1 [INFO] finished frobbing noteref-0.9.1 [INFO] frobbed toml for noteref-0.9.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/noteref/0.9.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting noteref-0.9.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/noteref/0.9.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 64058a9e4fda78f2901acca1fc9dc9e25b37b78d4714394edf69526d60a393cd [INFO] running `"docker" "start" "-a" "64058a9e4fda78f2901acca1fc9dc9e25b37b78d4714394edf69526d60a393cd"` [INFO] [stderr] Checking ignore v0.4.6 [INFO] [stderr] Checking noteref v0.9.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tag.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | tag_type: tag_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `tag_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tag.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | line_number: line_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tag.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | tag_type: tag_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `tag_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tag.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | line_number: line_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/citations.rs:7:15 [INFO] [stderr] | [INFO] [stderr] 7 | references: &Vec [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[super::tag::Tag]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/walk.rs:19:18 [INFO] [stderr] | [INFO] [stderr] 19 | if let Ok(_) = file.read_to_string(&mut contents) { [INFO] [stderr] | ___________- ^^^^^ [INFO] [stderr] 20 | | files_scanned += 1; [INFO] [stderr] 21 | | callback( [INFO] [stderr] 22 | | &dir_entry.path().to_string_lossy().into_owned(), [INFO] [stderr] 23 | | &contents [INFO] [stderr] 24 | | ); [INFO] [stderr] 25 | | } [INFO] [stderr] | |___________- help: try this: `if file.read_to_string(&mut contents).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/main.rs:82:26 [INFO] [stderr] | [INFO] [stderr] 82 | for (_, note) in ¬es { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 82 | for note in notes.values() { [INFO] [stderr] | ^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:114:30 [INFO] [stderr] | [INFO] [stderr] 114 | count::count(notes.len().into(), "note"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `notes.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:115:30 [INFO] [stderr] | [INFO] [stderr] 115 | count::count(references.len().into(), "reference"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `references.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/citations.rs:7:15 [INFO] [stderr] | [INFO] [stderr] 7 | references: &Vec [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[super::tag::Tag]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/citations.rs:110:33 [INFO] [stderr] | [INFO] [stderr] 110 | assert!(error.contains(&format!("{}", references[1].label))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `references[1].label.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/walk.rs:19:18 [INFO] [stderr] | [INFO] [stderr] 19 | if let Ok(_) = file.read_to_string(&mut contents) { [INFO] [stderr] | ___________- ^^^^^ [INFO] [stderr] 20 | | files_scanned += 1; [INFO] [stderr] 21 | | callback( [INFO] [stderr] 22 | | &dir_entry.path().to_string_lossy().into_owned(), [INFO] [stderr] 23 | | &contents [INFO] [stderr] 24 | | ); [INFO] [stderr] 25 | | } [INFO] [stderr] | |___________- help: try this: `if file.read_to_string(&mut contents).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/main.rs:82:26 [INFO] [stderr] | [INFO] [stderr] 82 | for (_, note) in ¬es { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 82 | for note in notes.values() { [INFO] [stderr] | ^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:114:30 [INFO] [stderr] | [INFO] [stderr] 114 | count::count(notes.len().into(), "note"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `notes.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:115:30 [INFO] [stderr] | [INFO] [stderr] 115 | count::count(references.len().into(), "reference"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `references.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.40s [INFO] running `"docker" "inspect" "64058a9e4fda78f2901acca1fc9dc9e25b37b78d4714394edf69526d60a393cd"` [INFO] running `"docker" "rm" "-f" "64058a9e4fda78f2901acca1fc9dc9e25b37b78d4714394edf69526d60a393cd"` [INFO] [stdout] 64058a9e4fda78f2901acca1fc9dc9e25b37b78d4714394edf69526d60a393cd