[INFO] crate noframe 0.0.2 is already in cache [INFO] extracting crate noframe 0.0.2 into work/ex/clippy-test-run/sources/stable/reg/noframe/0.0.2 [INFO] extracting crate noframe 0.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/noframe/0.0.2 [INFO] validating manifest of noframe-0.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of noframe-0.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing noframe-0.0.2 [INFO] finished frobbing noframe-0.0.2 [INFO] frobbed toml for noframe-0.0.2 written to work/ex/clippy-test-run/sources/stable/reg/noframe/0.0.2/Cargo.toml [INFO] started frobbing noframe-0.0.2 [INFO] finished frobbing noframe-0.0.2 [INFO] frobbed toml for noframe-0.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/noframe/0.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting noframe-0.0.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/noframe/0.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 75824b1705499e6cb652cc15b0c04c9a1e71ebc01180f52263bdc5ac67601378 [INFO] running `"docker" "start" "-a" "75824b1705499e6cb652cc15b0c04c9a1e71ebc01180f52263bdc5ac67601378"` [INFO] [stderr] Checking app_dirs2 v2.0.3 [INFO] [stderr] Checking ogg v0.4.1 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking alsa-sys v0.1.2 [INFO] [stderr] Checking lyon_geom v0.10.1 [INFO] [stderr] Checking rusttype v0.5.2 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking nalgebra v0.14.4 [INFO] [stderr] Checking zip v0.3.3 [INFO] [stderr] Checking gfx_core v0.8.3 [INFO] [stderr] Checking sdl2 v0.31.0 [INFO] [stderr] Checking lewton v0.5.2 [INFO] [stderr] Checking cpal v0.8.2 [INFO] [stderr] Checking lyon_path v0.10.1 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking lyon_tessellation v0.10.2 [INFO] [stderr] Checking rodio v0.7.0 [INFO] [stderr] Checking lyon v0.10.2 [INFO] [stderr] Checking gfx_device_gl v0.15.5 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_window_sdl v0.8.0 [INFO] [stderr] Checking gfx_glyph v0.10.2 [INFO] [stderr] Checking ggez v0.4.4 [INFO] [stderr] Checking noframe v0.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geo/point/mod.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | return point_acc; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `point_acc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geo/mask/mod.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / return ( [INFO] [stderr] 19 | | ( [INFO] [stderr] 20 | | sides_one.left >= sides_two.left && [INFO] [stderr] 21 | | sides_one.left < sides_two.right [INFO] [stderr] ... | [INFO] [stderr] 33 | | ) [INFO] [stderr] 34 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 18 | ( [INFO] [stderr] 19 | ( [INFO] [stderr] 20 | sides_one.left >= sides_two.left && [INFO] [stderr] 21 | sides_one.left < sides_two.right [INFO] [stderr] 22 | ) || ( [INFO] [stderr] 23 | sides_one.left <= sides_two.left && [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geo/mask/mod.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | / return match side { [INFO] [stderr] 106 | | Top => top_left.y, [INFO] [stderr] 107 | | Bottom => top_left.y + self.size().h, [INFO] [stderr] 108 | | Left => top_left.x, [INFO] [stderr] 109 | | Right => top_left.x + self.size().w [INFO] [stderr] 110 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 105 | match side { [INFO] [stderr] 106 | Top => top_left.y, [INFO] [stderr] 107 | Bottom => top_left.y + self.size().h, [INFO] [stderr] 108 | Left => top_left.x, [INFO] [stderr] 109 | Right => top_left.x + self.size().w [INFO] [stderr] 110 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/entity/traits/movement.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | return position; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/entity/mod.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | return graphics::rectangle(ctx, graphics::DrawMode::Fill, rect.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `graphics::rectangle(ctx, graphics::DrawMode::Fill, rect.into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/entity/mod.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | return self.draw_rect(ctx, rect); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.draw_rect(ctx, rect)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/entity/mod.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | return self.draw_rect(ctx, rect); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.draw_rect(ctx, rect)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/input_manager/mod.rs:55:24 [INFO] [stderr] | [INFO] [stderr] 55 | if repeat { return (); } [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geo/point/mod.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | return point_acc; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `point_acc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geo/mask/mod.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / return ( [INFO] [stderr] 19 | | ( [INFO] [stderr] 20 | | sides_one.left >= sides_two.left && [INFO] [stderr] 21 | | sides_one.left < sides_two.right [INFO] [stderr] ... | [INFO] [stderr] 33 | | ) [INFO] [stderr] 34 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 18 | ( [INFO] [stderr] 19 | ( [INFO] [stderr] 20 | sides_one.left >= sides_two.left && [INFO] [stderr] 21 | sides_one.left < sides_two.right [INFO] [stderr] 22 | ) || ( [INFO] [stderr] 23 | sides_one.left <= sides_two.left && [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geo/mask/mod.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | / return match side { [INFO] [stderr] 106 | | Top => top_left.y, [INFO] [stderr] 107 | | Bottom => top_left.y + self.size().h, [INFO] [stderr] 108 | | Left => top_left.x, [INFO] [stderr] 109 | | Right => top_left.x + self.size().w [INFO] [stderr] 110 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 105 | match side { [INFO] [stderr] 106 | Top => top_left.y, [INFO] [stderr] 107 | Bottom => top_left.y + self.size().h, [INFO] [stderr] 108 | Left => top_left.x, [INFO] [stderr] 109 | Right => top_left.x + self.size().w [INFO] [stderr] 110 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/entity/traits/movement.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | return position; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/entity/mod.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | return graphics::rectangle(ctx, graphics::DrawMode::Fill, rect.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `graphics::rectangle(ctx, graphics::DrawMode::Fill, rect.into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/entity/mod.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | return self.draw_rect(ctx, rect); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.draw_rect(ctx, rect)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/entity/mod.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | return self.draw_rect(ctx, rect); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.draw_rect(ctx, rect)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/input_manager/mod.rs:55:24 [INFO] [stderr] | [INFO] [stderr] 55 | if repeat { return (); } [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/input_manager/mod.rs:63:63 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn add_mouse_down(&mut self, mouse_button: MouseButton, x: i32, y: i32) { [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y` [INFO] [stderr] --> src/input_manager/mod.rs:63:71 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn add_mouse_down(&mut self, mouse_button: MouseButton, x: i32, y: i32) { [INFO] [stderr] | ^ help: consider using `_y` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/input_manager/mod.rs:67:61 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn add_mouse_up(&mut self, mouse_button: MouseButton, x: i32, y: i32) { [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y` [INFO] [stderr] --> src/input_manager/mod.rs:67:69 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn add_mouse_up(&mut self, mouse_button: MouseButton, x: i32, y: i32) { [INFO] [stderr] | ^ help: consider using `_y` instead [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/entity/traits/velocity.rs:58:12 [INFO] [stderr] | [INFO] [stderr] 58 | if velocity.x.signum() == new_x.signum() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(velocity.x.signum() - new_x.signum()).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/entity/traits/velocity.rs:58:12 [INFO] [stderr] | [INFO] [stderr] 58 | if velocity.x.signum() == new_x.signum() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/entity/traits/velocity.rs:63:12 [INFO] [stderr] | [INFO] [stderr] 63 | if velocity.y.signum() == new_y.signum() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(velocity.y.signum() - new_y.signum()).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/entity/traits/velocity.rs:63:12 [INFO] [stderr] | [INFO] [stderr] 63 | if velocity.y.signum() == new_y.signum() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/entity/traits/movement.rs:45:34 [INFO] [stderr] | [INFO] [stderr] 45 | Step::X(pol) => Point::new(pol.sign() as NumType, 0.0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(pol.sign())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/entity/traits/movement.rs:46:39 [INFO] [stderr] | [INFO] [stderr] 46 | Step::Y(pol) => Point::new(0.0, pol.sign() as NumType) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(pol.sign())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `input_manager::InputManager` [INFO] [stderr] --> src/input_manager/mod.rs:16:3 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new() -> Self { [INFO] [stderr] 17 | | Self { [INFO] [stderr] 18 | | keys_down: Vec::new(), [INFO] [stderr] 19 | | keys_up: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/input_manager/mod.rs:63:63 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn add_mouse_down(&mut self, mouse_button: MouseButton, x: i32, y: i32) { [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y` [INFO] [stderr] --> src/input_manager/mod.rs:63:71 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn add_mouse_down(&mut self, mouse_button: MouseButton, x: i32, y: i32) { [INFO] [stderr] | ^ help: consider using `_y` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/input_manager/mod.rs:67:61 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn add_mouse_up(&mut self, mouse_button: MouseButton, x: i32, y: i32) { [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y` [INFO] [stderr] --> src/input_manager/mod.rs:67:69 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn add_mouse_up(&mut self, mouse_button: MouseButton, x: i32, y: i32) { [INFO] [stderr] | ^ help: consider using `_y` instead [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `deltatime::Deltatime` [INFO] [stderr] --> src/deltatime.rs:13:3 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> Self { [INFO] [stderr] 14 | | Self { [INFO] [stderr] 15 | | value: Duration::new(0, 0), [INFO] [stderr] 16 | | last_update: Instant::now() [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | impl Default for deltatime::Deltatime { [INFO] [stderr] 13 | fn default() -> Self { [INFO] [stderr] 14 | Self::new() [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `noframe`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/entity/traits/velocity.rs:58:12 [INFO] [stderr] | [INFO] [stderr] 58 | if velocity.x.signum() == new_x.signum() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(velocity.x.signum() - new_x.signum()).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/entity/traits/velocity.rs:58:12 [INFO] [stderr] | [INFO] [stderr] 58 | if velocity.x.signum() == new_x.signum() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/entity/traits/velocity.rs:63:12 [INFO] [stderr] | [INFO] [stderr] 63 | if velocity.y.signum() == new_y.signum() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(velocity.y.signum() - new_y.signum()).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/entity/traits/velocity.rs:63:12 [INFO] [stderr] | [INFO] [stderr] 63 | if velocity.y.signum() == new_y.signum() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/entity/traits/movement.rs:45:34 [INFO] [stderr] | [INFO] [stderr] 45 | Step::X(pol) => Point::new(pol.sign() as NumType, 0.0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(pol.sign())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/entity/traits/movement.rs:46:39 [INFO] [stderr] | [INFO] [stderr] 46 | Step::Y(pol) => Point::new(0.0, pol.sign() as NumType) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(pol.sign())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `input_manager::InputManager` [INFO] [stderr] --> src/input_manager/mod.rs:16:3 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new() -> Self { [INFO] [stderr] 17 | | Self { [INFO] [stderr] 18 | | keys_down: Vec::new(), [INFO] [stderr] 19 | | keys_up: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `deltatime::Deltatime` [INFO] [stderr] --> src/deltatime.rs:13:3 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> Self { [INFO] [stderr] 14 | | Self { [INFO] [stderr] 15 | | value: Duration::new(0, 0), [INFO] [stderr] 16 | | last_update: Instant::now() [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | impl Default for deltatime::Deltatime { [INFO] [stderr] 13 | fn default() -> Self { [INFO] [stderr] 14 | Self::new() [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `noframe`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "75824b1705499e6cb652cc15b0c04c9a1e71ebc01180f52263bdc5ac67601378"` [INFO] running `"docker" "rm" "-f" "75824b1705499e6cb652cc15b0c04c9a1e71ebc01180f52263bdc5ac67601378"` [INFO] [stdout] 75824b1705499e6cb652cc15b0c04c9a1e71ebc01180f52263bdc5ac67601378