[INFO] crate noders 0.0.2 is already in cache [INFO] extracting crate noders 0.0.2 into work/ex/clippy-test-run/sources/stable/reg/noders/0.0.2 [INFO] extracting crate noders 0.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/noders/0.0.2 [INFO] validating manifest of noders-0.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of noders-0.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing noders-0.0.2 [INFO] finished frobbing noders-0.0.2 [INFO] frobbed toml for noders-0.0.2 written to work/ex/clippy-test-run/sources/stable/reg/noders/0.0.2/Cargo.toml [INFO] started frobbing noders-0.0.2 [INFO] finished frobbing noders-0.0.2 [INFO] frobbed toml for noders-0.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/noders/0.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting noders-0.0.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/noders/0.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0c10bd9a2944a1261ecaf2b867841a152991c2875d94f454770239b7a5221718 [INFO] running `"docker" "start" "-a" "0c10bd9a2944a1261ecaf2b867841a152991c2875d94f454770239b7a5221718"` [INFO] [stderr] Checking mio-extras v2.0.5 [INFO] [stderr] Checking noders v0.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:174:29 [INFO] [stderr] | [INFO] [stderr] 174 | let tcb = TimerCb { cb: cb, interval, millis, id: id.clone() }; [INFO] [stderr] | ^^^^^^ help: replace it with: `cb` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:430:13 [INFO] [stderr] | [INFO] [stderr] 430 | poll: poll, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `poll` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/callback.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | dispatch: dispatch::, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dispatch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:174:29 [INFO] [stderr] | [INFO] [stderr] 174 | let tcb = TimerCb { cb: cb, interval, millis, id: id.clone() }; [INFO] [stderr] | ^^^^^^ help: replace it with: `cb` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:430:13 [INFO] [stderr] | [INFO] [stderr] 430 | poll: poll, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `poll` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/callback.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | dispatch: dispatch::, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dispatch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:358:5 [INFO] [stderr] | [INFO] [stderr] 358 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:358:5 [INFO] [stderr] | [INFO] [stderr] 358 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/node.rs:82:32 [INFO] [stderr] | [INFO] [stderr] 82 | dur = Some(time.clone() - self.now); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*time` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: for loop over `x`, which is an `Option`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/node.rs:89:23 [INFO] [stderr] | [INFO] [stderr] 89 | for xx in x { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::for_loop_over_option)] on by default [INFO] [stderr] = help: consider replacing `for xx in x` with `if let Some(xx) = x` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/node.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | / match {match self.next_timeouts.get_mut(&when) { [INFO] [stderr] 104 | | Some(x) => { x.push(t); None }, [INFO] [stderr] 105 | | None => Some(t) [INFO] [stderr] 106 | | }} { [INFO] [stderr] 107 | | Some(x) => { self.next_timeouts.insert(when, vec![x]); } [INFO] [stderr] 108 | | None => () [INFO] [stderr] 109 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 103 | if let Some(x) = {match self.next_timeouts.get_mut(&when) { [INFO] [stderr] 104 | Some(x) => { x.push(t); None }, [INFO] [stderr] 105 | None => Some(t) [INFO] [stderr] 106 | }} { self.next_timeouts.insert(when, vec![x]); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/node.rs:131:43 [INFO] [stderr] | [INFO] [stderr] 131 | fn deregister_event(&mut self, token: &Token) -> io::Result { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Token` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/node.rs:146:21 [INFO] [stderr] | [INFO] [stderr] 146 | / match { [INFO] [stderr] 147 | | match tos.iter().enumerate().find(|&x| x.1.id == *token) { [INFO] [stderr] 148 | | Some((i, _elem)) => Some(i), [INFO] [stderr] 149 | | None => None [INFO] [stderr] ... | [INFO] [stderr] 157 | | None => () [INFO] [stderr] 158 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 146 | if let Some(i) = { [INFO] [stderr] 147 | match tos.iter().enumerate().find(|&x| x.1.id == *token) { [INFO] [stderr] 148 | Some((i, _elem)) => Some(i), [INFO] [stderr] 149 | None => None [INFO] [stderr] 150 | } [INFO] [stderr] 151 | } { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/node.rs:154:68 [INFO] [stderr] | [INFO] [stderr] 154 | if tos.is_empty() { remove_time = Some(time.clone()); } [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/node.rs:174:59 [INFO] [stderr] | [INFO] [stderr] 174 | let tcb = TimerCb { cb: cb, interval, millis, id: id.clone() }; [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/node.rs:208:43 [INFO] [stderr] | [INFO] [stderr] 208 | pub fn deregister_event(&self, token: &Token) -> io::Result { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/node.rs:340:9 [INFO] [stderr] | [INFO] [stderr] 340 | / match w.handlers.get(&Token::from(ev.token())) { [INFO] [stderr] 341 | | Some(eh) => { eh.handler.call(()); } [INFO] [stderr] 342 | | None => () [INFO] [stderr] 343 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(eh) = w.handlers.get(&Token::from(ev.token())) { eh.handler.call(()); }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/node.rs:346:5 [INFO] [stderr] | [INFO] [stderr] 346 | / loop { [INFO] [stderr] 347 | | match w.callback_receiver.try_recv() { [INFO] [stderr] 348 | | Ok(cb) => { calls.push(cb) } [INFO] [stderr] 349 | | _ => break, [INFO] [stderr] 350 | | } [INFO] [stderr] 351 | | } [INFO] [stderr] | |_____^ help: try: `while let Ok(cb) = w.callback_receiver.try_recv() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/node.rs:352:8 [INFO] [stderr] | [INFO] [stderr] 352 | if calls.len() > 0 { return true; } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!calls.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/node.rs:354:45 [INFO] [stderr] | [INFO] [stderr] 354 | if 0 == w.event_count && dur == None && 0 == callback_by_id.len() { return false; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `callback_by_id.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/dgram.rs:97:69 [INFO] [stderr] | [INFO] [stderr] 97 | cb.call(Message { buf: buf.clone(), sa: sa.clone() }); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `sa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/node.rs:82:32 [INFO] [stderr] | [INFO] [stderr] 82 | dur = Some(time.clone() - self.now); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*time` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: for loop over `x`, which is an `Option`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/node.rs:89:23 [INFO] [stderr] | [INFO] [stderr] 89 | for xx in x { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::for_loop_over_option)] on by default [INFO] [stderr] = help: consider replacing `for xx in x` with `if let Some(xx) = x` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/node.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | / match {match self.next_timeouts.get_mut(&when) { [INFO] [stderr] 104 | | Some(x) => { x.push(t); None }, [INFO] [stderr] 105 | | None => Some(t) [INFO] [stderr] 106 | | }} { [INFO] [stderr] 107 | | Some(x) => { self.next_timeouts.insert(when, vec![x]); } [INFO] [stderr] 108 | | None => () [INFO] [stderr] 109 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 103 | if let Some(x) = {match self.next_timeouts.get_mut(&when) { [INFO] [stderr] 104 | Some(x) => { x.push(t); None }, [INFO] [stderr] 105 | None => Some(t) [INFO] [stderr] 106 | }} { self.next_timeouts.insert(when, vec![x]); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/node.rs:131:43 [INFO] [stderr] | [INFO] [stderr] 131 | fn deregister_event(&mut self, token: &Token) -> io::Result { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Token` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/node.rs:146:21 [INFO] [stderr] | [INFO] [stderr] 146 | / match { [INFO] [stderr] 147 | | match tos.iter().enumerate().find(|&x| x.1.id == *token) { [INFO] [stderr] 148 | | Some((i, _elem)) => Some(i), [INFO] [stderr] 149 | | None => None [INFO] [stderr] ... | [INFO] [stderr] 157 | | None => () [INFO] [stderr] 158 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 146 | if let Some(i) = { [INFO] [stderr] 147 | match tos.iter().enumerate().find(|&x| x.1.id == *token) { [INFO] [stderr] 148 | Some((i, _elem)) => Some(i), [INFO] [stderr] 149 | None => None [INFO] [stderr] 150 | } [INFO] [stderr] 151 | } { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/node.rs:154:68 [INFO] [stderr] | [INFO] [stderr] 154 | if tos.is_empty() { remove_time = Some(time.clone()); } [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/node.rs:174:59 [INFO] [stderr] | [INFO] [stderr] 174 | let tcb = TimerCb { cb: cb, interval, millis, id: id.clone() }; [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/node.rs:208:43 [INFO] [stderr] | [INFO] [stderr] 208 | pub fn deregister_event(&self, token: &Token) -> io::Result { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/node.rs:340:9 [INFO] [stderr] | [INFO] [stderr] 340 | / match w.handlers.get(&Token::from(ev.token())) { [INFO] [stderr] 341 | | Some(eh) => { eh.handler.call(()); } [INFO] [stderr] 342 | | None => () [INFO] [stderr] 343 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(eh) = w.handlers.get(&Token::from(ev.token())) { eh.handler.call(()); }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: Could not compile `noders`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/node.rs:346:5 [INFO] [stderr] | [INFO] [stderr] 346 | / loop { [INFO] [stderr] 347 | | match w.callback_receiver.try_recv() { [INFO] [stderr] 348 | | Ok(cb) => { calls.push(cb) } [INFO] [stderr] 349 | | _ => break, [INFO] [stderr] 350 | | } [INFO] [stderr] 351 | | } [INFO] [stderr] | |_____^ help: try: `while let Ok(cb) = w.callback_receiver.try_recv() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/node.rs:352:8 [INFO] [stderr] | [INFO] [stderr] 352 | if calls.len() > 0 { return true; } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!calls.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/node.rs:354:45 [INFO] [stderr] | [INFO] [stderr] 354 | if 0 == w.event_count && dur == None && 0 == callback_by_id.len() { return false; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `callback_by_id.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/dgram.rs:97:69 [INFO] [stderr] | [INFO] [stderr] 97 | cb.call(Message { buf: buf.clone(), sa: sa.clone() }); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `sa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `noders`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "0c10bd9a2944a1261ecaf2b867841a152991c2875d94f454770239b7a5221718"` [INFO] running `"docker" "rm" "-f" "0c10bd9a2944a1261ecaf2b867841a152991c2875d94f454770239b7a5221718"` [INFO] [stdout] 0c10bd9a2944a1261ecaf2b867841a152991c2875d94f454770239b7a5221718