[INFO] crate node_editor 0.0.3 is already in cache
[INFO] extracting crate node_editor 0.0.3 into work/ex/clippy-test-run/sources/stable/reg/node_editor/0.0.3
[INFO] extracting crate node_editor 0.0.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/node_editor/0.0.3
[INFO] validating manifest of node_editor-0.0.3 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of node_editor-0.0.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing node_editor-0.0.3
[INFO] finished frobbing node_editor-0.0.3
[INFO] frobbed toml for node_editor-0.0.3 written to work/ex/clippy-test-run/sources/stable/reg/node_editor/0.0.3/Cargo.toml
[INFO] started frobbing node_editor-0.0.3
[INFO] finished frobbing node_editor-0.0.3
[INFO] frobbed toml for node_editor-0.0.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/node_editor/0.0.3/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting node_editor-0.0.3 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/node_editor/0.0.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 29e91effb292240e7f4bc5633c375c16d15d875fe1e92fa0101338a89c876c3f
[INFO] running `"docker" "start" "-a" "29e91effb292240e7f4bc5633c375c16d15d875fe1e92fa0101338a89c876c3f"`
[INFO] [stderr]     Checking variant_name v0.0.1
[INFO] [stderr]     Checking boow v0.1.3
[INFO] [stderr]    Compiling imgui-sys v0.0.21
[INFO] [stderr]     Checking ron v0.2.2
[INFO] [stderr]     Checking aflak_cake v0.0.3
[INFO] [stderr]     Checking imgui v0.0.21
[INFO] [stderr]     Checking node_editor v0.0.3 (/opt/crater/workdir)
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/editor.rs:841:9
[INFO] [stderr]     |
[INFO] [stderr] 841 | /         if ui.is_item_hovered() {
[INFO] [stderr] 842 | |             if ui.imgui().is_mouse_clicked(ImMouseButton::Left) {
[INFO] [stderr] 843 | |                 self.active_node = Some(*id);
[INFO] [stderr] 844 | |                 self.drag_node = Some(*id);
[INFO] [stderr] ...   |
[INFO] [stderr] 849 | |             }
[INFO] [stderr] 850 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 841 |         if ui.is_item_hovered() && ui.imgui().is_mouse_clicked(ImMouseButton::Left) {
[INFO] [stderr] 842 |     self.active_node = Some(*id);
[INFO] [stderr] 843 |     self.drag_node = Some(*id);
[INFO] [stderr] 844 |     if !ui.imgui().key_ctrl() {
[INFO] [stderr] 845 |         node_states.deselect_all();
[INFO] [stderr] 846 |     }
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/editor.rs:841:9
[INFO] [stderr]     |
[INFO] [stderr] 841 | /         if ui.is_item_hovered() {
[INFO] [stderr] 842 | |             if ui.imgui().is_mouse_clicked(ImMouseButton::Left) {
[INFO] [stderr] 843 | |                 self.active_node = Some(*id);
[INFO] [stderr] 844 | |                 self.drag_node = Some(*id);
[INFO] [stderr] ...   |
[INFO] [stderr] 849 | |             }
[INFO] [stderr] 850 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 841 |         if ui.is_item_hovered() && ui.imgui().is_mouse_clicked(ImMouseButton::Left) {
[INFO] [stderr] 842 |     self.active_node = Some(*id);
[INFO] [stderr] 843 |     self.drag_node = Some(*id);
[INFO] [stderr] 844 |     if !ui.imgui().key_ctrl() {
[INFO] [stderr] 845 |         node_states.deselect_all();
[INFO] [stderr] 846 |     }
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/compute.rs:25:9
[INFO] [stderr]    |
[INFO] [stderr] 25 | /         match self {
[INFO] [stderr] 26 | |             &ComputationState::NothingDone => false,
[INFO] [stderr] 27 | |             &ComputationState::Completed { .. } => false,
[INFO] [stderr] 28 | |             &ComputationState::Running { .. } => true,
[INFO] [stderr] 29 | |             &ComputationState::RunningFirstTime => true,
[INFO] [stderr] 30 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 25 |         match *self {
[INFO] [stderr] 26 |             ComputationState::NothingDone => false,
[INFO] [stderr] 27 |             ComputationState::Completed { .. } => false,
[INFO] [stderr] 28 |             ComputationState::Running { .. } => true,
[INFO] [stderr] 29 |             ComputationState::RunningFirstTime => true,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/compute.rs:33:30
[INFO] [stderr]    |
[INFO] [stderr] 33 |     pub(crate) fn to_running(&mut self) {
[INFO] [stderr]    |                              ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/compute.rs:70:45
[INFO] [stderr]    |
[INFO] [stderr] 70 |     pub unsafe fn compute_output(&self, id: &cake::OutputId) -> ComputeResult<T, E> {
[INFO] [stderr]    |                                             ^^^^^^^^^^^^^^^ help: consider passing by value instead: `cake::OutputId`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/compute.rs:71:27
[INFO] [stderr]    |
[INFO] [stderr] 71 |         let result_lock = self.output_results.get(id).unwrap();
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.output_results[id]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/editor.rs:121:48
[INFO] [stderr]     |
[INFO] [stderr] 121 |     pub fn update_constant_node(&mut self, id: &cake::TransformIdx, val: Vec<T>) {
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `cake::TransformIdx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/editor.rs:143:43
[INFO] [stderr]     |
[INFO] [stderr] 143 |     pub fn constant_node_value(&self, id: &cake::TransformIdx) -> Option<&[T]> {
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `cake::TransformIdx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/editor.rs:217:17
[INFO] [stderr]     |
[INFO] [stderr] 217 |                    self.active_node.map(|node_id| {
[INFO] [stderr]     |   _________________^
[INFO] [stderr]     |  |_________________|
[INFO] [stderr]     | ||
[INFO] [stderr] 218 | ||                     ui.spacing();
[INFO] [stderr] 219 | ||                     ui.separator();
[INFO] [stderr] 220 | ||                     if ui
[INFO] [stderr] ...   ||
[INFO] [stderr] 241 | ||                     ui.separator();
[INFO] [stderr] 242 | ||                 });
[INFO] [stderr]     | ||__________________^- help: try this: `if let Some(node_id) = self.active_node { ... }`
[INFO] [stderr]     | |___________________|
[INFO] [stderr]     | 
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 34
[INFO] [stderr]    --> src/editor.rs:361:41
[INFO] [stderr]     |
[INFO] [stderr] 361 |               draw_list.channels_split(5, |channels| {
[INFO] [stderr]     |  _________________________________________^
[INFO] [stderr] 362 | |                 let canvas_size = Vec2::new(ui.get_window_size());
[INFO] [stderr] 363 | |                 let win_pos = Vec2::new(ui.get_cursor_screen_pos());
[INFO] [stderr] 364 | |                 // TODO: Center view on a specific node
[INFO] [stderr] ...   |
[INFO] [stderr] 718 | |                 }
[INFO] [stderr] 719 | |             })
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/editor.rs:601:50
[INFO] [stderr]     |
[INFO] [stderr] 601 |                           let (p1, cp1, cp2, p2) = match self.creating_link.as_ref().unwrap() {
[INFO] [stderr]     |  __________________________________________________^
[INFO] [stderr] 602 | |                             &LinkExtremity::Output(output) => {
[INFO] [stderr] 603 | |                                 let output_node_count =
[INFO] [stderr] 604 | |                                     self.dst.get_transform(&output.t_idx).unwrap().output.len();
[INFO] [stderr] ...   |
[INFO] [stderr] 656 | |                             }
[INFO] [stderr] 657 | |                         };
[INFO] [stderr]     | |_________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 601 |                         let (p1, cp1, cp2, p2) = match *self.creating_link.as_ref().unwrap() {
[INFO] [stderr] 602 |                             LinkExtremity::Output(output) => {
[INFO] [stderr] 603 |                                 let output_node_count =
[INFO] [stderr] 604 |                                     self.dst.get_transform(&output.t_idx).unwrap().output.len();
[INFO] [stderr] 605 |                                 let output_node_state = self
[INFO] [stderr] 606 |                                     .node_states
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/editor.rs:791:13
[INFO] [stderr]     |
[INFO] [stderr] 791 | /             if let &cake::NodeId::Transform(ref t_idx) = id {
[INFO] [stderr] 792 | |                 if let Some(t) = dst.get_transform_mut(t_idx) {
[INFO] [stderr] 793 | |                     if let cake::Algorithm::Constant(ref mut constants) = t.algorithm {
[INFO] [stderr] 794 | |                         for c in constants.iter_mut() {
[INFO] [stderr] ...   |
[INFO] [stderr] 812 | |                 }
[INFO] [stderr] 813 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 791 |             if let cake::NodeId::Transform(ref t_idx) = *id {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]   --> src/export.rs:78:9
[INFO] [stderr]    |
[INFO] [stderr] 78 |         w.write(serialized.as_bytes())?;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]   --> src/export.rs:79:12
[INFO] [stderr]    |
[INFO] [stderr] 79 |         Ok(w.flush()?)
[INFO] [stderr]    |            ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]    |
[INFO] [stderr] 79 |         Ok(())
[INFO] [stderr]    |            ^^
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/export.rs:191:12
[INFO] [stderr]     |
[INFO] [stderr] 191 |         Ok(self.import(deserialized)?)
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 191 |         Ok(())
[INFO] [stderr]     |            ^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/id_stack.rs:10:9
[INFO] [stderr]    |
[INFO] [stderr] 10 | /         match self {
[INFO] [stderr] 11 | |             &NodeId::Transform(t_idx) => t_idx.id() as i32,
[INFO] [stderr] 12 | |             &NodeId::Output(output_id) => -(output_id.id() as i32),
[INFO] [stderr] 13 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 10 |         match *self {
[INFO] [stderr] 11 |             NodeId::Transform(t_idx) => t_idx.id() as i32,
[INFO] [stderr] 12 |             NodeId::Output(output_id) => -(output_id.id() as i32),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/node_state.rs:99:21
[INFO] [stderr]    |
[INFO] [stderr] 99 |         let state = self.0.get(id).unwrap();
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.0[id]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/vec2.rs:24:25
[INFO] [stderr]    |
[INFO] [stderr] 24 |     pub fn squared_norm(&self) -> f32 {
[INFO] [stderr]    |                         ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `node_editor`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/compute.rs:25:9
[INFO] [stderr]    |
[INFO] [stderr] 25 | /         match self {
[INFO] [stderr] 26 | |             &ComputationState::NothingDone => false,
[INFO] [stderr] 27 | |             &ComputationState::Completed { .. } => false,
[INFO] [stderr] 28 | |             &ComputationState::Running { .. } => true,
[INFO] [stderr] 29 | |             &ComputationState::RunningFirstTime => true,
[INFO] [stderr] 30 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 25 |         match *self {
[INFO] [stderr] 26 |             ComputationState::NothingDone => false,
[INFO] [stderr] 27 |             ComputationState::Completed { .. } => false,
[INFO] [stderr] 28 |             ComputationState::Running { .. } => true,
[INFO] [stderr] 29 |             ComputationState::RunningFirstTime => true,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/compute.rs:33:30
[INFO] [stderr]    |
[INFO] [stderr] 33 |     pub(crate) fn to_running(&mut self) {
[INFO] [stderr]    |                              ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/compute.rs:70:45
[INFO] [stderr]    |
[INFO] [stderr] 70 |     pub unsafe fn compute_output(&self, id: &cake::OutputId) -> ComputeResult<T, E> {
[INFO] [stderr]    |                                             ^^^^^^^^^^^^^^^ help: consider passing by value instead: `cake::OutputId`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/compute.rs:71:27
[INFO] [stderr]    |
[INFO] [stderr] 71 |         let result_lock = self.output_results.get(id).unwrap();
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.output_results[id]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/editor.rs:121:48
[INFO] [stderr]     |
[INFO] [stderr] 121 |     pub fn update_constant_node(&mut self, id: &cake::TransformIdx, val: Vec<T>) {
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `cake::TransformIdx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/editor.rs:143:43
[INFO] [stderr]     |
[INFO] [stderr] 143 |     pub fn constant_node_value(&self, id: &cake::TransformIdx) -> Option<&[T]> {
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `cake::TransformIdx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/editor.rs:217:17
[INFO] [stderr]     |
[INFO] [stderr] 217 |                    self.active_node.map(|node_id| {
[INFO] [stderr]     |   _________________^
[INFO] [stderr]     |  |_________________|
[INFO] [stderr]     | ||
[INFO] [stderr] 218 | ||                     ui.spacing();
[INFO] [stderr] 219 | ||                     ui.separator();
[INFO] [stderr] 220 | ||                     if ui
[INFO] [stderr] ...   ||
[INFO] [stderr] 241 | ||                     ui.separator();
[INFO] [stderr] 242 | ||                 });
[INFO] [stderr]     | ||__________________^- help: try this: `if let Some(node_id) = self.active_node { ... }`
[INFO] [stderr]     | |___________________|
[INFO] [stderr]     | 
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 34
[INFO] [stderr]    --> src/editor.rs:361:41
[INFO] [stderr]     |
[INFO] [stderr] 361 |               draw_list.channels_split(5, |channels| {
[INFO] [stderr]     |  _________________________________________^
[INFO] [stderr] 362 | |                 let canvas_size = Vec2::new(ui.get_window_size());
[INFO] [stderr] 363 | |                 let win_pos = Vec2::new(ui.get_cursor_screen_pos());
[INFO] [stderr] 364 | |                 // TODO: Center view on a specific node
[INFO] [stderr] ...   |
[INFO] [stderr] 718 | |                 }
[INFO] [stderr] 719 | |             })
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/editor.rs:601:50
[INFO] [stderr]     |
[INFO] [stderr] 601 |                           let (p1, cp1, cp2, p2) = match self.creating_link.as_ref().unwrap() {
[INFO] [stderr]     |  __________________________________________________^
[INFO] [stderr] 602 | |                             &LinkExtremity::Output(output) => {
[INFO] [stderr] 603 | |                                 let output_node_count =
[INFO] [stderr] 604 | |                                     self.dst.get_transform(&output.t_idx).unwrap().output.len();
[INFO] [stderr] ...   |
[INFO] [stderr] 656 | |                             }
[INFO] [stderr] 657 | |                         };
[INFO] [stderr]     | |_________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 601 |                         let (p1, cp1, cp2, p2) = match *self.creating_link.as_ref().unwrap() {
[INFO] [stderr] 602 |                             LinkExtremity::Output(output) => {
[INFO] [stderr] 603 |                                 let output_node_count =
[INFO] [stderr] 604 |                                     self.dst.get_transform(&output.t_idx).unwrap().output.len();
[INFO] [stderr] 605 |                                 let output_node_state = self
[INFO] [stderr] 606 |                                     .node_states
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/editor.rs:791:13
[INFO] [stderr]     |
[INFO] [stderr] 791 | /             if let &cake::NodeId::Transform(ref t_idx) = id {
[INFO] [stderr] 792 | |                 if let Some(t) = dst.get_transform_mut(t_idx) {
[INFO] [stderr] 793 | |                     if let cake::Algorithm::Constant(ref mut constants) = t.algorithm {
[INFO] [stderr] 794 | |                         for c in constants.iter_mut() {
[INFO] [stderr] ...   |
[INFO] [stderr] 812 | |                 }
[INFO] [stderr] 813 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 791 |             if let cake::NodeId::Transform(ref t_idx) = *id {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]   --> src/export.rs:78:9
[INFO] [stderr]    |
[INFO] [stderr] 78 |         w.write(serialized.as_bytes())?;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]   --> src/export.rs:79:12
[INFO] [stderr]    |
[INFO] [stderr] 79 |         Ok(w.flush()?)
[INFO] [stderr]    |            ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]    |
[INFO] [stderr] 79 |         Ok(())
[INFO] [stderr]    |            ^^
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/export.rs:191:12
[INFO] [stderr]     |
[INFO] [stderr] 191 |         Ok(self.import(deserialized)?)
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 191 |         Ok(())
[INFO] [stderr]     |            ^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/id_stack.rs:10:9
[INFO] [stderr]    |
[INFO] [stderr] 10 | /         match self {
[INFO] [stderr] 11 | |             &NodeId::Transform(t_idx) => t_idx.id() as i32,
[INFO] [stderr] 12 | |             &NodeId::Output(output_id) => -(output_id.id() as i32),
[INFO] [stderr] 13 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 10 |         match *self {
[INFO] [stderr] 11 |             NodeId::Transform(t_idx) => t_idx.id() as i32,
[INFO] [stderr] 12 |             NodeId::Output(output_id) => -(output_id.id() as i32),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/node_state.rs:99:21
[INFO] [stderr]    |
[INFO] [stderr] 99 |         let state = self.0.get(id).unwrap();
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.0[id]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/vec2.rs:24:25
[INFO] [stderr]    |
[INFO] [stderr] 24 |     pub fn squared_norm(&self) -> f32 {
[INFO] [stderr]    |                         ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `node_editor`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "29e91effb292240e7f4bc5633c375c16d15d875fe1e92fa0101338a89c876c3f"`
[INFO] running `"docker" "rm" "-f" "29e91effb292240e7f4bc5633c375c16d15d875fe1e92fa0101338a89c876c3f"`
[INFO] [stdout] 29e91effb292240e7f4bc5633c375c16d15d875fe1e92fa0101338a89c876c3f