[INFO] crate nn 0.1.6 is already in cache
[INFO] extracting crate nn 0.1.6 into work/ex/clippy-test-run/sources/stable/reg/nn/0.1.6
[INFO] extracting crate nn 0.1.6 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nn/0.1.6
[INFO] validating manifest of nn-0.1.6 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of nn-0.1.6 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing nn-0.1.6
[INFO] finished frobbing nn-0.1.6
[INFO] frobbed toml for nn-0.1.6 written to work/ex/clippy-test-run/sources/stable/reg/nn/0.1.6/Cargo.toml
[INFO] started frobbing nn-0.1.6
[INFO] finished frobbing nn-0.1.6
[INFO] frobbed toml for nn-0.1.6 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nn/0.1.6/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting nn-0.1.6 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/nn/0.1.6:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] acdc48ec7d98d295822a210f5a10aeece15a9e6fca87af9033d874ddfb12a3d0
[INFO] running `"docker" "start" "-a" "acdc48ec7d98d295822a210f5a10aeece15a9e6fca87af9033d874ddfb12a3d0"`
[INFO] [stderr]     Checking nn v0.1.6 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:237:14
[INFO] [stderr]     |
[INFO] [stderr] 237 |         NN { layers: layers, num_inputs: first_layer_size }
[INFO] [stderr]     |              ^^^^^^^^^^^^^^ help: replace it with: `layers`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:257:13
[INFO] [stderr]     |
[INFO] [stderr] 257 |             examples: examples,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `examples`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:237:14
[INFO] [stderr]     |
[INFO] [stderr] 237 |         NN { layers: layers, num_inputs: first_layer_size }
[INFO] [stderr]     |              ^^^^^^^^^^^^^^ help: replace it with: `layers`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:257:13
[INFO] [stderr]     |
[INFO] [stderr] 257 |             examples: examples,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `examples`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/lib.rs:225:26
[INFO] [stderr]     |
[INFO] [stderr] 225 |                 for _ in 0..prev_layer_size+1 {
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^ help: use: `0..=prev_layer_size`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]    --> src/lib.rs:269:9
[INFO] [stderr]     |
[INFO] [stderr] 269 |         json::encode(self).ok().expect("encoding JSON failed")
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ok_expect)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]    --> src/lib.rs:274:27
[INFO] [stderr]     |
[INFO] [stderr] 274 |         let network: NN = json::decode(encoded).ok().expect("decoding JSON failed");
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:359:58
[INFO] [stderr]     |
[INFO] [stderr] 359 |     fn update_weights(&mut self, network_weight_updates: &Vec<Vec<Vec<f64>>>, prev_deltas: &mut Vec<Vec<Vec<f64>>>, rate: f64, momentum: f64) {
[INFO] [stderr]     |                                                          ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec<Vec<f64>>]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:379:49
[INFO] [stderr]     |
[INFO] [stderr] 379 |     fn calculate_weight_updates(&self, results: &Vec<Vec<f64>>, targets: &[f64]) -> Vec<Vec<Vec<f64>>> {
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^^ help: change this to: `&[Vec<f64>]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/lib.rs:394:17
[INFO] [stderr]     |
[INFO] [stderr] 394 | /                 let mut node_error;
[INFO] [stderr] 395 | |
[INFO] [stderr] 396 | |                 // calculate error for this node
[INFO] [stderr] 397 | |                 if layer_index == layers.len() - 1 {
[INFO] [stderr] ...   |
[INFO] [stderr] 405 | |                     node_error = result * (1f64 - result) * sum;
[INFO] [stderr] 406 | |                 }
[INFO] [stderr]     | |_________________^ help: it is more idiomatic to write: `let <mut> node_error = if layer_index == layers.len() - 1 { result * (1f64 - result) * (targets[node_index] - result) } else { ..; result * (1f64 - result) * sum };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/lib.rs:410:21
[INFO] [stderr]     |
[INFO] [stderr] 410 | /                     let mut prev_layer_result;
[INFO] [stderr] 411 | |                     if weight_index == 0 {
[INFO] [stderr] 412 | |                         prev_layer_result = 1f64; // threshold
[INFO] [stderr] 413 | |                     } else {
[INFO] [stderr] 414 | |                         prev_layer_result = prev_layer_results[weight_index-1];
[INFO] [stderr] 415 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> prev_layer_result = if weight_index == 0 { 1f64 } else { prev_layer_results[weight_index-1] };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:453:27
[INFO] [stderr]     |
[INFO] [stderr] 453 | fn modified_dotprod(node: &Vec<f64>, values: &Vec<f64>) -> f64 {
[INFO] [stderr]     |                           ^^^^^^^^^ help: change this to: `&[f64]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:453:46
[INFO] [stderr]     |
[INFO] [stderr] 453 | fn modified_dotprod(node: &Vec<f64>, values: &Vec<f64>) -> f64 {
[INFO] [stderr]     |                                              ^^^^^^^^^ help: change this to: `&[f64]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:475:29
[INFO] [stderr]     |
[INFO] [stderr] 475 | fn calculate_error(results: &Vec<Vec<f64>>, targets: &[f64]) -> f64 {
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^ help: change this to: `&[Vec<f64>]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/lib.rs:476:9
[INFO] [stderr]     |
[INFO] [stderr] 476 |     let ref last_results = results[results.len()-1];
[INFO] [stderr]     |     ----^^^^^^^^^^^^^^^^---------------------------- help: try: `let last_results = &results[results.len()-1];`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/lib.rs:225:26
[INFO] [stderr]     |
[INFO] [stderr] 225 |                 for _ in 0..prev_layer_size+1 {
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^ help: use: `0..=prev_layer_size`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]    --> src/lib.rs:269:9
[INFO] [stderr]     |
[INFO] [stderr] 269 |         json::encode(self).ok().expect("encoding JSON failed")
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ok_expect)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]    --> src/lib.rs:274:27
[INFO] [stderr]     |
[INFO] [stderr] 274 |         let network: NN = json::decode(encoded).ok().expect("decoding JSON failed");
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:359:58
[INFO] [stderr]     |
[INFO] [stderr] 359 |     fn update_weights(&mut self, network_weight_updates: &Vec<Vec<Vec<f64>>>, prev_deltas: &mut Vec<Vec<Vec<f64>>>, rate: f64, momentum: f64) {
[INFO] [stderr]     |                                                          ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec<Vec<f64>>]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:379:49
[INFO] [stderr]     |
[INFO] [stderr] 379 |     fn calculate_weight_updates(&self, results: &Vec<Vec<f64>>, targets: &[f64]) -> Vec<Vec<Vec<f64>>> {
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^^ help: change this to: `&[Vec<f64>]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/lib.rs:394:17
[INFO] [stderr]     |
[INFO] [stderr] 394 | /                 let mut node_error;
[INFO] [stderr] 395 | |
[INFO] [stderr] 396 | |                 // calculate error for this node
[INFO] [stderr] 397 | |                 if layer_index == layers.len() - 1 {
[INFO] [stderr] ...   |
[INFO] [stderr] 405 | |                     node_error = result * (1f64 - result) * sum;
[INFO] [stderr] 406 | |                 }
[INFO] [stderr]     | |_________________^ help: it is more idiomatic to write: `let <mut> node_error = if layer_index == layers.len() - 1 { result * (1f64 - result) * (targets[node_index] - result) } else { ..; result * (1f64 - result) * sum };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/lib.rs:410:21
[INFO] [stderr]     |
[INFO] [stderr] 410 | /                     let mut prev_layer_result;
[INFO] [stderr] 411 | |                     if weight_index == 0 {
[INFO] [stderr] 412 | |                         prev_layer_result = 1f64; // threshold
[INFO] [stderr] 413 | |                     } else {
[INFO] [stderr] 414 | |                         prev_layer_result = prev_layer_results[weight_index-1];
[INFO] [stderr] 415 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> prev_layer_result = if weight_index == 0 { 1f64 } else { prev_layer_results[weight_index-1] };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:453:27
[INFO] [stderr]     |
[INFO] [stderr] 453 | fn modified_dotprod(node: &Vec<f64>, values: &Vec<f64>) -> f64 {
[INFO] [stderr]     |                           ^^^^^^^^^ help: change this to: `&[f64]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:453:46
[INFO] [stderr]     |
[INFO] [stderr] 453 | fn modified_dotprod(node: &Vec<f64>, values: &Vec<f64>) -> f64 {
[INFO] [stderr]     |                                              ^^^^^^^^^ help: change this to: `&[f64]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:475:29
[INFO] [stderr]     |
[INFO] [stderr] 475 | fn calculate_error(results: &Vec<Vec<f64>>, targets: &[f64]) -> f64 {
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^ help: change this to: `&[Vec<f64>]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/lib.rs:476:9
[INFO] [stderr]     |
[INFO] [stderr] 476 |     let ref last_results = results[results.len()-1];
[INFO] [stderr]     |     ----^^^^^^^^^^^^^^^^---------------------------- help: try: `let last_results = &results[results.len()-1];`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> tests/xor.rs:35:17
[INFO] [stderr]    |
[INFO] [stderr] 35 |         assert!(result == key);
[INFO] [stderr]    |                 ^^^^^^^^^^^^^ help: consider comparing them within some error: `(result - key).abs() < error`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> tests/xor.rs:35:17
[INFO] [stderr]    |
[INFO] [stderr] 35 |         assert!(result == key);
[INFO] [stderr]    |                 ^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `nn`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "acdc48ec7d98d295822a210f5a10aeece15a9e6fca87af9033d874ddfb12a3d0"`
[INFO] running `"docker" "rm" "-f" "acdc48ec7d98d295822a210f5a10aeece15a9e6fca87af9033d874ddfb12a3d0"`
[INFO] [stdout] acdc48ec7d98d295822a210f5a10aeece15a9e6fca87af9033d874ddfb12a3d0