[INFO] crate nmm_lib 0.1.0 is already in cache
[INFO] extracting crate nmm_lib 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/nmm_lib/0.1.0
[INFO] extracting crate nmm_lib 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nmm_lib/0.1.0
[INFO] validating manifest of nmm_lib-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of nmm_lib-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing nmm_lib-0.1.0
[INFO] finished frobbing nmm_lib-0.1.0
[INFO] frobbed toml for nmm_lib-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/nmm_lib/0.1.0/Cargo.toml
[INFO] started frobbing nmm_lib-0.1.0
[INFO] finished frobbing nmm_lib-0.1.0
[INFO] frobbed toml for nmm_lib-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nmm_lib/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting nmm_lib-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/nmm_lib/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 5d64bbbf956364b076fffa0b1bf532b469e66b86728a52186279821aa0bd27a2
[INFO] running `"docker" "start" "-a" "5d64bbbf956364b076fffa0b1bf532b469e66b86728a52186279821aa0bd27a2"`
[INFO] [stderr]     Checking nmm_lib v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:47:13
[INFO] [stderr]    |
[INFO] [stderr] 47 |             pieces: pieces,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `pieces`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:47:13
[INFO] [stderr]    |
[INFO] [stderr] 47 |             pieces: pieces,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `pieces`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:65:9
[INFO] [stderr]    |
[INFO] [stderr] 65 |         return self.pieces.clone();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.pieces.clone()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:69:9
[INFO] [stderr]    |
[INFO] [stderr] 69 |         return self.turn;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.turn`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:73:9
[INFO] [stderr]    |
[INFO] [stderr] 73 |         return self.next_player.clone();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.next_player.clone()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/piece.rs:23:25
[INFO] [stderr]    |
[INFO] [stderr] 23 |     pub fn get_location(&self) -> Location {
[INFO] [stderr]    |                         ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/piece.rs:27:23
[INFO] [stderr]    |
[INFO] [stderr] 27 |     pub fn get_player(&self) -> Player {
[INFO] [stderr]    |                       ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:65:9
[INFO] [stderr]    |
[INFO] [stderr] 65 |         return self.pieces.clone();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.pieces.clone()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:69:9
[INFO] [stderr]    |
[INFO] [stderr] 69 |         return self.turn;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.turn`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:73:9
[INFO] [stderr]    |
[INFO] [stderr] 73 |         return self.next_player.clone();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.next_player.clone()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name
[INFO] [stderr]   --> src/location.rs:32:5
[INFO] [stderr]    |
[INFO] [stderr] 32 | /     pub fn from_str(code: &str) -> Location {
[INFO] [stderr] 33 | |         use Location::*;
[INFO] [stderr] 34 | |         match code {
[INFO] [stderr] 35 | |             "Hand"      => Hand,
[INFO] [stderr] ...  |
[INFO] [stderr] 62 | |         }
[INFO] [stderr] 63 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/location.rs:65:19
[INFO] [stderr]    |
[INFO] [stderr] 65 |     pub fn to_str(&self) -> &'static str {
[INFO] [stderr]    |                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `Game`
[INFO] [stderr]   --> src/lib.rs:35:5
[INFO] [stderr]    |
[INFO] [stderr] 35 | /     pub fn new() -> Game {
[INFO] [stderr] 36 | |         Game{
[INFO] [stderr] 37 | |             pieces: Self::get_new_pieces(),
[INFO] [stderr] 38 | |             turn: 0,
[INFO] [stderr] 39 | |             next_player: Player::One
[INFO] [stderr] 40 | |         }
[INFO] [stderr] 41 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 34 | impl Default for Game {
[INFO] [stderr] 35 |     fn default() -> Self {
[INFO] [stderr] 36 |         Self::new()
[INFO] [stderr] 37 |     }
[INFO] [stderr] 38 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/lib.rs:61:9
[INFO] [stderr]    |
[INFO] [stderr] 61 |         String::from(json.to_string())
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `json.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/lib.rs:73:16
[INFO] [stderr]    |
[INFO] [stderr] 73 |         return self.next_player.clone();
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.next_player`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lib.rs:197:17
[INFO] [stderr]     |
[INFO] [stderr] 197 |                 piece.clone()
[INFO] [stderr]     |                 ^^^^^^^^^^^^^ help: try removing the `clone` call: `piece`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lib.rs:210:25
[INFO] [stderr]     |
[INFO] [stderr] 210 |                         piece.clone()
[INFO] [stderr]     |                         ^^^^^^^^^^^^^ help: try removing the `clone` call: `piece`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/piece.rs:23:25
[INFO] [stderr]    |
[INFO] [stderr] 23 |     pub fn get_location(&self) -> Location {
[INFO] [stderr]    |                         ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/piece.rs:27:23
[INFO] [stderr]    |
[INFO] [stderr] 27 |     pub fn get_player(&self) -> Player {
[INFO] [stderr]    |                       ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name
[INFO] [stderr]   --> src/location.rs:32:5
[INFO] [stderr]    |
[INFO] [stderr] 32 | /     pub fn from_str(code: &str) -> Location {
[INFO] [stderr] 33 | |         use Location::*;
[INFO] [stderr] 34 | |         match code {
[INFO] [stderr] 35 | |             "Hand"      => Hand,
[INFO] [stderr] ...  |
[INFO] [stderr] 62 | |         }
[INFO] [stderr] 63 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/location.rs:65:19
[INFO] [stderr]    |
[INFO] [stderr] 65 |     pub fn to_str(&self) -> &'static str {
[INFO] [stderr]    |                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/test.rs:177:32
[INFO] [stderr]     |
[INFO] [stderr] 177 | fn assert_piece_exists(pieces: &Vec<Piece>, player: Player, location: Location) {
[INFO] [stderr]     |                                ^^^^^^^^^^^ help: change this to: `&[Piece]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
[INFO] [stderr]    --> src/test.rs:178:36
[INFO] [stderr]     |
[INFO] [stderr] 178 |       assert!(pieces.iter().any(|&x| {
[INFO] [stderr]     |  ____________________________________^
[INFO] [stderr] 179 | |         x.get_location() == location && x.get_player() == player
[INFO] [stderr] 180 | |     }), "piece doesn't seem to exist");
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::block_in_if_condition_stmt)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/test.rs:183:38
[INFO] [stderr]     |
[INFO] [stderr] 183 | fn assert_piece_doesnt_exist(pieces: &Vec<Piece>, player: Player, location: Location) {
[INFO] [stderr]     |                                      ^^^^^^^^^^^ help: change this to: `&[Piece]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `Game`
[INFO] [stderr]   --> src/lib.rs:35:5
[INFO] [stderr]    |
[INFO] [stderr] 35 | /     pub fn new() -> Game {
[INFO] [stderr] 36 | |         Game{
[INFO] [stderr] 37 | |             pieces: Self::get_new_pieces(),
[INFO] [stderr] 38 | |             turn: 0,
[INFO] [stderr] 39 | |             next_player: Player::One
[INFO] [stderr] 40 | |         }
[INFO] [stderr] 41 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 34 | impl Default for Game {
[INFO] [stderr] 35 |     fn default() -> Self {
[INFO] [stderr] 36 |         Self::new()
[INFO] [stderr] 37 |     }
[INFO] [stderr] 38 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/lib.rs:61:9
[INFO] [stderr]    |
[INFO] [stderr] 61 |         String::from(json.to_string())
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `json.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/lib.rs:73:16
[INFO] [stderr]    |
[INFO] [stderr] 73 |         return self.next_player.clone();
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.next_player`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lib.rs:197:17
[INFO] [stderr]     |
[INFO] [stderr] 197 |                 piece.clone()
[INFO] [stderr]     |                 ^^^^^^^^^^^^^ help: try removing the `clone` call: `piece`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lib.rs:210:25
[INFO] [stderr]     |
[INFO] [stderr] 210 |                         piece.clone()
[INFO] [stderr]     |                         ^^^^^^^^^^^^^ help: try removing the `clone` call: `piece`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.33s
[INFO] running `"docker" "inspect" "5d64bbbf956364b076fffa0b1bf532b469e66b86728a52186279821aa0bd27a2"`
[INFO] running `"docker" "rm" "-f" "5d64bbbf956364b076fffa0b1bf532b469e66b86728a52186279821aa0bd27a2"`
[INFO] [stdout] 5d64bbbf956364b076fffa0b1bf532b469e66b86728a52186279821aa0bd27a2