[INFO] crate nitro_fs 0.1.0 is already in cache [INFO] extracting crate nitro_fs 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/nitro_fs/0.1.0 [INFO] extracting crate nitro_fs 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nitro_fs/0.1.0 [INFO] validating manifest of nitro_fs-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nitro_fs-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nitro_fs-0.1.0 [INFO] finished frobbing nitro_fs-0.1.0 [INFO] frobbed toml for nitro_fs-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/nitro_fs/0.1.0/Cargo.toml [INFO] started frobbing nitro_fs-0.1.0 [INFO] finished frobbing nitro_fs-0.1.0 [INFO] frobbed toml for nitro_fs-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nitro_fs/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nitro_fs-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/nitro_fs/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8633d987ddecc1efcf28d7bf74e4561a7ca464a79eca5e6d8db05124eb35c3a7 [INFO] running `"docker" "start" "-a" "8633d987ddecc1efcf28d7bf74e4561a7ca464a79eca5e6d8db05124eb35c3a7"` [INFO] [stderr] warning: the cargo feature `edition` is now stable and is no longer necessary to be listed in the manifest [INFO] [stderr] Checking nitro_fs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `bail` [INFO] [stderr] --> src/fat.rs:2:15 [INFO] [stderr] | [INFO] [stderr] 2 | use failure::{bail, ensure, Fail, Error}; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `bail` [INFO] [stderr] --> src/fat.rs:2:15 [INFO] [stderr] | [INFO] [stderr] 2 | use failure::{bail, ensure, Fail, Error}; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: item `fat::AllocInfo` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/fat.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | / impl AllocInfo { [INFO] [stderr] 20 | | pub fn new(reader: &mut R) -> Result { [INFO] [stderr] 21 | | Ok(Self { [INFO] [stderr] 22 | | start: reader.read_u32::()?, [INFO] [stderr] ... | [INFO] [stderr] 29 | | } [INFO] [stderr] 30 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/fat.rs:27:16 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn len(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:93:33 [INFO] [stderr] | [INFO] [stderr] 93 | cursor.set_position(dir.offset() as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(dir.offset())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: item `fat::AllocInfo` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/fat.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | / impl AllocInfo { [INFO] [stderr] 20 | | pub fn new(reader: &mut R) -> Result { [INFO] [stderr] 21 | | Ok(Self { [INFO] [stderr] 22 | | start: reader.read_u32::()?, [INFO] [stderr] ... | [INFO] [stderr] 29 | | } [INFO] [stderr] 30 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/fat.rs:27:16 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn len(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:93:33 [INFO] [stderr] | [INFO] [stderr] 93 | cursor.set_position(dir.offset() as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(dir.offset())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.68s [INFO] running `"docker" "inspect" "8633d987ddecc1efcf28d7bf74e4561a7ca464a79eca5e6d8db05124eb35c3a7"` [INFO] running `"docker" "rm" "-f" "8633d987ddecc1efcf28d7bf74e4561a7ca464a79eca5e6d8db05124eb35c3a7"` [INFO] [stdout] 8633d987ddecc1efcf28d7bf74e4561a7ca464a79eca5e6d8db05124eb35c3a7