[INFO] crate nihdb 0.3.0 is already in cache [INFO] extracting crate nihdb 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/nihdb/0.3.0 [INFO] extracting crate nihdb 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nihdb/0.3.0 [INFO] validating manifest of nihdb-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nihdb-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nihdb-0.3.0 [INFO] finished frobbing nihdb-0.3.0 [INFO] frobbed toml for nihdb-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/nihdb/0.3.0/Cargo.toml [INFO] started frobbing nihdb-0.3.0 [INFO] finished frobbing nihdb-0.3.0 [INFO] frobbed toml for nihdb-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nihdb/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nihdb-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/nihdb/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8904dba4ca2cd6ddcd839426e0d95adc8610ad1d85b3ebcb579ccc0e8783ae1a [INFO] running `"docker" "start" "-a" "8904dba4ca2cd6ddcd839426e0d95adc8610ad1d85b3ebcb579ccc0e8783ae1a"` [INFO] [stderr] Checking nihdb v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk.rs:256:37 [INFO] [stderr] | [INFO] [stderr] 256 | return Ok(TableKeysIterator{keys: keys, keys_pos: 0, keys_end_pos: keys_end_pos}); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `keys` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk.rs:256:62 [INFO] [stderr] | [INFO] [stderr] 256 | return Ok(TableKeysIterator{keys: keys, keys_pos: 0, keys_end_pos: keys_end_pos}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `keys_end_pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk.rs:396:17 [INFO] [stderr] | [INFO] [stderr] 396 | keys_iter: keys_iter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `keys_iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk.rs:397:17 [INFO] [stderr] | [INFO] [stderr] 397 | values_buf: values_buf, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `values_buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk.rs:399:17 [INFO] [stderr] | [INFO] [stderr] 399 | direction: direction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk.rs:403:17 [INFO] [stderr] | [INFO] [stderr] 403 | keys_iter: keys_iter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `keys_iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk.rs:407:17 [INFO] [stderr] | [INFO] [stderr] 407 | direction: direction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | iters: iters, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `iters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | iters_front: iters_front, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `iters_front` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | direction: direction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter.rs:98:77 [INFO] [stderr] | [INFO] [stderr] 98 | return Ok(ConcatIterator{current: Some((key, current)), next_gen: next_gen}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `next_gen` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter.rs:104:21 [INFO] [stderr] | [INFO] [stderr] 104 | next_gen: next_gen, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `next_gen` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memstore.rs:77:17 [INFO] [stderr] | [INFO] [stderr] 77 | direction: direction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memstore.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | direction: direction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/toc.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | level: level, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/toc.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | keys_offset: keys_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `keys_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/toc.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | file_size: file_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/toc.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | smallest_key: smallest_key, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `smallest_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/toc.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | biggest_key: biggest_key, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `biggest_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | threshold: threshold, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `threshold` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | directory: directory, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | toc_file: toc_file, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `toc_file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | toc: toc, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `toc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:229:72 [INFO] [stderr] | [INFO] [stderr] 229 | = table_infos.into_iter().map(|x: TableInfo| TableInfo{level: level, .. x}).collect(); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:232:17 [INFO] [stderr] | [INFO] [stderr] 232 | additions: additions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `additions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:285:21 [INFO] [stderr] | [INFO] [stderr] 285 | keys_offset: keys_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `keys_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:286:21 [INFO] [stderr] | [INFO] [stderr] 286 | file_size: file_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:296:17 [INFO] [stderr] | [INFO] [stderr] 296 | additions: additions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `additions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:297:17 [INFO] [stderr] | [INFO] [stderr] 297 | removals: removals, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `removals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:365:13 [INFO] [stderr] | [INFO] [stderr] 365 | level: level, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:366:13 [INFO] [stderr] | [INFO] [stderr] 366 | keys_offset: keys_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `keys_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:367:13 [INFO] [stderr] | [INFO] [stderr] 367 | file_size: file_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:502:13 [INFO] [stderr] | [INFO] [stderr] 502 | direction: direction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk.rs:256:37 [INFO] [stderr] | [INFO] [stderr] 256 | return Ok(TableKeysIterator{keys: keys, keys_pos: 0, keys_end_pos: keys_end_pos}); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `keys` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk.rs:256:62 [INFO] [stderr] | [INFO] [stderr] 256 | return Ok(TableKeysIterator{keys: keys, keys_pos: 0, keys_end_pos: keys_end_pos}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `keys_end_pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk.rs:396:17 [INFO] [stderr] | [INFO] [stderr] 396 | keys_iter: keys_iter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `keys_iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk.rs:397:17 [INFO] [stderr] | [INFO] [stderr] 397 | values_buf: values_buf, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `values_buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk.rs:399:17 [INFO] [stderr] | [INFO] [stderr] 399 | direction: direction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk.rs:403:17 [INFO] [stderr] | [INFO] [stderr] 403 | keys_iter: keys_iter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `keys_iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk.rs:407:17 [INFO] [stderr] | [INFO] [stderr] 407 | direction: direction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | iters: iters, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `iters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | iters_front: iters_front, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `iters_front` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | direction: direction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter.rs:98:77 [INFO] [stderr] | [INFO] [stderr] 98 | return Ok(ConcatIterator{current: Some((key, current)), next_gen: next_gen}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `next_gen` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter.rs:104:21 [INFO] [stderr] | [INFO] [stderr] 104 | next_gen: next_gen, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `next_gen` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memstore.rs:77:17 [INFO] [stderr] | [INFO] [stderr] 77 | direction: direction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memstore.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | direction: direction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/toc.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | level: level, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/toc.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | keys_offset: keys_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `keys_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/toc.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | file_size: file_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/toc.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | smallest_key: smallest_key, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `smallest_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/toc.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | biggest_key: biggest_key, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `biggest_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | threshold: threshold, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `threshold` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | directory: directory, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | toc_file: toc_file, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `toc_file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | toc: toc, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `toc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:229:72 [INFO] [stderr] | [INFO] [stderr] 229 | = table_infos.into_iter().map(|x: TableInfo| TableInfo{level: level, .. x}).collect(); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:232:17 [INFO] [stderr] | [INFO] [stderr] 232 | additions: additions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `additions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:285:21 [INFO] [stderr] | [INFO] [stderr] 285 | keys_offset: keys_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `keys_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:286:21 [INFO] [stderr] | [INFO] [stderr] 286 | file_size: file_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:296:17 [INFO] [stderr] | [INFO] [stderr] 296 | additions: additions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `additions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:297:17 [INFO] [stderr] | [INFO] [stderr] 297 | removals: removals, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `removals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:365:13 [INFO] [stderr] | [INFO] [stderr] 365 | level: level, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:366:13 [INFO] [stderr] | [INFO] [stderr] 366 | keys_offset: keys_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `keys_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:367:13 [INFO] [stderr] | [INFO] [stderr] 367 | file_size: file_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:502:13 [INFO] [stderr] | [INFO] [stderr] 502 | direction: direction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | return Some(Mutation::Set(s)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Mutation::Set(s))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | return Some(Mutation::Delete); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Mutation::Delete)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | / return 1 // prev key entry len [INFO] [stderr] 94 | | + 1 // value len [INFO] [stderr] 95 | | + 3 // value offset [INFO] [stderr] 96 | | + 1 // key len [INFO] [stderr] 97 | | + key.len(); [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 93 | 1 // prev key entry len [INFO] [stderr] 94 | + 1 // value len [INFO] [stderr] 95 | + 3 // value offset [INFO] [stderr] 96 | + 1 // key len [INFO] [stderr] 97 | + key.len() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | / return 1 // Set/delete byte [INFO] [stderr] 101 | | + 1 // val len [INFO] [stderr] 102 | | + val.len(); [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 100 | 1 // Set/delete byte [INFO] [stderr] 101 | + 1 // val len [INFO] [stderr] 102 | + val.len() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | / return match val { [INFO] [stderr] 106 | | &Mutation::Set(ref x) => set_value_usage(&x), [INFO] [stderr] 107 | | &Mutation::Delete => 1, [INFO] [stderr] 108 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 105 | match val { [INFO] [stderr] 106 | &Mutation::Set(ref x) => set_value_usage(&x), [INFO] [stderr] 107 | &Mutation::Delete => 1, [INFO] [stderr] 108 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | / return TableBuilder{ [INFO] [stderr] 125 | | values_buf: Vec::new(), [INFO] [stderr] 126 | | keys_buf: Vec::new(), [INFO] [stderr] 127 | | first_key: None, [INFO] [stderr] 128 | | last_key: None, [INFO] [stderr] 129 | | last_entry_len: 0, [INFO] [stderr] 130 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 124 | TableBuilder{ [INFO] [stderr] 125 | values_buf: Vec::new(), [INFO] [stderr] 126 | keys_buf: Vec::new(), [INFO] [stderr] 127 | first_key: None, [INFO] [stderr] 128 | last_key: None, [INFO] [stderr] 129 | last_entry_len: 0, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | return self.first_key.is_none(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.first_key.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | return self.values_buf.len() + self.keys_buf.len() + TAB_BACK_PADDING; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.values_buf.len() + self.keys_buf.len() + TAB_BACK_PADDING` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | / return Ok(( [INFO] [stderr] 175 | | keys_offset, [INFO] [stderr] 176 | | keys_offset + self.keys_buf.len() as u64, [INFO] [stderr] 177 | | self.first_key.as_ref().unwrap().clone(), [INFO] [stderr] 178 | | self.last_key.as_ref().unwrap().clone(), [INFO] [stderr] 179 | | )); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 174 | Ok(( [INFO] [stderr] 175 | keys_offset, [INFO] [stderr] 176 | keys_offset + self.keys_buf.len() as u64, [INFO] [stderr] 177 | self.first_key.as_ref().unwrap().clone(), [INFO] [stderr] 178 | self.last_key.as_ref().unwrap().clone(), [INFO] [stderr] 179 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:192:5 [INFO] [stderr] | [INFO] [stderr] 192 | return builder.finish(&mut f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `builder.finish(&mut f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:197:5 [INFO] [stderr] | [INFO] [stderr] 197 | return Ok(f); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:207:5 [INFO] [stderr] | [INFO] [stderr] 207 | return Ok(buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:234:5 [INFO] [stderr] | [INFO] [stderr] 234 | return Ok(None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(None)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:256:9 [INFO] [stderr] | [INFO] [stderr] 256 | return Ok(TableKeysIterator{keys: keys, keys_pos: 0, keys_end_pos: keys_end_pos}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(TableKeysIterator{keys: keys, keys_pos: 0, keys_end_pos: keys_end_pos})` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:260:9 [INFO] [stderr] | [INFO] [stderr] 260 | return TableKeysInterval{keys_pos: self.keys_pos, keys_end_pos: self.keys_end_pos}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TableKeysInterval{keys_pos: self.keys_pos, keys_end_pos: self.keys_end_pos}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:271:9 [INFO] [stderr] | [INFO] [stderr] 271 | return Ok((key, value_offset, value_length)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((key, value_offset, value_length))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:281:9 [INFO] [stderr] | [INFO] [stderr] 281 | return Ok(Some(tup)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some(tup))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:285:9 [INFO] [stderr] | [INFO] [stderr] 285 | return TableKeysIterator::help_current_key(&self.keys, self.keys_pos, self.keys_end_pos); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TableKeysIterator::help_current_key(&self.keys, self.keys_pos, self.keys_end_pos)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:294:9 [INFO] [stderr] | [INFO] [stderr] 294 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:298:9 [INFO] [stderr] | [INFO] [stderr] 298 | return TableKeysIterator::help_step_key(&self.keys, &mut self.keys_pos) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TableKeysIterator::help_step_key(&self.keys, &mut self.keys_pos)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:306:9 [INFO] [stderr] | [INFO] [stderr] 306 | return Ok(None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(None)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:320:9 [INFO] [stderr] | [INFO] [stderr] 320 | return ret; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:333:9 [INFO] [stderr] | [INFO] [stderr] 333 | return Ok(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:344:5 [INFO] [stderr] | [INFO] [stderr] 344 | return Ok((f, keys_buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((f, keys_buf))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:355:5 [INFO] [stderr] | [INFO] [stderr] 355 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:414:9 [INFO] [stderr] | [INFO] [stderr] 414 | / return match direction { [INFO] [stderr] 415 | | Direction::Forward => keys_iter.current_key(), [INFO] [stderr] 416 | | Direction::Backward => keys_iter.current_back_key() [INFO] [stderr] 417 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 414 | match direction { [INFO] [stderr] 415 | Direction::Forward => keys_iter.current_key(), [INFO] [stderr] 416 | Direction::Backward => keys_iter.current_back_key() [INFO] [stderr] 417 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:421:9 [INFO] [stderr] | [INFO] [stderr] 421 | return TableIterator::help_current_entry(&self.keys_iter, self.direction); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TableIterator::help_current_entry(&self.keys_iter, self.direction)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:428:9 [INFO] [stderr] | [INFO] [stderr] 428 | return ret; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:447:9 [INFO] [stderr] | [INFO] [stderr] 447 | return mk_err("current_value called on empty TableIterator"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `mk_err("current_value called on empty TableIterator")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:453:17 [INFO] [stderr] | [INFO] [stderr] 453 | return self.keys_iter.step_key(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.keys_iter.step_key()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:459:17 [INFO] [stderr] | [INFO] [stderr] 459 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encoding.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | return Some(n); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encoding.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | return Some(x as usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(x as usize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encoding.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | return Some(n); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encoding.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | return Some(n); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encoding.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | return Some(slice); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(slice)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encoding.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | return Some(s.to_vec()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(s.to_vec())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/error.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | return Error::MsgError(msg.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error::MsgError(msg.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/error.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | / return match self { [INFO] [stderr] 20 | | &Error::IoError(ref e) => (e as &std::error::Error).description(), [INFO] [stderr] 21 | | &Error::MsgError(ref s) => &s, [INFO] [stderr] 22 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 19 | match self { [INFO] [stderr] 20 | &Error::IoError(ref e) => (e as &std::error::Error).description(), [INFO] [stderr] 21 | &Error::MsgError(ref s) => &s, [INFO] [stderr] 22 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/error.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | return Err(Error::new(msg)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::new(msg))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/error.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | / return match self { [INFO] [stderr] 50 | | &Error::IoError(ref e) => Some(e), [INFO] [stderr] 51 | | &Error::MsgError(_) => None, [INFO] [stderr] 52 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 49 | match self { [INFO] [stderr] 50 | &Error::IoError(ref e) => Some(e), [INFO] [stderr] 51 | &Error::MsgError(_) => None, [INFO] [stderr] 52 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/iter.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | / return Ok(MergeIterator{ [INFO] [stderr] 48 | | iters: iters, [INFO] [stderr] 49 | | iters_front: iters_front, [INFO] [stderr] 50 | | direction: direction, [INFO] [stderr] 51 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 47 | Ok(MergeIterator{ [INFO] [stderr] 48 | iters: iters, [INFO] [stderr] 49 | iters_front: iters_front, [INFO] [stderr] 50 | direction: direction, [INFO] [stderr] 51 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/iter.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | return ret; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/iter.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/iter.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | return ret; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/iter.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/iter.rs:130:24 [INFO] [stderr] | [INFO] [stderr] 130 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 131 | | if let Some(iter) = (*self.next_gen)()? { [INFO] [stderr] 132 | | tup.1 = iter; [INFO] [stderr] 133 | | } else { [INFO] [stderr] 134 | | break; [INFO] [stderr] 135 | | } [INFO] [stderr] 136 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 130 | } else if let Some(iter) = (*self.next_gen)()? { [INFO] [stderr] 131 | tup.1 = iter; [INFO] [stderr] 132 | } else { [INFO] [stderr] 133 | break; [INFO] [stderr] 134 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memstore.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | return self.entries.get(key); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.entries.get(key)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memstore.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | return range.next().map(|(key, _)| key as &[u8]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `range.next().map(|(key, _)| key as &[u8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memstore.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | return range.next_back().map(|(key, _)| key as &[u8]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `range.next_back().map(|(key, _)| key as &[u8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memstore.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | return MemStore{entries: BTreeMap::::new(), mem_usage: 0}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `MemStore{entries: BTreeMap::::new(), mem_usage: 0}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memstore.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | / return match direction { [INFO] [stderr] 73 | | Direction::Forward => MemStoreIterator{ [INFO] [stderr] 74 | | memstore: ms, [INFO] [stderr] 75 | | current: ms.first_in_range(interval), [INFO] [stderr] ... | [INFO] [stderr] 84 | | } [INFO] [stderr] 85 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 72 | match direction { [INFO] [stderr] 73 | Direction::Forward => MemStoreIterator{ [INFO] [stderr] 74 | memstore: ms, [INFO] [stderr] 75 | current: ms.first_in_range(interval), [INFO] [stderr] 76 | bound: interval.upper.clone(), [INFO] [stderr] 77 | direction: direction, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memstore.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | return Ok(self.current); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(self.current)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memstore.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | return mk_err("current_value called on empty MemStoreIterator"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `mk_err("current_value called on empty MemStoreIterator")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memstore.rs:112:17 [INFO] [stderr] | [INFO] [stderr] 112 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memstore.rs:123:17 [INFO] [stderr] | [INFO] [stderr] 123 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/toc.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | return Ok(f); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/toc.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | / return Some(TableInfo{ [INFO] [stderr] 112 | | id: TableId(id), [INFO] [stderr] 113 | | level: level, [INFO] [stderr] 114 | | keys_offset: keys_offset, [INFO] [stderr] ... | [INFO] [stderr] 117 | | biggest_key: biggest_key, [INFO] [stderr] 118 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 111 | Some(TableInfo{ [INFO] [stderr] 112 | id: TableId(id), [INFO] [stderr] 113 | level: level, [INFO] [stderr] 114 | keys_offset: keys_offset, [INFO] [stderr] 115 | file_size: file_size, [INFO] [stderr] 116 | smallest_key: smallest_key, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/toc.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | return ret; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/toc.rs:174:5 [INFO] [stderr] | [INFO] [stderr] 174 | return Some(Entry{removals, additions}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Entry{removals, additions})` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/toc.rs:189:5 [INFO] [stderr] | [INFO] [stderr] 189 | return ret; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/toc.rs:204:5 [INFO] [stderr] | [INFO] [stderr] 204 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/toc.rs:224:5 [INFO] [stderr] | [INFO] [stderr] 224 | return Ok(ret); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ret)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/toc.rs:228:5 [INFO] [stderr] | [INFO] [stderr] 228 | / return toc.table_infos.iter().all(|(id, info)| [INFO] [stderr] 229 | | dirent_tables.get(id).map(|x| *x) == Some(info.file_size) [INFO] [stderr] 230 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 228 | toc.table_infos.iter().all(|(id, info)| [INFO] [stderr] 229 | dirent_tables.get(id).map(|x| *x) == Some(info.file_size) [INFO] [stderr] 230 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/toc.rs:267:5 [INFO] [stderr] | [INFO] [stderr] 267 | return Ok((f, toc)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((f, toc))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/toc.rs:274:5 [INFO] [stderr] | [INFO] [stderr] 274 | return Ok(process_entry(toc, entry)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(process_entry(toc, entry))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / return match bound { [INFO] [stderr] 20 | | &Bound::Excluded(ref s) => x < &s, [INFO] [stderr] 21 | | &Bound::Included(ref s) => x <= &s, [INFO] [stderr] 22 | | &Bound::Unbounded => true, [INFO] [stderr] 23 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 19 | match bound { [INFO] [stderr] 20 | &Bound::Excluded(ref s) => x < &s, [INFO] [stderr] 21 | &Bound::Included(ref s) => x <= &s, [INFO] [stderr] 22 | &Bound::Unbounded => true, [INFO] [stderr] 23 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / return match bound { [INFO] [stderr] 28 | | &Bound::Excluded(ref s) => x > &s, [INFO] [stderr] 29 | | &Bound::Included(ref s) => x >= &s, [INFO] [stderr] 30 | | &Bound::Unbounded => true, [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 27 | match bound { [INFO] [stderr] 28 | &Bound::Excluded(ref s) => x > &s, [INFO] [stderr] 29 | &Bound::Included(ref s) => x >= &s, [INFO] [stderr] 30 | &Bound::Unbounded => true, [INFO] [stderr] 31 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | return Ok(Store::make_existing(threshold, dir.to_string(), toc_file, toc, MemStore::new())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Store::make_existing(threshold, dir.to_string(), toc_file, toc, MemStore::new()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | / return Store{ [INFO] [stderr] 80 | | memstores: vec![MemStore::new(), ms], [INFO] [stderr] 81 | | threshold: threshold, [INFO] [stderr] 82 | | [INFO] [stderr] ... | [INFO] [stderr] 85 | | toc: toc, [INFO] [stderr] 86 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 79 | Store{ [INFO] [stderr] 80 | memstores: vec![MemStore::new(), ms], [INFO] [stderr] 81 | threshold: threshold, [INFO] [stderr] 82 | [INFO] [stderr] 83 | directory: directory, [INFO] [stderr] 84 | toc_file: toc_file, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | return Ok(false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(false)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | return Ok(false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(false)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | return self.consider_split(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.consider_split()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | return Ok(false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(false)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:236:13 [INFO] [stderr] | [INFO] [stderr] 236 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:308:13 [INFO] [stderr] | [INFO] [stderr] 308 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:267:28 [INFO] [stderr] | [INFO] [stderr] 267 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 268 | | if builder.is_empty() { [INFO] [stderr] 269 | | break 'outer; [INFO] [stderr] 270 | | } else { [INFO] [stderr] 271 | | break 'inner; [INFO] [stderr] 272 | | } [INFO] [stderr] 273 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 267 | } else if builder.is_empty() { [INFO] [stderr] 268 | break 'outer; [INFO] [stderr] 269 | } else { [INFO] [stderr] 270 | break 'inner; [INFO] [stderr] 271 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:313:9 [INFO] [stderr] | [INFO] [stderr] 313 | return !(!above_lower_bound(&x.biggest_key, &y.lower) || !below_upper_bound(&x.smallest_key, &y.upper)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `!(!above_lower_bound(&x.biggest_key, &y.lower) || !below_upper_bound(&x.smallest_key, &y.upper))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:324:9 [INFO] [stderr] | [INFO] [stderr] 324 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:328:9 [INFO] [stderr] | [INFO] [stderr] 328 | return !(x.biggest_key < y.smallest_key || y.biggest_key < x.smallest_key); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `!(x.biggest_key < y.smallest_key || y.biggest_key < x.smallest_key)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:353:9 [INFO] [stderr] | [INFO] [stderr] 353 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:372:9 [INFO] [stderr] | [INFO] [stderr] 372 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:404:9 [INFO] [stderr] | [INFO] [stderr] 404 | return Ok(false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(false)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:437:9 [INFO] [stderr] | [INFO] [stderr] 437 | return Ok(None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(None)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:447:9 [INFO] [stderr] | [INFO] [stderr] 447 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:499:9 [INFO] [stderr] | [INFO] [stderr] 499 | / return Ok(StoreIter{ [INFO] [stderr] 500 | | interval: interval.clone(), [INFO] [stderr] 501 | | iters: MergeIterator::make(iters, direction)?, [INFO] [stderr] 502 | | direction: direction, [INFO] [stderr] 503 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 499 | Ok(StoreIter{ [INFO] [stderr] 500 | interval: interval.clone(), [INFO] [stderr] 501 | iters: MergeIterator::make(iters, direction)?, [INFO] [stderr] 502 | direction: direction, [INFO] [stderr] 503 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:511:9 [INFO] [stderr] | [INFO] [stderr] 511 | return self.range_directed(interval, Direction::Forward); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.range_directed(interval, Direction::Forward)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:516:9 [INFO] [stderr] | [INFO] [stderr] 516 | return self.range_directed(interval, Direction::Backward); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.range_directed(interval, Direction::Backward)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | return Some(Mutation::Set(s)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Mutation::Set(s))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | return Some(Mutation::Delete); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Mutation::Delete)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | / return 1 // prev key entry len [INFO] [stderr] 94 | | + 1 // value len [INFO] [stderr] 95 | | + 3 // value offset [INFO] [stderr] 96 | | + 1 // key len [INFO] [stderr] 97 | | + key.len(); [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 93 | 1 // prev key entry len [INFO] [stderr] 94 | + 1 // value len [INFO] [stderr] 95 | + 3 // value offset [INFO] [stderr] 96 | + 1 // key len [INFO] [stderr] 97 | + key.len() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | / return 1 // Set/delete byte [INFO] [stderr] 101 | | + 1 // val len [INFO] [stderr] 102 | | + val.len(); [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 100 | 1 // Set/delete byte [INFO] [stderr] 101 | + 1 // val len [INFO] [stderr] 102 | + val.len() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | / return match val { [INFO] [stderr] 106 | | &Mutation::Set(ref x) => set_value_usage(&x), [INFO] [stderr] 107 | | &Mutation::Delete => 1, [INFO] [stderr] 108 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 105 | match val { [INFO] [stderr] 106 | &Mutation::Set(ref x) => set_value_usage(&x), [INFO] [stderr] 107 | &Mutation::Delete => 1, [INFO] [stderr] 108 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | / return TableBuilder{ [INFO] [stderr] 125 | | values_buf: Vec::new(), [INFO] [stderr] 126 | | keys_buf: Vec::new(), [INFO] [stderr] 127 | | first_key: None, [INFO] [stderr] 128 | | last_key: None, [INFO] [stderr] 129 | | last_entry_len: 0, [INFO] [stderr] 130 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 124 | TableBuilder{ [INFO] [stderr] 125 | values_buf: Vec::new(), [INFO] [stderr] 126 | keys_buf: Vec::new(), [INFO] [stderr] 127 | first_key: None, [INFO] [stderr] 128 | last_key: None, [INFO] [stderr] 129 | last_entry_len: 0, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | return self.first_key.is_none(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.first_key.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | return self.values_buf.len() + self.keys_buf.len() + TAB_BACK_PADDING; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.values_buf.len() + self.keys_buf.len() + TAB_BACK_PADDING` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | / return Ok(( [INFO] [stderr] 175 | | keys_offset, [INFO] [stderr] 176 | | keys_offset + self.keys_buf.len() as u64, [INFO] [stderr] 177 | | self.first_key.as_ref().unwrap().clone(), [INFO] [stderr] 178 | | self.last_key.as_ref().unwrap().clone(), [INFO] [stderr] 179 | | )); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 174 | Ok(( [INFO] [stderr] 175 | keys_offset, [INFO] [stderr] 176 | keys_offset + self.keys_buf.len() as u64, [INFO] [stderr] 177 | self.first_key.as_ref().unwrap().clone(), [INFO] [stderr] 178 | self.last_key.as_ref().unwrap().clone(), [INFO] [stderr] 179 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:192:5 [INFO] [stderr] | [INFO] [stderr] 192 | return builder.finish(&mut f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `builder.finish(&mut f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:197:5 [INFO] [stderr] | [INFO] [stderr] 197 | return Ok(f); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:207:5 [INFO] [stderr] | [INFO] [stderr] 207 | return Ok(buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:234:5 [INFO] [stderr] | [INFO] [stderr] 234 | return Ok(None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(None)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:256:9 [INFO] [stderr] | [INFO] [stderr] 256 | return Ok(TableKeysIterator{keys: keys, keys_pos: 0, keys_end_pos: keys_end_pos}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(TableKeysIterator{keys: keys, keys_pos: 0, keys_end_pos: keys_end_pos})` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:260:9 [INFO] [stderr] | [INFO] [stderr] 260 | return TableKeysInterval{keys_pos: self.keys_pos, keys_end_pos: self.keys_end_pos}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TableKeysInterval{keys_pos: self.keys_pos, keys_end_pos: self.keys_end_pos}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:271:9 [INFO] [stderr] | [INFO] [stderr] 271 | return Ok((key, value_offset, value_length)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((key, value_offset, value_length))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:281:9 [INFO] [stderr] | [INFO] [stderr] 281 | return Ok(Some(tup)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some(tup))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:285:9 [INFO] [stderr] | [INFO] [stderr] 285 | return TableKeysIterator::help_current_key(&self.keys, self.keys_pos, self.keys_end_pos); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TableKeysIterator::help_current_key(&self.keys, self.keys_pos, self.keys_end_pos)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:294:9 [INFO] [stderr] | [INFO] [stderr] 294 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:298:9 [INFO] [stderr] | [INFO] [stderr] 298 | return TableKeysIterator::help_step_key(&self.keys, &mut self.keys_pos) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TableKeysIterator::help_step_key(&self.keys, &mut self.keys_pos)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:306:9 [INFO] [stderr] | [INFO] [stderr] 306 | return Ok(None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(None)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:320:9 [INFO] [stderr] | [INFO] [stderr] 320 | return ret; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:333:9 [INFO] [stderr] | [INFO] [stderr] 333 | return Ok(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:344:5 [INFO] [stderr] | [INFO] [stderr] 344 | return Ok((f, keys_buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((f, keys_buf))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:355:5 [INFO] [stderr] | [INFO] [stderr] 355 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:414:9 [INFO] [stderr] | [INFO] [stderr] 414 | / return match direction { [INFO] [stderr] 415 | | Direction::Forward => keys_iter.current_key(), [INFO] [stderr] 416 | | Direction::Backward => keys_iter.current_back_key() [INFO] [stderr] 417 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 414 | match direction { [INFO] [stderr] 415 | Direction::Forward => keys_iter.current_key(), [INFO] [stderr] 416 | Direction::Backward => keys_iter.current_back_key() [INFO] [stderr] 417 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:421:9 [INFO] [stderr] | [INFO] [stderr] 421 | return TableIterator::help_current_entry(&self.keys_iter, self.direction); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TableIterator::help_current_entry(&self.keys_iter, self.direction)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:428:9 [INFO] [stderr] | [INFO] [stderr] 428 | return ret; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:447:9 [INFO] [stderr] | [INFO] [stderr] 447 | return mk_err("current_value called on empty TableIterator"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `mk_err("current_value called on empty TableIterator")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:453:17 [INFO] [stderr] | [INFO] [stderr] 453 | return self.keys_iter.step_key(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.keys_iter.step_key()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk.rs:459:17 [INFO] [stderr] | [INFO] [stderr] 459 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encoding.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | return Some(n); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encoding.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | return Some(x as usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(x as usize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encoding.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | return Some(n); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encoding.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | return Some(n); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encoding.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | return Some(slice); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(slice)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encoding.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | return Some(s.to_vec()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(s.to_vec())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoding.rs:163:25 [INFO] [stderr] | [INFO] [stderr] 163 | help_test_enc64(12345678); [INFO] [stderr] | ^^^^^^^^ help: consider: `12_345_678` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoding.rs:165:42 [INFO] [stderr] | [INFO] [stderr] 165 | help_test_enc64(((1u64) << 62) | 12345678); [INFO] [stderr] | ^^^^^^^^ help: consider: `12_345_678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoding.rs:167:42 [INFO] [stderr] | [INFO] [stderr] 167 | help_test_enc64(((1u64) << 63) | 12345678); [INFO] [stderr] | ^^^^^^^^ help: consider: `12_345_678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/error.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | return Error::MsgError(msg.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error::MsgError(msg.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/error.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | / return match self { [INFO] [stderr] 20 | | &Error::IoError(ref e) => (e as &std::error::Error).description(), [INFO] [stderr] 21 | | &Error::MsgError(ref s) => &s, [INFO] [stderr] 22 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 19 | match self { [INFO] [stderr] 20 | &Error::IoError(ref e) => (e as &std::error::Error).description(), [INFO] [stderr] 21 | &Error::MsgError(ref s) => &s, [INFO] [stderr] 22 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/error.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | return Err(Error::new(msg)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::new(msg))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/error.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | / return match self { [INFO] [stderr] 50 | | &Error::IoError(ref e) => Some(e), [INFO] [stderr] 51 | | &Error::MsgError(_) => None, [INFO] [stderr] 52 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 49 | match self { [INFO] [stderr] 50 | &Error::IoError(ref e) => Some(e), [INFO] [stderr] 51 | &Error::MsgError(_) => None, [INFO] [stderr] 52 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/iter.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | / return Ok(MergeIterator{ [INFO] [stderr] 48 | | iters: iters, [INFO] [stderr] 49 | | iters_front: iters_front, [INFO] [stderr] 50 | | direction: direction, [INFO] [stderr] 51 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 47 | Ok(MergeIterator{ [INFO] [stderr] 48 | iters: iters, [INFO] [stderr] 49 | iters_front: iters_front, [INFO] [stderr] 50 | direction: direction, [INFO] [stderr] 51 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/iter.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | return ret; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/iter.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/iter.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | return ret; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/iter.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/iter.rs:130:24 [INFO] [stderr] | [INFO] [stderr] 130 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 131 | | if let Some(iter) = (*self.next_gen)()? { [INFO] [stderr] 132 | | tup.1 = iter; [INFO] [stderr] 133 | | } else { [INFO] [stderr] 134 | | break; [INFO] [stderr] 135 | | } [INFO] [stderr] 136 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 130 | } else if let Some(iter) = (*self.next_gen)()? { [INFO] [stderr] 131 | tup.1 = iter; [INFO] [stderr] 132 | } else { [INFO] [stderr] 133 | break; [INFO] [stderr] 134 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memstore.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | return self.entries.get(key); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.entries.get(key)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memstore.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | return range.next().map(|(key, _)| key as &[u8]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `range.next().map(|(key, _)| key as &[u8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memstore.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | return range.next_back().map(|(key, _)| key as &[u8]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `range.next_back().map(|(key, _)| key as &[u8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memstore.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | return MemStore{entries: BTreeMap::::new(), mem_usage: 0}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `MemStore{entries: BTreeMap::::new(), mem_usage: 0}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memstore.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | / return match direction { [INFO] [stderr] 73 | | Direction::Forward => MemStoreIterator{ [INFO] [stderr] 74 | | memstore: ms, [INFO] [stderr] 75 | | current: ms.first_in_range(interval), [INFO] [stderr] ... | [INFO] [stderr] 84 | | } [INFO] [stderr] 85 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 72 | match direction { [INFO] [stderr] 73 | Direction::Forward => MemStoreIterator{ [INFO] [stderr] 74 | memstore: ms, [INFO] [stderr] 75 | current: ms.first_in_range(interval), [INFO] [stderr] 76 | bound: interval.upper.clone(), [INFO] [stderr] 77 | direction: direction, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memstore.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | return Ok(self.current); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(self.current)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memstore.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | return mk_err("current_value called on empty MemStoreIterator"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `mk_err("current_value called on empty MemStoreIterator")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memstore.rs:112:17 [INFO] [stderr] | [INFO] [stderr] 112 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memstore.rs:123:17 [INFO] [stderr] | [INFO] [stderr] 123 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/toc.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | return Ok(f); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/toc.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | / return Some(TableInfo{ [INFO] [stderr] 112 | | id: TableId(id), [INFO] [stderr] 113 | | level: level, [INFO] [stderr] 114 | | keys_offset: keys_offset, [INFO] [stderr] ... | [INFO] [stderr] 117 | | biggest_key: biggest_key, [INFO] [stderr] 118 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 111 | Some(TableInfo{ [INFO] [stderr] 112 | id: TableId(id), [INFO] [stderr] 113 | level: level, [INFO] [stderr] 114 | keys_offset: keys_offset, [INFO] [stderr] 115 | file_size: file_size, [INFO] [stderr] 116 | smallest_key: smallest_key, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/toc.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | return ret; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/toc.rs:174:5 [INFO] [stderr] | [INFO] [stderr] 174 | return Some(Entry{removals, additions}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Entry{removals, additions})` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/toc.rs:189:5 [INFO] [stderr] | [INFO] [stderr] 189 | return ret; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/toc.rs:204:5 [INFO] [stderr] | [INFO] [stderr] 204 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/toc.rs:224:5 [INFO] [stderr] | [INFO] [stderr] 224 | return Ok(ret); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ret)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/toc.rs:228:5 [INFO] [stderr] | [INFO] [stderr] 228 | / return toc.table_infos.iter().all(|(id, info)| [INFO] [stderr] 229 | | dirent_tables.get(id).map(|x| *x) == Some(info.file_size) [INFO] [stderr] 230 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 228 | toc.table_infos.iter().all(|(id, info)| [INFO] [stderr] 229 | dirent_tables.get(id).map(|x| *x) == Some(info.file_size) [INFO] [stderr] 230 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/toc.rs:267:5 [INFO] [stderr] | [INFO] [stderr] 267 | return Ok((f, toc)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((f, toc))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/toc.rs:274:5 [INFO] [stderr] | [INFO] [stderr] 274 | return Ok(process_entry(toc, entry)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(process_entry(toc, entry))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / return match bound { [INFO] [stderr] 20 | | &Bound::Excluded(ref s) => x < &s, [INFO] [stderr] 21 | | &Bound::Included(ref s) => x <= &s, [INFO] [stderr] 22 | | &Bound::Unbounded => true, [INFO] [stderr] 23 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 19 | match bound { [INFO] [stderr] 20 | &Bound::Excluded(ref s) => x < &s, [INFO] [stderr] 21 | &Bound::Included(ref s) => x <= &s, [INFO] [stderr] 22 | &Bound::Unbounded => true, [INFO] [stderr] 23 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / return match bound { [INFO] [stderr] 28 | | &Bound::Excluded(ref s) => x > &s, [INFO] [stderr] 29 | | &Bound::Included(ref s) => x >= &s, [INFO] [stderr] 30 | | &Bound::Unbounded => true, [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 27 | match bound { [INFO] [stderr] 28 | &Bound::Excluded(ref s) => x > &s, [INFO] [stderr] 29 | &Bound::Included(ref s) => x >= &s, [INFO] [stderr] 30 | &Bound::Unbounded => true, [INFO] [stderr] 31 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | return Ok(Store::make_existing(threshold, dir.to_string(), toc_file, toc, MemStore::new())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Store::make_existing(threshold, dir.to_string(), toc_file, toc, MemStore::new()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | / return Store{ [INFO] [stderr] 80 | | memstores: vec![MemStore::new(), ms], [INFO] [stderr] 81 | | threshold: threshold, [INFO] [stderr] 82 | | [INFO] [stderr] ... | [INFO] [stderr] 85 | | toc: toc, [INFO] [stderr] 86 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 79 | Store{ [INFO] [stderr] 80 | memstores: vec![MemStore::new(), ms], [INFO] [stderr] 81 | threshold: threshold, [INFO] [stderr] 82 | [INFO] [stderr] 83 | directory: directory, [INFO] [stderr] 84 | toc_file: toc_file, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | return Ok(false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(false)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | return Ok(false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(false)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | return self.consider_split(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.consider_split()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | return Ok(false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(false)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:236:13 [INFO] [stderr] | [INFO] [stderr] 236 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:308:13 [INFO] [stderr] | [INFO] [stderr] 308 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:267:28 [INFO] [stderr] | [INFO] [stderr] 267 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 268 | | if builder.is_empty() { [INFO] [stderr] 269 | | break 'outer; [INFO] [stderr] 270 | | } else { [INFO] [stderr] 271 | | break 'inner; [INFO] [stderr] 272 | | } [INFO] [stderr] 273 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 267 | } else if builder.is_empty() { [INFO] [stderr] 268 | break 'outer; [INFO] [stderr] 269 | } else { [INFO] [stderr] 270 | break 'inner; [INFO] [stderr] 271 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:313:9 [INFO] [stderr] | [INFO] [stderr] 313 | return !(!above_lower_bound(&x.biggest_key, &y.lower) || !below_upper_bound(&x.smallest_key, &y.upper)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `!(!above_lower_bound(&x.biggest_key, &y.lower) || !below_upper_bound(&x.smallest_key, &y.upper))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:324:9 [INFO] [stderr] | [INFO] [stderr] 324 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:328:9 [INFO] [stderr] | [INFO] [stderr] 328 | return !(x.biggest_key < y.smallest_key || y.biggest_key < x.smallest_key); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `!(x.biggest_key < y.smallest_key || y.biggest_key < x.smallest_key)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:353:9 [INFO] [stderr] | [INFO] [stderr] 353 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:372:9 [INFO] [stderr] | [INFO] [stderr] 372 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:404:9 [INFO] [stderr] | [INFO] [stderr] 404 | return Ok(false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(false)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:437:9 [INFO] [stderr] | [INFO] [stderr] 437 | return Ok(None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(None)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:447:9 [INFO] [stderr] | [INFO] [stderr] 447 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:499:9 [INFO] [stderr] | [INFO] [stderr] 499 | / return Ok(StoreIter{ [INFO] [stderr] 500 | | interval: interval.clone(), [INFO] [stderr] 501 | | iters: MergeIterator::make(iters, direction)?, [INFO] [stderr] 502 | | direction: direction, [INFO] [stderr] 503 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 499 | Ok(StoreIter{ [INFO] [stderr] 500 | interval: interval.clone(), [INFO] [stderr] 501 | iters: MergeIterator::make(iters, direction)?, [INFO] [stderr] 502 | direction: direction, [INFO] [stderr] 503 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:511:9 [INFO] [stderr] | [INFO] [stderr] 511 | return self.range_directed(interval, Direction::Forward); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.range_directed(interval, Direction::Forward)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:516:9 [INFO] [stderr] | [INFO] [stderr] 516 | return self.range_directed(interval, Direction::Backward); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.range_directed(interval, Direction::Backward)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:571:9 [INFO] [stderr] | [INFO] [stderr] 571 | return ret; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:588:13 [INFO] [stderr] | [INFO] [stderr] 588 | return ts; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `ts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:596:13 [INFO] [stderr] | [INFO] [stderr] 596 | return self.store.take().map(|_| ()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.store.take().map(|_| ())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:599:13 [INFO] [stderr] | [INFO] [stderr] 599 | return self.store.as_mut().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.store.as_mut().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:604:9 [INFO] [stderr] | [INFO] [stderr] 604 | return s.as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `s.as_bytes()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:800:40 [INFO] [stderr] | [INFO] [stderr] 800 | let mut ts = TestStore::create(2000000); [INFO] [stderr] | ^^^^^^^ help: consider: `2_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/disk.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | / match m { [INFO] [stderr] 57 | | &Mutation::Set(ref s) => { [INFO] [stderr] 58 | | v.push(0); [INFO] [stderr] 59 | | encode_str(v, s); [INFO] [stderr] ... | [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 56 | match *m { [INFO] [stderr] 57 | Mutation::Set(ref s) => { [INFO] [stderr] 58 | v.push(0); [INFO] [stderr] 59 | encode_str(v, s); [INFO] [stderr] 60 | }, [INFO] [stderr] 61 | Mutation::Delete => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/disk.rs:105:12 [INFO] [stderr] | [INFO] [stderr] 105 | return match val { [INFO] [stderr] | ____________^ [INFO] [stderr] 106 | | &Mutation::Set(ref x) => set_value_usage(&x), [INFO] [stderr] 107 | | &Mutation::Delete => 1, [INFO] [stderr] 108 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 105 | return match *val { [INFO] [stderr] 106 | Mutation::Set(ref x) => set_value_usage(&x), [INFO] [stderr] 107 | Mutation::Delete => 1, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/encoding.rs:27:14 [INFO] [stderr] | [INFO] [stderr] 27 | n |= ((b & 127) as u64) << shift; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(b & 127)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/encoding.rs:42:10 [INFO] [stderr] | [INFO] [stderr] 42 | n |= (b as u64) << 63; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `bytes`. [INFO] [stderr] --> src/encoding.rs:56:14 [INFO] [stderr] | [INFO] [stderr] 56 | for i in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 56 | for in &mut bytes { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/encoding.rs:70:14 [INFO] [stderr] | [INFO] [stderr] 70 | n |= v[*pos + i] as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(v[*pos + i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `bytes`. [INFO] [stderr] --> src/encoding.rs:78:14 [INFO] [stderr] | [INFO] [stderr] 78 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 78 | for in &mut bytes { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/encoding.rs:92:14 [INFO] [stderr] | [INFO] [stderr] 92 | n |= v[*pos + i] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(v[*pos + i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:19:16 [INFO] [stderr] | [INFO] [stderr] 19 | return match self { [INFO] [stderr] | ________________^ [INFO] [stderr] 20 | | &Error::IoError(ref e) => (e as &std::error::Error).description(), [INFO] [stderr] 21 | | &Error::MsgError(ref s) => &s, [INFO] [stderr] 22 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 19 | return match *self { [INFO] [stderr] 20 | Error::IoError(ref e) => (e as &std::error::Error).description(), [INFO] [stderr] 21 | Error::MsgError(ref s) => &s, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | return match self { [INFO] [stderr] | ________________^ [INFO] [stderr] 50 | | &Error::IoError(ref e) => Some(e), [INFO] [stderr] 51 | | &Error::MsgError(_) => None, [INFO] [stderr] 52 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 49 | return match *self { [INFO] [stderr] 50 | Error::IoError(ref e) => Some(e), [INFO] [stderr] 51 | Error::MsgError(_) => None, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/toc.rs:34:29 [INFO] [stderr] | [INFO] [stderr] 34 | const TOC_MAGIC: [u8; 8] = ['N' as u8, 'I' as u8, 'H' as u8, '\0' as u8, 1, 0, 0, 0]; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'N' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/toc.rs:34:40 [INFO] [stderr] | [INFO] [stderr] 34 | const TOC_MAGIC: [u8; 8] = ['N' as u8, 'I' as u8, 'H' as u8, '\0' as u8, 1, 0, 0, 0]; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'I' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/toc.rs:34:51 [INFO] [stderr] | [INFO] [stderr] 34 | const TOC_MAGIC: [u8; 8] = ['N' as u8, 'I' as u8, 'H' as u8, '\0' as u8, 1, 0, 0, 0]; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'H' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/toc.rs:34:62 [INFO] [stderr] | [INFO] [stderr] 34 | const TOC_MAGIC: [u8; 8] = ['N' as u8, 'I' as u8, 'H' as u8, '\0' as u8, 1, 0, 0, 0]; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/toc.rs:89:83 [INFO] [stderr] | [INFO] [stderr] 89 | let set: &mut BTreeSet = toc.level_infos.entry(level).or_insert_with(|| BTreeSet::::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BTreeSet::::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/toc.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | for ref table_info in &ent.additions { [INFO] [stderr] | ^^^^^^^^^^^^^^ -------------- help: try: `let table_info = &&ent.additions;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/toc.rs:197:5 [INFO] [stderr] | [INFO] [stderr] 197 | / if let Some(x) = frontpart.parse::().ok() { [INFO] [stderr] 198 | | // Multiple strings ("1", "01", "001", ...) can parse to the same [INFO] [stderr] 199 | | // integer, so double-check that this is truly the right table file. [INFO] [stderr] 200 | | if table_filename(TableId(x)) == name { [INFO] [stderr] 201 | | return Some(TableId(x)); [INFO] [stderr] 202 | | } [INFO] [stderr] 203 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::if_let_some_result)] on by default [INFO] [stderr] = help: Consider matching on `Ok(x)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/toc.rs:229:9 [INFO] [stderr] | [INFO] [stderr] 229 | dirent_tables.get(id).map(|x| *x) == Some(info.file_size) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `dirent_tables.get(id).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/util.rs:19:12 [INFO] [stderr] | [INFO] [stderr] 19 | return match bound { [INFO] [stderr] | ____________^ [INFO] [stderr] 20 | | &Bound::Excluded(ref s) => x < &s, [INFO] [stderr] 21 | | &Bound::Included(ref s) => x <= &s, [INFO] [stderr] 22 | | &Bound::Unbounded => true, [INFO] [stderr] 23 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 19 | return match *bound { [INFO] [stderr] 20 | Bound::Excluded(ref s) => x < &s, [INFO] [stderr] 21 | Bound::Included(ref s) => x <= &s, [INFO] [stderr] 22 | Bound::Unbounded => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/util.rs:20:36 [INFO] [stderr] | [INFO] [stderr] 20 | &Bound::Excluded(ref s) => x < &s, [INFO] [stderr] | ^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/util.rs:21:36 [INFO] [stderr] | [INFO] [stderr] 21 | &Bound::Included(ref s) => x <= &s, [INFO] [stderr] | ^^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/util.rs:27:12 [INFO] [stderr] | [INFO] [stderr] 27 | return match bound { [INFO] [stderr] | ____________^ [INFO] [stderr] 28 | | &Bound::Excluded(ref s) => x > &s, [INFO] [stderr] 29 | | &Bound::Included(ref s) => x >= &s, [INFO] [stderr] 30 | | &Bound::Unbounded => true, [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 27 | return match *bound { [INFO] [stderr] 28 | Bound::Excluded(ref s) => x > &s, [INFO] [stderr] 29 | Bound::Included(ref s) => x >= &s, [INFO] [stderr] 30 | Bound::Unbounded => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/util.rs:28:36 [INFO] [stderr] | [INFO] [stderr] 28 | &Bound::Excluded(ref s) => x > &s, [INFO] [stderr] | ^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/util.rs:29:36 [INFO] [stderr] | [INFO] [stderr] 29 | &Bound::Included(ref s) => x >= &s, [INFO] [stderr] | ^^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/util.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / match x { [INFO] [stderr] 36 | | &Bound::Excluded(ref b) => Bound::Excluded(b), [INFO] [stderr] 37 | | &Bound::Included(ref b) => Bound::Included(b), [INFO] [stderr] 38 | | &Bound::Unbounded => Bound::Unbounded, [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 35 | match *x { [INFO] [stderr] 36 | Bound::Excluded(ref b) => Bound::Excluded(b), [INFO] [stderr] 37 | Bound::Included(ref b) => Bound::Included(b), [INFO] [stderr] 38 | Bound::Unbounded => Bound::Unbounded, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:155:19 [INFO] [stderr] | [INFO] [stderr] 155 | = self.toc.level_infos.get(&0).unwrap().iter().rev().skip(1).map(|&x| x).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.toc.level_infos.get(&0).unwrap().iter().rev().skip(1).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:155:19 [INFO] [stderr] | [INFO] [stderr] 155 | = self.toc.level_infos.get(&0).unwrap().iter().rev().skip(1).map(|&x| x).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.toc.level_infos[&0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:219:33 [INFO] [stderr] | [INFO] [stderr] 219 | assert!(if level == 0 { tables.len() > 0 } else { tables.len() == 1 }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!tables.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:293:19 [INFO] [stderr] | [INFO] [stderr] 293 | = tables.iter().chain(lower_overlapping_ids.iter()).map(|&x| x).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `tables.iter().chain(lower_overlapping_ids.iter()).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:379:27 [INFO] [stderr] | [INFO] [stderr] 379 | return Ok(match m { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 380 | | &Mutation::Set(_) => true, [INFO] [stderr] 381 | | &Mutation::Delete => false, [INFO] [stderr] 382 | | }); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 379 | return Ok(match *m { [INFO] [stderr] 380 | Mutation::Set(_) => true, [INFO] [stderr] 381 | Mutation::Delete => false, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:390:20 [INFO] [stderr] | [INFO] [stderr] 390 | if key >= &ti.smallest_key && key <= &ti.biggest_key { [INFO] [stderr] | ^^^^^^^---------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `ti.smallest_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:390:47 [INFO] [stderr] | [INFO] [stderr] 390 | if key >= &ti.smallest_key && key <= &ti.biggest_key { [INFO] [stderr] | ^^^^^^^--------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `ti.biggest_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:413:27 [INFO] [stderr] | [INFO] [stderr] 413 | return Ok(match m { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 414 | | &Mutation::Set(ref x) => Some(x.clone()), [INFO] [stderr] 415 | | &Mutation::Delete => None, [INFO] [stderr] 416 | | }); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 413 | return Ok(match *m { [INFO] [stderr] 414 | Mutation::Set(ref x) => Some(x.clone()), [INFO] [stderr] 415 | Mutation::Delete => None, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:425:20 [INFO] [stderr] | [INFO] [stderr] 425 | if key >= &ti.smallest_key && key <= &ti.biggest_key { [INFO] [stderr] | ^^^^^^^---------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `ti.smallest_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:425:47 [INFO] [stderr] | [INFO] [stderr] 425 | if key >= &ti.smallest_key && key <= &ti.biggest_key { [INFO] [stderr] | ^^^^^^^--------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `ti.biggest_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/disk.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | / match m { [INFO] [stderr] 57 | | &Mutation::Set(ref s) => { [INFO] [stderr] 58 | | v.push(0); [INFO] [stderr] 59 | | encode_str(v, s); [INFO] [stderr] ... | [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 56 | match *m { [INFO] [stderr] 57 | Mutation::Set(ref s) => { [INFO] [stderr] 58 | v.push(0); [INFO] [stderr] 59 | encode_str(v, s); [INFO] [stderr] 60 | }, [INFO] [stderr] 61 | Mutation::Delete => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/disk.rs:105:12 [INFO] [stderr] | [INFO] [stderr] 105 | return match val { [INFO] [stderr] | ____________^ [INFO] [stderr] 106 | | &Mutation::Set(ref x) => set_value_usage(&x), [INFO] [stderr] 107 | | &Mutation::Delete => 1, [INFO] [stderr] 108 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 105 | return match *val { [INFO] [stderr] 106 | Mutation::Set(ref x) => set_value_usage(&x), [INFO] [stderr] 107 | Mutation::Delete => 1, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/encoding.rs:27:14 [INFO] [stderr] | [INFO] [stderr] 27 | n |= ((b & 127) as u64) << shift; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(b & 127)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/encoding.rs:42:10 [INFO] [stderr] | [INFO] [stderr] 42 | n |= (b as u64) << 63; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `bytes`. [INFO] [stderr] --> src/encoding.rs:56:14 [INFO] [stderr] | [INFO] [stderr] 56 | for i in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 56 | for in &mut bytes { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/encoding.rs:70:14 [INFO] [stderr] | [INFO] [stderr] 70 | n |= v[*pos + i] as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(v[*pos + i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `bytes`. [INFO] [stderr] --> src/encoding.rs:78:14 [INFO] [stderr] | [INFO] [stderr] 78 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 78 | for in &mut bytes { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/encoding.rs:92:14 [INFO] [stderr] | [INFO] [stderr] 92 | n |= v[*pos + i] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(v[*pos + i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/encoding.rs:124:27 [INFO] [stderr] | [INFO] [stderr] 124 | let text: &[u8] = "this is a test".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"this is a test"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/encoding.rs:145:19 [INFO] [stderr] | [INFO] [stderr] 145 | if num <= u32::max_value() as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(u32::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:19:16 [INFO] [stderr] | [INFO] [stderr] 19 | return match self { [INFO] [stderr] | ________________^ [INFO] [stderr] 20 | | &Error::IoError(ref e) => (e as &std::error::Error).description(), [INFO] [stderr] 21 | | &Error::MsgError(ref s) => &s, [INFO] [stderr] 22 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 19 | return match *self { [INFO] [stderr] 20 | Error::IoError(ref e) => (e as &std::error::Error).description(), [INFO] [stderr] 21 | Error::MsgError(ref s) => &s, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | return match self { [INFO] [stderr] | ________________^ [INFO] [stderr] 50 | | &Error::IoError(ref e) => Some(e), [INFO] [stderr] 51 | | &Error::MsgError(_) => None, [INFO] [stderr] 52 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 49 | return match *self { [INFO] [stderr] 50 | Error::IoError(ref e) => Some(e), [INFO] [stderr] 51 | Error::MsgError(_) => None, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/toc.rs:34:29 [INFO] [stderr] | [INFO] [stderr] 34 | const TOC_MAGIC: [u8; 8] = ['N' as u8, 'I' as u8, 'H' as u8, '\0' as u8, 1, 0, 0, 0]; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'N' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/toc.rs:34:40 [INFO] [stderr] | [INFO] [stderr] 34 | const TOC_MAGIC: [u8; 8] = ['N' as u8, 'I' as u8, 'H' as u8, '\0' as u8, 1, 0, 0, 0]; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'I' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/toc.rs:34:51 [INFO] [stderr] | [INFO] [stderr] 34 | const TOC_MAGIC: [u8; 8] = ['N' as u8, 'I' as u8, 'H' as u8, '\0' as u8, 1, 0, 0, 0]; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'H' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/toc.rs:34:62 [INFO] [stderr] | [INFO] [stderr] 34 | const TOC_MAGIC: [u8; 8] = ['N' as u8, 'I' as u8, 'H' as u8, '\0' as u8, 1, 0, 0, 0]; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/toc.rs:89:83 [INFO] [stderr] | [INFO] [stderr] 89 | let set: &mut BTreeSet = toc.level_infos.entry(level).or_insert_with(|| BTreeSet::::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BTreeSet::::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/toc.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | for ref table_info in &ent.additions { [INFO] [stderr] | ^^^^^^^^^^^^^^ -------------- help: try: `let table_info = &&ent.additions;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/toc.rs:197:5 [INFO] [stderr] | [INFO] [stderr] 197 | / if let Some(x) = frontpart.parse::().ok() { [INFO] [stderr] 198 | | // Multiple strings ("1", "01", "001", ...) can parse to the same [INFO] [stderr] 199 | | // integer, so double-check that this is truly the right table file. [INFO] [stderr] 200 | | if table_filename(TableId(x)) == name { [INFO] [stderr] 201 | | return Some(TableId(x)); [INFO] [stderr] 202 | | } [INFO] [stderr] 203 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::if_let_some_result)] on by default [INFO] [stderr] = help: Consider matching on `Ok(x)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/toc.rs:229:9 [INFO] [stderr] | [INFO] [stderr] 229 | dirent_tables.get(id).map(|x| *x) == Some(info.file_size) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `dirent_tables.get(id).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/util.rs:19:12 [INFO] [stderr] | [INFO] [stderr] 19 | return match bound { [INFO] [stderr] | ____________^ [INFO] [stderr] 20 | | &Bound::Excluded(ref s) => x < &s, [INFO] [stderr] 21 | | &Bound::Included(ref s) => x <= &s, [INFO] [stderr] 22 | | &Bound::Unbounded => true, [INFO] [stderr] 23 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 19 | return match *bound { [INFO] [stderr] 20 | Bound::Excluded(ref s) => x < &s, [INFO] [stderr] 21 | Bound::Included(ref s) => x <= &s, [INFO] [stderr] 22 | Bound::Unbounded => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/util.rs:20:36 [INFO] [stderr] | [INFO] [stderr] 20 | &Bound::Excluded(ref s) => x < &s, [INFO] [stderr] | ^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/util.rs:21:36 [INFO] [stderr] | [INFO] [stderr] 21 | &Bound::Included(ref s) => x <= &s, [INFO] [stderr] | ^^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/util.rs:27:12 [INFO] [stderr] | [INFO] [stderr] 27 | return match bound { [INFO] [stderr] | ____________^ [INFO] [stderr] 28 | | &Bound::Excluded(ref s) => x > &s, [INFO] [stderr] 29 | | &Bound::Included(ref s) => x >= &s, [INFO] [stderr] 30 | | &Bound::Unbounded => true, [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 27 | return match *bound { [INFO] [stderr] 28 | Bound::Excluded(ref s) => x > &s, [INFO] [stderr] 29 | Bound::Included(ref s) => x >= &s, [INFO] [stderr] 30 | Bound::Unbounded => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/util.rs:28:36 [INFO] [stderr] | [INFO] [stderr] 28 | &Bound::Excluded(ref s) => x > &s, [INFO] [stderr] | ^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/util.rs:29:36 [INFO] [stderr] | [INFO] [stderr] 29 | &Bound::Included(ref s) => x >= &s, [INFO] [stderr] | ^^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/util.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / match x { [INFO] [stderr] 36 | | &Bound::Excluded(ref b) => Bound::Excluded(b), [INFO] [stderr] 37 | | &Bound::Included(ref b) => Bound::Included(b), [INFO] [stderr] 38 | | &Bound::Unbounded => Bound::Unbounded, [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 35 | match *x { [INFO] [stderr] 36 | Bound::Excluded(ref b) => Bound::Excluded(b), [INFO] [stderr] 37 | Bound::Included(ref b) => Bound::Included(b), [INFO] [stderr] 38 | Bound::Unbounded => Bound::Unbounded, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:155:19 [INFO] [stderr] | [INFO] [stderr] 155 | = self.toc.level_infos.get(&0).unwrap().iter().rev().skip(1).map(|&x| x).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.toc.level_infos.get(&0).unwrap().iter().rev().skip(1).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:155:19 [INFO] [stderr] | [INFO] [stderr] 155 | = self.toc.level_infos.get(&0).unwrap().iter().rev().skip(1).map(|&x| x).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.toc.level_infos[&0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:219:33 [INFO] [stderr] | [INFO] [stderr] 219 | assert!(if level == 0 { tables.len() > 0 } else { tables.len() == 1 }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!tables.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:293:19 [INFO] [stderr] | [INFO] [stderr] 293 | = tables.iter().chain(lower_overlapping_ids.iter()).map(|&x| x).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `tables.iter().chain(lower_overlapping_ids.iter()).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:379:27 [INFO] [stderr] | [INFO] [stderr] 379 | return Ok(match m { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 380 | | &Mutation::Set(_) => true, [INFO] [stderr] 381 | | &Mutation::Delete => false, [INFO] [stderr] 382 | | }); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 379 | return Ok(match *m { [INFO] [stderr] 380 | Mutation::Set(_) => true, [INFO] [stderr] 381 | Mutation::Delete => false, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:390:20 [INFO] [stderr] | [INFO] [stderr] 390 | if key >= &ti.smallest_key && key <= &ti.biggest_key { [INFO] [stderr] | ^^^^^^^---------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `ti.smallest_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:390:47 [INFO] [stderr] | [INFO] [stderr] 390 | if key >= &ti.smallest_key && key <= &ti.biggest_key { [INFO] [stderr] | ^^^^^^^--------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `ti.biggest_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:413:27 [INFO] [stderr] | [INFO] [stderr] 413 | return Ok(match m { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 414 | | &Mutation::Set(ref x) => Some(x.clone()), [INFO] [stderr] 415 | | &Mutation::Delete => None, [INFO] [stderr] 416 | | }); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 413 | return Ok(match *m { [INFO] [stderr] 414 | Mutation::Set(ref x) => Some(x.clone()), [INFO] [stderr] 415 | Mutation::Delete => None, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:425:20 [INFO] [stderr] | [INFO] [stderr] 425 | if key >= &ti.smallest_key && key <= &ti.biggest_key { [INFO] [stderr] | ^^^^^^^---------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `ti.smallest_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:425:47 [INFO] [stderr] | [INFO] [stderr] 425 | if key >= &ti.smallest_key && key <= &ti.biggest_key { [INFO] [stderr] | ^^^^^^^--------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `ti.biggest_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.00s [INFO] running `"docker" "inspect" "8904dba4ca2cd6ddcd839426e0d95adc8610ad1d85b3ebcb579ccc0e8783ae1a"` [INFO] running `"docker" "rm" "-f" "8904dba4ca2cd6ddcd839426e0d95adc8610ad1d85b3ebcb579ccc0e8783ae1a"` [INFO] [stdout] 8904dba4ca2cd6ddcd839426e0d95adc8610ad1d85b3ebcb579ccc0e8783ae1a