[INFO] crate nickel_sqlite 0.4.0 is already in cache [INFO] extracting crate nickel_sqlite 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/nickel_sqlite/0.4.0 [INFO] extracting crate nickel_sqlite 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nickel_sqlite/0.4.0 [INFO] validating manifest of nickel_sqlite-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nickel_sqlite-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nickel_sqlite-0.4.0 [INFO] finished frobbing nickel_sqlite-0.4.0 [INFO] frobbed toml for nickel_sqlite-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/nickel_sqlite/0.4.0/Cargo.toml [INFO] started frobbing nickel_sqlite-0.4.0 [INFO] finished frobbing nickel_sqlite-0.4.0 [INFO] frobbed toml for nickel_sqlite-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nickel_sqlite/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nickel_sqlite-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/nickel_sqlite/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 364ebba5ffeecaa853f9ba5286886852b3de82c5d402ae0a885b20585ab5c1b8 [INFO] running `"docker" "start" "-a" "364ebba5ffeecaa853f9ba5286886852b3de82c5d402ae0a885b20585ab5c1b8"` [INFO] [stderr] Checking rusqlite v0.13.0 [INFO] [stderr] Checking nickel v0.10.2 [INFO] [stderr] Checking r2d2_sqlite v0.5.0 [INFO] [stderr] Checking nickel_sqlite v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/middleware.rs:28:28 [INFO] [stderr] | [INFO] [stderr] 28 | SqliteMiddleware { pool: pool } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pool` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/middleware.rs:28:28 [INFO] [stderr] | [INFO] [stderr] 28 | SqliteMiddleware { pool: pool } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pool` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> examples/with_pool.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / match db.execute(CREATE_TABLE, &[]) { [INFO] [stderr] 33 | | Ok(_) => println!("created table 'person'"), [INFO] [stderr] 34 | | Err(_) => {} // handle err [INFO] [stderr] 35 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Ok(_) = db.execute(CREATE_TABLE, &[]) { println!("created table 'person'") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> examples/with_pool.rs:45:25 [INFO] [stderr] | [INFO] [stderr] 45 | Ok(_) => format!("Sucessfully created an entry"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Sucessfully created an entry".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> examples/example.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / match db.execute(CREATE_TABLE, &[]) { [INFO] [stderr] 29 | | Ok(_) => println!("created table 'person'"), [INFO] [stderr] 30 | | Err(_) => {} // handle error [INFO] [stderr] 31 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Ok(_) = db.execute(CREATE_TABLE, &[]) { println!("created table 'person'") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> examples/example.rs:41:25 [INFO] [stderr] | [INFO] [stderr] 41 | Ok(_) => format!("Sucessfully created an entry"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Sucessfully created an entry".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.04s [INFO] running `"docker" "inspect" "364ebba5ffeecaa853f9ba5286886852b3de82c5d402ae0a885b20585ab5c1b8"` [INFO] running `"docker" "rm" "-f" "364ebba5ffeecaa853f9ba5286886852b3de82c5d402ae0a885b20585ab5c1b8"` [INFO] [stdout] 364ebba5ffeecaa853f9ba5286886852b3de82c5d402ae0a885b20585ab5c1b8