[INFO] crate nickel 0.10.2 is already in cache [INFO] extracting crate nickel 0.10.2 into work/ex/clippy-test-run/sources/stable/reg/nickel/0.10.2 [INFO] extracting crate nickel 0.10.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nickel/0.10.2 [INFO] validating manifest of nickel-0.10.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nickel-0.10.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nickel-0.10.2 [INFO] removed 0 missing examples [INFO] finished frobbing nickel-0.10.2 [INFO] frobbed toml for nickel-0.10.2 written to work/ex/clippy-test-run/sources/stable/reg/nickel/0.10.2/Cargo.toml [INFO] started frobbing nickel-0.10.2 [INFO] removed 0 missing examples [INFO] finished frobbing nickel-0.10.2 [INFO] frobbed toml for nickel-0.10.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nickel/0.10.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nickel-0.10.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/nickel/0.10.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 07062422c4b378cafbf9552d306017458d0a66f2c4a4a6c000c42c3420196b49 [INFO] running `"docker" "start" "-a" "07062422c4b378cafbf9552d306017458d0a66f2c4a4a6c000c42c3420196b49"` [INFO] [stderr] Checking mustache v0.8.2 [INFO] [stderr] Checking nickel v0.10.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/router/router.rs:66:21 [INFO] [stderr] | [INFO] [stderr] 66 | route: route [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `route` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/router/router.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | method: method, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `method` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/router/matcher.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | regex: regex [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `regex` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | middleware_stack: middleware_stack, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `middleware_stack` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nickel.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | middleware_stack: middleware_stack, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `middleware_stack` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nickel.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nickel.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | data: data [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/response.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | templates: templates, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `templates` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/response.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/response.rs:233:21 [INFO] [stderr] | [INFO] [stderr] 233 | origin: origin, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/response.rs:234:21 [INFO] [stderr] | [INFO] [stderr] 234 | templates: templates, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `templates` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/response.rs:235:21 [INFO] [stderr] | [INFO] [stderr] 235 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/response.rs:236:21 [INFO] [stderr] | [INFO] [stderr] 236 | map: map, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/response.rs:237:21 [INFO] [stderr] | [INFO] [stderr] 237 | on_send: on_send [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `on_send` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/favicon_handler.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | icon: icon, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `icon` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/favicon_handler.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | icon_path: icon_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `icon_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mount.rs:68:21 [INFO] [stderr] | [INFO] [stderr] 68 | mount_point: mount_point, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mount_point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mount.rs:69:21 [INFO] [stderr] | [INFO] [stderr] 69 | middleware: middleware [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `middleware` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/template_cache.rs:23:26 [INFO] [stderr] | [INFO] [stderr] 23 | Ok(TemplateEntry{template: template, mtime: attr.modified()?, last_checked: SystemTime::now()}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `template` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/router/router.rs:66:21 [INFO] [stderr] | [INFO] [stderr] 66 | route: route [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `route` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/router/router.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | method: method, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `method` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/router/matcher.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | regex: regex [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `regex` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | middleware_stack: middleware_stack, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `middleware_stack` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nickel.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | middleware_stack: middleware_stack, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `middleware_stack` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nickel.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nickel.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | data: data [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/response.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | templates: templates, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `templates` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/response.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/response.rs:233:21 [INFO] [stderr] | [INFO] [stderr] 233 | origin: origin, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/response.rs:234:21 [INFO] [stderr] | [INFO] [stderr] 234 | templates: templates, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `templates` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/response.rs:235:21 [INFO] [stderr] | [INFO] [stderr] 235 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/response.rs:236:21 [INFO] [stderr] | [INFO] [stderr] 236 | map: map, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/response.rs:237:21 [INFO] [stderr] | [INFO] [stderr] 237 | on_send: on_send [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `on_send` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/favicon_handler.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | icon: icon, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `icon` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/favicon_handler.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | icon_path: icon_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `icon_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mount.rs:68:21 [INFO] [stderr] | [INFO] [stderr] 68 | mount_point: mount_point, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mount_point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mount.rs:69:21 [INFO] [stderr] | [INFO] [stderr] 69 | middleware: middleware [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `middleware` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/template_cache.rs:23:26 [INFO] [stderr] | [INFO] [stderr] 23 | Ok(TemplateEntry{template: template, mtime: attr.modified()?, last_checked: SystemTime::now()}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `template` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/router/mod.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | pub mod router; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/router/mod.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | pub mod router; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/router/router.rs:31:16 [INFO] [stderr] | [INFO] [stderr] 31 | if k == &key { [INFO] [stderr] | ^^^^^---- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `router::router::Router` [INFO] [stderr] --> src/router/router.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | / pub fn new() -> Router { [INFO] [stderr] 54 | | Router { [INFO] [stderr] 55 | | routes: Vec::new() [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 48 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/router/into_matcher.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | let c = captures.iter().skip(1).next().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `nickel::Nickel` [INFO] [stderr] --> src/nickel.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | / pub fn new() -> Nickel<()> { [INFO] [stderr] 95 | | Nickel::with_data(()) [INFO] [stderr] 96 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 92 | impl Default for nickel::Nickel { [INFO] [stderr] 93 | fn default() -> Self { [INFO] [stderr] 94 | Self::new() [INFO] [stderr] 95 | } [INFO] [stderr] 96 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/macros/middleware.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | / fn restrict<'mw, D, R: Responder>(r: R, res: Response<'mw, D>) [INFO] [stderr] 97 | | -> MiddlewareResult<'mw, D> { [INFO] [stderr] 98 | | res.send(r) [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] ::: src/nickel.rs:229:46 [INFO] [stderr] | [INFO] [stderr] 229 | self.middleware_stack.add_middleware(middleware! { [INFO] [stderr] | ______________________________________________- [INFO] [stderr] 230 | | (StatusCode::NotFound, "File Not Found") [INFO] [stderr] 231 | | }); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/macros/middleware.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | / fn restrict<'mw, D, R: Responder>(r: R, res: Response<'mw, D>) [INFO] [stderr] 97 | | -> MiddlewareResult<'mw, D> { [INFO] [stderr] 98 | | res.send(r) [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] ::: src/nickel.rs:303:46 [INFO] [stderr] | [INFO] [stderr] 303 | self.middleware_stack.add_middleware(middleware! { [INFO] [stderr] | ______________________________________________- [INFO] [stderr] 304 | | (StatusCode::NotFound, "File Not Found") [INFO] [stderr] 305 | | }); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/response.rs:30:14 [INFO] [stderr] | [INFO] [stderr] 30 | on_send: Vec)>> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/response.rs:34:30 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn from_internal<'c, 'd>(response: HyperResponse<'c, Fresh>, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/responder.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | fn respond<'a>(self, Response<'a, D>) -> MiddlewareResult<'a, D>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/responder.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / fn respond<'a>(self, res: Response<'a, D>) -> MiddlewareResult<'a, D> { [INFO] [stderr] 30 | | res.next_middleware() [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/responder.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / fn respond<'a>(self, mut res: Response<'a, D>) -> MiddlewareResult<'a, D> { [INFO] [stderr] 36 | | maybe_set_type(&mut res, MediaType::Json); [INFO] [stderr] 37 | | res.send(json::encode(&self) [INFO] [stderr] 38 | | .map_err(|e| format!("Failed to parse JSON: {}", e))) [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/responder.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / fn respond<'a>(self, res: Response<'a, D>) -> MiddlewareResult<'a, D> { [INFO] [stderr] 46 | | let data = try_with!(res, self); [INFO] [stderr] 47 | | res.send(data) [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/responder.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | fn respond<'c>($s, mut $res: Response<'c, D>) -> MiddlewareResult<'c, D> $b [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 67 | / dual_impl!(&'a [u8], [INFO] [stderr] 68 | | Vec, [INFO] [stderr] 69 | | |self, res| { [INFO] [stderr] 70 | | maybe_set_type(&mut res, MediaType::Bin); [INFO] [stderr] ... | [INFO] [stderr] 76 | | } [INFO] [stderr] 77 | | }); [INFO] [stderr] | |_______________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/responder.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | fn respond<'c>($s, mut $res: Response<'c, D>) -> MiddlewareResult<'c, D> $b [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 67 | / dual_impl!(&'a [u8], [INFO] [stderr] 68 | | Vec, [INFO] [stderr] 69 | | |self, res| { [INFO] [stderr] 70 | | maybe_set_type(&mut res, MediaType::Bin); [INFO] [stderr] ... | [INFO] [stderr] 76 | | } [INFO] [stderr] 77 | | }); [INFO] [stderr] | |_______________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/responder.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | fn respond<'c>($s, mut $res: Response<'c, D>) -> MiddlewareResult<'c, D> $b [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 79 | / dual_impl!(&'a str, [INFO] [stderr] 80 | | String, [INFO] [stderr] 81 | | |self, res| { [INFO] [stderr] 82 | | maybe_set_type(&mut res, MediaType::Html); [INFO] [stderr] 83 | | res.send(self.as_bytes()) [INFO] [stderr] 84 | | }); [INFO] [stderr] | |_______________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/responder.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | fn respond<'c>($s, mut $res: Response<'c, D>) -> MiddlewareResult<'c, D> $b [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 79 | / dual_impl!(&'a str, [INFO] [stderr] 80 | | String, [INFO] [stderr] 81 | | |self, res| { [INFO] [stderr] 82 | | maybe_set_type(&mut res, MediaType::Html); [INFO] [stderr] 83 | | res.send(self.as_bytes()) [INFO] [stderr] 84 | | }); [INFO] [stderr] | |_______________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/responder.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | fn respond<'c>($s, mut $res: Response<'c, D>) -> MiddlewareResult<'c, D> $b [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 86 | / dual_impl!((StatusCode, &'static str), [INFO] [stderr] 87 | | (StatusCode, String), [INFO] [stderr] 88 | | |self, res| { [INFO] [stderr] 89 | | let (status, message) = self; [INFO] [stderr] ... | [INFO] [stderr] 99 | | } [INFO] [stderr] 100 | | }); [INFO] [stderr] | |_______________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/responder.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | fn respond<'c>($s, mut $res: Response<'c, D>) -> MiddlewareResult<'c, D> $b [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 86 | / dual_impl!((StatusCode, &'static str), [INFO] [stderr] 87 | | (StatusCode, String), [INFO] [stderr] 88 | | |self, res| { [INFO] [stderr] 89 | | let (status, message) = self; [INFO] [stderr] ... | [INFO] [stderr] 99 | | } [INFO] [stderr] 100 | | }); [INFO] [stderr] | |_______________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/responder.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | / fn respond<'c>(self, res: Response<'c, D>) -> MiddlewareResult<'c, D> { [INFO] [stderr] 105 | | res.send((self, "")) [INFO] [stderr] 106 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/responder.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | fn respond<'c>($s, mut $res: Response<'c, D>) -> MiddlewareResult<'c, D> $b [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 109 | / dual_impl!(&'a [&'a str], [INFO] [stderr] 110 | | &'a [String], [INFO] [stderr] 111 | | |self, res| { [INFO] [stderr] 112 | | maybe_set_type(&mut res, MediaType::Html); [INFO] [stderr] ... | [INFO] [stderr] 120 | | Ok(Halt(stream)) [INFO] [stderr] 121 | | }); [INFO] [stderr] | |_______________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/responder.rs:115:21 [INFO] [stderr] | [INFO] [stderr] 115 | for ref s in self.iter() { [INFO] [stderr] | ^^^^^ ----------- help: try: `let s = &self.iter();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/responder.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | fn respond<'c>($s, mut $res: Response<'c, D>) -> MiddlewareResult<'c, D> $b [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 109 | / dual_impl!(&'a [&'a str], [INFO] [stderr] 110 | | &'a [String], [INFO] [stderr] 111 | | |self, res| { [INFO] [stderr] 112 | | maybe_set_type(&mut res, MediaType::Html); [INFO] [stderr] ... | [INFO] [stderr] 120 | | Ok(Halt(stream)) [INFO] [stderr] 121 | | }); [INFO] [stderr] | |_______________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/responder.rs:115:21 [INFO] [stderr] | [INFO] [stderr] 115 | for ref s in self.iter() { [INFO] [stderr] | ^^^^^ ----------- help: try: `let s = &self.iter();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/responder.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | fn respond<'c>($s, mut $res: Response<'c, D>) -> MiddlewareResult<'c, D> $b [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 123 | / dual_impl!((u16, &'static str), [INFO] [stderr] 124 | | (u16, String), [INFO] [stderr] 125 | | |self, res| { [INFO] [stderr] 126 | | let (status, message) = self; [INFO] [stderr] 127 | | res.send((StatusCode::from_u16(status), message)) [INFO] [stderr] 128 | | }); [INFO] [stderr] | |_______________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/responder.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | fn respond<'c>($s, mut $res: Response<'c, D>) -> MiddlewareResult<'c, D> $b [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 123 | / dual_impl!((u16, &'static str), [INFO] [stderr] 124 | | (u16, String), [INFO] [stderr] 125 | | |self, res| { [INFO] [stderr] 126 | | let (status, message) = self; [INFO] [stderr] 127 | | res.send((StatusCode::from_u16(status), message)) [INFO] [stderr] 128 | | }); [INFO] [stderr] | |_______________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/static_files_handler.rs:59:22 [INFO] [stderr] | [INFO] [stderr] 59 | fn with_file<'a, 'b, D, P>(&self, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/query_string.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | / self.get_ref::() [INFO] [stderr] 41 | | .ok() [INFO] [stderr] 42 | | .expect("Bug: QueryStringParser returned None") [INFO] [stderr] | |___________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/router/router.rs:31:16 [INFO] [stderr] | [INFO] [stderr] 31 | if k == &key { [INFO] [stderr] | ^^^^^---- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `router::router::Router` [INFO] [stderr] --> src/router/router.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | / pub fn new() -> Router { [INFO] [stderr] 54 | | Router { [INFO] [stderr] 55 | | routes: Vec::new() [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 48 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/macros/middleware.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | / fn restrict<'mw, D, R: Responder>(r: R, res: Response<'mw, D>) [INFO] [stderr] 97 | | -> MiddlewareResult<'mw, D> { [INFO] [stderr] 98 | | res.send(r) [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] ::: src/router/router.rs:205:56 [INFO] [stderr] | [INFO] [stderr] 205 | route_store.add_route(Method::Get, "/foo/:userid", middleware! { "hello from foo" }); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/macros/middleware.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | / fn restrict<'mw, D, R: Responder>(r: R, res: Response<'mw, D>) [INFO] [stderr] 97 | | -> MiddlewareResult<'mw, D> { [INFO] [stderr] 98 | | res.send(r) [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] ::: src/router/router.rs:206:48 [INFO] [stderr] | [INFO] [stderr] 206 | route_store.add_route(Method::Get, "/bar", middleware! { "hello from foo" }); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/macros/middleware.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | / fn restrict<'mw, D, R: Responder>(r: R, res: Response<'mw, D>) [INFO] [stderr] 97 | | -> MiddlewareResult<'mw, D> { [INFO] [stderr] 98 | | res.send(r) [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] ::: src/router/router.rs:207:63 [INFO] [stderr] | [INFO] [stderr] 207 | route_store.add_route(Method::Get, "/file/:format/:file", middleware! { "hello from foo" }); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/macros/middleware.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | / fn restrict<'mw, D, R: Responder>(r: R, res: Response<'mw, D>) [INFO] [stderr] 97 | | -> MiddlewareResult<'mw, D> { [INFO] [stderr] 98 | | res.send(r) [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] ::: src/router/router.rs:269:19 [INFO] [stderr] | [INFO] [stderr] 269 | let handler = middleware! { "hello from foo" }; [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/macros/middleware.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | / fn restrict<'mw, D, R: Responder>(r: R, res: Response<'mw, D>) [INFO] [stderr] 97 | | -> MiddlewareResult<'mw, D> { [INFO] [stderr] 98 | | res.send(r) [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] ::: src/router/router.rs:291:47 [INFO] [stderr] | [INFO] [stderr] 291 | route_store.add_route(Method::Get, regex, middleware! { "hello from foo" }); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/macros/middleware.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | / fn restrict<'mw, D, R: Responder>(r: R, res: Response<'mw, D>) [INFO] [stderr] 97 | | -> MiddlewareResult<'mw, D> { [INFO] [stderr] 98 | | res.send(r) [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] ::: src/router/router.rs:313:47 [INFO] [stderr] | [INFO] [stderr] 313 | route_store.add_route(Method::Get, regex, middleware! { "hello from foo" }); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/macros/middleware.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | / fn restrict<'mw, D, R: Responder>(r: R, res: Response<'mw, D>) [INFO] [stderr] 97 | | -> MiddlewareResult<'mw, D> { [INFO] [stderr] 98 | | res.send(r) [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] ::: src/router/router.rs:338:47 [INFO] [stderr] | [INFO] [stderr] 338 | route_store.add_route(Method::Get, regex, middleware! { "hello from foo" }); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/macros/middleware.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | / fn restrict<'mw, D, R: Responder>(r: R, res: Response<'mw, D>) [INFO] [stderr] 97 | | -> MiddlewareResult<'mw, D> { [INFO] [stderr] 98 | | res.send(r) [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] ::: src/router/router.rs:339:49 [INFO] [stderr] | [INFO] [stderr] 339 | route_store.add_route(Method::Get, "/:foo", middleware! { "hello from foo" }); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/router/into_matcher.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | let c = captures.iter().skip(1).next().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `nickel::Nickel` [INFO] [stderr] --> src/nickel.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | / pub fn new() -> Nickel<()> { [INFO] [stderr] 95 | | Nickel::with_data(()) [INFO] [stderr] 96 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 92 | impl Default for nickel::Nickel { [INFO] [stderr] 93 | fn default() -> Self { [INFO] [stderr] 94 | Self::new() [INFO] [stderr] 95 | } [INFO] [stderr] 96 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/macros/middleware.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | / fn restrict<'mw, D, R: Responder>(r: R, res: Response<'mw, D>) [INFO] [stderr] 97 | | -> MiddlewareResult<'mw, D> { [INFO] [stderr] 98 | | res.send(r) [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] ::: src/nickel.rs:229:46 [INFO] [stderr] | [INFO] [stderr] 229 | self.middleware_stack.add_middleware(middleware! { [INFO] [stderr] | ______________________________________________- [INFO] [stderr] 230 | | (StatusCode::NotFound, "File Not Found") [INFO] [stderr] 231 | | }); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/macros/middleware.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | / fn restrict<'mw, D, R: Responder>(r: R, res: Response<'mw, D>) [INFO] [stderr] 97 | | -> MiddlewareResult<'mw, D> { [INFO] [stderr] 98 | | res.send(r) [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] ::: src/nickel.rs:303:46 [INFO] [stderr] | [INFO] [stderr] 303 | self.middleware_stack.add_middleware(middleware! { [INFO] [stderr] | ______________________________________________- [INFO] [stderr] 304 | | (StatusCode::NotFound, "File Not Found") [INFO] [stderr] 305 | | }); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/response.rs:30:14 [INFO] [stderr] | [INFO] [stderr] 30 | on_send: Vec)>> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/response.rs:34:30 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn from_internal<'c, 'd>(response: HyperResponse<'c, Fresh>, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/responder.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | fn respond<'a>(self, Response<'a, D>) -> MiddlewareResult<'a, D>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/responder.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / fn respond<'a>(self, res: Response<'a, D>) -> MiddlewareResult<'a, D> { [INFO] [stderr] 30 | | res.next_middleware() [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/responder.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / fn respond<'a>(self, mut res: Response<'a, D>) -> MiddlewareResult<'a, D> { [INFO] [stderr] 36 | | maybe_set_type(&mut res, MediaType::Json); [INFO] [stderr] 37 | | res.send(json::encode(&self) [INFO] [stderr] 38 | | .map_err(|e| format!("Failed to parse JSON: {}", e))) [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/responder.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / fn respond<'a>(self, res: Response<'a, D>) -> MiddlewareResult<'a, D> { [INFO] [stderr] 46 | | let data = try_with!(res, self); [INFO] [stderr] 47 | | res.send(data) [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/responder.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | fn respond<'c>($s, mut $res: Response<'c, D>) -> MiddlewareResult<'c, D> $b [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 67 | / dual_impl!(&'a [u8], [INFO] [stderr] 68 | | Vec, [INFO] [stderr] 69 | | |self, res| { [INFO] [stderr] 70 | | maybe_set_type(&mut res, MediaType::Bin); [INFO] [stderr] ... | [INFO] [stderr] 76 | | } [INFO] [stderr] 77 | | }); [INFO] [stderr] | |_______________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/responder.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | fn respond<'c>($s, mut $res: Response<'c, D>) -> MiddlewareResult<'c, D> $b [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 67 | / dual_impl!(&'a [u8], [INFO] [stderr] 68 | | Vec, [INFO] [stderr] 69 | | |self, res| { [INFO] [stderr] 70 | | maybe_set_type(&mut res, MediaType::Bin); [INFO] [stderr] ... | [INFO] [stderr] 76 | | } [INFO] [stderr] 77 | | }); [INFO] [stderr] | |_______________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/responder.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | fn respond<'c>($s, mut $res: Response<'c, D>) -> MiddlewareResult<'c, D> $b [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 79 | / dual_impl!(&'a str, [INFO] [stderr] 80 | | String, [INFO] [stderr] 81 | | |self, res| { [INFO] [stderr] 82 | | maybe_set_type(&mut res, MediaType::Html); [INFO] [stderr] 83 | | res.send(self.as_bytes()) [INFO] [stderr] 84 | | }); [INFO] [stderr] | |_______________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/responder.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | fn respond<'c>($s, mut $res: Response<'c, D>) -> MiddlewareResult<'c, D> $b [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 79 | / dual_impl!(&'a str, [INFO] [stderr] 80 | | String, [INFO] [stderr] 81 | | |self, res| { [INFO] [stderr] 82 | | maybe_set_type(&mut res, MediaType::Html); [INFO] [stderr] 83 | | res.send(self.as_bytes()) [INFO] [stderr] 84 | | }); [INFO] [stderr] | |_______________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/responder.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | fn respond<'c>($s, mut $res: Response<'c, D>) -> MiddlewareResult<'c, D> $b [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 86 | / dual_impl!((StatusCode, &'static str), [INFO] [stderr] 87 | | (StatusCode, String), [INFO] [stderr] 88 | | |self, res| { [INFO] [stderr] 89 | | let (status, message) = self; [INFO] [stderr] ... | [INFO] [stderr] 99 | | } [INFO] [stderr] 100 | | }); [INFO] [stderr] | |_______________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/responder.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | fn respond<'c>($s, mut $res: Response<'c, D>) -> MiddlewareResult<'c, D> $b [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 86 | / dual_impl!((StatusCode, &'static str), [INFO] [stderr] 87 | | (StatusCode, String), [INFO] [stderr] 88 | | |self, res| { [INFO] [stderr] 89 | | let (status, message) = self; [INFO] [stderr] ... | [INFO] [stderr] 99 | | } [INFO] [stderr] 100 | | }); [INFO] [stderr] | |_______________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/responder.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | / fn respond<'c>(self, res: Response<'c, D>) -> MiddlewareResult<'c, D> { [INFO] [stderr] 105 | | res.send((self, "")) [INFO] [stderr] 106 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/responder.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | fn respond<'c>($s, mut $res: Response<'c, D>) -> MiddlewareResult<'c, D> $b [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 109 | / dual_impl!(&'a [&'a str], [INFO] [stderr] 110 | | &'a [String], [INFO] [stderr] 111 | | |self, res| { [INFO] [stderr] 112 | | maybe_set_type(&mut res, MediaType::Html); [INFO] [stderr] ... | [INFO] [stderr] 120 | | Ok(Halt(stream)) [INFO] [stderr] 121 | | }); [INFO] [stderr] | |_______________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/responder.rs:115:21 [INFO] [stderr] | [INFO] [stderr] 115 | for ref s in self.iter() { [INFO] [stderr] | ^^^^^ ----------- help: try: `let s = &self.iter();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/responder.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | fn respond<'c>($s, mut $res: Response<'c, D>) -> MiddlewareResult<'c, D> $b [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 109 | / dual_impl!(&'a [&'a str], [INFO] [stderr] 110 | | &'a [String], [INFO] [stderr] 111 | | |self, res| { [INFO] [stderr] 112 | | maybe_set_type(&mut res, MediaType::Html); [INFO] [stderr] ... | [INFO] [stderr] 120 | | Ok(Halt(stream)) [INFO] [stderr] 121 | | }); [INFO] [stderr] | |_______________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/responder.rs:115:21 [INFO] [stderr] | [INFO] [stderr] 115 | for ref s in self.iter() { [INFO] [stderr] | ^^^^^ ----------- help: try: `let s = &self.iter();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/responder.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | fn respond<'c>($s, mut $res: Response<'c, D>) -> MiddlewareResult<'c, D> $b [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 123 | / dual_impl!((u16, &'static str), [INFO] [stderr] 124 | | (u16, String), [INFO] [stderr] 125 | | |self, res| { [INFO] [stderr] 126 | | let (status, message) = self; [INFO] [stderr] 127 | | res.send((StatusCode::from_u16(status), message)) [INFO] [stderr] 128 | | }); [INFO] [stderr] | |_______________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/responder.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | fn respond<'c>($s, mut $res: Response<'c, D>) -> MiddlewareResult<'c, D> $b [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 123 | / dual_impl!((u16, &'static str), [INFO] [stderr] 124 | | (u16, String), [INFO] [stderr] 125 | | |self, res| { [INFO] [stderr] 126 | | let (status, message) = self; [INFO] [stderr] 127 | | res.send((StatusCode::from_u16(status), message)) [INFO] [stderr] 128 | | }); [INFO] [stderr] | |_______________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/static_files_handler.rs:59:22 [INFO] [stderr] | [INFO] [stderr] 59 | fn with_file<'a, 'b, D, P>(&self, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/query_string.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | / self.get_ref::() [INFO] [stderr] 41 | | .ok() [INFO] [stderr] 42 | | .expect("Bug: QueryStringParser returned None") [INFO] [stderr] | |___________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> examples/integration_testing.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | return res.next_middleware() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `res.next_middleware()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> examples/macro_example.rs:28:15 [INFO] [stderr] | [INFO] [stderr] 28 | fn custom_404<'a, D>(err: &mut NickelError, _req: &mut Request) -> Action { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> examples/macro_example.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | let foo = query.get("foo").unwrap_or("This is only a default value"); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> examples/macro_example.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | let bar = query.get("bar").unwrap_or("This is only a default value"); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> tests/examples/../../examples/integration_testing.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | return res.next_middleware() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `res.next_middleware()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> tests/util/mod.rs:108:5 [INFO] [stderr] | [INFO] [stderr] 108 | / if let Some(arg) = env::var("FEATURES").ok() { [INFO] [stderr] 109 | | for feature_arg in arg.split_whitespace() { [INFO] [stderr] 110 | | command.arg(feature_arg); [INFO] [stderr] 111 | | } [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::if_let_some_result)] on by default [INFO] [stderr] = help: Consider matching on `Ok(arg)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> tests/util/mod.rs:125:16 [INFO] [stderr] | [INFO] [stderr] 125 | let line = stdout.lines() [INFO] [stderr] | ________________^ [INFO] [stderr] 126 | | .map(Result::unwrap) [INFO] [stderr] 127 | | .inspect(|line| println!("Processing Stdout: {:?}", line)) [INFO] [stderr] 128 | | .filter(|line| line.starts_with("Listening")) [INFO] [stderr] 129 | | .next() [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|line| line.starts_with("Listening")).next()` with `find(|line| line.starts_with("Listening"))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/util/mod.rs:135:10 [INFO] [stderr] | [INFO] [stderr] 135 | .expect(&format!("Failed to parse port from {:?}", line)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Failed to parse port from {:?}", line))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> tests/examples/mount.rs:9:13 [INFO] [stderr] | [INFO] [stderr] 9 | let ref mut res = response_for(&url); [INFO] [stderr] | ----^^^^^^^^^^^---------------------- help: try: `let res = &mut response_for(&url);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> tests/examples/routing.rs:9:13 [INFO] [stderr] | [INFO] [stderr] 9 | let ref mut res = response_for(&url); [INFO] [stderr] | ----^^^^^^^^^^^---------------------- help: try: `let res = &mut response_for(&url);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> tests/examples/chaining.rs:14:17 [INFO] [stderr] | [INFO] [stderr] 14 | let ref mut res = response_for_method(method, &url); [INFO] [stderr] | ----^^^^^^^^^^^------------------------------------- help: try: `let res = &mut response_for_method(method, &url);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> tests/examples/json.rs:8:13 [INFO] [stderr] | [INFO] [stderr] 8 | let ref mut res = response_for(&url); [INFO] [stderr] | ----^^^^^^^^^^^---------------------- help: try: `let res = &mut response_for(&url);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> tests/examples/json.rs:22:17 [INFO] [stderr] | [INFO] [stderr] 22 | let ref mut res = response_for_post(&url, body); [INFO] [stderr] | ----^^^^^^^^^^^--------------------------------- help: try: `let res = &mut response_for_post(&url, body);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> tests/examples/query_string/mod.rs:8:13 [INFO] [stderr] | [INFO] [stderr] 8 | let ref mut res = response_for(&url); [INFO] [stderr] | ----^^^^^^^^^^^---------------------- help: try: `let res = &mut response_for(&url);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> tests/examples/regex_route.rs:9:13 [INFO] [stderr] | [INFO] [stderr] 9 | let ref mut res = response_for(&url); [INFO] [stderr] | ----^^^^^^^^^^^---------------------- help: try: `let res = &mut response_for(&url);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> tests/examples/custom_error_handler.rs:9:13 [INFO] [stderr] | [INFO] [stderr] 9 | let ref mut res = response_for(&url); [INFO] [stderr] | ----^^^^^^^^^^^---------------------- help: try: `let res = &mut response_for(&url);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> tests/examples/static_files.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | let ref mut res = response_for(&url); [INFO] [stderr] | ----^^^^^^^^^^^---------------------- help: try: `let res = &mut response_for(&url);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> tests/examples/form_data.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | let ref mut res = Client::new() [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 19 | let res = &mut Client::new() [INFO] [stderr] 20 | .post(&url) [INFO] [stderr] 21 | .header(ContentType::form_url_encoded()) [INFO] [stderr] 22 | .body(r#"firstname=John&lastname=Doe&phone=911&email=john@doe.com"#) [INFO] [stderr] 23 | .send() [INFO] [stderr] 24 | .unwrap(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> tests/examples/form_data.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | let ref mut res = Client::new() [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 34 | let res = &mut Client::new() [INFO] [stderr] 35 | .post(&url) [INFO] [stderr] 36 | .header(ContentType::form_url_encoded()) [INFO] [stderr] 37 | .send() [INFO] [stderr] 38 | .unwrap(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> examples/query_string.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | format!("You didn't provide any foo values!") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"You didn't provide any foo values!".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> examples/template.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | return res.render("examples/assets/template.tpl", &data) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `res.render("examples/assets/template.tpl", &data)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> examples/https.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] extern crate nickel; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> examples/routing.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | let foo = request.param("foo").unwrap(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> examples/form_data/form_data.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | return res.render("examples/form_data/views/contact.html", &data) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `res.render("examples/form_data/views/contact.html", &data)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> examples/form_data/form_data.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | return res.render("examples/form_data/views/confirmation.html", &data) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `res.render("examples/form_data/views/confirmation.html", &data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 30.83s [INFO] running `"docker" "inspect" "07062422c4b378cafbf9552d306017458d0a66f2c4a4a6c000c42c3420196b49"` [INFO] running `"docker" "rm" "-f" "07062422c4b378cafbf9552d306017458d0a66f2c4a4a6c000c42c3420196b49"` [INFO] [stdout] 07062422c4b378cafbf9552d306017458d0a66f2c4a4a6c000c42c3420196b49