[INFO] crate nginx-config 0.13.2 is already in cache [INFO] extracting crate nginx-config 0.13.2 into work/ex/clippy-test-run/sources/stable/reg/nginx-config/0.13.2 [INFO] extracting crate nginx-config 0.13.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nginx-config/0.13.2 [INFO] validating manifest of nginx-config-0.13.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nginx-config-0.13.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nginx-config-0.13.2 [INFO] finished frobbing nginx-config-0.13.2 [INFO] frobbed toml for nginx-config-0.13.2 written to work/ex/clippy-test-run/sources/stable/reg/nginx-config/0.13.2/Cargo.toml [INFO] started frobbing nginx-config-0.13.2 [INFO] finished frobbing nginx-config-0.13.2 [INFO] frobbed toml for nginx-config-0.13.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nginx-config/0.13.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nginx-config-0.13.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/nginx-config/0.13.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6fec2dad35fa9e60c5abc4f8777bf3c85b2a9b4c50b6d453a6fb34380de33bdd [INFO] running `"docker" "start" "-a" "6fec2dad35fa9e60c5abc4f8777bf3c85b2a9b4c50b6d453a6fb34380de33bdd"` [INFO] [stderr] Checking combine v3.6.6 [INFO] [stderr] Checking nginx-config v0.13.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/helpers.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/helpers.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/helpers.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rewrite.rs:88:30 [INFO] [stderr] | [INFO] [stderr] 88 | => Ok(Text { code: code, text: Some(target) }), [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rewrite.rs:104:38 [INFO] [stderr] | [INFO] [stderr] 104 | => Ok(Text { code: code, text: None }), [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/helpers.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/helpers.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/helpers.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rewrite.rs:88:30 [INFO] [stderr] | [INFO] [stderr] 88 | => Ok(Text { code: code, text: Some(target) }), [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rewrite.rs:104:38 [INFO] [stderr] | [INFO] [stderr] 104 | => Ok(Text { code: code, text: None }), [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/display.rs:344:57 [INFO] [stderr] | [INFO] [stderr] 344 | If(ast::If { ref condition, ref directives, position: _ }) => { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `If { ref condition, ref directives, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/display.rs:677:5 [INFO] [stderr] | [INFO] [stderr] 677 | return s [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/error.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | return ParseError(Errors { position: e.position, errors: error_buf }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ParseError(Errors { position: e.position, errors: error_buf })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/grammar.rs:206:18 [INFO] [stderr] | [INFO] [stderr] 206 | _ => return Err(Error::unexpected_message( [INFO] [stderr] | __________________^ [INFO] [stderr] 207 | | format!("invalid response code {}", code))), [INFO] [stderr] | |___________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 206 | _ => Err(Error::unexpected_message( [INFO] [stderr] 207 | format!("invalid response code {}", code))), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokenizer.rs:189:17 [INFO] [stderr] | [INFO] [stderr] 189 | return Ok((String, nchars)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((String, nchars))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/value.rs:188:9 [INFO] [stderr] | [INFO] [stderr] 188 | return Err(Error::unexpected_message("unclosed quote")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::unexpected_message("unclosed quote"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/value.rs:218:9 [INFO] [stderr] | [INFO] [stderr] 218 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/visitors.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | return Some(x); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/core.rs:32:31 [INFO] [stderr] | [INFO] [stderr] 32 | Literal(ref x) => return Ok(x), [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `Ok(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/core.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | _ => return Err(Error::unexpected_message( [INFO] [stderr] | __________________^ [INFO] [stderr] 34 | | "only last argument of error_codes \ [INFO] [stderr] 35 | | can contain variables")), [INFO] [stderr] | |________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 33 | _ => Err(Error::unexpected_message( [INFO] [stderr] 34 | "only last argument of error_codes \ [INFO] [stderr] 35 | can contain variables")), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/core.rs:153:9 [INFO] [stderr] | [INFO] [stderr] 153 | return lst; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `lst` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/proxy.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | return Ok(Specific(codes, time)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Specific(codes, time))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rewrite.rs:74:31 [INFO] [stderr] | [INFO] [stderr] 74 | Literal(ref x) => return Ok(x), [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `Ok(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rewrite.rs:75:18 [INFO] [stderr] | [INFO] [stderr] 75 | _ => return Err(Error::unexpected_message( [INFO] [stderr] | __________________^ [INFO] [stderr] 76 | | "return code can't contain variables")), [INFO] [stderr] | |_______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 75 | _ => Err(Error::unexpected_message( [INFO] [stderr] 76 | "return code can't contain variables")), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rewrite.rs:167:17 [INFO] [stderr] | [INFO] [stderr] 167 | "-d" => return Ok(DirExists(right)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(DirExists(right))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rewrite.rs:168:18 [INFO] [stderr] | [INFO] [stderr] 168 | "!-d" => return Ok(DirNotExists(right)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(DirNotExists(right))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rewrite.rs:169:17 [INFO] [stderr] | [INFO] [stderr] 169 | "-f" => return Ok(FileExists(right)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(FileExists(right))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rewrite.rs:170:18 [INFO] [stderr] | [INFO] [stderr] 170 | "!-f" => return Ok(FileNotExists(right)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(FileNotExists(right))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rewrite.rs:171:17 [INFO] [stderr] | [INFO] [stderr] 171 | "-x" => return Ok(Executable(right)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Executable(right))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rewrite.rs:172:18 [INFO] [stderr] | [INFO] [stderr] 172 | "!-x" => return Ok(NotExecutable(right)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(NotExecutable(right))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rewrite.rs:173:17 [INFO] [stderr] | [INFO] [stderr] 173 | "-e" => return Ok(Exists(right)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Exists(right))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rewrite.rs:174:18 [INFO] [stderr] | [INFO] [stderr] 174 | "!-e" => return Ok(NotExists(right)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(NotExists(right))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rewrite.rs:175:14 [INFO] [stderr] | [INFO] [stderr] 175 | _ => return Err(Error::unexpected_message("missing parenthesis")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::unexpected_message("missing parenthesis"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rewrite.rs:195:16 [INFO] [stderr] | [INFO] [stderr] 195 | "=" => return Ok(Eq(left, right)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Eq(left, right))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rewrite.rs:196:17 [INFO] [stderr] | [INFO] [stderr] 196 | "!=" => return Ok(Neq(left, right)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Neq(left, right))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rewrite.rs:197:16 [INFO] [stderr] | [INFO] [stderr] 197 | "~" => return Ok(RegEq(left, right, true)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(RegEq(left, right, true))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rewrite.rs:198:17 [INFO] [stderr] | [INFO] [stderr] 198 | "!~" => return Ok(RegNeq(left, right, true)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(RegNeq(left, right, true))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rewrite.rs:199:17 [INFO] [stderr] | [INFO] [stderr] 199 | "~*" => return Ok(RegEq(left, right, false)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(RegEq(left, right, false))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rewrite.rs:200:18 [INFO] [stderr] | [INFO] [stderr] 200 | "!~*" => return Ok(RegNeq(left, right, false)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(RegNeq(left, right, false))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rewrite.rs:201:14 [INFO] [stderr] | [INFO] [stderr] 201 | _ => return Err(Error::unexpected_message("missing parenthesis")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::unexpected_message("missing parenthesis"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/display.rs:344:57 [INFO] [stderr] | [INFO] [stderr] 344 | If(ast::If { ref condition, ref directives, position: _ }) => { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `If { ref condition, ref directives, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/display.rs:677:5 [INFO] [stderr] | [INFO] [stderr] 677 | return s [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/error.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | return ParseError(Errors { position: e.position, errors: error_buf }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ParseError(Errors { position: e.position, errors: error_buf })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/grammar.rs:206:18 [INFO] [stderr] | [INFO] [stderr] 206 | _ => return Err(Error::unexpected_message( [INFO] [stderr] | __________________^ [INFO] [stderr] 207 | | format!("invalid response code {}", code))), [INFO] [stderr] | |___________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 206 | _ => Err(Error::unexpected_message( [INFO] [stderr] 207 | format!("invalid response code {}", code))), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokenizer.rs:189:17 [INFO] [stderr] | [INFO] [stderr] 189 | return Ok((String, nchars)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((String, nchars))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokenizer.rs:254:9 [INFO] [stderr] | [INFO] [stderr] 254 | return r; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokenizer.rs:266:9 [INFO] [stderr] | [INFO] [stderr] 266 | return r; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/value.rs:188:9 [INFO] [stderr] | [INFO] [stderr] 188 | return Err(Error::unexpected_message("unclosed quote")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::unexpected_message("unclosed quote"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/value.rs:218:9 [INFO] [stderr] | [INFO] [stderr] 218 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/visitors.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | return Some(x); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/core.rs:32:31 [INFO] [stderr] | [INFO] [stderr] 32 | Literal(ref x) => return Ok(x), [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `Ok(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/core.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | _ => return Err(Error::unexpected_message( [INFO] [stderr] | __________________^ [INFO] [stderr] 34 | | "only last argument of error_codes \ [INFO] [stderr] 35 | | can contain variables")), [INFO] [stderr] | |________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 33 | _ => Err(Error::unexpected_message( [INFO] [stderr] 34 | "only last argument of error_codes \ [INFO] [stderr] 35 | can contain variables")), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/core.rs:153:9 [INFO] [stderr] | [INFO] [stderr] 153 | return lst; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `lst` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/proxy.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | return Ok(Specific(codes, time)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Specific(codes, time))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rewrite.rs:74:31 [INFO] [stderr] | [INFO] [stderr] 74 | Literal(ref x) => return Ok(x), [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `Ok(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rewrite.rs:75:18 [INFO] [stderr] | [INFO] [stderr] 75 | _ => return Err(Error::unexpected_message( [INFO] [stderr] | __________________^ [INFO] [stderr] 76 | | "return code can't contain variables")), [INFO] [stderr] | |_______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 75 | _ => Err(Error::unexpected_message( [INFO] [stderr] 76 | "return code can't contain variables")), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rewrite.rs:167:17 [INFO] [stderr] | [INFO] [stderr] 167 | "-d" => return Ok(DirExists(right)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(DirExists(right))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rewrite.rs:168:18 [INFO] [stderr] | [INFO] [stderr] 168 | "!-d" => return Ok(DirNotExists(right)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(DirNotExists(right))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rewrite.rs:169:17 [INFO] [stderr] | [INFO] [stderr] 169 | "-f" => return Ok(FileExists(right)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(FileExists(right))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rewrite.rs:170:18 [INFO] [stderr] | [INFO] [stderr] 170 | "!-f" => return Ok(FileNotExists(right)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(FileNotExists(right))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rewrite.rs:171:17 [INFO] [stderr] | [INFO] [stderr] 171 | "-x" => return Ok(Executable(right)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Executable(right))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rewrite.rs:172:18 [INFO] [stderr] | [INFO] [stderr] 172 | "!-x" => return Ok(NotExecutable(right)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(NotExecutable(right))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rewrite.rs:173:17 [INFO] [stderr] | [INFO] [stderr] 173 | "-e" => return Ok(Exists(right)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Exists(right))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rewrite.rs:174:18 [INFO] [stderr] | [INFO] [stderr] 174 | "!-e" => return Ok(NotExists(right)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(NotExists(right))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rewrite.rs:175:14 [INFO] [stderr] | [INFO] [stderr] 175 | _ => return Err(Error::unexpected_message("missing parenthesis")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::unexpected_message("missing parenthesis"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rewrite.rs:195:16 [INFO] [stderr] | [INFO] [stderr] 195 | "=" => return Ok(Eq(left, right)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Eq(left, right))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rewrite.rs:196:17 [INFO] [stderr] | [INFO] [stderr] 196 | "!=" => return Ok(Neq(left, right)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Neq(left, right))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rewrite.rs:197:16 [INFO] [stderr] | [INFO] [stderr] 197 | "~" => return Ok(RegEq(left, right, true)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(RegEq(left, right, true))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rewrite.rs:198:17 [INFO] [stderr] | [INFO] [stderr] 198 | "!~" => return Ok(RegNeq(left, right, true)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(RegNeq(left, right, true))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rewrite.rs:199:17 [INFO] [stderr] | [INFO] [stderr] 199 | "~*" => return Ok(RegEq(left, right, false)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(RegEq(left, right, false))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rewrite.rs:200:18 [INFO] [stderr] | [INFO] [stderr] 200 | "!~*" => return Ok(RegNeq(left, right, false)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(RegNeq(left, right, false))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rewrite.rs:201:14 [INFO] [stderr] | [INFO] [stderr] 201 | _ => return Err(Error::unexpected_message("missing parenthesis")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::unexpected_message("missing parenthesis"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/ast.rs:303:15 [INFO] [stderr] | [INFO] [stderr] 303 | pub gzip: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 44 [INFO] [stderr] --> src/display.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | / fn display(&self, f: &mut Formatter) { [INFO] [stderr] 44 | | use ast::Item::*; [INFO] [stderr] 45 | | match *self { [INFO] [stderr] 46 | | | Daemon(opt) [INFO] [stderr] ... | [INFO] [stderr] 592 | | } [INFO] [stderr] 593 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/error.rs:61:21 [INFO] [stderr] | [INFO] [stderr] 61 | / match item { [INFO] [stderr] 62 | | Info::Borrowed(item) => { [INFO] [stderr] 63 | | let conf = jaro_winkler(&unexpected, item); [INFO] [stderr] 64 | | if conf > 0.8 { [INFO] [stderr] ... | [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 61 | if let Info::Borrowed(item) = item { [INFO] [stderr] 62 | let conf = jaro_winkler(&unexpected, item); [INFO] [stderr] 63 | if conf > 0.8 { [INFO] [stderr] 64 | close.push((item, conf)); [INFO] [stderr] 65 | } [INFO] [stderr] 66 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/grammar.rs:59:36 [INFO] [stderr] | [INFO] [stderr] 59 | if t.value.starts_with("~") { [INFO] [stderr] | ^^^ help: try using a char instead: `'~'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/grammar.rs:65:43 [INFO] [stderr] | [INFO] [stderr] 65 | } else if t.value.starts_with(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: type does not implement `fmt::Debug`; consider adding #[derive(Debug)] or a manual implementation [INFO] [stderr] --> src/grammar.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | / enum Tok { [INFO] [stderr] 81 | | Hostnames, [INFO] [stderr] 82 | | Volatile, [INFO] [stderr] 83 | | Pattern(String, Value), [INFO] [stderr] 84 | | Default(Value), [INFO] [stderr] 85 | | Include(String), [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | #![warn(missing_debug_implementations)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/grammar.rs:105:44 [INFO] [stderr] | [INFO] [stderr] 105 | ident("default").with(value()).map(|v| Tok::Default(v)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Tok::Default` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/grammar.rs:106:42 [INFO] [stderr] | [INFO] [stderr] 106 | ident("include").with(raw()).map(|v| Tok::Include(v)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Tok::Include` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/grammar.rs:139:49 [INFO] [stderr] | [INFO] [stderr] 139 | } else if s.starts_with(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/grammar.rs:205:13 [INFO] [stderr] | [INFO] [stderr] 205 | 200...599 => Ok(Code::Normal(code)), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_overlapping_arm)] on by default [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/grammar.rs:204:13 [INFO] [stderr] | [INFO] [stderr] 204 | 301 | 302 | 303 | 307 | 308 => Ok(Code::Redirect(code)), [INFO] [stderr] | ^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/grammar.rs:230:43 [INFO] [stderr] | [INFO] [stderr] 230 | [Literal(x)] if x.starts_with("=") => { [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/grammar.rs:233:43 [INFO] [stderr] | [INFO] [stderr] 233 | [Literal(x)] if x.starts_with("@") => { [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/value.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / pub(crate) fn parse<'a>(position: Pos, tok: Token<'a>) [INFO] [stderr] 32 | | -> Result, Token<'a>>> [INFO] [stderr] 33 | | { [INFO] [stderr] 34 | | Value::parse_str(position, tok.value) [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/value.rs:41:37 [INFO] [stderr] | [INFO] [stderr] 41 | } else if token.starts_with("'") { [INFO] [stderr] | ^^^ help: try using a char instead: `'''` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/value.rs:99:34 [INFO] [stderr] | [INFO] [stderr] 99 | .unwrap_or(value.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| value.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/value.rs:137:24 [INFO] [stderr] | [INFO] [stderr] 137 | if cur_slice.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!cur_slice.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/value.rs:151:24 [INFO] [stderr] | [INFO] [stderr] 151 | if cur_slice.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!cur_slice.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/value.rs:241:24 [INFO] [stderr] | [INFO] [stderr] 241 | fn next_alphanum(data: &Vec, index: usize) -> bool { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Item]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/visitors.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | / match self.cur.take() { [INFO] [stderr] 34 | | Some(dir) => { [INFO] [stderr] 35 | | if let Some(ch) = dir.item.children() { [INFO] [stderr] 36 | | self.queue.extend(ch.iter().rev()); [INFO] [stderr] ... | [INFO] [stderr] 39 | | None => {} [INFO] [stderr] 40 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 33 | if let Some(dir) = self.cur.take() { [INFO] [stderr] 34 | if let Some(ch) = dir.item.children() { [INFO] [stderr] 35 | self.queue.extend(ch.iter().rev()); [INFO] [stderr] 36 | } [INFO] [stderr] 37 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/visitors.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | / match dir.item.children_mut() { [INFO] [stderr] 64 | | Some(children) => _visit_mutable(children, f), [INFO] [stderr] 65 | | None => {} [INFO] [stderr] 66 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(children) = dir.item.children_mut() { _visit_mutable(children, f) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/visitors.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | let ref mut f = f; [INFO] [stderr] | ----^^^^^^^^^----- help: try: `let f = &mut f;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/visitors.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | let ref mut inner_visitor = inner_visitor; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^^^----------------- help: try: `let inner_visitor = &mut inner_visitor;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/access.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | / fn parse_source<'a>(val: Token<'a>) [INFO] [stderr] 14 | | -> Result, Token<'a>>> [INFO] [stderr] 15 | | { [INFO] [stderr] 16 | | let value = val.value; [INFO] [stderr] ... | [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: type does not implement `fmt::Debug`; consider adding #[derive(Debug)] or a manual implementation [INFO] [stderr] --> src/core.rs:80:1 [INFO] [stderr] | [INFO] [stderr] 80 | / enum ListenParts { [INFO] [stderr] 81 | | DefaultServer, [INFO] [stderr] 82 | | Ssl, [INFO] [stderr] 83 | | Ext(ast::HttpExt), [INFO] [stderr] ... | [INFO] [stderr] 93 | | ReusePort, [INFO] [stderr] 94 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/proxy.rs:31:20 [INFO] [stderr] | [INFO] [stderr] 31 | if v.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rewrite.rs:163:8 [INFO] [stderr] | [INFO] [stderr] 163 | if v.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rewrite.rs:185:8 [INFO] [stderr] | [INFO] [stderr] 185 | if v.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: type does not implement `fmt::Debug`; consider adding #[derive(Debug)] or a manual implementation [INFO] [stderr] --> src/log.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / enum I { [INFO] [stderr] 17 | | If(Value), [INFO] [stderr] 18 | | Gzip(Option), [INFO] [stderr] 19 | | Flush(String), [INFO] [stderr] 20 | | Buffer(String), [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/real_ip.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | / fn parse_source<'a>(val: Token<'a>) [INFO] [stderr] 14 | | -> Result, Token<'a>>> [INFO] [stderr] 15 | | { [INFO] [stderr] 16 | | let value = val.value; [INFO] [stderr] ... | [INFO] [stderr] 29 | | } [INFO] [stderr] 30 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/ast.rs:303:15 [INFO] [stderr] | [INFO] [stderr] 303 | pub gzip: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 44 [INFO] [stderr] --> src/display.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | / fn display(&self, f: &mut Formatter) { [INFO] [stderr] 44 | | use ast::Item::*; [INFO] [stderr] 45 | | match *self { [INFO] [stderr] 46 | | | Daemon(opt) [INFO] [stderr] ... | [INFO] [stderr] 592 | | } [INFO] [stderr] 593 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/error.rs:61:21 [INFO] [stderr] | [INFO] [stderr] 61 | / match item { [INFO] [stderr] 62 | | Info::Borrowed(item) => { [INFO] [stderr] 63 | | let conf = jaro_winkler(&unexpected, item); [INFO] [stderr] 64 | | if conf > 0.8 { [INFO] [stderr] ... | [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 61 | if let Info::Borrowed(item) = item { [INFO] [stderr] 62 | let conf = jaro_winkler(&unexpected, item); [INFO] [stderr] 63 | if conf > 0.8 { [INFO] [stderr] 64 | close.push((item, conf)); [INFO] [stderr] 65 | } [INFO] [stderr] 66 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/grammar.rs:59:36 [INFO] [stderr] | [INFO] [stderr] 59 | if t.value.starts_with("~") { [INFO] [stderr] | ^^^ help: try using a char instead: `'~'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/grammar.rs:65:43 [INFO] [stderr] | [INFO] [stderr] 65 | } else if t.value.starts_with(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: type does not implement `fmt::Debug`; consider adding #[derive(Debug)] or a manual implementation [INFO] [stderr] --> src/grammar.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | / enum Tok { [INFO] [stderr] 81 | | Hostnames, [INFO] [stderr] 82 | | Volatile, [INFO] [stderr] 83 | | Pattern(String, Value), [INFO] [stderr] 84 | | Default(Value), [INFO] [stderr] 85 | | Include(String), [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | #![warn(missing_debug_implementations)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/grammar.rs:105:44 [INFO] [stderr] | [INFO] [stderr] 105 | ident("default").with(value()).map(|v| Tok::Default(v)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Tok::Default` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/grammar.rs:106:42 [INFO] [stderr] | [INFO] [stderr] 106 | ident("include").with(raw()).map(|v| Tok::Include(v)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Tok::Include` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/grammar.rs:139:49 [INFO] [stderr] | [INFO] [stderr] 139 | } else if s.starts_with(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/grammar.rs:205:13 [INFO] [stderr] | [INFO] [stderr] 205 | 200...599 => Ok(Code::Normal(code)), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_overlapping_arm)] on by default [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/grammar.rs:204:13 [INFO] [stderr] | [INFO] [stderr] 204 | 301 | 302 | 303 | 307 | 308 => Ok(Code::Redirect(code)), [INFO] [stderr] | ^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/grammar.rs:230:43 [INFO] [stderr] | [INFO] [stderr] 230 | [Literal(x)] if x.starts_with("=") => { [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/grammar.rs:233:43 [INFO] [stderr] | [INFO] [stderr] 233 | [Literal(x)] if x.starts_with("@") => { [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/value.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / pub(crate) fn parse<'a>(position: Pos, tok: Token<'a>) [INFO] [stderr] 32 | | -> Result, Token<'a>>> [INFO] [stderr] 33 | | { [INFO] [stderr] 34 | | Value::parse_str(position, tok.value) [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/value.rs:41:37 [INFO] [stderr] | [INFO] [stderr] 41 | } else if token.starts_with("'") { [INFO] [stderr] | ^^^ help: try using a char instead: `'''` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/value.rs:99:34 [INFO] [stderr] | [INFO] [stderr] 99 | .unwrap_or(value.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| value.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/value.rs:137:24 [INFO] [stderr] | [INFO] [stderr] 137 | if cur_slice.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!cur_slice.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/value.rs:151:24 [INFO] [stderr] | [INFO] [stderr] 151 | if cur_slice.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!cur_slice.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/value.rs:241:24 [INFO] [stderr] | [INFO] [stderr] 241 | fn next_alphanum(data: &Vec, index: usize) -> bool { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Item]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/visitors.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | / match self.cur.take() { [INFO] [stderr] 34 | | Some(dir) => { [INFO] [stderr] 35 | | if let Some(ch) = dir.item.children() { [INFO] [stderr] 36 | | self.queue.extend(ch.iter().rev()); [INFO] [stderr] ... | [INFO] [stderr] 39 | | None => {} [INFO] [stderr] 40 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 33 | if let Some(dir) = self.cur.take() { [INFO] [stderr] 34 | if let Some(ch) = dir.item.children() { [INFO] [stderr] 35 | self.queue.extend(ch.iter().rev()); [INFO] [stderr] 36 | } [INFO] [stderr] 37 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/visitors.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | / match dir.item.children_mut() { [INFO] [stderr] 64 | | Some(children) => _visit_mutable(children, f), [INFO] [stderr] 65 | | None => {} [INFO] [stderr] 66 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(children) = dir.item.children_mut() { _visit_mutable(children, f) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/visitors.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | let ref mut f = f; [INFO] [stderr] | ----^^^^^^^^^----- help: try: `let f = &mut f;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/visitors.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | let ref mut inner_visitor = inner_visitor; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^^^----------------- help: try: `let inner_visitor = &mut inner_visitor;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/access.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | / fn parse_source<'a>(val: Token<'a>) [INFO] [stderr] 14 | | -> Result, Token<'a>>> [INFO] [stderr] 15 | | { [INFO] [stderr] 16 | | let value = val.value; [INFO] [stderr] ... | [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: type does not implement `fmt::Debug`; consider adding #[derive(Debug)] or a manual implementation [INFO] [stderr] --> src/core.rs:80:1 [INFO] [stderr] | [INFO] [stderr] 80 | / enum ListenParts { [INFO] [stderr] 81 | | DefaultServer, [INFO] [stderr] 82 | | Ssl, [INFO] [stderr] 83 | | Ext(ast::HttpExt), [INFO] [stderr] ... | [INFO] [stderr] 93 | | ReusePort, [INFO] [stderr] 94 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/proxy.rs:31:20 [INFO] [stderr] | [INFO] [stderr] 31 | if v.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rewrite.rs:163:8 [INFO] [stderr] | [INFO] [stderr] 163 | if v.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rewrite.rs:185:8 [INFO] [stderr] | [INFO] [stderr] 185 | if v.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: type does not implement `fmt::Debug`; consider adding #[derive(Debug)] or a manual implementation [INFO] [stderr] --> src/log.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / enum I { [INFO] [stderr] 17 | | If(Value), [INFO] [stderr] 18 | | Gzip(Option), [INFO] [stderr] 19 | | Flush(String), [INFO] [stderr] 20 | | Buffer(String), [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/real_ip.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | / fn parse_source<'a>(val: Token<'a>) [INFO] [stderr] 14 | | -> Result, Token<'a>>> [INFO] [stderr] 15 | | { [INFO] [stderr] 16 | | let value = val.value; [INFO] [stderr] ... | [INFO] [stderr] 29 | | } [INFO] [stderr] 30 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 31.62s [INFO] running `"docker" "inspect" "6fec2dad35fa9e60c5abc4f8777bf3c85b2a9b4c50b6d453a6fb34380de33bdd"` [INFO] running `"docker" "rm" "-f" "6fec2dad35fa9e60c5abc4f8777bf3c85b2a9b4c50b6d453a6fb34380de33bdd"` [INFO] [stdout] 6fec2dad35fa9e60c5abc4f8777bf3c85b2a9b4c50b6d453a6fb34380de33bdd