[INFO] crate nff 0.1.2 is already in cache [INFO] extracting crate nff 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/nff/0.1.2 [INFO] extracting crate nff 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nff/0.1.2 [INFO] validating manifest of nff-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nff-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nff-0.1.2 [INFO] finished frobbing nff-0.1.2 [INFO] frobbed toml for nff-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/nff/0.1.2/Cargo.toml [INFO] started frobbing nff-0.1.2 [INFO] finished frobbing nff-0.1.2 [INFO] frobbed toml for nff-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nff/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nff-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/nff/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2c4611d0e19982f73638909d524c71f628c1e5230de861b1407a68955d4b3561 [INFO] running `"docker" "start" "-a" "2c4611d0e19982f73638909d524c71f628c1e5230de861b1407a68955d4b3561"` [INFO] [stderr] Checking hashbrown v0.1.8 [INFO] [stderr] Checking nff v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:61:17 [INFO] [stderr] | [INFO] [stderr] 61 | let mut rhs = side.next().expect("Missing right hand side").trim().chars(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:41:35 [INFO] [stderr] | [INFO] [stderr] 41 | for line in grammar.split("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:55:20 [INFO] [stderr] | [INFO] [stderr] 55 | if let Some(_) = lhs.next() { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 56 | | panic!("left hand side too long"); [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____________- help: try this: `if lhs.next().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/lib.rs:95:24 [INFO] [stderr] | [INFO] [stderr] 95 | if nullable == true && nullable != *self.nullable_map.get(non_terminal).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `nullable` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:61:17 [INFO] [stderr] | [INFO] [stderr] 61 | let mut rhs = side.next().expect("Missing right hand side").trim().chars(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:41:35 [INFO] [stderr] | [INFO] [stderr] 41 | for line in grammar.split("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:55:20 [INFO] [stderr] | [INFO] [stderr] 55 | if let Some(_) = lhs.next() { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 56 | | panic!("left hand side too long"); [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____________- help: try this: `if lhs.next().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/lib.rs:95:24 [INFO] [stderr] | [INFO] [stderr] 95 | if nullable == true && nullable != *self.nullable_map.get(non_terminal).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `nullable` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.81s [INFO] running `"docker" "inspect" "2c4611d0e19982f73638909d524c71f628c1e5230de861b1407a68955d4b3561"` [INFO] running `"docker" "rm" "-f" "2c4611d0e19982f73638909d524c71f628c1e5230de861b1407a68955d4b3561"` [INFO] [stdout] 2c4611d0e19982f73638909d524c71f628c1e5230de861b1407a68955d4b3561