[INFO] crate nexus 0.0.1 is already in cache [INFO] extracting crate nexus 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/nexus/0.0.1 [INFO] extracting crate nexus 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nexus/0.0.1 [INFO] validating manifest of nexus-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nexus-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nexus-0.0.1 [INFO] finished frobbing nexus-0.0.1 [INFO] frobbed toml for nexus-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/nexus/0.0.1/Cargo.toml [INFO] started frobbing nexus-0.0.1 [INFO] finished frobbing nexus-0.0.1 [INFO] frobbed toml for nexus-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nexus/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nexus-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/nexus/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d008f129bdceafd1ab7028151876c024f629ef0832532f30ff7a7e6131fb8f31 [INFO] running `"docker" "start" "-a" "d008f129bdceafd1ab7028151876c024f629ef0832532f30ff7a7e6131fb8f31"` [INFO] [stderr] Checking nexus v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tcp/protocol.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | listener: listener, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `listener` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tcp/tcp_reactor.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | reactor: reactor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `reactor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tcp/protocol.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | listener: listener, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `listener` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tcp/tcp_reactor.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | reactor: reactor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `reactor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::error::Error` [INFO] [stderr] --> src/reactor/mod.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use std::error::Error; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::error::Error` [INFO] [stderr] --> src/reactor/mod.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use std::error::Error; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::thread::sleep_ms': replaced by `std::thread::sleep` [INFO] [stderr] --> src/reactor/mod.rs:230:9 [INFO] [stderr] | [INFO] [stderr] 230 | ::std::thread::sleep_ms(60); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::thread::sleep_ms': replaced by `std::thread::sleep` [INFO] [stderr] --> src/reactor/mod.rs:240:9 [INFO] [stderr] | [INFO] [stderr] 240 | ::std::thread::sleep_ms(60); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/reactor/configurer.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | / match self.error.take() { [INFO] [stderr] 28 | | Some(err) => { [INFO] [stderr] 29 | | handler.set_protocol_error(err); [INFO] [stderr] 30 | | handler.shutdown_handle().shutdown(); [INFO] [stderr] ... | [INFO] [stderr] 33 | | None => {}, [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | if let Some(err) = self.error.take() { [INFO] [stderr] 28 | handler.set_protocol_error(err); [INFO] [stderr] 29 | handler.shutdown_handle().shutdown(); [INFO] [stderr] 30 | return; [INFO] [stderr] 31 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/reactor/handler.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | / match timeout { [INFO] [stderr] 101 | | Some(t) => { [INFO] [stderr] 102 | | event_loop.clear_timeout(t); [INFO] [stderr] 103 | | }, [INFO] [stderr] 104 | | None => {}, [INFO] [stderr] 105 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 100 | if let Some(t) = timeout { [INFO] [stderr] 101 | event_loop.clear_timeout(t); [INFO] [stderr] 102 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/reactor/mod.rs:74:29 [INFO] [stderr] | [INFO] [stderr] 74 | fn to_event_loop_config(self) -> EventLoopConfig { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/reactor/mod.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | / match self.timer_tick_interval_ms { [INFO] [stderr] 78 | | Some(ms) => { event_config.timer_tick_ms(ms); }, [INFO] [stderr] 79 | | None => {}, [INFO] [stderr] 80 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(ms) = self.timer_tick_interval_ms { event_config.timer_tick_ms(ms); }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused import: `Configurer` [INFO] [stderr] --> src/reactor/mod.rs:155:28 [INFO] [stderr] | [INFO] [stderr] 155 | use reactor::{Reactor, Configurer, ReactorConfig}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/reactor/configurer.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | / match self.error.take() { [INFO] [stderr] 28 | | Some(err) => { [INFO] [stderr] 29 | | handler.set_protocol_error(err); [INFO] [stderr] 30 | | handler.shutdown_handle().shutdown(); [INFO] [stderr] ... | [INFO] [stderr] 33 | | None => {}, [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | if let Some(err) = self.error.take() { [INFO] [stderr] 28 | handler.set_protocol_error(err); [INFO] [stderr] 29 | handler.shutdown_handle().shutdown(); [INFO] [stderr] 30 | return; [INFO] [stderr] 31 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/reactor/handler.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | / match timeout { [INFO] [stderr] 101 | | Some(t) => { [INFO] [stderr] 102 | | event_loop.clear_timeout(t); [INFO] [stderr] 103 | | }, [INFO] [stderr] 104 | | None => {}, [INFO] [stderr] 105 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 100 | if let Some(t) = timeout { [INFO] [stderr] 101 | event_loop.clear_timeout(t); [INFO] [stderr] 102 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/reactor/mod.rs:74:29 [INFO] [stderr] | [INFO] [stderr] 74 | fn to_event_loop_config(self) -> EventLoopConfig { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/reactor/mod.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | / match self.timer_tick_interval_ms { [INFO] [stderr] 78 | | Some(ms) => { event_config.timer_tick_ms(ms); }, [INFO] [stderr] 79 | | None => {}, [INFO] [stderr] 80 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(ms) = self.timer_tick_interval_ms { event_config.timer_tick_ms(ms); }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/test_helpers/fake_protocol.rs:80:19 [INFO] [stderr] | [INFO] [stderr] 80 | let res = match *socket { [INFO] [stderr] | ___________________^ [INFO] [stderr] 81 | | &mut PReader(ref mut r) => r.read(&mut buf), [INFO] [stderr] 82 | | &mut PWriter(_) => panic!("A readable writer was found."), [INFO] [stderr] 83 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 80 | let res = match *(*socket) { [INFO] [stderr] 81 | PReader(ref mut r) => r.read(&mut buf), [INFO] [stderr] 82 | PWriter(_) => panic!("A readable writer was found."), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/test_helpers/fake_protocol.rs:195:9 [INFO] [stderr] | [INFO] [stderr] 195 | / match err_guard.take() { [INFO] [stderr] 196 | | Some(err) => { [INFO] [stderr] 197 | | event_configurer.shutdown(err); [INFO] [stderr] 198 | | return; [INFO] [stderr] 199 | | }, [INFO] [stderr] 200 | | None => {}, [INFO] [stderr] 201 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 195 | if let Some(err) = err_guard.take() { [INFO] [stderr] 196 | event_configurer.shutdown(err); [INFO] [stderr] 197 | return; [INFO] [stderr] 198 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/test_helpers/fake_protocol.rs:221:9 [INFO] [stderr] | [INFO] [stderr] 221 | (*guard).clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `(*guard)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/test_helpers/fake_protocol.rs:226:9 [INFO] [stderr] | [INFO] [stderr] 226 | (*guard).clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `(*guard)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/test_helpers/fake_protocol.rs:231:9 [INFO] [stderr] | [INFO] [stderr] 231 | (*guard).clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `(*guard)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/test_helpers/fake_protocol.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | (*guard).clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `(*guard)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/test_helpers/fake_protocol.rs:241:9 [INFO] [stderr] | [INFO] [stderr] 241 | (*guard).clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `(*guard)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.37s [INFO] running `"docker" "inspect" "d008f129bdceafd1ab7028151876c024f629ef0832532f30ff7a7e6131fb8f31"` [INFO] running `"docker" "rm" "-f" "d008f129bdceafd1ab7028151876c024f629ef0832532f30ff7a7e6131fb8f31"` [INFO] [stdout] d008f129bdceafd1ab7028151876c024f629ef0832532f30ff7a7e6131fb8f31